====================================================== WARNING: possible circular locking dependency detected 6.9.0-rc2-next-20240402-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.4/6002 is trying to acquire lock: ffff8880621288f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_allocate+0x9e/0x8c0 fs/hfsplus/bitmap.c:35 but task is already holding lock: ffff88801f5087c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x21b/0x1b70 fs/hfsplus/extents.c:457 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 hfsplus_get_block+0x383/0x14f0 fs/hfsplus/extents.c:260 block_read_full_folio+0x42e/0xe10 fs/buffer.c:2384 filemap_read_folio+0x1a0/0x790 mm/filemap.c:2355 do_read_cache_folio+0x134/0x820 mm/filemap.c:3782 do_read_cache_page+0x30/0x200 mm/filemap.c:3848 read_mapping_page include/linux/pagemap.h:891 [inline] hfsplus_block_allocate+0xee/0x8c0 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0xade/0x1b70 fs/hfsplus/extents.c:468 hfsplus_get_block+0x406/0x14f0 fs/hfsplus/extents.c:245 __block_write_begin_int+0x50c/0x1a70 fs/buffer.c:2105 __block_write_begin fs/buffer.c:2154 [inline] block_write_begin+0x9b/0x1e0 fs/buffer.c:2213 cont_write_begin+0x645/0x890 fs/buffer.c:2567 hfsplus_write_begin+0x8a/0xd0 fs/hfsplus/inode.c:47 page_symlink+0x2a6/0x4a0 fs/namei.c:5232 hfsplus_symlink+0xca/0x270 fs/hfsplus/dir.c:449 vfs_symlink+0x137/0x2a0 fs/namei.c:4484 do_symlinkat+0x222/0x3a0 fs/namei.c:4510 __do_sys_symlink fs/namei.c:4531 [inline] __se_sys_symlink fs/namei.c:4529 [inline] __x64_sys_symlink+0x7e/0x90 fs/namei.c:4529 do_syscall_64+0xfb/0x240 entry_SYSCALL_64_after_hwframe+0x72/0x7a -> #0 (&sbi->alloc_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18cb/0x58e0 kernel/locking/lockdep.c:3869 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 hfsplus_block_allocate+0x9e/0x8c0 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0xade/0x1b70 fs/hfsplus/extents.c:468 hfsplus_bmap_reserve+0x105/0x4e0 fs/hfsplus/btree.c:358 hfsplus_create_cat+0x1b0/0x1b60 fs/hfsplus/catalog.c:272 hfsplus_fill_super+0x13ee/0x1ca0 fs/hfsplus/super.c:566 mount_bdev+0x20a/0x2d0 fs/super.c:1658 legacy_get_tree+0xee/0x190 fs/fs_context.c:662 vfs_get_tree+0x90/0x2a0 fs/super.c:1779 do_new_mount+0x2be/0xb40 fs/namespace.c:3352 do_mount fs/namespace.c:3692 [inline] __do_sys_mount fs/namespace.c:3898 [inline] __se_sys_mount+0x2d9/0x3c0 fs/namespace.c:3875 do_syscall_64+0xfb/0x240 entry_SYSCALL_64_after_hwframe+0x72/0x7a other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 4 locks held by syz-executor.4/6002: #0: ffff88807d6e80e0 (&type->s_umount_key#52/1){+.+.}-{3:3}, at: alloc_super+0x221/0x9d0 fs/super.c:343 #1: ffff888062128998 (&sbi->vh_mutex){+.+.}-{3:3}, at: hfsplus_fill_super+0x1380/0x1ca0 fs/hfsplus/super.c:559 #2: ffff88805b2340b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x14a/0x1c0 #3: ffff88801f5087c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x21b/0x1b70 fs/hfsplus/extents.c:457 stack backtrace: CPU: 1 PID: 6002 Comm: syz-executor.4 Not tainted 6.9.0-rc2-next-20240402-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18cb/0x58e0 kernel/locking/lockdep.c:3869 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 hfsplus_block_allocate+0x9e/0x8c0 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0xade/0x1b70 fs/hfsplus/extents.c:468 hfsplus_bmap_reserve+0x105/0x4e0 fs/hfsplus/btree.c:358 hfsplus_create_cat+0x1b0/0x1b60 fs/hfsplus/catalog.c:272 hfsplus_fill_super+0x13ee/0x1ca0 fs/hfsplus/super.c:566 mount_bdev+0x20a/0x2d0 fs/super.c:1658 legacy_get_tree+0xee/0x190 fs/fs_context.c:662 vfs_get_tree+0x90/0x2a0 fs/super.c:1779 do_new_mount+0x2be/0xb40 fs/namespace.c:3352 do_mount fs/namespace.c:3692 [inline] __do_sys_mount fs/namespace.c:3898 [inline] __se_sys_mount+0x2d9/0x3c0 fs/namespace.c:3875 do_syscall_64+0xfb/0x240 entry_SYSCALL_64_after_hwframe+0x72/0x7a RIP: 0033:0x7fd66947f4ea Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 de 09 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fd66a205ef8 EFLAGS: 00000202 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00007fd66a205f80 RCX: 00007fd66947f4ea RDX: 0000000020000000 RSI: 0000000020002380 RDI: 00007fd66a205f40 RBP: 0000000020000000 R08: 00007fd66a205f80 R09: 000000000080000c R10: 000000000080000c R11: 0000000000000202 R12: 0000000020002380 R13: 00007fd66a205f40 R14: 00000000000006da R15: 00000000200023c0