====================================================== WARNING: possible circular locking dependency detected 6.6.0-rc5-syzkaller-00157-ge8c127b05766 #0 Not tainted ------------------------------------------------------ syz-executor.2/28945 is trying to acquire lock: ffff88806471a0e0 (&type->s_umount_key#31){++++}-{3:3}, at: __super_lock fs/super.c:58 [inline] ffff88806471a0e0 (&type->s_umount_key#31){++++}-{3:3}, at: super_lock+0x176/0x390 fs/super.c:117 but task is already holding lock: ffff88801ac99808 (&bdev->bd_holder_lock){+.+.}-{3:3}, at: blkdev_flushbuf block/ioctl.c:370 [inline] ffff88801ac99808 (&bdev->bd_holder_lock){+.+.}-{3:3}, at: blkdev_common_ioctl+0x81e/0x2860 block/ioctl.c:502 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #4 (&bdev->bd_holder_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:747 bd_finish_claiming+0x231/0x3f0 block/bdev.c:566 blkdev_get_by_dev+0x481/0x620 block/bdev.c:799 setup_bdev_super+0x5d/0x600 fs/super.c:1484 mount_bdev+0x1e0/0x300 fs/super.c:1626 legacy_get_tree+0xef/0x190 fs/fs_context.c:638 vfs_get_tree+0x8c/0x280 fs/super.c:1750 do_new_mount+0x28f/0xae0 fs/namespace.c:3335 init_mount+0xd4/0x130 fs/init.c:25 do_mount_root+0x98/0x230 init/do_mounts.c:166 mount_root_generic+0x193/0x3b0 init/do_mounts.c:205 prepare_namespace+0xc2/0x100 init/do_mounts.c:489 kernel_init_freeable+0x46a/0x5c0 init/main.c:1560 kernel_init+0x1d/0x2a0 init/main.c:1437 ret_from_fork+0x48/0x80 arch/x86/kernel/process.c:147 ret_from_fork_asm+0x11/0x20 arch/x86/entry/entry_64.S:304 -> #3 (bdev_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:747 bd_prepare_to_claim+0x1b0/0x4c0 block/bdev.c:508 truncate_bdev_range+0x4e/0x260 block/bdev.c:105 blkdev_fallocate+0x2d2/0x440 block/fops.c:776 vfs_fallocate+0x551/0x6b0 fs/open.c:324 ksys_fallocate fs/open.c:347 [inline] __do_sys_fallocate fs/open.c:355 [inline] __se_sys_fallocate fs/open.c:353 [inline] __x64_sys_fallocate+0xbd/0x100 fs/open.c:353 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #2 (mapping.invalidate_lock#2){++++}-{3:3}: down_read+0xb1/0xa40 kernel/locking/rwsem.c:1520 filemap_invalidate_lock_shared include/linux/fs.h:857 [inline] page_cache_ra_unbounded+0xf1/0x7c0 mm/readahead.c:225 page_cache_sync_readahead include/linux/pagemap.h:1293 [inline] ext4_readdir+0xe36/0x37e0 fs/ext4/dir.c:194 iterate_dir+0x1cd/0x580 fs/readdir.c:106 __do_sys_getdents64 fs/readdir.c:405 [inline] __se_sys_getdents64+0x20d/0x4f0 fs/readdir.c:390 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (&type->i_mutex_dir_key#3){++++}-{3:3}: down_write+0x3a/0x50 kernel/locking/rwsem.c:1573 inode_lock include/linux/fs.h:802 [inline] ext4_process_orphan+0x164/0x2d0 fs/ext4/orphan.c:337 ext4_orphan_cleanup+0xb71/0x1400 fs/ext4/orphan.c:474 __ext4_fill_super fs/ext4/super.c:5582 [inline] ext4_fill_super+0x641a/0x6d10 fs/ext4/super.c:5703 get_tree_bdev+0x416/0x5b0 fs/super.c:1577 vfs_get_tree+0x8c/0x280 fs/super.c:1750 do_new_mount+0x28f/0xae0 fs/namespace.c:3335 do_mount fs/namespace.c:3675 [inline] __do_sys_mount fs/namespace.c:3884 [inline] __se_sys_mount+0x2d9/0x3c0 fs/namespace.c:3861 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&type->s_umount_key#31){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3868 [inline] __lock_acquire+0x39ff/0x7f70 kernel/locking/lockdep.c:5136 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5753 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1520 __super_lock fs/super.c:58 [inline] super_lock+0x176/0x390 fs/super.c:117 super_lock_shared fs/super.c:146 [inline] super_lock_shared_active fs/super.c:1431 [inline] fs_bdev_sync+0xa5/0x170 fs/super.c:1466 blkdev_flushbuf block/ioctl.c:372 [inline] blkdev_common_ioctl+0x889/0x2860 block/ioctl.c:502 blkdev_ioctl+0x520/0x730 block/ioctl.c:624 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:871 [inline] __se_sys_ioctl+0xf8/0x170 fs/ioctl.c:857 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &type->s_umount_key#31 --> bdev_lock --> &bdev->bd_holder_lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&bdev->bd_holder_lock); lock(bdev_lock); lock(&bdev->bd_holder_lock); rlock(&type->s_umount_key#31); *** DEADLOCK *** 1 lock held by syz-executor.2/28945: #0: ffff88801ac99808 (&bdev->bd_holder_lock){+.+.}-{3:3}, at: blkdev_flushbuf block/ioctl.c:370 [inline] #0: ffff88801ac99808 (&bdev->bd_holder_lock){+.+.}-{3:3}, at: blkdev_common_ioctl+0x81e/0x2860 block/ioctl.c:502 stack backtrace: CPU: 0 PID: 28945 Comm: syz-executor.2 Not tainted 6.6.0-rc5-syzkaller-00157-ge8c127b05766 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/06/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106 check_noncircular+0x375/0x4a0 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3868 [inline] __lock_acquire+0x39ff/0x7f70 kernel/locking/lockdep.c:5136 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5753 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1520 __super_lock fs/super.c:58 [inline] super_lock+0x176/0x390 fs/super.c:117 super_lock_shared fs/super.c:146 [inline] super_lock_shared_active fs/super.c:1431 [inline] fs_bdev_sync+0xa5/0x170 fs/super.c:1466 blkdev_flushbuf block/ioctl.c:372 [inline] blkdev_common_ioctl+0x889/0x2860 block/ioctl.c:502 blkdev_ioctl+0x520/0x730 block/ioctl.c:624 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:871 [inline] __se_sys_ioctl+0xf8/0x170 fs/ioctl.c:857 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f319b27cae9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f319bfdf0c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007f319b39bf80 RCX: 00007f319b27cae9 RDX: 0000000000000003 RSI: 0000000000001261 RDI: 0000000000000005 RBP: 00007f319b2c847a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007f319b39bf80 R15: 00007ffdb606de28