F2FS-fs (loop0): Mounted with checkpoint version = 48b305e5 ====================================================== WARNING: possible circular locking dependency detected 6.5.0-rc4-syzkaller-00009-g4b954598a47b #0 Not tainted ------------------------------------------------------ syz-executor200/5016 is trying to acquire lock: ffff888075e80528 (&fi->i_sem){+.+.}-{3:3}, at: f2fs_down_write fs/f2fs/f2fs.h:2133 [inline] ffff888075e80528 (&fi->i_sem){+.+.}-{3:3}, at: f2fs_add_inline_entry+0x3a8/0x760 fs/f2fs/inline.c:644 but task is already holding lock: ffff888075e810a0 (&fi->i_xattr_sem){.+.+}-{3:3}, at: f2fs_down_read fs/f2fs/f2fs.h:2108 [inline] ffff888075e810a0 (&fi->i_xattr_sem){.+.+}-{3:3}, at: f2fs_add_dentry+0x9f/0x1e0 fs/f2fs/dir.c:783 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&fi->i_xattr_sem){.+.+}-{3:3}: down_read+0x47/0x2f0 kernel/locking/rwsem.c:1520 f2fs_down_read fs/f2fs/f2fs.h:2108 [inline] f2fs_getxattr+0xb8/0x1460 fs/f2fs/xattr.c:532 __f2fs_get_acl+0x52/0x8e0 fs/f2fs/acl.c:179 f2fs_acl_create fs/f2fs/acl.c:377 [inline] f2fs_init_acl+0xd7/0x9a0 fs/f2fs/acl.c:420 f2fs_init_inode_metadata+0x824/0x1190 fs/f2fs/dir.c:558 f2fs_add_regular_entry+0x904/0xe30 fs/f2fs/dir.c:740 f2fs_add_dentry+0xf7/0x1e0 fs/f2fs/dir.c:788 f2fs_do_add_link+0x21e/0x340 fs/f2fs/dir.c:827 f2fs_add_link fs/f2fs/f2fs.h:3554 [inline] f2fs_mkdir+0x2f5/0x530 fs/f2fs/namei.c:781 vfs_mkdir+0x29d/0x450 fs/namei.c:4117 do_mkdirat+0x264/0x520 fs/namei.c:4140 __do_sys_mkdirat fs/namei.c:4155 [inline] __se_sys_mkdirat fs/namei.c:4153 [inline] __x64_sys_mkdirat+0x89/0xa0 fs/namei.c:4153 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&fi->i_sem){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3142 [inline] check_prevs_add kernel/locking/lockdep.c:3261 [inline] validate_chain kernel/locking/lockdep.c:3876 [inline] __lock_acquire+0x39ff/0x7f70 kernel/locking/lockdep.c:5144 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5761 down_write+0x3a/0x50 kernel/locking/rwsem.c:1573 f2fs_down_write fs/f2fs/f2fs.h:2133 [inline] f2fs_add_inline_entry+0x3a8/0x760 fs/f2fs/inline.c:644 f2fs_add_dentry+0xba/0x1e0 fs/f2fs/dir.c:784 f2fs_do_add_link+0x21e/0x340 fs/f2fs/dir.c:827 f2fs_rename fs/f2fs/namei.c:1071 [inline] f2fs_rename2+0x17ab/0x29b0 fs/f2fs/namei.c:1332 vfs_rename+0xaba/0xde0 fs/namei.c:4857 do_renameat2+0xd78/0x1660 fs/namei.c:5009 __do_sys_renameat2 fs/namei.c:5042 [inline] __se_sys_renameat2 fs/namei.c:5039 [inline] __x64_sys_renameat2+0xd2/0xe0 fs/namei.c:5039 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- rlock(&fi->i_xattr_sem); lock(&fi->i_sem); lock(&fi->i_xattr_sem); lock(&fi->i_sem); *** DEADLOCK *** 7 locks held by syz-executor200/5016: #0: ffff88807e130410 (sb_writers#9){.+.+}-{0:0}, at: mnt_want_write+0x3f/0x90 fs/namespace.c:403 #1: ffff88807e1306f8 (&type->s_vfs_rename_key){+.+.}-{3:3}, at: lock_rename fs/namei.c:3046 [inline] #1: ffff88807e1306f8 (&type->s_vfs_rename_key){+.+.}-{3:3}, at: do_renameat2+0x5c8/0x1660 fs/namei.c:4948 #2: ffff888079279300 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:806 [inline] #2: ffff888079279300 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: lock_two_directories+0x66/0x150 fs/namei.c:3019 #3: ffff888075e80a28 (&type->i_mutex_dir_key#7/2){+.+.}-{3:3}, at: lock_two_directories+0x107/0x150 #4: ffff888075e80150 (&sb->s_type->i_mutex_key#14){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:806 [inline] #4: ffff888075e80150 (&sb->s_type->i_mutex_key#14){+.+.}-{3:3}, at: lock_two_inodes+0x100/0x180 fs/inode.c:1143 #5: ffff888079c603b0 (&sbi->cp_rwsem){.+.+}-{3:3}, at: f2fs_down_read fs/f2fs/f2fs.h:2108 [inline] #5: ffff888079c603b0 (&sbi->cp_rwsem){.+.+}-{3:3}, at: f2fs_lock_op fs/f2fs/f2fs.h:2151 [inline] #5: ffff888079c603b0 (&sbi->cp_rwsem){.+.+}-{3:3}, at: f2fs_rename fs/f2fs/namei.c:1069 [inline] #5: ffff888079c603b0 (&sbi->cp_rwsem){.+.+}-{3:3}, at: f2fs_rename2+0x1799/0x29b0 fs/f2fs/namei.c:1332 #6: ffff888075e810a0 (&fi->i_xattr_sem){.+.+}-{3:3}, at: f2fs_down_read fs/f2fs/f2fs.h:2108 [inline] #6: ffff888075e810a0 (&fi->i_xattr_sem){.+.+}-{3:3}, at: f2fs_add_dentry+0x9f/0x1e0 fs/f2fs/dir.c:783 stack backtrace: CPU: 1 PID: 5016 Comm: syz-executor200 Not tainted 6.5.0-rc4-syzkaller-00009-g4b954598a47b #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106 check_noncircular+0x375/0x4a0 kernel/locking/lockdep.c:2195 check_prev_add kernel/locking/lockdep.c:3142 [inline] check_prevs_add kernel/locking/lockdep.c:3261 [inline] validate_chain kernel/locking/lockdep.c:3876 [inline] __lock_acquire+0x39ff/0x7f70 kernel/locking/lockdep.c:5144 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5761 down_write+0x3a/0x50 kernel/locking/rwsem.c:1573 f2fs_down_write fs/f2fs/f2fs.h:2133 [inline] f2fs_add_inline_entry+0x3a8/0x760 fs/f2fs/inline.c:644 f2fs_add_dentry+0xba/0x1e0 fs/f2fs/dir.c:784 f2fs_do_add_link+0x21e/0x340 fs/f2fs/dir.c:827 f2fs_rename fs/f2fs/namei.c:1071 [inline] f2fs_rename2+0x17ab/0x29b0 fs/f2fs/namei.c:1332 vfs_rename+0xaba/0xde0 fs/namei.c:4857 do_renameat2+0xd78/0x1660 fs/namei.c:5009 __do_sys_renameat2 fs/namei.c:5042 [inline] __se_sys_renameat2 fs/namei.c:5039 [inline] __x64_sys_renameat2+0xd2/0xe0 fs/namei.c:5039 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7fe16f115739 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 61 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffd9001dcd8 EFLAGS: 00000246 ORIG_RAX: 000000000000013c RAX: ffffffffffffffda RBX: 0030656c69662f2e RCX: 00007fe16f115739 RDX: 0000000000000004 RSI: 00000000200001c0 RDI: 0000000000000004 RBP: 00007fe16f18d610 R08: 0000000000000000 R09: 00007ffd9001dea8 R10: 00000000200002c0 R11: 0000000000000246 R12: