====================================================== WARNING: possible circular locking dependency detected 4.19.211-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.3/21892 is trying to acquire lock: 0000000090f63a84 (sb_writers#3){.+.+}, at: sb_start_write include/linux/fs.h:1579 [inline] 0000000090f63a84 (sb_writers#3){.+.+}, at: mnt_want_write+0x3a/0xb0 fs/namespace.c:360 but task is already holding lock: 000000002610d828 (&ovl_i_mutex_dir_key[depth]){++++}, at: inode_lock include/linux/fs.h:748 [inline] 000000002610d828 (&ovl_i_mutex_dir_key[depth]){++++}, at: do_last fs/namei.c:3324 [inline] 000000002610d828 (&ovl_i_mutex_dir_key[depth]){++++}, at: path_openat+0x1071/0x2df0 fs/namei.c:3537 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&ovl_i_mutex_dir_key[depth]){++++}: inode_lock_shared include/linux/fs.h:758 [inline] do_last fs/namei.c:3326 [inline] path_openat+0x17ec/0x2df0 fs/namei.c:3537 do_filp_open+0x18c/0x3f0 fs/namei.c:3567 do_open_execat+0x11d/0x5b0 fs/exec.c:853 __do_execve_file+0x1a8b/0x2360 fs/exec.c:1770 do_execveat_common fs/exec.c:1879 [inline] do_execveat+0x3d/0x50 fs/exec.c:1907 __do_sys_execveat fs/exec.c:1988 [inline] __se_sys_execveat fs/exec.c:1980 [inline] __x64_sys_execveat+0xe1/0x120 fs/exec.c:1980 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe -> #2 (&sig->cred_guard_mutex){+.+.}: do_io_accounting fs/proc/base.c:2750 [inline] proc_tgid_io_accounting+0x1cf/0x7f0 fs/proc/base.c:2799 proc_single_show+0xeb/0x170 fs/proc/base.c:755 seq_read+0x4e0/0x11c0 fs/seq_file.c:232 do_loop_readv_writev fs/read_write.c:701 [inline] do_loop_readv_writev fs/read_write.c:688 [inline] do_iter_read+0x471/0x630 fs/read_write.c:925 vfs_readv+0xe5/0x150 fs/read_write.c:987 do_preadv fs/read_write.c:1071 [inline] __do_sys_preadv fs/read_write.c:1121 [inline] __se_sys_preadv fs/read_write.c:1116 [inline] __x64_sys_preadv+0x22b/0x310 fs/read_write.c:1116 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe -> #1 (&p->lock){+.+.}: seq_read+0x6b/0x11c0 fs/seq_file.c:164 proc_reg_read+0x1bd/0x2d0 fs/proc/inode.c:231 do_loop_readv_writev fs/read_write.c:701 [inline] do_loop_readv_writev fs/read_write.c:688 [inline] do_iter_read+0x471/0x630 fs/read_write.c:925 vfs_readv+0xe5/0x150 fs/read_write.c:987 kernel_readv fs/splice.c:362 [inline] default_file_splice_read+0x457/0xa00 fs/splice.c:417 do_splice_to+0x10e/0x160 fs/splice.c:881 splice_direct_to_actor+0x2b9/0x8d0 fs/splice.c:959 do_splice_direct+0x1a7/0x270 fs/splice.c:1068 do_sendfile+0x550/0xc30 fs/read_write.c:1447 __do_sys_sendfile64 fs/read_write.c:1508 [inline] __se_sys_sendfile64+0x147/0x160 fs/read_write.c:1494 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe -> #0 (sb_writers#3){.+.+}: percpu_down_read_preempt_disable include/linux/percpu-rwsem.h:36 [inline] percpu_down_read include/linux/percpu-rwsem.h:59 [inline] __sb_start_write+0x6e/0x2a0 fs/super.c:1366 sb_start_write include/linux/fs.h:1579 [inline] mnt_want_write+0x3a/0xb0 fs/namespace.c:360 ovl_create_object+0x96/0x290 fs/overlayfs/dir.c:602 lookup_open+0x893/0x1a20 fs/namei.c:3235 do_last fs/namei.c:3327 [inline] path_openat+0x1094/0x2df0 fs/namei.c:3537 do_filp_open+0x18c/0x3f0 fs/namei.c:3567 do_sys_open+0x3b3/0x520 fs/open.c:1085 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe other info that might help us debug this: Chain exists of: sb_writers#3 --> &sig->cred_guard_mutex --> &ovl_i_mutex_dir_key[depth] Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ovl_i_mutex_dir_key[depth]); lock(&sig->cred_guard_mutex); lock(&ovl_i_mutex_dir_key[depth]); lock(sb_writers#3); *** DEADLOCK *** 2 locks held by syz-executor.3/21892: #0: 00000000d7b25842 (sb_writers#25){.+.+}, at: sb_start_write include/linux/fs.h:1579 [inline] #0: 00000000d7b25842 (sb_writers#25){.+.+}, at: mnt_want_write+0x3a/0xb0 fs/namespace.c:360 #1: 000000002610d828 (&ovl_i_mutex_dir_key[depth]){++++}, at: inode_lock include/linux/fs.h:748 [inline] #1: 000000002610d828 (&ovl_i_mutex_dir_key[depth]){++++}, at: do_last fs/namei.c:3324 [inline] #1: 000000002610d828 (&ovl_i_mutex_dir_key[depth]){++++}, at: path_openat+0x1071/0x2df0 fs/namei.c:3537 stack backtrace: CPU: 1 PID: 21892 Comm: syz-executor.3 Not tainted 4.19.211-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x1fc/0x2ef lib/dump_stack.c:118 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1222 check_prev_add kernel/locking/lockdep.c:1866 [inline] check_prevs_add kernel/locking/lockdep.c:1979 [inline] validate_chain kernel/locking/lockdep.c:2420 [inline] __lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3416 lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908 percpu_down_read_preempt_disable include/linux/percpu-rwsem.h:36 [inline] percpu_down_read include/linux/percpu-rwsem.h:59 [inline] __sb_start_write+0x6e/0x2a0 fs/super.c:1366 sb_start_write include/linux/fs.h:1579 [inline] mnt_want_write+0x3a/0xb0 fs/namespace.c:360 ovl_create_object+0x96/0x290 fs/overlayfs/dir.c:602 lookup_open+0x893/0x1a20 fs/namei.c:3235 do_last fs/namei.c:3327 [inline] path_openat+0x1094/0x2df0 fs/namei.c:3537 do_filp_open+0x18c/0x3f0 fs/namei.c:3567 do_sys_open+0x3b3/0x520 fs/open.c:1085 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x7f915e89e0f9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f915cdef168 EFLAGS: 00000246 ORIG_RAX: 0000000000000002 RAX: ffffffffffffffda RBX: 00007f915e9be050 RCX: 00007f915e89e0f9 RDX: 0000000000000000 RSI: 0000000000141042 RDI: 0000000020000040 RBP: 00007f915e8f9ae9 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffcc62e439f R14: 00007f915cdef300 R15: 0000000000022000 ieee80211 phy40: Selected rate control algorithm 'minstrel_ht' ieee80211 phy41: Selected rate control algorithm 'minstrel_ht' ieee80211 phy42: Selected rate control algorithm 'minstrel_ht' ieee80211 phy43: Selected rate control algorithm 'minstrel_ht' input: syz0 as /devices/virtual/input/input5 input: syz0 as /devices/virtual/input/input6 input: syz0 as /devices/virtual/input/input7 input: syz0 as /devices/virtual/input/input8 XFS (loop2): Mounting V4 Filesystem XFS (loop2): Ending clean mount XFS (loop2): Quotacheck needed: Please wait. XFS (loop2): Quotacheck: Done. kauditd_printk_skb: 5 callbacks suppressed audit: type=1804 audit(1678171651.944:372): pid=22128 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.2" name="/root/syzkaller-testdir1633499476/syzkaller.1Pbw1F/186/file0/bus" dev="loop2" ino=42 res=1 audit: type=1804 audit(1678171652.234:373): pid=22148 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=ToMToU comm="syz-executor.2" name="/root/syzkaller-testdir1633499476/syzkaller.1Pbw1F/186/file0/bus" dev="loop2" ino=42 res=1 XFS (loop2): Unmounting Filesystem (syz-executor.3,22228,1):ocfs2_parse_options:1513 ERROR: Invalid heartbeat mount options (syz-executor.3,22228,1):ocfs2_fill_super:1225 ERROR: status = -22 XFS (loop2): Mounting V4 Filesystem XFS (loop2): Ending clean mount XFS (loop2): Quotacheck needed: Please wait. XFS (loop2): Quotacheck: Done. audit: type=1804 audit(1678171653.634:374): pid=22229 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.2" name="/root/syzkaller-testdir1633499476/syzkaller.1Pbw1F/187/file0/bus" dev="loop2" ino=42 res=1 audit: type=1804 audit(1678171653.664:375): pid=22229 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.2" name="/root/syzkaller-testdir1633499476/syzkaller.1Pbw1F/187/file0/bus" dev="loop2" ino=42 res=1 audit: type=1804 audit(1678171654.024:376): pid=22253 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=ToMToU comm="syz-executor.2" name="/root/syzkaller-testdir1633499476/syzkaller.1Pbw1F/187/file0/bus" dev="loop2" ino=42 res=1 XFS (loop2): Unmounting Filesystem (syz-executor.3,22260,0):ocfs2_parse_options:1513 ERROR: Invalid heartbeat mount options (syz-executor.3,22260,0):ocfs2_fill_super:1225 ERROR: status = -22 audit: type=1804 audit(1678171654.424:377): pid=22267 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.2" name="/root/syzkaller-testdir1633499476/syzkaller.1Pbw1F/188/bus" dev="sda1" ino=14819 res=1 audit: type=1804 audit(1678171654.484:378): pid=22268 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=ToMToU comm="syz-executor.2" name="/root/syzkaller-testdir1633499476/syzkaller.1Pbw1F/188/bus" dev="sda1" ino=14819 res=1 XFS (loop2): Mounting V4 Filesystem XFS (loop2): Ending clean mount XFS (loop2): Quotacheck needed: Please wait. XFS (loop2): Quotacheck: Done. XFS (loop2): Unmounting Filesystem IPVS: ftp: loaded support on port[0] = 21 chnl_net:caif_netlink_parms(): no params data found bridge0: port 1(bridge_slave_0) entered blocking state bridge0: port 1(bridge_slave_0) entered disabled state device bridge_slave_0 entered promiscuous mode bridge0: port 2(bridge_slave_1) entered blocking state bridge0: port 2(bridge_slave_1) entered disabled state device bridge_slave_1 entered promiscuous mode bond0: Enslaving bond_slave_0 as an active interface with an up link bond0: Enslaving bond_slave_1 as an active interface with an up link IPv6: ADDRCONF(NETDEV_UP): team_slave_0: link is not ready team0: Port device team_slave_0 added IPv6: ADDRCONF(NETDEV_UP): team_slave_1: link is not ready team0: Port device team_slave_1 added batman_adv: batadv0: Adding interface: batadv_slave_0 batman_adv: batadv0: The MTU of interface batadv_slave_0 is too small (1500) to handle the transport of batman-adv packets. Packets going over this interface will be fragmented on layer2 which could impact the performance. Setting the MTU to 1560 would solve the problem. batman_adv: batadv0: Not using interface batadv_slave_0 (retrying later): interface not active batman_adv: batadv0: Adding interface: batadv_slave_1 batman_adv: batadv0: The MTU of interface batadv_slave_1 is too small (1500) to handle the transport of batman-adv packets. Packets going over this interface will be fragmented on layer2 which could impact the performance. Setting the MTU to 1560 would solve the problem.