overlayfs: upper fs does not support RENAME_WHITEOUT. ====================================================== WARNING: possible circular locking dependency detected 5.15.175-syzkaller #0 Not tainted ------------------------------------------------------ syz.5.283/5438 is trying to acquire lock: ffff0000cb6e1090 (&sbi->lock){+.+.}-{3:3}, at: reiserfs_write_lock+0x7c/0xe8 fs/reiserfs/lock.c:27 but task is already holding lock: ffff0000e8b00980 (&type->i_mutex_dir_key#11/3){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline] ffff0000e8b00980 (&type->i_mutex_dir_key#11/3){+.+.}-{3:3}, at: open_xa_root fs/reiserfs/xattr.c:127 [inline] ffff0000e8b00980 (&type->i_mutex_dir_key#11/3){+.+.}-{3:3}, at: open_xa_dir+0x11c/0x578 fs/reiserfs/xattr.c:152 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&type->i_mutex_dir_key#11/3){+.+.}-{3:3}: down_write_nested+0xc0/0x130 kernel/locking/rwsem.c:1667 inode_lock_nested include/linux/fs.h:824 [inline] open_xa_root fs/reiserfs/xattr.c:127 [inline] open_xa_dir+0x11c/0x578 fs/reiserfs/xattr.c:152 reiserfs_for_each_xattr+0x16c/0x8d8 fs/reiserfs/xattr.c:252 reiserfs_delete_xattrs+0x2c/0xa4 fs/reiserfs/xattr.c:364 reiserfs_evict_inode+0x1dc/0x3f0 fs/reiserfs/inode.c:53 evict+0x418/0x894 fs/inode.c:622 iput_final fs/inode.c:1744 [inline] iput+0x744/0x824 fs/inode.c:1770 reiserfs_mknod+0x2d0/0x5a8 vfs_mknod+0x3c8/0x448 fs/namei.c:3944 unix_bind_bsd net/unix/af_unix.c:1076 [inline] unix_bind+0x428/0x7f4 net/unix/af_unix.c:1164 __sys_bind+0x1e8/0x284 net/socket.c:1720 __do_sys_bind net/socket.c:1731 [inline] __se_sys_bind net/socket.c:1729 [inline] __arm64_sys_bind+0x7c/0x94 net/socket.c:1729 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #0 (&sbi->lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 reiserfs_write_lock+0x7c/0xe8 fs/reiserfs/lock.c:27 reiserfs_mkdir+0x280/0x77c fs/reiserfs/namei.c:831 xattr_mkdir fs/reiserfs/xattr.c:76 [inline] open_xa_root fs/reiserfs/xattr.c:136 [inline] open_xa_dir+0x288/0x578 fs/reiserfs/xattr.c:152 xattr_lookup+0x3c/0x268 fs/reiserfs/xattr.c:395 reiserfs_xattr_set_handle+0xe4/0xc10 fs/reiserfs/xattr.c:540 reiserfs_xattr_set+0x398/0x4b0 fs/reiserfs/xattr.c:640 trusted_set+0x98/0xec fs/reiserfs/xattr_trusted.c:31 __vfs_setxattr+0x388/0x3a4 fs/xattr.c:182 __vfs_setxattr_noperm+0x110/0x528 fs/xattr.c:216 __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:277 vfs_setxattr+0x1a8/0x344 fs/xattr.c:303 ovl_do_setxattr fs/overlayfs/overlayfs.h:203 [inline] ovl_make_workdir fs/overlayfs/super.c:1420 [inline] ovl_get_workdir+0x980/0x1110 fs/overlayfs/super.c:1524 ovl_fill_super+0x15b4/0x2254 fs/overlayfs/super.c:2080 mount_nodev+0x68/0x104 fs/super.c:1446 ovl_mount+0x3c/0x50 fs/overlayfs/super.c:2171 legacy_get_tree+0xd4/0x16c fs/fs_context.c:611 vfs_get_tree+0x90/0x274 fs/super.c:1530 do_new_mount+0x278/0x8fc fs/namespace.c:3012 path_mount+0x594/0x101c fs/namespace.c:3342 do_mount fs/namespace.c:3355 [inline] __do_sys_mount fs/namespace.c:3563 [inline] __se_sys_mount fs/namespace.c:3540 [inline] __arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3540 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&type->i_mutex_dir_key#11/3); lock(&sbi->lock); lock(&type->i_mutex_dir_key#11/3); lock(&sbi->lock); *** DEADLOCK *** 4 locks held by syz.5.283/5438: #0: ffff0000eec8e0e0 (&type->s_umount_key#51/1){+.+.}-{3:3}, at: alloc_super+0x1b8/0x844 fs/super.c:229 #1: ffff0000e2d40460 (sb_writers#20){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:377 #2: ffff0000e8b02400 (&type->i_mutex_dir_key#11){++++}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #2: ffff0000e8b02400 (&type->i_mutex_dir_key#11){++++}-{3:3}, at: vfs_setxattr+0x17c/0x344 fs/xattr.c:302 #3: ffff0000e8b00980 (&type->i_mutex_dir_key#11/3){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline] #3: ffff0000e8b00980 (&type->i_mutex_dir_key#11/3){+.+.}-{3:3}, at: open_xa_root fs/reiserfs/xattr.c:127 [inline] #3: ffff0000e8b00980 (&type->i_mutex_dir_key#11/3){+.+.}-{3:3}, at: open_xa_dir+0x11c/0x578 fs/reiserfs/xattr.c:152 stack backtrace: CPU: 0 PID: 5438 Comm: syz.5.283 Not tainted 5.15.175-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call trace: dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 reiserfs_write_lock+0x7c/0xe8 fs/reiserfs/lock.c:27 reiserfs_mkdir+0x280/0x77c fs/reiserfs/namei.c:831 xattr_mkdir fs/reiserfs/xattr.c:76 [inline] open_xa_root fs/reiserfs/xattr.c:136 [inline] open_xa_dir+0x288/0x578 fs/reiserfs/xattr.c:152 xattr_lookup+0x3c/0x268 fs/reiserfs/xattr.c:395 reiserfs_xattr_set_handle+0xe4/0xc10 fs/reiserfs/xattr.c:540 reiserfs_xattr_set+0x398/0x4b0 fs/reiserfs/xattr.c:640 trusted_set+0x98/0xec fs/reiserfs/xattr_trusted.c:31 __vfs_setxattr+0x388/0x3a4 fs/xattr.c:182 __vfs_setxattr_noperm+0x110/0x528 fs/xattr.c:216 __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:277 vfs_setxattr+0x1a8/0x344 fs/xattr.c:303 ovl_do_setxattr fs/overlayfs/overlayfs.h:203 [inline] ovl_make_workdir fs/overlayfs/super.c:1420 [inline] ovl_get_workdir+0x980/0x1110 fs/overlayfs/super.c:1524 ovl_fill_super+0x15b4/0x2254 fs/overlayfs/super.c:2080 mount_nodev+0x68/0x104 fs/super.c:1446 ovl_mount+0x3c/0x50 fs/overlayfs/super.c:2171 legacy_get_tree+0xd4/0x16c fs/fs_context.c:611 vfs_get_tree+0x90/0x274 fs/super.c:1530 do_new_mount+0x278/0x8fc fs/namespace.c:3012 path_mount+0x594/0x101c fs/namespace.c:3342 do_mount fs/namespace.c:3355 [inline] __do_sys_mount fs/namespace.c:3563 [inline] __se_sys_mount fs/namespace.c:3540 [inline] __arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3540 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584