====================================================== WARNING: possible circular locking dependency detected 6.0.0-rc1-next-20220819-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.2/14601 is trying to acquire lock: ffff88814bd80650 (sb_internal){.+.+}-{0:0}, at: evict+0x2ed/0x6b0 fs/inode.c:666 but task is already holding lock: ffff88814bd82bd8 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_ext_migrate+0x22c/0x1c10 fs/ext4/migrate.c:437 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&sbi->s_writepages_rwsem){++++}-{0:0}: percpu_down_read include/linux/percpu-rwsem.h:51 [inline] ext4_writepages+0x1c4/0x3b60 fs/ext4/inode.c:2687 do_writepages+0x1ab/0x690 mm/page-writeback.c:2468 filemap_fdatawrite_wbc mm/filemap.c:388 [inline] filemap_fdatawrite_wbc+0x143/0x1b0 mm/filemap.c:378 __filemap_fdatawrite_range+0xb4/0xf0 mm/filemap.c:421 filemap_write_and_wait_range+0x85/0x100 mm/filemap.c:673 __iomap_dio_rw+0x5ed/0x1c20 fs/iomap/direct-io.c:573 iomap_dio_rw+0x3c/0xa0 fs/iomap/direct-io.c:690 ext4_dio_write_iter fs/ext4/file.c:566 [inline] ext4_file_write_iter+0xf21/0x1660 fs/ext4/file.c:677 call_write_iter include/linux/fs.h:2188 [inline] do_iter_readv_writev+0x20b/0x3b0 fs/read_write.c:729 do_iter_write+0x182/0x700 fs/read_write.c:855 vfs_iter_write+0x70/0xa0 fs/read_write.c:896 iter_file_splice_write+0x741/0xc90 fs/splice.c:686 do_splice_from fs/splice.c:764 [inline] direct_splice_actor+0x110/0x180 fs/splice.c:931 splice_direct_to_actor+0x331/0x8a0 fs/splice.c:886 do_splice_direct+0x1a7/0x270 fs/splice.c:974 do_sendfile+0xb19/0x1270 fs/read_write.c:1249 __do_sys_sendfile64 fs/read_write.c:1317 [inline] __se_sys_sendfile64 fs/read_write.c:1303 [inline] __x64_sys_sendfile64+0x1cc/0x210 fs/read_write.c:1303 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #2 (&sb->s_type->i_mutex_key#8){++++}-{3:3}: down_read+0x98/0x450 kernel/locking/rwsem.c:1499 inode_lock_shared include/linux/fs.h:766 [inline] ext4_bmap+0x4e/0x460 fs/ext4/inode.c:3157 bmap+0xaa/0x120 fs/inode.c:1800 jbd2_journal_bmap+0xa8/0x180 fs/jbd2/journal.c:971 __jbd2_journal_erase fs/jbd2/journal.c:1784 [inline] jbd2_journal_flush+0x84f/0xc00 fs/jbd2/journal.c:2490 ext4_ioctl_checkpoint fs/ext4/ioctl.c:1082 [inline] __ext4_ioctl+0x28fd/0x4ab0 fs/ext4/ioctl.c:1586 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (&journal->j_checkpoint_mutex){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:603 [inline] mutex_lock_io_nested+0x13f/0x1190 kernel/locking/mutex.c:833 __jbd2_log_wait_for_space+0x234/0x460 fs/jbd2/checkpoint.c:110 add_transaction_credits+0xa2d/0xb70 fs/jbd2/transaction.c:298 start_this_handle+0x3ae/0x14a0 fs/jbd2/transaction.c:422 jbd2__journal_start+0x38c/0x910 fs/jbd2/transaction.c:520 __ext4_journal_start_sb+0x3a3/0x490 fs/ext4/ext4_jbd2.c:105 __ext4_journal_start fs/ext4/ext4_jbd2.h:326 [inline] ext4_evict_inode+0x990/0x1d40 fs/ext4/inode.c:251 evict+0x2ed/0x6b0 fs/inode.c:666 iput_final fs/inode.c:1749 [inline] iput.part.0+0x55d/0x810 fs/inode.c:1775 iput+0x58/0x70 fs/inode.c:1765 do_unlinkat+0x41b/0x650 fs/namei.c:4304 __do_sys_unlink fs/namei.c:4345 [inline] __se_sys_unlink fs/namei.c:4343 [inline] __x64_sys_unlink+0xc6/0x110 fs/namei.c:4343 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (sb_internal){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3095 [inline] check_prevs_add kernel/locking/lockdep.c:3214 [inline] validate_chain kernel/locking/lockdep.c:3829 [inline] __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5053 lock_acquire kernel/locking/lockdep.c:5666 [inline] lock_acquire+0x1ab/0x570 kernel/locking/lockdep.c:5631 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1826 [inline] sb_start_intwrite include/linux/fs.h:1948 [inline] ext4_evict_inode+0x11de/0x1d40 fs/ext4/inode.c:240 evict+0x2ed/0x6b0 fs/inode.c:666 iput_final fs/inode.c:1749 [inline] iput.part.0+0x55d/0x810 fs/inode.c:1775 iput+0x58/0x70 fs/inode.c:1765 ext4_ext_migrate+0xb9d/0x1c10 fs/ext4/migrate.c:587 __ext4_ioctl+0x12a4/0x4ab0 fs/ext4/ioctl.c:1388 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: sb_internal --> &sb->s_type->i_mutex_key#8 --> &sbi->s_writepages_rwsem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&sbi->s_writepages_rwsem); lock(&sb->s_type->i_mutex_key#8); lock(&sbi->s_writepages_rwsem); lock(sb_internal); *** DEADLOCK *** 3 locks held by syz-executor.2/14601: #0: ffff88814bd80460 (sb_writers#4){.+.+}-{0:0}, at: __ext4_ioctl+0x1273/0x4ab0 fs/ext4/ioctl.c:1378 #1: ffff8880306bca38 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: inode_lock include/linux/fs.h:756 [inline] #1: ffff8880306bca38 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: __ext4_ioctl+0x129c/0x4ab0 fs/ext4/ioctl.c:1387 #2: ffff88814bd82bd8 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_ext_migrate+0x22c/0x1c10 fs/ext4/migrate.c:437 stack backtrace: CPU: 0 PID: 14601 Comm: syz-executor.2 Not tainted 6.0.0-rc1-next-20220819-syzkaller #0 BUG: sleeping function called from invalid context at kernel/locking/rwsem.c:1521 in_atomic(): 0, irqs_disabled(): 1, non_block: 0, pid: 14601, name: syz-executor.2 preempt_count: 0, expected: 0 RCU nest depth: 0, expected: 0 INFO: lockdep is turned off. irq event stamp: 263 hardirqs last enabled at (263): [] raw_spin_rq_unlock_irq kernel/sched/sched.h:1352 [inline] hardirqs last enabled at (263): [] finish_lock_switch kernel/sched/core.c:4956 [inline] hardirqs last enabled at (263): [] finish_task_switch.isra.0+0x2b5/0xc70 kernel/sched/core.c:5074 hardirqs last disabled at (262): [] __schedule+0x2907/0x52b0 kernel/sched/core.c:6408 softirqs last enabled at (0): [] copy_process+0x2138/0x7120 kernel/fork.c:2204 softirqs last disabled at (0): [<0000000000000000>] 0x0 CPU: 0 PID: 14601 Comm: syz-executor.2 Not tainted 6.0.0-rc1-next-20220819-syzkaller #0 syz-executor.2[14601] cmdline: /root/syz-executor.2 exec Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/22/2022 Call Trace: __dump_stack lib/dump_stack.c:122 [inline] dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:140 __might_resched.cold+0x222/0x26b kernel/sched/core.c:9896 down_read_killable+0x75/0x490 kernel/locking/rwsem.c:1521 mmap_read_lock_killable include/linux/mmap_lock.h:126 [inline] __access_remote_vm+0xac/0x6f0 mm/memory.c:5461 get_mm_cmdline.part.0+0x217/0x620 fs/proc/base.c:299 get_mm_cmdline fs/proc/base.c:367 [inline] get_task_cmdline_kernel+0x1d9/0x220 fs/proc/base.c:367 dump_stack_print_cmdline.part.0+0x82/0x150 lib/dump_stack.c:61 dump_stack_print_cmdline lib/dump_stack.c:89 [inline] dump_stack_print_info+0x185/0x190 lib/dump_stack.c:97 __dump_stack lib/dump_stack.c:121 [inline] dump_stack_lvl+0xc1/0x134 lib/dump_stack.c:140 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2175 check_prev_add kernel/locking/lockdep.c:3095 [inline] check_prevs_add kernel/locking/lockdep.c:3214 [inline] validate_chain kernel/locking/lockdep.c:3829 [inline] __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5053 lock_acquire kernel/locking/lockdep.c:5666 [inline] lock_acquire+0x1ab/0x570 kernel/locking/lockdep.c:5631 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1826 [inline] sb_start_intwrite include/linux/fs.h:1948 [inline] ext4_evict_inode+0x11de/0x1d40 fs/ext4/inode.c:240 evict+0x2ed/0x6b0 fs/inode.c:666 iput_final fs/inode.c:1749 [inline] iput.part.0+0x55d/0x810 fs/inode.c:1775 iput+0x58/0x70 fs/inode.c:1765 ext4_ext_migrate+0xb9d/0x1c10 fs/ext4/migrate.c:587 __ext4_ioctl+0x12a4/0x4ab0 fs/ext4/ioctl.c:1388 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f3bafe89279 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f3baf5de168 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007f3baff9c050 RCX: 00007f3bafe89279 RDX: 0000000000000000 RSI: 0000000000006609 RDI: 0000000000000003 RBP: 00007f3bafee3189 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffd80b8222f R14: 00007f3baf5de300 R15: 0000000000022000 syz-executor.2[14601] cmdline: /root/syz-executor.2 exec Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/22/2022 Call Trace: __dump_stack lib/dump_stack.c:122 [inline] dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:140 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2175 check_prev_add kernel/locking/lockdep.c:3095 [inline] check_prevs_add kernel/locking/lockdep.c:3214 [inline] validate_chain kernel/locking/lockdep.c:3829 [inline] __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5053 lock_acquire kernel/locking/lockdep.c:5666 [inline] lock_acquire+0x1ab/0x570 kernel/locking/lockdep.c:5631 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1826 [inline] sb_start_intwrite include/linux/fs.h:1948 [inline] ext4_evict_inode+0x11de/0x1d40 fs/ext4/inode.c:240 evict+0x2ed/0x6b0 fs/inode.c:666 iput_final fs/inode.c:1749 [inline] iput.part.0+0x55d/0x810 fs/inode.c:1775 iput+0x58/0x70 fs/inode.c:1765 ext4_ext_migrate+0xb9d/0x1c10 fs/ext4/migrate.c:587 __ext4_ioctl+0x12a4/0x4ab0 fs/ext4/ioctl.c:1388 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f3bafe89279 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f3baf5de168 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007f3baff9c050 RCX: 00007f3bafe89279 RDX: 0000000000000000 RSI: 0000000000006609 RDI: 0000000000000003 RBP: 00007f3bafee3189 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffd80b8222f R14: 00007f3baf5de300 R15: 0000000000022000