====================================================== WARNING: possible circular locking dependency detected 5.15.139-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.0/10368 is trying to acquire lock: ffff88808efab8f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_allocate+0x8a/0x8d0 fs/hfsplus/bitmap.c:35 but task is already holding lock: ffff88808c8e0108 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1d2/0x1b10 fs/hfsplus/extents.c:457 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfsplus_get_block+0x37f/0x14e0 fs/hfsplus/extents.c:260 block_read_full_page+0x2f9/0xde0 fs/buffer.c:2290 do_read_cache_page+0x752/0x1040 read_mapping_page include/linux/pagemap.h:515 [inline] hfsplus_block_allocate+0xfa/0x8d0 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0xa4c/0x1b10 fs/hfsplus/extents.c:468 hfsplus_get_block+0x402/0x14e0 fs/hfsplus/extents.c:245 __block_write_begin_int+0x60b/0x1650 fs/buffer.c:2012 __block_write_begin fs/buffer.c:2062 [inline] block_write_begin fs/buffer.c:2122 [inline] cont_write_begin+0x5d6/0x840 fs/buffer.c:2471 hfsplus_write_begin+0x92/0xd0 fs/hfsplus/inode.c:53 cont_expand_zero fs/buffer.c:2431 [inline] cont_write_begin+0x654/0x840 fs/buffer.c:2461 hfsplus_write_begin+0x92/0xd0 fs/hfsplus/inode.c:53 generic_cont_expand_simple+0x144/0x230 fs/buffer.c:2362 hfsplus_setattr+0x169/0x280 fs/hfsplus/inode.c:261 notify_change+0xc6d/0xf50 fs/attr.c:505 do_truncate+0x21c/0x300 fs/open.c:65 vfs_truncate+0x2dd/0x3a0 fs/open.c:111 do_sys_truncate+0xda/0x190 fs/open.c:134 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb -> #0 (&sbi->alloc_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfsplus_block_allocate+0x8a/0x8d0 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0xa4c/0x1b10 fs/hfsplus/extents.c:468 hfsplus_bmap_reserve+0x101/0x4e0 fs/hfsplus/btree.c:357 hfsplus_rename_cat+0x1cf/0x1090 fs/hfsplus/catalog.c:456 hfsplus_unlink+0x304/0x7f0 fs/hfsplus/dir.c:376 hfsplus_rename+0xc4/0x1b0 fs/hfsplus/dir.c:547 vfs_rename+0xbfc/0xf90 fs/namei.c:4742 do_renameat2+0xb97/0x13b0 fs/namei.c:4892 __do_sys_rename fs/namei.c:4938 [inline] __se_sys_rename fs/namei.c:4936 [inline] __x64_sys_rename+0x82/0x90 fs/namei.c:4936 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 7 locks held by syz-executor.0/10368: #0: ffff88801efa6460 (sb_writers#23){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377 #1: ffff88808c8e24c0 (&type->i_mutex_dir_key#14/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:822 [inline] #1: ffff88808c8e24c0 (&type->i_mutex_dir_key#14/1){+.+.}-{3:3}, at: lock_rename+0xf6/0x1c0 fs/namei.c:2967 #2: ffff88808c8e4d40 (&sb->s_type->i_mutex_key#28){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:822 [inline] #2: ffff88808c8e4d40 (&sb->s_type->i_mutex_key#28){+.+.}-{3:3}, at: lock_two_inodes+0xfc/0x180 fs/inode.c:1063 #3: ffff88808c8e5ac0 (&sb->s_type->i_mutex_key#28/4){+.+.}-{3:3}, at: vfs_rename+0x749/0xf90 fs/namei.c:4714 #4: ffff88808efab998 (&sbi->vh_mutex){+.+.}-{3:3}, at: hfsplus_unlink+0x15d/0x7f0 fs/hfsplus/dir.c:370 #5: ffff88809104c0b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x146/0x1c0 #6: ffff88808c8e0108 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1d2/0x1b10 fs/hfsplus/extents.c:457 stack backtrace: CPU: 0 PID: 10368 Comm: syz-executor.0 Not tainted 5.15.139-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/10/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfsplus_block_allocate+0x8a/0x8d0 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0xa4c/0x1b10 fs/hfsplus/extents.c:468 hfsplus_bmap_reserve+0x101/0x4e0 fs/hfsplus/btree.c:357 hfsplus_rename_cat+0x1cf/0x1090 fs/hfsplus/catalog.c:456 hfsplus_unlink+0x304/0x7f0 fs/hfsplus/dir.c:376 hfsplus_rename+0xc4/0x1b0 fs/hfsplus/dir.c:547 vfs_rename+0xbfc/0xf90 fs/namei.c:4742 do_renameat2+0xb97/0x13b0 fs/namei.c:4892 __do_sys_rename fs/namei.c:4938 [inline] __se_sys_rename fs/namei.c:4936 [inline] __x64_sys_rename+0x82/0x90 fs/namei.c:4936 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb RIP: 0033:0x7f41c241cae9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f41c095c0c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000052 RAX: ffffffffffffffda RBX: 00007f41c253c120 RCX: 00007f41c241cae9 RDX: 0000000000000000 RSI: 0000000020000300 RDI: 0000000020000b00 RBP: 00007f41c246847a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000006e R14: 00007f41c253c120 R15: 00007ffdc3fb5ca8