====================================================== WARNING: possible circular locking dependency detected 6.10.0-rc6-next-20240703-syzkaller #0 Not tainted ------------------------------------------------------ syz.0.1364/11886 is trying to acquire lock: ffff88805cc3a1e0 (&ea_inode->i_rwsem#8/1){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:799 [inline] ffff88805cc3a1e0 (&ea_inode->i_rwsem#8/1){+.+.}-{3:3}, at: ext4_xattr_inode_iget+0x3fe/0x580 fs/ext4/xattr.c:461 but task is already holding lock: ffff88805cc3be58 (&ei->i_data_sem/3){++++}-{3:3}, at: ext4_setattr+0x14bf/0x1bc0 fs/ext4/inode.c:5484 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ei->i_data_sem/3){++++}-{3:3}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5816 down_write+0x3a/0x50 kernel/locking/rwsem.c:1579 ext4_update_i_disksize fs/ext4/ext4.h:3395 [inline] ext4_xattr_inode_write fs/ext4/xattr.c:1446 [inline] ext4_xattr_inode_lookup_create+0x166b/0x1ee0 fs/ext4/xattr.c:1596 ext4_xattr_ibody_set+0x214/0x730 fs/ext4/xattr.c:2263 ext4_xattr_set_handle+0xba6/0x1580 fs/ext4/xattr.c:2440 ext4_xattr_set+0x241/0x3d0 fs/ext4/xattr.c:2554 __vfs_setxattr+0x468/0x4a0 fs/xattr.c:200 __vfs_setxattr_noperm+0x12e/0x660 fs/xattr.c:234 vfs_setxattr+0x221/0x430 fs/xattr.c:321 do_setxattr fs/xattr.c:629 [inline] setxattr+0x25d/0x2f0 fs/xattr.c:652 do_setxattrat+0x21f/0x300 fs/xattr.c:678 __do_sys_setxattr fs/xattr.c:718 [inline] __se_sys_setxattr fs/xattr.c:714 [inline] __x64_sys_setxattr+0xbc/0xe0 fs/xattr.c:714 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&ea_inode->i_rwsem#8/1){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3158 [inline] check_prevs_add kernel/locking/lockdep.c:3277 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3901 __lock_acquire+0x1359/0x2000 kernel/locking/lockdep.c:5193 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5816 down_write+0x3a/0x50 kernel/locking/rwsem.c:1579 inode_lock include/linux/fs.h:799 [inline] ext4_xattr_inode_iget+0x3fe/0x580 fs/ext4/xattr.c:461 ext4_xattr_inode_get+0x167/0x490 fs/ext4/xattr.c:535 ext4_xattr_move_to_block fs/ext4/xattr.c:2636 [inline] ext4_xattr_make_inode_space fs/ext4/xattr.c:2738 [inline] ext4_expand_extra_isize_ea+0xf21/0x1cf0 fs/ext4/xattr.c:2830 __ext4_expand_extra_isize+0x2fb/0x3e0 fs/ext4/inode.c:5856 ext4_try_to_expand_extra_isize fs/ext4/inode.c:5899 [inline] __ext4_mark_inode_dirty+0x524/0x880 fs/ext4/inode.c:5977 ext4_setattr+0x1552/0x1bc0 fs/ext4/inode.c:5487 notify_change+0xb9d/0xe70 fs/attr.c:495 do_truncate+0x220/0x310 fs/open.c:65 handle_truncate fs/namei.c:3338 [inline] do_open fs/namei.c:3688 [inline] path_openat+0x2ced/0x3470 fs/namei.c:3843 do_filp_open+0x235/0x490 fs/namei.c:3870 do_sys_openat2+0x13e/0x1d0 fs/open.c:1416 do_sys_open fs/open.c:1431 [inline] __do_sys_creat fs/open.c:1507 [inline] __se_sys_creat fs/open.c:1501 [inline] __x64_sys_creat+0x123/0x170 fs/open.c:1501 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ei->i_data_sem/3); lock(&ea_inode->i_rwsem#8/1); lock(&ei->i_data_sem/3); lock(&ea_inode->i_rwsem#8/1); *** DEADLOCK *** 5 locks held by syz.0.1364/11886: #0: ffff88807f5ca420 (sb_writers#4){++++}-{0:0}, at: mnt_want_write+0x3f/0x90 fs/namespace.c:514 #1: ffff88805cc3bfc8 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: inode_lock include/linux/fs.h:799 [inline] #1: ffff88805cc3bfc8 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: do_truncate+0x20c/0x310 fs/open.c:63 #2: ffff88805cc3c168 (mapping.invalidate_lock){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:844 [inline] #2: ffff88805cc3c168 (mapping.invalidate_lock){++++}-{3:3}, at: ext4_setattr+0xf35/0x1bc0 fs/ext4/inode.c:5445 #3: ffff88805cc3be58 (&ei->i_data_sem/3){++++}-{3:3}, at: ext4_setattr+0x14bf/0x1bc0 fs/ext4/inode.c:5484 #4: ffff88805cc3bc98 (&ei->xattr_sem){++++}-{3:3}, at: ext4_write_trylock_xattr fs/ext4/xattr.h:162 [inline] #4: ffff88805cc3bc98 (&ei->xattr_sem){++++}-{3:3}, at: ext4_try_to_expand_extra_isize fs/ext4/inode.c:5896 [inline] #4: ffff88805cc3bc98 (&ei->xattr_sem){++++}-{3:3}, at: __ext4_mark_inode_dirty+0x491/0x880 fs/ext4/inode.c:5977 stack backtrace: CPU: 0 UID: 0 PID: 11886 Comm: syz.0.1364 Not tainted 6.10.0-rc6-next-20240703-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/07/2024 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2074 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2203 check_prev_add kernel/locking/lockdep.c:3158 [inline] check_prevs_add kernel/locking/lockdep.c:3277 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3901 __lock_acquire+0x1359/0x2000 kernel/locking/lockdep.c:5193 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5816 down_write+0x3a/0x50 kernel/locking/rwsem.c:1579 inode_lock include/linux/fs.h:799 [inline] ext4_xattr_inode_iget+0x3fe/0x580 fs/ext4/xattr.c:461 ext4_xattr_inode_get+0x167/0x490 fs/ext4/xattr.c:535 ext4_xattr_move_to_block fs/ext4/xattr.c:2636 [inline] ext4_xattr_make_inode_space fs/ext4/xattr.c:2738 [inline] ext4_expand_extra_isize_ea+0xf21/0x1cf0 fs/ext4/xattr.c:2830 __ext4_expand_extra_isize+0x2fb/0x3e0 fs/ext4/inode.c:5856 ext4_try_to_expand_extra_isize fs/ext4/inode.c:5899 [inline] __ext4_mark_inode_dirty+0x524/0x880 fs/ext4/inode.c:5977 ext4_setattr+0x1552/0x1bc0 fs/ext4/inode.c:5487 notify_change+0xb9d/0xe70 fs/attr.c:495 do_truncate+0x220/0x310 fs/open.c:65 handle_truncate fs/namei.c:3338 [inline] do_open fs/namei.c:3688 [inline] path_openat+0x2ced/0x3470 fs/namei.c:3843 do_filp_open+0x235/0x490 fs/namei.c:3870 do_sys_openat2+0x13e/0x1d0 fs/open.c:1416 do_sys_open fs/open.c:1431 [inline] __do_sys_creat fs/open.c:1507 [inline] __se_sys_creat fs/open.c:1501 [inline] __x64_sys_creat+0x123/0x170 fs/open.c:1501 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fa42cb75bd9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fa42d9dc048 EFLAGS: 00000246 ORIG_RAX: 0000000000000055 RAX: ffffffffffffffda RBX: 00007fa42cd03f60 RCX: 00007fa42cb75bd9 RDX: 0000000000000000 RSI: 0000000000000087 RDI: 0000000020000040 RBP: 00007fa42cbe4aa1 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007fa42cd03f60 R15: 00007ffedeea5798