====================================================== WARNING: possible circular locking dependency detected 6.2.0-syzkaller-12896-g2d8cb0bfca6a #0 Not tainted ------------------------------------------------------ syz-executor.1/5588 is trying to acquire lock: ffff88814ac9c170 (&journal->j_barrier){+.+.}-{3:3}, at: jbd2_journal_lock_updates+0x162/0x310 fs/jbd2/transaction.c:904 but task is already holding lock: ffff88814ac9ab98 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x180/0x550 fs/ext4/inode.c:6157 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&sbi->s_writepages_rwsem){++++}-{0:0}: percpu_down_read include/linux/percpu-rwsem.h:51 [inline] ext4_writepages+0x1a9/0x5e0 fs/ext4/inode.c:2963 do_writepages+0x1a8/0x640 mm/page-writeback.c:2551 filemap_fdatawrite_wbc mm/filemap.c:390 [inline] filemap_fdatawrite_wbc+0x147/0x1b0 mm/filemap.c:380 __filemap_fdatawrite_range+0xb8/0xf0 mm/filemap.c:423 filemap_write_and_wait_range mm/filemap.c:678 [inline] filemap_write_and_wait_range+0xa1/0x120 mm/filemap.c:669 __iomap_dio_rw+0x5ea/0x1d80 fs/iomap/direct-io.c:566 iomap_dio_rw+0x40/0xa0 fs/iomap/direct-io.c:683 ext4_dio_read_iter fs/ext4/file.c:94 [inline] ext4_file_read_iter+0x4be/0x690 fs/ext4/file.c:145 call_read_iter include/linux/fs.h:1845 [inline] generic_file_splice_read+0x182/0x4b0 fs/splice.c:402 do_splice_to+0x1b9/0x240 fs/splice.c:885 splice_direct_to_actor+0x2ab/0x8a0 fs/splice.c:957 do_splice_direct+0x1ab/0x280 fs/splice.c:1066 do_sendfile+0xb19/0x12c0 fs/read_write.c:1255 __do_sys_sendfile64 fs/read_write.c:1323 [inline] __se_sys_sendfile64 fs/read_write.c:1309 [inline] __x64_sys_sendfile64+0x1d0/0x210 fs/read_write.c:1309 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #2 (&sb->s_type->i_mutex_key#8){++++}-{3:3}: down_read+0x3d/0x50 kernel/locking/rwsem.c:1520 inode_lock_shared include/linux/fs.h:768 [inline] ext4_bmap+0x52/0x470 fs/ext4/inode.c:3242 bmap+0xae/0x120 fs/inode.c:1799 jbd2_journal_bmap+0xac/0x1c0 fs/jbd2/journal.c:976 __jbd2_journal_erase fs/jbd2/journal.c:1788 [inline] jbd2_journal_flush+0x87b/0xc90 fs/jbd2/journal.c:2491 ext4_ioctl_checkpoint fs/ext4/ioctl.c:1082 [inline] __ext4_ioctl+0xb3f/0x4c90 fs/ext4/ioctl.c:1590 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __x64_sys_ioctl+0x197/0x210 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (&journal->j_checkpoint_mutex){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:603 [inline] mutex_lock_io_nested+0x143/0x11a0 kernel/locking/mutex.c:833 jbd2_journal_flush+0x19e/0xc90 fs/jbd2/journal.c:2463 ext4_ioctl_checkpoint fs/ext4/ioctl.c:1082 [inline] __ext4_ioctl+0xb3f/0x4c90 fs/ext4/ioctl.c:1590 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __x64_sys_ioctl+0x197/0x210 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&journal->j_barrier){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056 lock_acquire kernel/locking/lockdep.c:5669 [inline] lock_acquire+0x1e3/0x670 kernel/locking/lockdep.c:5634 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x12f/0x1350 kernel/locking/mutex.c:747 jbd2_journal_lock_updates+0x162/0x310 fs/jbd2/transaction.c:904 ext4_change_inode_journal_flag+0x188/0x550 fs/ext4/inode.c:6158 ext4_ioctl_setflags fs/ext4/ioctl.c:687 [inline] ext4_fileattr_set+0xe78/0x1a50 fs/ext4/ioctl.c:1004 vfs_fileattr_set+0x7ff/0xc40 fs/ioctl.c:696 ioctl_fssetxattr fs/ioctl.c:758 [inline] do_vfs_ioctl+0xfa8/0x1670 fs/ioctl.c:845 __do_sys_ioctl fs/ioctl.c:868 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __x64_sys_ioctl+0x10c/0x210 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &journal->j_barrier --> &sb->s_type->i_mutex_key#8 --> &sbi->s_writepages_rwsem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&sbi->s_writepages_rwsem); lock(&sb->s_type->i_mutex_key#8); lock(&sbi->s_writepages_rwsem); lock(&journal->j_barrier); *** DEADLOCK *** 4 locks held by syz-executor.1/5588: #0: ffff88814ac98460 (sb_writers#4){.+.+}-{0:0}, at: ioctl_setflags fs/ioctl.c:725 [inline] #0: ffff88814ac98460 (sb_writers#4){.+.+}-{0:0}, at: do_vfs_ioctl+0xf6d/0x1670 fs/ioctl.c:839 #1: ffff888075b5b628 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #1: ffff888075b5b628 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: vfs_fileattr_set+0x14c/0xc40 fs/ioctl.c:681 #2: ffff888075b5b7c8 (mapping.invalidate_lock){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:803 [inline] #2: ffff888075b5b7c8 (mapping.invalidate_lock){++++}-{3:3}, at: ext4_change_inode_journal_flag+0x127/0x550 fs/ext4/inode.c:6149 #3: ffff88814ac9ab98 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x180/0x550 fs/ext4/inode.c:6157 stack backtrace: CPU: 0 PID: 5588 Comm: syz-executor.1 Not tainted 6.2.0-syzkaller-12896-g2d8cb0bfca6a #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x150 lib/dump_stack.c:106 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056 lock_acquire kernel/locking/lockdep.c:5669 [inline] lock_acquire+0x1e3/0x670 kernel/locking/lockdep.c:5634 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x12f/0x1350 kernel/locking/mutex.c:747 jbd2_journal_lock_updates+0x162/0x310 fs/jbd2/transaction.c:904 ext4_change_inode_journal_flag+0x188/0x550 fs/ext4/inode.c:6158 ext4_ioctl_setflags fs/ext4/ioctl.c:687 [inline] ext4_fileattr_set+0xe78/0x1a50 fs/ext4/ioctl.c:1004 vfs_fileattr_set+0x7ff/0xc40 fs/ioctl.c:696 ioctl_fssetxattr fs/ioctl.c:758 [inline] do_vfs_ioctl+0xfa8/0x1670 fs/ioctl.c:845 __do_sys_ioctl fs/ioctl.c:868 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __x64_sys_ioctl+0x10c/0x210 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f6f1de8c0f9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f6f1eb16168 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007f6f1dfac050 RCX: 00007f6f1de8c0f9 RDX: 00000000200000c0 RSI: 0000000040086602 RDI: 0000000000000009 RBP: 00007f6f1dee7ae9 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffc6a405a9f R14: 00007f6f1eb16300 R15: 0000000000022000