====================================================== WARNING: possible circular locking dependency detected 5.17.0-rc5-syzkaller-00272-g9137eda53752 #0 Not tainted ------------------------------------------------------ udevd/25301 is trying to acquire lock: ffff8880465b3138 ((wq_completion)loop1){+.+.}-{0:0}, at: flush_workqueue+0xe1/0x13a0 kernel/workqueue.c:2824 but task is already holding lock: ffff888043bb8918 (&disk->open_mutex){+.+.}-{3:3}, at: blkdev_put+0x99/0x950 block/bdev.c:902 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #7 (&disk->open_mutex){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:600 [inline] __mutex_lock+0x12f/0x12f0 kernel/locking/mutex.c:733 bd_register_pending_holders+0x2c/0x470 block/holder.c:161 device_add_disk+0x6bb/0xd70 block/genhd.c:493 add_disk include/linux/genhd.h:169 [inline] loop_add+0x71e/0x900 drivers/block/loop.c:2046 loop_probe+0x6a/0x80 drivers/block/loop.c:2091 blk_request_module+0x111/0x1d0 block/genhd.c:704 blkdev_get_no_open+0x74/0x90 block/bdev.c:737 blkdev_get_by_dev.part.0+0x22/0xc70 block/bdev.c:791 blkdev_get_by_dev+0x6b/0x80 block/bdev.c:847 blkdev_open+0x154/0x2e0 block/fops.c:503 do_dentry_open+0x4b9/0x1250 fs/open.c:824 do_open fs/namei.c:3476 [inline] path_openat+0x1c9e/0x2940 fs/namei.c:3609 do_filp_open+0x1aa/0x400 fs/namei.c:3636 do_sys_openat2+0x16d/0x4d0 fs/open.c:1214 do_sys_open fs/open.c:1230 [inline] __do_sys_open fs/open.c:1238 [inline] __se_sys_open fs/open.c:1234 [inline] __x64_sys_open+0x119/0x1c0 fs/open.c:1234 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae -> #6 (major_names_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:600 [inline] __mutex_lock+0x12f/0x12f0 kernel/locking/mutex.c:733 blk_request_module+0x25/0x1d0 block/genhd.c:701 blkdev_get_no_open+0x74/0x90 block/bdev.c:737 blkdev_get_by_dev.part.0+0x22/0xc70 block/bdev.c:791 blkdev_get_by_dev+0x6b/0x80 block/bdev.c:847 swsusp_check+0x97/0x420 kernel/power/swap.c:1526 software_resume.part.0+0x102/0x1f0 kernel/power/hibernate.c:979 software_resume kernel/power/hibernate.c:86 [inline] resume_store+0x161/0x190 kernel/power/hibernate.c:1181 kobj_attr_store+0x50/0x80 lib/kobject.c:856 sysfs_kf_write+0x110/0x160 fs/sysfs/file.c:136 kernfs_fop_write_iter+0x3f8/0x610 fs/kernfs/file.c:296 call_write_iter include/linux/fs.h:2074 [inline] do_iter_readv_writev+0x47a/0x750 fs/read_write.c:725 do_iter_write+0x188/0x710 fs/read_write.c:851 vfs_iter_write+0x70/0xa0 fs/read_write.c:892 iter_file_splice_write+0x6fa/0xc10 fs/splice.c:689 do_splice_from fs/splice.c:767 [inline] direct_splice_actor+0x110/0x180 fs/splice.c:936 splice_direct_to_actor+0x34b/0x8c0 fs/splice.c:891 do_splice_direct+0x1b3/0x280 fs/splice.c:979 generic_copy_file_range fs/read_write.c:1378 [inline] do_copy_file_range fs/read_write.c:1401 [inline] vfs_copy_file_range+0x57b/0x1260 fs/read_write.c:1508 __do_sys_copy_file_range+0x177/0x410 fs/read_write.c:1561 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae -> #5 (system_transition_mutex/1){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:600 [inline] __mutex_lock+0x12f/0x12f0 kernel/locking/mutex.c:733 software_resume.part.0+0x19/0x1f0 kernel/power/hibernate.c:934 software_resume kernel/power/hibernate.c:86 [inline] resume_store+0x161/0x190 kernel/power/hibernate.c:1181 kobj_attr_store+0x50/0x80 lib/kobject.c:856 sysfs_kf_write+0x110/0x160 fs/sysfs/file.c:136 kernfs_fop_write_iter+0x3f8/0x610 fs/kernfs/file.c:296 call_write_iter include/linux/fs.h:2074 [inline] do_iter_readv_writev+0x47a/0x750 fs/read_write.c:725 do_iter_write+0x188/0x710 fs/read_write.c:851 vfs_iter_write+0x70/0xa0 fs/read_write.c:892 iter_file_splice_write+0x6fa/0xc10 fs/splice.c:689 do_splice_from fs/splice.c:767 [inline] direct_splice_actor+0x110/0x180 fs/splice.c:936 splice_direct_to_actor+0x34b/0x8c0 fs/splice.c:891 do_splice_direct+0x1b3/0x280 fs/splice.c:979 generic_copy_file_range fs/read_write.c:1378 [inline] do_copy_file_range fs/read_write.c:1401 [inline] vfs_copy_file_range+0x57b/0x1260 fs/read_write.c:1508 __do_sys_copy_file_range+0x177/0x410 fs/read_write.c:1561 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae -> #4 (&of->mutex){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:600 [inline] __mutex_lock+0x12f/0x12f0 kernel/locking/mutex.c:733 kernfs_seq_start+0x47/0x470 fs/kernfs/file.c:112 seq_read_iter+0x2c6/0x1280 fs/seq_file.c:225 kernfs_fop_read_iter+0x514/0x6f0 fs/kernfs/file.c:241 call_read_iter include/linux/fs.h:2068 [inline] new_sync_read+0x429/0x6e0 fs/read_write.c:400 vfs_read+0x35c/0x600 fs/read_write.c:481 ksys_read+0x12d/0x250 fs/read_write.c:619 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae -> #3 (&p->lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:600 [inline] __mutex_lock+0x12f/0x12f0 kernel/locking/mutex.c:733 seq_read_iter+0xdf/0x1280 fs/seq_file.c:182 call_read_iter include/linux/fs.h:2068 [inline] generic_file_splice_read+0x45b/0x6d0 fs/splice.c:311 do_splice_to+0x1bf/0x250 fs/splice.c:796 splice_direct_to_actor+0x2c2/0x8c0 fs/splice.c:870 do_splice_direct+0x1b3/0x280 fs/splice.c:979 do_sendfile+0xaf2/0x1250 fs/read_write.c:1245 __do_sys_sendfile64 fs/read_write.c:1310 [inline] __se_sys_sendfile64 fs/read_write.c:1296 [inline] __x64_sys_sendfile64+0x1cc/0x210 fs/read_write.c:1296 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae -> #2 (sb_writers#3){.+.+}-{0:0}: percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1722 [inline] sb_start_write include/linux/fs.h:1792 [inline] file_start_write include/linux/fs.h:2937 [inline] lo_write_bvec drivers/block/loop.c:243 [inline] lo_write_simple drivers/block/loop.c:266 [inline] do_req_filebacked drivers/block/loop.c:495 [inline] loop_handle_cmd drivers/block/loop.c:1852 [inline] loop_process_work+0x1499/0x1db0 drivers/block/loop.c:1892 process_one_work+0x9ac/0x1650 kernel/workqueue.c:2307 worker_thread+0x657/0x1110 kernel/workqueue.c:2454 kthread+0x2e9/0x3a0 kernel/kthread.c:377 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295 -> #1 ((work_completion)(&worker->work)){+.+.}-{0:0}: process_one_work+0x91b/0x1650 kernel/workqueue.c:2283 worker_thread+0x657/0x1110 kernel/workqueue.c:2454 kthread+0x2e9/0x3a0 kernel/kthread.c:377 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295 -> #0 ((wq_completion)loop1){+.+.}-{0:0}: check_prev_add kernel/locking/lockdep.c:3063 [inline] check_prevs_add kernel/locking/lockdep.c:3186 [inline] validate_chain kernel/locking/lockdep.c:3801 [inline] __lock_acquire+0x2ad4/0x56c0 kernel/locking/lockdep.c:5027 lock_acquire kernel/locking/lockdep.c:5639 [inline] lock_acquire+0x1ab/0x510 kernel/locking/lockdep.c:5604 flush_workqueue+0x110/0x13a0 kernel/workqueue.c:2827 drain_workqueue+0x1a5/0x3c0 kernel/workqueue.c:2992 destroy_workqueue+0x71/0x800 kernel/workqueue.c:4429 __loop_clr_fd+0x1ab/0xe20 drivers/block/loop.c:1124 lo_release+0x1ac/0x1f0 drivers/block/loop.c:1756 blkdev_put_whole block/bdev.c:689 [inline] blkdev_put+0x2de/0x950 block/bdev.c:944 blkdev_close+0x6a/0x80 block/fops.c:517 __fput+0x286/0x9f0 fs/file_table.c:317 task_work_run+0xdd/0x1a0 kernel/task_work.c:164 tracehook_notify_resume include/linux/tracehook.h:188 [inline] exit_to_user_mode_loop kernel/entry/common.c:175 [inline] exit_to_user_mode_prepare+0x27e/0x290 kernel/entry/common.c:207 __syscall_exit_to_user_mode_work kernel/entry/common.c:289 [inline] syscall_exit_to_user_mode+0x19/0x60 kernel/entry/common.c:300 do_syscall_64+0x42/0xb0 arch/x86/entry/common.c:86 entry_SYSCALL_64_after_hwframe+0x44/0xae other info that might help us debug this: Chain exists of: (wq_completion)loop1 --> major_names_lock --> &disk->open_mutex Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&disk->open_mutex); lock(major_names_lock); lock(&disk->open_mutex); lock((wq_completion)loop1); *** DEADLOCK *** 1 lock held by udevd/25301: #0: ffff888043bb8918 (&disk->open_mutex){+.+.}-{3:3}, at: blkdev_put+0x99/0x950 block/bdev.c:902 stack backtrace: CPU: 1 PID: 25301 Comm: udevd Not tainted 5.17.0-rc5-syzkaller-00272-g9137eda53752 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2143 check_prev_add kernel/locking/lockdep.c:3063 [inline] check_prevs_add kernel/locking/lockdep.c:3186 [inline] validate_chain kernel/locking/lockdep.c:3801 [inline] __lock_acquire+0x2ad4/0x56c0 kernel/locking/lockdep.c:5027 lock_acquire kernel/locking/lockdep.c:5639 [inline] lock_acquire+0x1ab/0x510 kernel/locking/lockdep.c:5604 flush_workqueue+0x110/0x13a0 kernel/workqueue.c:2827 drain_workqueue+0x1a5/0x3c0 kernel/workqueue.c:2992 destroy_workqueue+0x71/0x800 kernel/workqueue.c:4429 __loop_clr_fd+0x1ab/0xe20 drivers/block/loop.c:1124 lo_release+0x1ac/0x1f0 drivers/block/loop.c:1756 blkdev_put_whole block/bdev.c:689 [inline] blkdev_put+0x2de/0x950 block/bdev.c:944 blkdev_close+0x6a/0x80 block/fops.c:517 __fput+0x286/0x9f0 fs/file_table.c:317 task_work_run+0xdd/0x1a0 kernel/task_work.c:164 tracehook_notify_resume include/linux/tracehook.h:188 [inline] exit_to_user_mode_loop kernel/entry/common.c:175 [inline] exit_to_user_mode_prepare+0x27e/0x290 kernel/entry/common.c:207 __syscall_exit_to_user_mode_work kernel/entry/common.c:289 [inline] syscall_exit_to_user_mode+0x19/0x60 kernel/entry/common.c:300 do_syscall_64+0x42/0xb0 arch/x86/entry/common.c:86 entry_SYSCALL_64_after_hwframe+0x44/0xae RIP: 0033:0x7f071e83bfc3 Code: 48 ff ff ff b8 ff ff ff ff e9 3e ff ff ff 66 0f 1f 84 00 00 00 00 00 64 8b 04 25 18 00 00 00 85 c0 75 14 b8 03 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 45 c3 0f 1f 40 00 48 83 ec 18 89 7c 24 0c e8 RSP: 002b:00007ffd3f0e1e78 EFLAGS: 00000246 ORIG_RAX: 0000000000000003 RAX: 0000000000000000 RBX: 00007f071e6e46a8 RCX: 00007f071e83bfc3 RDX: 000000000000001c RSI: 00007ffd3f0e1678 RDI: 0000000000000008 RBP: 000055c0e121ed60 R08: 0000000000000007 R09: 000055c0e121cdf0 R10: 00000000c68cb5e0 R11: 0000000000000246 R12: 0000000000000002 R13: 000055c0e11ed9b0 R14: 0000000000000008 R15: 000055c0e11df2c0