overlayfs: fs on './file0' does not support file handles, falling back to index=off. overlayfs: fs on './file0' does not support file handles, falling back to index=off. ====================================================== audit: type=1800 audit(1677493798.822:106): pid=11610 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.1" name="file0" dev="sda1" ino=14249 res=0 WARNING: possible circular locking dependency detected 4.14.307-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.3/11660 is trying to acquire lock: (&ovl_i_mutex_dir_key[depth]){++++} audit: type=1804 audit(1677493799.042:107): pid=11610 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.1" name="/root/syzkaller-testdir1636454773/syzkaller.nphsXb/67/file0" dev="sda1" ino=14249 res=1 , at: [] iterate_dir+0x387/0x5e0 fs/readdir.c:43 but task is already holding lock: (sb_writers#6){.+.+}, at: [] sb_start_write include/linux/fs.h:1551 [inline] (sb_writers#6){.+.+}, at: [] mnt_want_write+0x3a/0xb0 fs/namespace.c:386 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 audit: type=1804 audit(1677493799.062:108): pid=11610 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="ToMToU" comm="syz-executor.1" name="/root/syzkaller-testdir1636454773/syzkaller.nphsXb/67/file0" dev="sda1" ino=14249 res=1 (sb_writers#6){.+.+}: percpu_down_read_preempt_disable include/linux/percpu-rwsem.h:36 [inline] percpu_down_read include/linux/percpu-rwsem.h:59 [inline] __sb_start_write+0x64/0x260 fs/super.c:1342 sb_start_write include/linux/fs.h:1551 [inline] mnt_want_write+0x3a/0xb0 fs/namespace.c:386 ovl_xattr_set+0x4d/0x290 fs/overlayfs/inode.c:214 audit: type=1800 audit(1677493799.692:109): pid=11618 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.2" name="file0" dev="sda1" ino=14255 res=0 ovl_posix_acl_xattr_set+0x2b7/0x830 fs/overlayfs/super.c:762 __vfs_setxattr+0xdc/0x130 fs/xattr.c:150 __vfs_setxattr_noperm+0xfd/0x3d0 fs/xattr.c:181 __vfs_setxattr_locked+0x14d/0x250 fs/xattr.c:239 vfs_setxattr+0xcf/0x230 fs/xattr.c:256 setxattr+0x1a9/0x300 fs/xattr.c:523 path_setxattr+0x118/0x130 fs/xattr.c:542 audit: type=1804 audit(1677493799.712:110): pid=11618 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.2" name="/root/syzkaller-testdir950429425/syzkaller.F8OciH/70/file0" dev="sda1" ino=14255 res=1 SYSC_setxattr fs/xattr.c:557 [inline] SyS_setxattr+0x36/0x50 fs/xattr.c:553 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x5e/0xd3 -> #0 (&ovl_i_mutex_dir_key[depth]){++++}: lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998 down_write_killable+0x37/0xb0 kernel/locking/rwsem.c:68 audit: type=1804 audit(1677493799.722:111): pid=11618 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="ToMToU" comm="syz-executor.2" name="/root/syzkaller-testdir950429425/syzkaller.F8OciH/70/file0" dev="sda1" ino=14255 res=1 iterate_dir+0x387/0x5e0 fs/readdir.c:43 ovl_dir_read fs/overlayfs/readdir.c:306 [inline] ovl_dir_read_merged+0x2c5/0x430 fs/overlayfs/readdir.c:365 ovl_check_empty_dir+0x6e/0x200 fs/overlayfs/readdir.c:870 ovl_check_empty_and_clear+0x72/0xe0 fs/overlayfs/dir.c:306 ovl_rename+0x57d/0xe50 fs/overlayfs/dir.c:959 audit: type=1800 audit(1677493800.262:112): pid=11626 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.1" name="file0" dev="sda1" ino=14205 res=0 vfs_rename+0x560/0x1820 fs/namei.c:4498 SYSC_renameat2 fs/namei.c:4646 [inline] SyS_renameat2+0x95b/0xad0 fs/namei.c:4535 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x5e/0xd3 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(sb_writers#6); lock(&ovl_i_mutex_dir_key[depth]); lock(sb_writers#6); lock(&ovl_i_mutex_dir_key[depth]); *** DEADLOCK *** 6 locks held by syz-executor.3/11660: #0: (sb_writers#18){.+.+}, at: [] sb_start_write include/linux/fs.h:1551 [inline] #0: (sb_writers#18){.+.+}, at: [] mnt_want_write+0x3a/0xb0 fs/namespace.c:386 #1: (&type->s_vfs_rename_key#4){+.+.}, at: [] lock_rename+0x54/0x280 fs/namei.c:2889 #2: (&ovl_i_mutex_dir_key[depth]#2/1){+.+.}, at: [] inode_lock_nested include/linux/fs.h:754 [inline] #2: (&ovl_i_mutex_dir_key[depth]#2/1){+.+.}, at: [] lock_rename+0x132/0x280 fs/namei.c:2900 #3: (&ovl_i_mutex_dir_key[depth]#2/2){+.+.}, at: [] inode_lock_nested include/linux/fs.h:754 [inline] #3: (&ovl_i_mutex_dir_key[depth]#2/2){+.+.}, at: [] lock_rename+0x166/0x280 fs/namei.c:2901 #4: (&ovl_i_mutex_dir_key[depth]#2){++++}, at: [] inode_lock include/linux/fs.h:719 [inline] #4: (&ovl_i_mutex_dir_key[depth]#2){++++}, at: [] vfs_rename+0xbd8/0x1820 fs/namei.c:4472 #5: (sb_writers#6){.+.+}, at: [] sb_start_write include/linux/fs.h:1551 [inline] #5: (sb_writers#6){.+.+}, at: [] mnt_want_write+0x3a/0xb0 fs/namespace.c:386 stack backtrace: CPU: 0 PID: 11660 Comm: syz-executor.3 Not tainted 4.14.307-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/16/2023 Call Trace: __dump_stack lib/dump_stack.c:17 [inline] dump_stack+0x1b2/0x281 lib/dump_stack.c:58 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1258 check_prev_add kernel/locking/lockdep.c:1905 [inline] check_prevs_add kernel/locking/lockdep.c:2022 [inline] validate_chain kernel/locking/lockdep.c:2464 [inline] __lock_acquire+0x2e0e/0x3f20 kernel/locking/lockdep.c:3491 lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998 down_write_killable+0x37/0xb0 kernel/locking/rwsem.c:68 iterate_dir+0x387/0x5e0 fs/readdir.c:43 ovl_dir_read fs/overlayfs/readdir.c:306 [inline] ovl_dir_read_merged+0x2c5/0x430 fs/overlayfs/readdir.c:365 ovl_check_empty_dir+0x6e/0x200 fs/overlayfs/readdir.c:870 ovl_check_empty_and_clear+0x72/0xe0 fs/overlayfs/dir.c:306 ovl_rename+0x57d/0xe50 fs/overlayfs/dir.c:959 vfs_rename+0x560/0x1820 fs/namei.c:4498 SYSC_renameat2 fs/namei.c:4646 [inline] SyS_renameat2+0x95b/0xad0 fs/namei.c:4535 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x5e/0xd3 RIP: 0033:0x7f9a1dba30f9 RSP: 002b:00007f9a1c115168 EFLAGS: 00000246 ORIG_RAX: 0000000000000052 RAX: ffffffffffffffda RBX: 00007f9a1dcc2f80 RCX: 00007f9a1dba30f9 RDX: 0000000000000000 RSI: 0000000020000440 RDI: 0000000020000100 RBP: 00007f9a1dbfeae9 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffdc8c9556f R14: 00007f9a1c115300 R15: 0000000000022000 overlayfs: fs on 'file0' does not support file handles, falling back to index=off. overlayfs: fs on 'file0' does not support file handles, falling back to index=off. overlayfs: fs on 'file0' does not support file handles, falling back to index=off. overlayfs: fs on './file0' does not support file handles, falling back to index=off. overlayfs: fs on './file0' does not support file handles, falling back to index=off. overlayfs: fs on './file0' does not support file handles, falling back to index=off. (syz-executor.4,11760,1):ocfs2_parse_options:1498 ERROR: Invalid heartbeat mount options (syz-executor.4,11760,0):ocfs2_fill_super:1217 ERROR: status = -22 (syz-executor.4,11822,0):ocfs2_parse_options:1498 ERROR: Invalid heartbeat mount options (syz-executor.4,11822,0):ocfs2_fill_super:1217 ERROR: status = -22 (syz-executor.4,11874,0):ocfs2_parse_options:1498 ERROR: Invalid heartbeat mount options (syz-executor.4,11874,0):ocfs2_fill_super:1217 ERROR: status = -22 (syz-executor.4,11929,0):ocfs2_parse_options:1498 ERROR: Invalid heartbeat mount options (syz-executor.4,11929,0):ocfs2_fill_super:1217 ERROR: status = -22