====================================================== WARNING: possible circular locking dependency detected 6.13.0-rc3-syzkaller-00193-ge9b8ffafd20a #0 Not tainted ------------------------------------------------------ syz.2.683/12215 is trying to acquire lock: ffff8880594adf40 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:818 [inline] ffff8880594adf40 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{4:4}, at: ocfs2_reserve_local_alloc_bits+0x132/0x2840 fs/ocfs2/localalloc.c:636 but task is already holding lock: ffff88805961cda0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_lock_global_qf+0x225/0x2b0 fs/ocfs2/quota_global.c:314 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #7 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 ocfs2_lock_global_qf+0x225/0x2b0 fs/ocfs2/quota_global.c:314 ocfs2_acquire_dquot+0x2b0/0xb70 fs/ocfs2/quota_global.c:823 dqget+0x770/0xeb0 fs/quota/dquot.c:977 ocfs2_setattr+0x114c/0x1ef0 fs/ocfs2/file.c:1243 notify_change+0xbca/0xe90 fs/attr.c:552 chown_common+0x501/0x850 fs/open.c:778 do_fchownat+0x16a/0x240 fs/open.c:809 __do_sys_lchown fs/open.c:834 [inline] __se_sys_lchown fs/open.c:832 [inline] __x64_sys_lchown+0x85/0xa0 fs/open.c:832 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #6 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:818 [inline] ocfs2_lock_global_qf+0x206/0x2b0 fs/ocfs2/quota_global.c:313 ocfs2_acquire_dquot+0x2b0/0xb70 fs/ocfs2/quota_global.c:823 dqget+0x770/0xeb0 fs/quota/dquot.c:977 ocfs2_setattr+0x114c/0x1ef0 fs/ocfs2/file.c:1243 notify_change+0xbca/0xe90 fs/attr.c:552 chown_common+0x501/0x850 fs/open.c:778 do_fchownat+0x16a/0x240 fs/open.c:809 __do_sys_lchown fs/open.c:834 [inline] __se_sys_lchown fs/open.c:832 [inline] __x64_sys_lchown+0x85/0xa0 fs/open.c:832 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #5 (&dquot->dq_lock){+.+.}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 __mutex_lock_common kernel/locking/mutex.c:585 [inline] __mutex_lock+0x1ac/0xee0 kernel/locking/mutex.c:735 wait_on_dquot fs/quota/dquot.c:354 [inline] dqget+0x6e6/0xeb0 fs/quota/dquot.c:972 dquot_transfer+0x482/0x6d0 fs/quota/dquot.c:2154 ext4_setattr+0xb49/0x1da0 fs/ext4/inode.c:5400 notify_change+0xbca/0xe90 fs/attr.c:552 chown_common+0x501/0x850 fs/open.c:778 do_fchownat+0x16a/0x240 fs/open.c:809 __do_sys_lchown fs/open.c:834 [inline] __se_sys_lchown fs/open.c:832 [inline] __x64_sys_lchown+0x85/0xa0 fs/open.c:832 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #4 (&ei->xattr_sem){++++}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 ext4_write_lock_xattr fs/ext4/xattr.h:154 [inline] ext4_xattr_set_handle+0x277/0x1580 fs/ext4/xattr.c:2373 ext4_initxattrs+0xa3/0x120 fs/ext4/xattr_security.c:44 security_inode_init_security+0x29c/0x480 security/security.c:1847 __ext4_new_inode+0x3635/0x4380 fs/ext4/ialloc.c:1324 ext4_create+0x279/0x550 fs/ext4/namei.c:2841 lookup_open fs/namei.c:3649 [inline] open_last_lookups fs/namei.c:3748 [inline] path_openat+0x1c03/0x3590 fs/namei.c:3984 do_filp_open+0x27f/0x4e0 fs/namei.c:4014 do_sys_openat2+0x13e/0x1d0 fs/open.c:1402 do_sys_open fs/open.c:1417 [inline] __do_sys_openat fs/open.c:1433 [inline] __se_sys_openat fs/open.c:1428 [inline] __x64_sys_openat+0x247/0x2a0 fs/open.c:1428 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #3 (jbd2_handle){++++}-{0:0}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 start_this_handle+0x1eb4/0x2110 fs/jbd2/transaction.c:448 jbd2__journal_start+0x2da/0x5d0 fs/jbd2/transaction.c:505 jbd2_journal_start+0x29/0x40 fs/jbd2/transaction.c:544 ocfs2_start_trans+0x3c9/0x700 fs/ocfs2/journal.c:352 ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline] ocfs2_reserve_suballoc_bits+0x9f6/0x4e70 fs/ocfs2/suballoc.c:832 ocfs2_reserve_new_metadata_blocks+0x41c/0x9c0 fs/ocfs2/suballoc.c:982 ocfs2_calc_security_init+0x3b8/0x620 fs/ocfs2/xattr.c:590 ocfs2_symlink+0x125c/0x2d80 fs/ocfs2/namei.c:1909 vfs_symlink+0x137/0x2e0 fs/namei.c:4669 do_symlinkat+0x222/0x3a0 fs/namei.c:4695 __do_sys_symlink fs/namei.c:4716 [inline] __se_sys_symlink fs/namei.c:4714 [inline] __x64_sys_symlink+0x7a/0x90 fs/namei.c:4714 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (&journal->j_trans_barrier){.+.+}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1524 ocfs2_start_trans+0x3be/0x700 fs/ocfs2/journal.c:350 ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline] ocfs2_reserve_suballoc_bits+0x9f6/0x4e70 fs/ocfs2/suballoc.c:832 ocfs2_reserve_new_metadata_blocks+0x41c/0x9c0 fs/ocfs2/suballoc.c:982 ocfs2_calc_security_init+0x3b8/0x620 fs/ocfs2/xattr.c:590 ocfs2_symlink+0x125c/0x2d80 fs/ocfs2/namei.c:1909 vfs_symlink+0x137/0x2e0 fs/namei.c:4669 do_symlinkat+0x222/0x3a0 fs/namei.c:4695 __do_sys_symlink fs/namei.c:4716 [inline] __se_sys_symlink fs/namei.c:4714 [inline] __x64_sys_symlink+0x7a/0x90 fs/namei.c:4714 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (sb_internal#4){.+.+}-{0:0}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1725 [inline] sb_start_intwrite include/linux/fs.h:1908 [inline] ocfs2_start_trans+0x2b9/0x700 fs/ocfs2/journal.c:348 ocfs2_symlink+0x1401/0x2d80 fs/ocfs2/namei.c:1928 vfs_symlink+0x137/0x2e0 fs/namei.c:4669 do_symlinkat+0x222/0x3a0 fs/namei.c:4695 __do_sys_symlink fs/namei.c:4716 [inline] __se_sys_symlink fs/namei.c:4714 [inline] __x64_sys_symlink+0x7a/0x90 fs/namei.c:4714 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:818 [inline] ocfs2_reserve_local_alloc_bits+0x132/0x2840 fs/ocfs2/localalloc.c:636 ocfs2_reserve_clusters_with_limit+0x1b8/0xb60 fs/ocfs2/suballoc.c:1166 ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1227 [inline] ocfs2_lock_allocators+0x30a/0x630 fs/ocfs2/suballoc.c:2746 ocfs2_extend_allocation+0x4ed/0x1bf0 fs/ocfs2/file.c:589 ocfs2_extend_no_holes+0x1f6/0x4a0 fs/ocfs2/file.c:1027 ocfs2_acquire_dquot+0x64d/0xb70 fs/ocfs2/quota_global.c:848 dqget+0x770/0xeb0 fs/quota/dquot.c:977 ocfs2_setattr+0x114c/0x1ef0 fs/ocfs2/file.c:1243 notify_change+0xbca/0xe90 fs/attr.c:552 chown_common+0x501/0x850 fs/open.c:778 do_fchownat+0x16a/0x240 fs/open.c:809 __do_sys_lchown fs/open.c:834 [inline] __se_sys_lchown fs/open.c:832 [inline] __x64_sys_lchown+0x85/0xa0 fs/open.c:832 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> &ocfs2_quota_ip_alloc_sem_key Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_quota_ip_alloc_sem_key); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7); lock(&ocfs2_quota_ip_alloc_sem_key); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5); *** DEADLOCK *** 5 locks held by syz.2.683/12215: #0: ffff88801185c420 (sb_writers#19){.+.+}-{0:0}, at: mnt_want_write+0x3f/0x90 fs/namespace.c:515 #1: ffff88805961b480 (&type->i_mutex_dir_key#13){++++}-{4:4}, at: inode_lock include/linux/fs.h:818 [inline] #1: ffff88805961b480 (&type->i_mutex_dir_key#13){++++}-{4:4}, at: chown_common+0x3e1/0x850 fs/open.c:768 #2: ffff8880561680a8 (&dquot->dq_lock){+.+.}-{4:4}, at: ocfs2_acquire_dquot+0x2a3/0xb70 fs/ocfs2/quota_global.c:818 #3: ffff88805961d100 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:818 [inline] #3: ffff88805961d100 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}, at: ocfs2_lock_global_qf+0x206/0x2b0 fs/ocfs2/quota_global.c:313 #4: ffff88805961cda0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_lock_global_qf+0x225/0x2b0 fs/ocfs2/quota_global.c:314 stack backtrace: CPU: 0 UID: 0 PID: 12215 Comm: syz.2.683 Not tainted 6.13.0-rc3-syzkaller-00193-ge9b8ffafd20a #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2074 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2206 check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:818 [inline] ocfs2_reserve_local_alloc_bits+0x132/0x2840 fs/ocfs2/localalloc.c:636 ocfs2_reserve_clusters_with_limit+0x1b8/0xb60 fs/ocfs2/suballoc.c:1166 ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1227 [inline] ocfs2_lock_allocators+0x30a/0x630 fs/ocfs2/suballoc.c:2746 ocfs2_extend_allocation+0x4ed/0x1bf0 fs/ocfs2/file.c:589 ocfs2_extend_no_holes+0x1f6/0x4a0 fs/ocfs2/file.c:1027 ocfs2_acquire_dquot+0x64d/0xb70 fs/ocfs2/quota_global.c:848 dqget+0x770/0xeb0 fs/quota/dquot.c:977 ocfs2_setattr+0x114c/0x1ef0 fs/ocfs2/file.c:1243 notify_change+0xbca/0xe90 fs/attr.c:552 chown_common+0x501/0x850 fs/open.c:778 do_fchownat+0x16a/0x240 fs/open.c:809 __do_sys_lchown fs/open.c:834 [inline] __se_sys_lchown fs/open.c:832 [inline] __x64_sys_lchown+0x85/0xa0 fs/open.c:832 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f0243b85d29 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f02449e2038 EFLAGS: 00000246 ORIG_RAX: 000000000000005e RAX: ffffffffffffffda RBX: 00007f0243d75fa0 RCX: 00007f0243b85d29 RDX: 000000000000ee01 RSI: 0000000000000000 RDI: 00000000200006c0 RBP: 00007f0243c01aa8 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f0243d75fa0 R15: 00007ffcbb4f5ee8