ocfs2: Mounting device (7,5) on (node local, slot 0) with ordered data mode. ====================================================== WARNING: possible circular locking dependency detected 5.15.170-syzkaller #0 Not tainted ------------------------------------------------------ syz.5.218/5193 is trying to acquire lock: ffff0000e3824650 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_write_begin_inline fs/ocfs2/aops.c:1482 [inline] ffff0000e3824650 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1585 [inline] ffff0000e3824650 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_write_begin_nolock+0x9dc/0x3e1c fs/ocfs2/aops.c:1671 but task is already holding lock: ffff0000e687cda0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_write_begin+0x178/0x38c fs/ocfs2/aops.c:1903 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #6 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}: down_write+0xbc/0x12c kernel/locking/rwsem.c:1551 ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314 ocfs2_acquire_dquot+0x258/0xa90 fs/ocfs2/quota_global.c:811 dqget+0x664/0xd0c fs/quota/dquot.c:986 dquot_get_next_dqblk+0xb8/0x348 fs/quota/dquot.c:2711 quota_getnextquota+0x264/0x674 fs/quota/quota.c:249 do_quotactl+0x52c/0x698 fs/quota/quota.c:799 __do_sys_quotactl fs/quota/quota.c:959 [inline] __se_sys_quotactl fs/quota/quota.c:915 [inline] __arm64_sys_quotactl+0x2d8/0x7a4 fs/quota/quota.c:915 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #5 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}: down_write+0xbc/0x12c kernel/locking/rwsem.c:1551 inode_lock include/linux/fs.h:789 [inline] ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313 ocfs2_acquire_dquot+0x258/0xa90 fs/ocfs2/quota_global.c:811 dqget+0x664/0xd0c fs/quota/dquot.c:986 dquot_get_next_dqblk+0xb8/0x348 fs/quota/dquot.c:2711 quota_getnextquota+0x264/0x674 fs/quota/quota.c:249 do_quotactl+0x52c/0x698 fs/quota/quota.c:799 __do_sys_quotactl fs/quota/quota.c:959 [inline] __se_sys_quotactl fs/quota/quota.c:915 [inline] __arm64_sys_quotactl+0x2d8/0x7a4 fs/quota/quota.c:915 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #4 (&dquot->dq_lock){+.+.}-{3:3}: __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 dquot_commit+0x54/0x240 fs/quota/dquot.c:507 ext4_write_dquot+0x1b4/0x314 fs/ext4/super.c:6173 ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6233 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0x108/0x424 fs/quota/dquot.c:412 __dquot_alloc_space+0xb54/0xf7c fs/quota/dquot.c:1750 dquot_alloc_space_nodirty include/linux/quotaops.h:297 [inline] dquot_alloc_space include/linux/quotaops.h:310 [inline] dquot_alloc_block include/linux/quotaops.h:334 [inline] ext4_mb_new_blocks+0xe78/0x4278 fs/ext4/mballoc.c:5739 ext4_ext_map_blocks+0x1500/0x6418 fs/ext4/extents.c:4339 ext4_map_blocks+0x8d0/0x1a44 fs/ext4/inode.c:672 ext4_getblk+0x160/0x688 fs/ext4/inode.c:869 ext4_bread+0x3c/0x1d4 fs/ext4/inode.c:922 ext4_append+0x260/0x4cc fs/ext4/namei.c:83 ext4_add_entry+0x8f4/0xf0c fs/ext4/namei.c:2511 ext4_add_nondir+0x98/0x244 fs/ext4/namei.c:2845 ext4_create+0x314/0x480 fs/ext4/namei.c:2891 lookup_open fs/namei.c:3462 [inline] open_last_lookups fs/namei.c:3532 [inline] path_openat+0xf18/0x26cc fs/namei.c:3739 do_filp_open+0x1a8/0x3b4 fs/namei.c:3769 do_sys_openat2+0x128/0x3e0 fs/open.c:1253 do_sys_open fs/open.c:1269 [inline] __do_sys_openat fs/open.c:1285 [inline] __se_sys_openat fs/open.c:1280 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1280 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #3 (&ei->i_data_sem){++++}-{3:3}: down_write+0xbc/0x12c kernel/locking/rwsem.c:1551 ext4_map_blocks+0x830/0x1a44 fs/ext4/inode.c:665 mpage_map_one_extent fs/ext4/inode.c:2407 [inline] mpage_map_and_submit_extent fs/ext4/inode.c:2460 [inline] ext4_writepages+0x12c0/0x36fc fs/ext4/inode.c:2828 do_writepages+0x39c/0x5ec mm/page-writeback.c:2386 __writeback_single_inode+0x148/0x13a4 fs/fs-writeback.c:1647 writeback_sb_inodes+0x94c/0x1654 fs/fs-writeback.c:1930 __writeback_inodes_wb+0x110/0x39c fs/fs-writeback.c:2001 wb_writeback+0x410/0xfc8 fs/fs-writeback.c:2106 wb_check_background_flush fs/fs-writeback.c:2172 [inline] wb_do_writeback fs/fs-writeback.c:2260 [inline] wb_workfn+0xc44/0x1070 fs/fs-writeback.c:2288 process_one_work+0x790/0x11b8 kernel/workqueue.c:2310 worker_thread+0x910/0x1034 kernel/workqueue.c:2457 kthread+0x37c/0x45c kernel/kthread.c:334 ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:870 -> #2 (jbd2_handle){++++}-{0:0}: start_this_handle+0xfc0/0x12a4 fs/jbd2/transaction.c:464 jbd2__journal_start+0x29c/0x7b4 fs/jbd2/transaction.c:521 jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:560 ocfs2_start_trans+0x468/0x804 fs/ocfs2/journal.c:354 ocfs2_modify_bh+0xe4/0x498 fs/ocfs2/quota_local.c:101 ocfs2_local_read_info+0x1220/0x15bc fs/ocfs2/quota_local.c:768 dquot_load_quota_sb+0x6f0/0xb1c fs/quota/dquot.c:2461 dquot_load_quota_inode+0x280/0x4f4 fs/quota/dquot.c:2498 ocfs2_enable_quotas+0x17c/0x3cc fs/ocfs2/super.c:927 ocfs2_fill_super+0x3698/0x498c fs/ocfs2/super.c:1140 mount_bdev+0x274/0x370 fs/super.c:1400 ocfs2_mount+0x44/0x58 fs/ocfs2/super.c:1187 legacy_get_tree+0xd4/0x16c fs/fs_context.c:611 vfs_get_tree+0x90/0x274 fs/super.c:1530 do_new_mount+0x278/0x8fc fs/namespace.c:3012 path_mount+0x594/0x101c fs/namespace.c:3342 do_mount fs/namespace.c:3355 [inline] __do_sys_mount fs/namespace.c:3563 [inline] __se_sys_mount fs/namespace.c:3540 [inline] __arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3540 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #1 (&journal->j_trans_barrier){.+.+}-{3:3}: down_read+0xc0/0x398 kernel/locking/rwsem.c:1498 ocfs2_start_trans+0x45c/0x804 fs/ocfs2/journal.c:352 ocfs2_modify_bh+0xe4/0x498 fs/ocfs2/quota_local.c:101 ocfs2_local_read_info+0x1220/0x15bc fs/ocfs2/quota_local.c:768 dquot_load_quota_sb+0x6f0/0xb1c fs/quota/dquot.c:2461 dquot_load_quota_inode+0x280/0x4f4 fs/quota/dquot.c:2498 ocfs2_enable_quotas+0x17c/0x3cc fs/ocfs2/super.c:927 ocfs2_fill_super+0x3698/0x498c fs/ocfs2/super.c:1140 mount_bdev+0x274/0x370 fs/super.c:1400 ocfs2_mount+0x44/0x58 fs/ocfs2/super.c:1187 legacy_get_tree+0xd4/0x16c fs/fs_context.c:611 vfs_get_tree+0x90/0x274 fs/super.c:1530 do_new_mount+0x278/0x8fc fs/namespace.c:3012 path_mount+0x594/0x101c fs/namespace.c:3342 do_mount fs/namespace.c:3355 [inline] __do_sys_mount fs/namespace.c:3563 [inline] __se_sys_mount fs/namespace.c:3540 [inline] __arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3540 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #0 (sb_internal#2){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1813 [inline] sb_start_intwrite include/linux/fs.h:1930 [inline] ocfs2_start_trans+0x2dc/0x804 fs/ocfs2/journal.c:350 ocfs2_write_begin_inline fs/ocfs2/aops.c:1482 [inline] ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1585 [inline] ocfs2_write_begin_nolock+0x9dc/0x3e1c fs/ocfs2/aops.c:1671 ocfs2_write_begin+0x1ac/0x38c fs/ocfs2/aops.c:1905 generic_perform_write+0x24c/0x520 mm/filemap.c:3785 __generic_file_write_iter+0x230/0x454 mm/filemap.c:3912 ocfs2_file_write_iter+0x1478/0x1e00 fs/ocfs2/file.c:2459 call_write_iter include/linux/fs.h:2174 [inline] new_sync_write fs/read_write.c:507 [inline] vfs_write+0x884/0xb44 fs/read_write.c:594 ksys_write+0x15c/0x26c fs/read_write.c:647 __do_sys_write fs/read_write.c:659 [inline] __se_sys_write fs/read_write.c:656 [inline] __arm64_sys_write+0x7c/0x90 fs/read_write.c:656 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 other info that might help us debug this: Chain exists of: sb_internal#2 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2 --> &ocfs2_quota_ip_alloc_sem_key Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_quota_ip_alloc_sem_key); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2); lock(&ocfs2_quota_ip_alloc_sem_key); lock(sb_internal#2); *** DEADLOCK *** 4 locks held by syz.5.218/5193: #0: ffff0000d0cc4ff0 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x128/0x170 fs/file.c:1057 #1: ffff0000e3824460 (sb_writers#25){.+.+}-{0:0}, at: vfs_write+0x228/0xb44 fs/read_write.c:590 #2: ffff0000e687d108 (&sb->s_type->i_mutex_key#32){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #2: ffff0000e687d108 (&sb->s_type->i_mutex_key#32){+.+.}-{3:3}, at: ocfs2_file_write_iter+0x38c/0x1e00 fs/ocfs2/file.c:2391 #3: ffff0000e687cda0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_write_begin+0x178/0x38c fs/ocfs2/aops.c:1903 stack backtrace: CPU: 0 PID: 5193 Comm: syz.5.218 Not tainted 5.15.170-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call trace: dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1813 [inline] sb_start_intwrite include/linux/fs.h:1930 [inline] ocfs2_start_trans+0x2dc/0x804 fs/ocfs2/journal.c:350 ocfs2_write_begin_inline fs/ocfs2/aops.c:1482 [inline] ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1585 [inline] ocfs2_write_begin_nolock+0x9dc/0x3e1c fs/ocfs2/aops.c:1671 ocfs2_write_begin+0x1ac/0x38c fs/ocfs2/aops.c:1905 generic_perform_write+0x24c/0x520 mm/filemap.c:3785 __generic_file_write_iter+0x230/0x454 mm/filemap.c:3912 ocfs2_file_write_iter+0x1478/0x1e00 fs/ocfs2/file.c:2459 call_write_iter include/linux/fs.h:2174 [inline] new_sync_write fs/read_write.c:507 [inline] vfs_write+0x884/0xb44 fs/read_write.c:594 ksys_write+0x15c/0x26c fs/read_write.c:647 __do_sys_write fs/read_write.c:659 [inline] __se_sys_write fs/read_write.c:656 [inline] __arm64_sys_write+0x7c/0x90 fs/read_write.c:656 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 netlink: 24 bytes leftover after parsing attributes in process `syz.5.218'.