======================================================
WARNING: possible circular locking dependency detected
6.7.0-syzkaller-12824-g9d64bf433c53 #0 Not tainted
------------------------------------------------------
syz-executor702/5056 is trying to acquire lock:
ffff88804e1987c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1c1/0x1090 fs/hfsplus/extents.c:457

but task is already holding lock:
ffff888020f000b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x1a3/0x200 fs/hfsplus/bfind.c:30

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&tree->tree_lock){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:608 [inline]
       __mutex_lock+0x175/0x9d0 kernel/locking/mutex.c:752
       hfsplus_file_truncate+0x882/0x9d0 fs/hfsplus/extents.c:595
       hfsplus_setattr+0x1eb/0x310 fs/hfsplus/inode.c:265
       notify_change+0x742/0x11c0 fs/attr.c:499
       do_truncate+0x15c/0x220 fs/open.c:66
       do_sys_ftruncate+0x6a2/0x790 fs/open.c:194
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xd3/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x63/0x6b

-> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x2445/0x3b30 kernel/locking/lockdep.c:5137
       lock_acquire kernel/locking/lockdep.c:5754 [inline]
       lock_acquire+0x1ae/0x520 kernel/locking/lockdep.c:5719
       __mutex_lock_common kernel/locking/mutex.c:608 [inline]
       __mutex_lock+0x175/0x9d0 kernel/locking/mutex.c:752
       hfsplus_file_extend+0x1c1/0x1090 fs/hfsplus/extents.c:457
       hfsplus_bmap_reserve+0x318/0x410 fs/hfsplus/btree.c:358
       hfsplus_rename_cat+0x2ad/0x1230 fs/hfsplus/catalog.c:456
       hfsplus_rename+0x118/0x200 fs/hfsplus/dir.c:552
       vfs_rename+0xf83/0x20a0 fs/namei.c:4879
       do_renameat2+0xc50/0xdc0 fs/namei.c:5036
       __do_sys_rename fs/namei.c:5083 [inline]
       __se_sys_rename fs/namei.c:5081 [inline]
       __x64_sys_rename+0x81/0xa0 fs/namei.c:5081
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xd3/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x63/0x6b

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&tree->tree_lock);
                               lock(&HFSPLUS_I(inode)->extents_lock);
                               lock(&tree->tree_lock);
  lock(&HFSPLUS_I(inode)->extents_lock);

 *** DEADLOCK ***

5 locks held by syz-executor702/5056:
 #0: ffff888023012420 (sb_writers#9){.+.+}-{0:0}, at: do_renameat2+0x3d2/0xdc0 fs/namei.c:4966
 #1: ffff88804e199e00 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:837 [inline]
 #1: ffff88804e199e00 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: lock_rename fs/namei.c:3065 [inline]
 #1: ffff88804e199e00 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: lock_rename fs/namei.c:3062 [inline]
 #1: ffff88804e199e00 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: do_renameat2+0xad5/0xdc0 fs/namei.c:4971
 #2: ffff888079791080 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:802 [inline]
 #2: ffff888079791080 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: lock_two_nondirectories+0x195/0x200 fs/inode.c:1109
 #3: ffff888079791e00 (&sb->s_type->i_mutex_key#15/4){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:837 [inline]
 #3: ffff888079791e00 (&sb->s_type->i_mutex_key#15/4){+.+.}-{3:3}, at: lock_two_nondirectories+0xed/0x200 fs/inode.c:1111
 #4: ffff888020f000b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x1a3/0x200 fs/hfsplus/bfind.c:30

stack backtrace:
CPU: 0 PID: 5056 Comm: syz-executor702 Not tainted 6.7.0-syzkaller-12824-g9d64bf433c53 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/17/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xd9/0x1b0 lib/dump_stack.c:106
 check_noncircular+0x317/0x400 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x2445/0x3b30 kernel/locking/lockdep.c:5137
 lock_acquire kernel/locking/lockdep.c:5754 [inline]
 lock_acquire+0x1ae/0x520 kernel/locking/lockdep.c:5719
 __mutex_lock_common kernel/locking/mutex.c:608 [inline]
 __mutex_lock+0x175/0x9d0 kernel/locking/mutex.c:752
 hfsplus_file_extend+0x1c1/0x1090 fs/hfsplus/extents.c:457
 hfsplus_bmap_reserve+0x318/0x410 fs/hfsplus/btree.c:358
 hfsplus_rename_cat+0x2ad/0x1230 fs/hfsplus/catalog.c:456
 hfsplus_rename+0x118/0x200 fs/hfsplus/dir.c:552
 vfs_rename+0xf83/0x20a0 fs/namei.c:4879
 do_renameat2+0xc50/0xdc0 fs/namei.c:5036
 __do_sys_rename fs/namei.c:5083 [inline]
 __se_sys_rename fs/namei.c:5081 [inline]
 __x64_sys_rename+0x81/0xa0 fs/namei.c:5081
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xd3/0x250 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x63/0x6b
RIP: 0033:0x7f92ecdea739
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 61 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fff067c5878 EFLAGS: 00000246 ORIG_RAX: 0000000000000052
RAX: ffffffffffffffda RBX: 0031656c6966