====================================================== WARNING: possible circular locking dependency detected 4.14.307-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.2/11621 is trying to acquire lock: (&ovl_i_mutex_dir_key[depth]#2){++++}, at: [] iterate_dir+0x387/0x5e0 fs/readdir.c:43 but task is already holding lock: (sb_writers#3){.+.+}, at: [] sb_start_write include/linux/fs.h:1551 [inline] (sb_writers#3){.+.+}, at: [] mnt_want_write+0x3a/0xb0 fs/namespace.c:386 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (sb_writers#3){.+.+}: percpu_down_read_preempt_disable include/linux/percpu-rwsem.h:36 [inline] percpu_down_read include/linux/percpu-rwsem.h:59 [inline] __sb_start_write+0x64/0x260 fs/super.c:1342 sb_start_write include/linux/fs.h:1551 [inline] mnt_want_write+0x3a/0xb0 fs/namespace.c:386 ovl_xattr_set+0x4d/0x290 fs/overlayfs/inode.c:214 __vfs_setxattr+0xdc/0x130 fs/xattr.c:150 __vfs_setxattr_noperm+0xfd/0x3d0 fs/xattr.c:181 __vfs_setxattr_locked+0x14d/0x250 fs/xattr.c:239 vfs_setxattr+0xcf/0x230 fs/xattr.c:256 setxattr+0x1a9/0x300 fs/xattr.c:523 path_setxattr+0x118/0x130 fs/xattr.c:542 SYSC_lsetxattr fs/xattr.c:564 [inline] SyS_lsetxattr+0x33/0x40 fs/xattr.c:560 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x5e/0xd3 -> #0 (&ovl_i_mutex_dir_key[depth]#2){++++}: lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998 down_write_killable+0x37/0xb0 kernel/locking/rwsem.c:68 iterate_dir+0x387/0x5e0 fs/readdir.c:43 ovl_dir_read fs/overlayfs/readdir.c:306 [inline] ovl_dir_read_merged+0x2c5/0x430 fs/overlayfs/readdir.c:365 ovl_check_empty_dir+0x6e/0x200 fs/overlayfs/readdir.c:870 ovl_check_empty_and_clear+0x72/0xe0 fs/overlayfs/dir.c:306 ovl_rename+0x57d/0xe50 fs/overlayfs/dir.c:959 vfs_rename+0x560/0x1820 fs/namei.c:4498 SYSC_renameat2 fs/namei.c:4646 [inline] SyS_renameat2+0x95b/0xad0 fs/namei.c:4535 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x5e/0xd3 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(sb_writers#3); lock(&ovl_i_mutex_dir_key[depth]#2); lock(sb_writers#3); lock(&ovl_i_mutex_dir_key[depth]#2); *** DEADLOCK *** 6 locks held by syz-executor.2/11621: #0: (sb_writers#14){.+.+}, at: [] sb_start_write include/linux/fs.h:1551 [inline] #0: (sb_writers#14){.+.+}, at: [] mnt_want_write+0x3a/0xb0 fs/namespace.c:386 #1: (&type->s_vfs_rename_key#2){+.+.}, at: [] lock_rename+0x54/0x280 fs/namei.c:2889 #2: (&ovl_i_mutex_dir_key[depth]/1){+.+.}, at: [] inode_lock_nested include/linux/fs.h:754 [inline] #2: (&ovl_i_mutex_dir_key[depth]/1){+.+.}, at: [] lock_rename+0x132/0x280 fs/namei.c:2900 #3: (&ovl_i_mutex_dir_key[depth]/2){+.+.}, at: [] inode_lock_nested include/linux/fs.h:754 [inline] #3: (&ovl_i_mutex_dir_key[depth]/2){+.+.}, at: [] lock_rename+0x166/0x280 fs/namei.c:2901 #4: (&ovl_i_mutex_dir_key[depth]){++++}, at: [] inode_lock include/linux/fs.h:719 [inline] #4: (&ovl_i_mutex_dir_key[depth]){++++}, at: [] vfs_rename+0xbd8/0x1820 fs/namei.c:4472 #5: (sb_writers#3){.+.+}, at: [] sb_start_write include/linux/fs.h:1551 [inline] #5: (sb_writers#3){.+.+}, at: [] mnt_want_write+0x3a/0xb0 fs/namespace.c:386 stack backtrace: CPU: 1 PID: 11621 Comm: syz-executor.2 Not tainted 4.14.307-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/16/2023 Call Trace: __dump_stack lib/dump_stack.c:17 [inline] dump_stack+0x1b2/0x281 lib/dump_stack.c:58 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1258 check_prev_add kernel/locking/lockdep.c:1905 [inline] check_prevs_add kernel/locking/lockdep.c:2022 [inline] validate_chain kernel/locking/lockdep.c:2464 [inline] __lock_acquire+0x2e0e/0x3f20 kernel/locking/lockdep.c:3491 lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998 down_write_killable+0x37/0xb0 kernel/locking/rwsem.c:68 iterate_dir+0x387/0x5e0 fs/readdir.c:43 ovl_dir_read fs/overlayfs/readdir.c:306 [inline] ovl_dir_read_merged+0x2c5/0x430 fs/overlayfs/readdir.c:365 ovl_check_empty_dir+0x6e/0x200 fs/overlayfs/readdir.c:870 ovl_check_empty_and_clear+0x72/0xe0 fs/overlayfs/dir.c:306 ovl_rename+0x57d/0xe50 fs/overlayfs/dir.c:959 vfs_rename+0x560/0x1820 fs/namei.c:4498 SYSC_renameat2 fs/namei.c:4646 [inline] SyS_renameat2+0x95b/0xad0 fs/namei.c:4535 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x5e/0xd3 RIP: 0033:0x7f2ea49d90f9 RSP: 002b:00007f2ea2f4b168 EFLAGS: 00000246 ORIG_RAX: 0000000000000052 RAX: ffffffffffffffda RBX: 00007f2ea4af8f80 RCX: 00007f2ea49d90f9 RDX: 0000000000000000 RSI: 0000000020000440 RDI: 0000000020000100 RBP: 00007f2ea4a34ae9 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffce6874dcf R14: 00007f2ea2f4b300 R15: 0000000000022000 overlayfs: fs on 'file0' does not support file handles, falling back to index=off. overlayfs: fs on 'file0' does not support file handles, falling back to index=off. device ip6gretap0 entered promiscuous mode overlayfs: fs on './file0' does not support file handles, falling back to index=off. overlayfs: fs on './file0' does not support file handles, falling back to index=off. 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 9pnet_virtio: no channels available for device 127.0.0.1 REISERFS (device loop4): found reiserfs format "3.5" with non-standard journal REISERFS (device loop4): using ordered data mode reiserfs: using flush barriers REISERFS (device loop4): journal params: device loop4, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30 input: syz1 as /devices/virtual/input/input5 REISERFS (device loop4): checking transaction log (loop4) REISERFS (device loop4): Using r5 hash to sort names reiserfs: enabling write barrier flush mode REISERFS (device loop4): Created .reiserfs_priv - reserved for xattr storage. overlayfs: fs on './file0' does not support file handles, falling back to index=off. overlayfs: upper fs needs to support d_type. overlayfs: upper fs does not support tmpfile. overlayfs: upper fs does not support xattr. 9pnet_virtio: no channels available for device 127.0.0.1 XFS (loop2): Superblock has unknown incompatible features (0x8) enabled. XFS (loop2): Filesystem can not be safely mounted by this kernel. 9pnet_virtio: no channels available for device 127.0.0.1 XFS (loop2): SB validate failed with error -22. input: syz1 as /devices/virtual/input/input6 input: syz1 as /devices/virtual/input/input7 REISERFS (device loop4): found reiserfs format "3.5" with non-standard journal REISERFS (device loop4): using ordered data mode reiserfs: using flush barriers REISERFS (device loop4): journal params: device loop4, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30 REISERFS (device loop4): checking transaction log (loop4) REISERFS (device loop4): Using r5 hash to sort names input: syz1 as /devices/virtual/input/input8 reiserfs: enabling write barrier flush mode REISERFS (device loop4): Created .reiserfs_priv - reserved for xattr storage. input: syz1 as /devices/virtual/input/input9 overlayfs: fs on './file0' does not support file handles, falling back to index=off. overlayfs: upper fs needs to support d_type. overlayfs: upper fs does not support tmpfile. overlayfs: upper fs does not support xattr. XFS (loop2): Superblock has unknown incompatible features (0x8) enabled. XFS (loop2): Filesystem can not be safely mounted by this kernel. XFS (loop2): SB validate failed with error -22. input: syz1 as /devices/virtual/input/input10 input: syz1 as /devices/virtual/input/input11 REISERFS (device loop4): found reiserfs format "3.5" with non-standard journal REISERFS (device loop4): using ordered data mode reiserfs: using flush barriers REISERFS (device loop4): journal params: device loop4, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30 REISERFS (device loop4): checking transaction log (loop4) REISERFS (device loop4): Using r5 hash to sort names input: syz1 as /devices/virtual/input/input12 input: syz1 as /devices/virtual/input/input13 XFS (loop2): Superblock has unknown incompatible features (0x8) enabled. XFS (loop2): Filesystem can not be safely mounted by this kernel. reiserfs: enabling write barrier flush mode REISERFS (device loop4): Created .reiserfs_priv - reserved for xattr storage. overlayfs: fs on './file0' does not support file handles, falling back to index=off. XFS (loop2): SB validate failed with error -22. overlayfs: upper fs needs to support d_type. overlayfs: upper fs does not support tmpfile. overlayfs: upper fs does not support xattr. input: syz1 as /devices/virtual/input/input14 REISERFS (device loop4): found reiserfs format "3.5" with non-standard journal input: syz1 as /devices/virtual/input/input15 REISERFS (device loop4): using ordered data mode reiserfs: using flush barriers REISERFS (device loop4): journal params: device loop4, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30 REISERFS (device loop4): checking transaction log (loop4) REISERFS (device loop4): Using r5 hash to sort names reiserfs: enabling write barrier flush mode REISERFS (device loop4): Created .reiserfs_priv - reserved for xattr storage. overlayfs: fs on './file0' does not support file handles, falling back to index=off. overlayfs: upper fs needs to support d_type. overlayfs: upper fs does not support tmpfile. overlayfs: upper fs does not support xattr. input: syz1 as /devices/virtual/input/input16 input: syz1 as /devices/virtual/input/input17 XFS (loop2): Superblock has unknown incompatible features (0x8) enabled. XFS (loop2): Filesystem can not be safely mounted by this kernel. XFS (loop2): SB validate failed with error -22. input: syz1 as /devices/virtual/input/input18 input: syz1 as /devices/virtual/input/input19 REISERFS (device loop2): found reiserfs format "3.5" with non-standard journal REISERFS (device loop2): using ordered data mode reiserfs: using flush barriers input: syz1 as /devices/virtual/input/input20 REISERFS (device loop2): journal params: device loop2, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30 REISERFS (device loop2): checking transaction log (loop2) REISERFS (device loop4): found reiserfs format "3.5" with non-standard journal REISERFS (device loop2): Using r5 hash to sort names REISERFS (device loop4): using ordered data mode reiserfs: using flush barriers REISERFS (device loop4): journal params: device loop4, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30 reiserfs: enabling write barrier flush mode REISERFS (device loop2): Created .reiserfs_priv - reserved for xattr storage. REISERFS (device loop4): checking transaction log (loop4) REISERFS (device loop4): Using r5 hash to sort names reiserfs: enabling write barrier flush mode REISERFS (device loop4): Created .reiserfs_priv - reserved for xattr storage. overlayfs: fs on './file0' does not support file handles, falling back to index=off. overlayfs: upper fs needs to support d_type. overlayfs: upper fs does not support tmpfile. overlayfs: upper fs does not support xattr. overlayfs: fs on './file0' does not support file handles, falling back to index=off. overlayfs: upper fs needs to support d_type. overlayfs: upper fs does not support tmpfile. overlayfs: upper fs does not support xattr. REISERFS (device loop5): found reiserfs format "3.5" with non-standard journal REISERFS (device loop5): using ordered data mode reiserfs: using flush barriers REISERFS (device loop5): journal params: device loop5, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30 REISERFS (device loop5): checking transaction log (loop5) REISERFS (device loop5): Using r5 hash to sort names reiserfs: enabling write barrier flush mode REISERFS (device loop4): found reiserfs format "3.5" with non-standard journal REISERFS (device loop5): Created .reiserfs_priv - reserved for xattr storage. REISERFS (device loop4): using ordered data mode reiserfs: using flush barriers REISERFS (device loop4): journal params: device loop4, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30 REISERFS (device loop4): checking transaction log (loop4) REISERFS (device loop4): Using r5 hash to sort names REISERFS (device loop2): found reiserfs format "3.5" with non-standard journal REISERFS (device loop2): using ordered data mode reiserfs: using flush barriers EXT4-fs (loop3): Test dummy encryption mount option ignored REISERFS (device loop2): journal params: device loop2, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30 reiserfs: enabling write barrier flush mode EXT4-fs (loop3): Ignoring removed nomblk_io_submit option EXT4-fs (loop3): Unsupported blocksize for fs encryption REISERFS (device loop2): checking transaction log (loop2) REISERFS (device loop4): Created .reiserfs_priv - reserved for xattr storage. REISERFS (device loop2): Using r5 hash to sort names reiserfs: enabling write barrier flush mode REISERFS (device loop2): Created .reiserfs_priv - reserved for xattr storage. EXT4-fs (loop3): Test dummy encryption mount option ignored overlayfs: fs on './file0' does not support file handles, falling back to index=off. EXT4-fs (loop3): Ignoring removed nomblk_io_submit option EXT4-fs (loop3): Unsupported blocksize for fs encryption overlayfs: upper fs needs to support d_type. overlayfs: upper fs does not support tmpfile. overlayfs: upper fs does not support xattr. EXT4-fs (loop3): Test dummy encryption mount option ignored EXT4-fs (loop3): Ignoring removed nomblk_io_submit option EXT4-fs (loop3): Unsupported blocksize for fs encryption overlayfs: fs on './file0' does not support file handles, falling back to index=off. overlayfs: fs on './file0' does not support file handles, falling back to index=off. overlayfs: upper fs needs to support d_type. overlayfs: upper fs does not support tmpfile. overlayfs: upper fs needs to support d_type. overlayfs: upper fs does not support xattr. overlayfs: upper fs does not support tmpfile. overlayfs: upper fs does not support xattr. EXT4-fs (loop3): Test dummy encryption mount option ignored EXT4-fs (loop3): Ignoring removed nomblk_io_submit option EXT4-fs (loop3): Unsupported blocksize for fs encryption REISERFS (device loop4): found reiserfs format "3.5" with non-standard journal REISERFS (device loop4): using ordered data mode reiserfs: using flush barriers REISERFS (device loop4): journal params: device loop4, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30 REISERFS (device loop5): found reiserfs format "3.5" with non-standard journal REISERFS (device loop4): checking transaction log (loop4) REISERFS (device loop5): using ordered data mode REISERFS (device loop2): found reiserfs format "3.5" with non-standard journal REISERFS (device loop4): Using r5 hash to sort names reiserfs: using flush barriers REISERFS (device loop2): using ordered data mode reiserfs: enabling write barrier flush mode REISERFS (device loop5): journal params: device loop5, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30 REISERFS (device loop4): Created .reiserfs_priv - reserved for xattr storage. reiserfs: using flush barriers REISERFS (device loop2): journal params: device loop2, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30