EXT4-fs: Journaled quota options ignored when QUOTA feature is enabled
EXT4-fs (loop6): mounted filesystem without journal. Quota mode: writeback.
======================================================
WARNING: possible circular locking dependency detected
6.1.118-syzkaller #0 Not tainted
------------------------------------------------------
syz.6.969/9366 is trying to acquire lock:
ffff0000e17a2268 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_commit+0x54/0x240 fs/quota/dquot.c:507

but task is already holding lock:
ffff0000f4e52aa8 (&ei->i_data_sem){++++}-{3:3}, at: ext4_map_blocks+0x77c/0x1810 fs/ext4/inode.c:671

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #5 (&ei->i_data_sem){++++}-{3:3}:
       down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
       ext4_truncate+0x7e0/0x1178 fs/ext4/inode.c:4283
       ext4_setattr+0xda0/0x14e8 fs/ext4/inode.c:5601
       notify_change+0xb58/0xe1c fs/attr.c:499
       do_truncate+0x1c0/0x28c fs/open.c:65
       do_sys_ftruncate+0x288/0x31c fs/open.c:193
       __do_sys_ftruncate fs/open.c:204 [inline]
       __se_sys_ftruncate fs/open.c:202 [inline]
       __arm64_sys_ftruncate+0x60/0x74 fs/open.c:202
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #4 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0x1140/0x13ac fs/jbd2/transaction.c:463
       jbd2__journal_start+0x298/0x544 fs/jbd2/transaction.c:520
       jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:559
       ocfs2_start_trans+0x3e8/0x73c fs/ocfs2/journal.c:354
       ocfs2_modify_bh+0xe4/0x484 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x1220/0x15bc fs/ocfs2/quota_local.c:768
       dquot_load_quota_sb+0x6f0/0xb1c fs/quota/dquot.c:2468
       dquot_load_quota_inode+0x280/0x4f4 fs/quota/dquot.c:2505
       ocfs2_enable_quotas+0x17c/0x3cc fs/ocfs2/super.c:926
       ocfs2_fill_super+0x3ef4/0x4a0c fs/ocfs2/super.c:1139
       mount_bdev+0x274/0x370 fs/super.c:1443
       ocfs2_mount+0x44/0x58 fs/ocfs2/super.c:1186
       legacy_get_tree+0xd4/0x16c fs/fs_context.c:632
       vfs_get_tree+0x90/0x274 fs/super.c:1573
       do_new_mount+0x278/0x8fc fs/namespace.c:3056
       path_mount+0x590/0xe5c fs/namespace.c:3386
       do_mount fs/namespace.c:3399 [inline]
       __do_sys_mount fs/namespace.c:3607 [inline]
       __se_sys_mount fs/namespace.c:3584 [inline]
       __arm64_sys_mount+0x45c/0x594 fs/namespace.c:3584
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #3 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x64/0x308 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x3dc/0x73c fs/ocfs2/journal.c:352
       ocfs2_modify_bh+0xe4/0x484 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x1220/0x15bc fs/ocfs2/quota_local.c:768
       dquot_load_quota_sb+0x6f0/0xb1c fs/quota/dquot.c:2468
       dquot_load_quota_inode+0x280/0x4f4 fs/quota/dquot.c:2505
       ocfs2_enable_quotas+0x17c/0x3cc fs/ocfs2/super.c:926
       ocfs2_fill_super+0x3ef4/0x4a0c fs/ocfs2/super.c:1139
       mount_bdev+0x274/0x370 fs/super.c:1443
       ocfs2_mount+0x44/0x58 fs/ocfs2/super.c:1186
       legacy_get_tree+0xd4/0x16c fs/fs_context.c:632
       vfs_get_tree+0x90/0x274 fs/super.c:1573
       do_new_mount+0x278/0x8fc fs/namespace.c:3056
       path_mount+0x590/0xe5c fs/namespace.c:3386
       do_mount fs/namespace.c:3399 [inline]
       __do_sys_mount fs/namespace.c:3607 [inline]
       __se_sys_mount fs/namespace.c:3584 [inline]
       __arm64_sys_mount+0x45c/0x594 fs/namespace.c:3584
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #2 (sb_internal#4){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1891 [inline]
       sb_start_intwrite include/linux/fs.h:2013 [inline]
       ocfs2_start_trans+0x260/0x73c fs/ocfs2/journal.c:350
       ocfs2_acquire_dquot+0x3d8/0xb1c fs/ocfs2/quota_global.c:843
       dqget+0x660/0xcec fs/quota/dquot.c:986
       __dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1515
       dquot_initialize+0x24/0x34 fs/quota/dquot.c:1577
       ocfs2_get_init_inode+0x14c/0x1b8 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x8ac/0x2560 fs/ocfs2/namei.c:308
       ocfs2_create+0x1a8/0x560 fs/ocfs2/namei.c:672
       lookup_open fs/namei.c:3482 [inline]
       open_last_lookups fs/namei.c:3550 [inline]
       path_openat+0xeac/0x2548 fs/namei.c:3780
       do_filp_open+0x1bc/0x3cc fs/namei.c:3810
       do_sys_openat2+0x128/0x3e0 fs/open.c:1318
       do_sys_open fs/open.c:1334 [inline]
       __do_sys_openat fs/open.c:1350 [inline]
       __se_sys_openat fs/open.c:1345 [inline]
       __arm64_sys_openat+0x1f0/0x240 fs/open.c:1345
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #1 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
       down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
       ocfs2_create_local_dquot+0x194/0x1654 fs/ocfs2/quota_local.c:1231
       ocfs2_acquire_dquot+0x720/0xb1c fs/ocfs2/quota_global.c:866
       dqget+0x660/0xcec fs/quota/dquot.c:986
       __dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1515
       dquot_initialize+0x24/0x34 fs/quota/dquot.c:1577
       ocfs2_get_init_inode+0x14c/0x1b8 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x8ac/0x2560 fs/ocfs2/namei.c:308
       ocfs2_create+0x1a8/0x560 fs/ocfs2/namei.c:672
       lookup_open fs/namei.c:3482 [inline]
       open_last_lookups fs/namei.c:3550 [inline]
       path_openat+0xeac/0x2548 fs/namei.c:3780
       do_filp_open+0x1bc/0x3cc fs/namei.c:3810
       do_sys_openat2+0x128/0x3e0 fs/open.c:1318
       do_sys_open fs/open.c:1334 [inline]
       __do_sys_openat fs/open.c:1350 [inline]
       __se_sys_openat fs/open.c:1345 [inline]
       __arm64_sys_openat+0x1f0/0x240 fs/open.c:1345
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #0 (&dquot->dq_lock){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049
       lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662
       __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799
       dquot_commit+0x54/0x240 fs/quota/dquot.c:507
       ext4_write_dquot+0x1b4/0x314 fs/ext4/super.c:6777
       ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6837
       mark_dquot_dirty fs/quota/dquot.c:372 [inline]
       mark_all_dquot_dirty+0x108/0x424 fs/quota/dquot.c:412
       __dquot_alloc_space+0xb28/0xf50 fs/quota/dquot.c:1750
       dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline]
       dquot_alloc_space include/linux/quotaops.h:313 [inline]
       dquot_alloc_block include/linux/quotaops.h:337 [inline]
       ext4_mb_new_blocks+0xe8c/0x4680 fs/ext4/mballoc.c:5727
       ext4_ext_map_blocks+0x15a8/0x6638 fs/ext4/extents.c:4339
       ext4_map_blocks+0x810/0x1810 fs/ext4/inode.c:678
       _ext4_get_block+0x1c0/0x5a0 fs/ext4/inode.c:821
       ext4_get_block+0x4c/0x60 fs/ext4/inode.c:838
       ext4_block_write_begin+0x500/0x1130 fs/ext4/inode.c:1123
       ext4_write_begin+0x620/0x138c
       ext4_da_write_begin+0x38c/0xa68 fs/ext4/inode.c:2999
       generic_perform_write+0x278/0x55c mm/filemap.c:3845
       ext4_buffered_write_iter+0x2e0/0x538 fs/ext4/file.c:285
       ext4_file_write_iter+0x18c/0x1654
       do_iter_write+0x534/0x964 fs/read_write.c:861
       vfs_writev fs/read_write.c:934 [inline]
       do_pwritev+0x1ec/0x334 fs/read_write.c:1031
       __do_sys_pwritev2 fs/read_write.c:1090 [inline]
       __se_sys_pwritev2 fs/read_write.c:1081 [inline]
       __arm64_sys_pwritev2+0xd4/0x108 fs/read_write.c:1081
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

other info that might help us debug this:

Chain exists of:
  &dquot->dq_lock --> jbd2_handle --> &ei->i_data_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ei->i_data_sem);
                               lock(jbd2_handle);
                               lock(&ei->i_data_sem);
  lock(&dquot->dq_lock);

 *** DEADLOCK ***

4 locks held by syz.6.969/9366:
 #0: ffff0000f9d60460 (sb_writers#3){.+.+}-{0:0}, at: vfs_writev fs/read_write.c:933 [inline]
 #0: ffff0000f9d60460 (sb_writers#3){.+.+}-{0:0}, at: do_pwritev+0x1d8/0x334 fs/read_write.c:1031
 #1: ffff0000f4e52c20 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #1: ffff0000f4e52c20 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: ext4_buffered_write_iter+0x9c/0x538 fs/ext4/file.c:279
 #2: ffff0000f4e52aa8 (&ei->i_data_sem){++++}-{3:3}, at: ext4_map_blocks+0x77c/0x1810 fs/ext4/inode.c:671
 #3: ffff800015cd8a48 (dquot_srcu){....}-{0:0}, at: rcu_lock_acquire+0x10/0x4c include/linux/rcupdate.h:349

stack backtrace:
CPU: 1 PID: 9366 Comm: syz.6.969 Not tainted 6.1.118-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call trace:
 dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
 dump_stack+0x1c/0x5c lib/dump_stack.c:113
 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048
 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049
 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662
 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603
 __mutex_lock kernel/locking/mutex.c:747 [inline]
 mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799
 dquot_commit+0x54/0x240 fs/quota/dquot.c:507
 ext4_write_dquot+0x1b4/0x314 fs/ext4/super.c:6777
 ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6837
 mark_dquot_dirty fs/quota/dquot.c:372 [inline]
 mark_all_dquot_dirty+0x108/0x424 fs/quota/dquot.c:412
 __dquot_alloc_space+0xb28/0xf50 fs/quota/dquot.c:1750
 dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline]
 dquot_alloc_space include/linux/quotaops.h:313 [inline]
 dquot_alloc_block include/linux/quotaops.h:337 [inline]
 ext4_mb_new_blocks+0xe8c/0x4680 fs/ext4/mballoc.c:5727
 ext4_ext_map_blocks+0x15a8/0x6638 fs/ext4/extents.c:4339
 ext4_map_blocks+0x810/0x1810 fs/ext4/inode.c:678
 _ext4_get_block+0x1c0/0x5a0 fs/ext4/inode.c:821
 ext4_get_block+0x4c/0x60 fs/ext4/inode.c:838
 ext4_block_write_begin+0x500/0x1130 fs/ext4/inode.c:1123
 ext4_write_begin+0x620/0x138c
 ext4_da_write_begin+0x38c/0xa68 fs/ext4/inode.c:2999
 generic_perform_write+0x278/0x55c mm/filemap.c:3845
 ext4_buffered_write_iter+0x2e0/0x538 fs/ext4/file.c:285
 ext4_file_write_iter+0x18c/0x1654
 do_iter_write+0x534/0x964 fs/read_write.c:861
 vfs_writev fs/read_write.c:934 [inline]
 do_pwritev+0x1ec/0x334 fs/read_write.c:1031
 __do_sys_pwritev2 fs/read_write.c:1090 [inline]
 __se_sys_pwritev2 fs/read_write.c:1081 [inline]
 __arm64_sys_pwritev2+0xd4/0x108 fs/read_write.c:1081
 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
 invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585