hfsplus: catalog searching failed ====================================================== WARNING: possible circular locking dependency detected 6.9.0-rc5-syzkaller-00025-ga2c63a3f3d68 #0 Not tainted ------------------------------------------------------ syz-executor.1/5450 is trying to acquire lock: ffff88805faae8f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_allocate+0x9e/0x8c0 fs/hfsplus/bitmap.c:35 but task is already holding lock: ffff8880114fa2c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x21b/0x1b70 fs/hfsplus/extents.c:457 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 hfsplus_get_block+0x383/0x14f0 fs/hfsplus/extents.c:260 block_read_full_folio+0x42e/0xe10 fs/buffer.c:2384 filemap_read_folio+0x1a0/0x790 mm/filemap.c:2331 do_read_cache_folio+0x134/0x820 mm/filemap.c:3747 do_read_cache_page+0x30/0x200 mm/filemap.c:3813 read_mapping_page include/linux/pagemap.h:888 [inline] hfsplus_block_allocate+0xee/0x8c0 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0xade/0x1b70 fs/hfsplus/extents.c:468 hfsplus_get_block+0x406/0x14f0 fs/hfsplus/extents.c:245 __block_write_begin_int+0x50c/0x1a70 fs/buffer.c:2105 __block_write_begin fs/buffer.c:2154 [inline] block_write_begin+0x9b/0x1e0 fs/buffer.c:2213 cont_write_begin+0x645/0x890 fs/buffer.c:2567 hfsplus_write_begin+0x8a/0xd0 fs/hfsplus/inode.c:47 generic_perform_write+0x322/0x640 mm/filemap.c:3974 generic_file_write_iter+0xaf/0x310 mm/filemap.c:4095 call_write_iter include/linux/fs.h:2110 [inline] new_sync_write fs/read_write.c:497 [inline] vfs_write+0xa84/0xcb0 fs/read_write.c:590 ksys_write+0x1a0/0x2c0 fs/read_write.c:643 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&sbi->alloc_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18cb/0x58e0 kernel/locking/lockdep.c:3869 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 hfsplus_block_allocate+0x9e/0x8c0 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0xade/0x1b70 fs/hfsplus/extents.c:468 hfsplus_bmap_reserve+0x105/0x4e0 fs/hfsplus/btree.c:358 hfsplus_rename_cat+0x1d0/0x1050 fs/hfsplus/catalog.c:456 hfsplus_unlink+0x308/0x790 fs/hfsplus/dir.c:376 hfsplus_rename+0xc8/0x1c0 fs/hfsplus/dir.c:547 vfs_rename+0xbdb/0xf00 fs/namei.c:4880 do_renameat2+0xd94/0x13f0 fs/namei.c:5037 __do_sys_renameat2 fs/namei.c:5071 [inline] __se_sys_renameat2 fs/namei.c:5068 [inline] __x64_sys_renameat2+0xd2/0xf0 fs/namei.c:5068 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 7 locks held by syz-executor.1/5450: #0: ffff88807b14a420 (sb_writers#13){.+.+}-{0:0}, at: mnt_want_write+0x3f/0x90 fs/namespace.c:409 #1: ffff8880114fb900 (&type->i_mutex_dir_key#8/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:830 [inline] #1: ffff8880114fb900 (&type->i_mutex_dir_key#8/1){+.+.}-{3:3}, at: lock_rename fs/namei.c:3066 [inline] #1: ffff8880114fb900 (&type->i_mutex_dir_key#8/1){+.+.}-{3:3}, at: do_renameat2+0x62c/0x13f0 fs/namei.c:4972 #2: ffff888020054d40 (&sb->s_type->i_mutex_key#20){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:795 [inline] #2: ffff888020054d40 (&sb->s_type->i_mutex_key#20){+.+.}-{3:3}, at: lock_two_nondirectories+0xe1/0x170 fs/inode.c:1111 #3: ffff888020055400 (&sb->s_type->i_mutex_key#20/4){+.+.}-{3:3}, at: vfs_rename+0x6a2/0xf00 fs/namei.c:4851 #4: ffff88805faae998 (&sbi->vh_mutex){+.+.}-{3:3}, at: hfsplus_unlink+0x161/0x790 fs/hfsplus/dir.c:370 #5: ffff88807dc920b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x14a/0x1c0 #6: ffff8880114fa2c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x21b/0x1b70 fs/hfsplus/extents.c:457 stack backtrace: CPU: 1 PID: 5450 Comm: syz-executor.1 Not tainted 6.9.0-rc5-syzkaller-00025-ga2c63a3f3d68 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18cb/0x58e0 kernel/locking/lockdep.c:3869 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 hfsplus_block_allocate+0x9e/0x8c0 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0xade/0x1b70 fs/hfsplus/extents.c:468 hfsplus_bmap_reserve+0x105/0x4e0 fs/hfsplus/btree.c:358 hfsplus_rename_cat+0x1d0/0x1050 fs/hfsplus/catalog.c:456 hfsplus_unlink+0x308/0x790 fs/hfsplus/dir.c:376 hfsplus_rename+0xc8/0x1c0 fs/hfsplus/dir.c:547 vfs_rename+0xbdb/0xf00 fs/namei.c:4880 do_renameat2+0xd94/0x13f0 fs/namei.c:5037 __do_sys_renameat2 fs/namei.c:5071 [inline] __se_sys_renameat2 fs/namei.c:5068 [inline] __x64_sys_renameat2+0xd2/0xf0 fs/namei.c:5068 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f071c87dea9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f071d5a70c8 EFLAGS: 00000246 ORIG_RAX: 000000000000013c RAX: ffffffffffffffda RBX: 00007f071c9abf80 RCX: 00007f071c87dea9 RDX: ffffffffffffff9c RSI: 0000000020000b80 RDI: ffffffffffffff9c RBP: 00007f071c8ca4a4 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000020000bc0 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007f071c9abf80 R15: 00007ffffdd77448