ntfs3: loop4: Different NTFS' sector size (2048) and media sector size (512) ====================================================== WARNING: possible circular locking dependency detected 5.15.165-syzkaller #0 Not tainted ------------------------------------------------------ syz.4.610/7168 is trying to acquire lock: ffff888063a5e0e0 (&ni->ni_lock){+.+.}-{3:3}, at: ntfs_set_state+0x1fa/0x660 fs/ntfs3/fsntfs.c:925 but task is already holding lock: ffff8880639c8100 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1100 [inline] ffff8880639c8100 (&ni->ni_lock/4){+.+.}-{3:3}, at: ntfs_lookup+0xf5/0x1f0 fs/ntfs3/namei.c:82 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ni->ni_lock/4){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 ni_lock fs/ntfs3/ntfs_fs.h:1100 [inline] mi_read+0x2dd/0x5a0 fs/ntfs3/record.c:148 ntfs_read_mft fs/ntfs3/inode.c:69 [inline] ntfs_iget5+0x472/0x38e0 fs/ntfs3/inode.c:525 ni_update_parent+0x93f/0xdc0 fs/ntfs3/frecord.c:3154 ni_write_inode+0xe32/0x1070 fs/ntfs3/frecord.c:3252 write_inode fs/fs-writeback.c:1495 [inline] __writeback_single_inode+0x644/0xe30 fs/fs-writeback.c:1705 writeback_single_inode+0x22c/0x960 fs/fs-writeback.c:1760 sync_inode_metadata+0xba/0x110 fs/fs-writeback.c:2820 __generic_file_fsync+0x13b/0x190 fs/libfs.c:1115 generic_file_fsync+0x6f/0xe0 fs/libfs.c:1145 generic_write_sync include/linux/fs.h:2984 [inline] ntfs_file_write_iter+0x453/0x540 fs/ntfs3/file.c:1149 do_iter_readv_writev+0x594/0x7a0 do_iter_write+0x1e6/0x760 fs/read_write.c:855 vfs_writev fs/read_write.c:928 [inline] do_pwritev+0x219/0x360 fs/read_write.c:1025 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #0 (&ni->ni_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 ntfs_set_state+0x1fa/0x660 fs/ntfs3/fsntfs.c:925 ntfs_read_ea+0x2a3/0xa00 fs/ntfs3/xattr.c:177 ntfs_get_ea+0x1c2/0x680 fs/ntfs3/xattr.c:271 ntfs_get_wsl_perm+0xd5/0x4c0 fs/ntfs3/xattr.c:1014 ntfs_read_mft fs/ntfs3/inode.c:374 [inline] ntfs_iget5+0x1b00/0x38e0 fs/ntfs3/inode.c:525 dir_search_u+0x2f6/0x390 fs/ntfs3/dir.c:264 ntfs_lookup+0x102/0x1f0 fs/ntfs3/namei.c:83 lookup_open fs/namei.c:3440 [inline] open_last_lookups fs/namei.c:3532 [inline] path_openat+0x111d/0x2f20 fs/namei.c:3739 do_filp_open+0x21c/0x460 fs/namei.c:3769 do_sys_openat2+0x13b/0x4f0 fs/open.c:1253 do_sys_open fs/open.c:1269 [inline] __do_sys_openat fs/open.c:1285 [inline] __se_sys_openat fs/open.c:1280 [inline] __x64_sys_openat+0x243/0x290 fs/open.c:1280 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ni->ni_lock/4); lock(&ni->ni_lock); lock(&ni->ni_lock/4); lock(&ni->ni_lock); *** DEADLOCK *** 3 locks held by syz.4.610/7168: #0: ffff88805f4e8460 (sb_writers#31){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377 #1: ffff8880639c83a0 (&type->i_mutex_dir_key#24){++++}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #1: ffff8880639c83a0 (&type->i_mutex_dir_key#24){++++}-{3:3}, at: open_last_lookups fs/namei.c:3529 [inline] #1: ffff8880639c83a0 (&type->i_mutex_dir_key#24){++++}-{3:3}, at: path_openat+0x824/0x2f20 fs/namei.c:3739 #2: ffff8880639c8100 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1100 [inline] #2: ffff8880639c8100 (&ni->ni_lock/4){+.+.}-{3:3}, at: ntfs_lookup+0xf5/0x1f0 fs/ntfs3/namei.c:82 stack backtrace: CPU: 0 PID: 7168 Comm: syz.4.610 Not tainted 5.15.165-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 ntfs_set_state+0x1fa/0x660 fs/ntfs3/fsntfs.c:925 ntfs_read_ea+0x2a3/0xa00 fs/ntfs3/xattr.c:177 ntfs_get_ea+0x1c2/0x680 fs/ntfs3/xattr.c:271 ntfs_get_wsl_perm+0xd5/0x4c0 fs/ntfs3/xattr.c:1014 ntfs_read_mft fs/ntfs3/inode.c:374 [inline] ntfs_iget5+0x1b00/0x38e0 fs/ntfs3/inode.c:525 dir_search_u+0x2f6/0x390 fs/ntfs3/dir.c:264 ntfs_lookup+0x102/0x1f0 fs/ntfs3/namei.c:83 lookup_open fs/namei.c:3440 [inline] open_last_lookups fs/namei.c:3532 [inline] path_openat+0x111d/0x2f20 fs/namei.c:3739 do_filp_open+0x21c/0x460 fs/namei.c:3769 do_sys_openat2+0x13b/0x4f0 fs/open.c:1253 do_sys_open fs/open.c:1269 [inline] __do_sys_openat fs/open.c:1285 [inline] __se_sys_openat fs/open.c:1280 [inline] __x64_sys_openat+0x243/0x290 fs/open.c:1280 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 RIP: 0033:0x7f43b0468e79 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f43ae8e5038 EFLAGS: 00000246 ORIG_RAX: 0000000000000101 RAX: ffffffffffffffda RBX: 00007f43b0604f80 RCX: 00007f43b0468e79 RDX: 00000000000281c2 RSI: 00000000200000c0 RDI: ffffffffffffff9c RBP: 00007f43b04d693e R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f43b0604f80 R15: 00007fff43f2dce8