vcan0: j1939_xtp_rx_abort_one: 0xffff88802355f800: 0x00000: (3) A timeout occurred and this is the connection abort to close the session. ====================================================== WARNING: possible circular locking dependency detected 5.17.0-rc1-syzkaller #0 Not tainted ------------------------------------------------------ ksoftirqd/1/19 is trying to acquire lock: ffff88801bcb5088 ( &priv->active_session_list_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:354 [inline] &priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_list_lock net/can/j1939/transport.c:238 [inline] &priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_activate+0x4d/0x450 net/can/j1939/transport.c:1553 but task is already holding lock: ffff88807cbdc5c0 (&jsk->sk_session_queue_lock ){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:354 [inline] ){+.-.}-{2:2}, at: j1939_sk_queue_activate_next+0x52/0x390 net/can/j1939/socket.c:204 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&jsk->sk_session_queue_lock){+.-.}-{2:2} : lock_acquire+0x19f/0x4d0 kernel/locking/lockdep.c:5639 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x31/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:354 [inline] j1939_sk_queue_drop_all+0x3f/0x250 net/can/j1939/socket.c:139 j1939_sk_netdev_event_netdown+0xf5/0x160 net/can/j1939/socket.c:1272 j1939_netdev_notify+0x204/0x330 net/can/j1939/main.c:372 notifier_call_chain kernel/notifier.c:84 [inline] raw_notifier_call_chain+0xe7/0x170 kernel/notifier.c:392 __dev_notify_flags+0x306/0x5e0 dev_change_flags+0xe3/0x190 net/core/dev.c:8215 do_setlink+0xce5/0x4170 net/core/rtnetlink.c:2729 __rtnl_newlink net/core/rtnetlink.c:3412 [inline] rtnl_newlink+0x170d/0x1d10 net/core/rtnetlink.c:3527 rtnetlink_rcv_msg+0x96f/0xec0 net/core/rtnetlink.c:5592 netlink_rcv_skb+0x200/0x470 net/netlink/af_netlink.c:2494 netlink_unicast_kernel net/netlink/af_netlink.c:1317 [inline] netlink_unicast+0x81a/0x9f0 net/netlink/af_netlink.c:1343 netlink_sendmsg+0xaec/0xe60 net/netlink/af_netlink.c:1919 sock_sendmsg_nosec net/socket.c:705 [inline] sock_sendmsg net/socket.c:725 [inline] ____sys_sendmsg+0x5b9/0x910 net/socket.c:2413 ___sys_sendmsg net/socket.c:2467 [inline] __sys_sendmsg+0x280/0x370 net/socket.c:2496 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x44/0xd0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae -> #1 ( &priv->j1939_socks_lock){+.-.}-{2:2}: lock_acquire+0x19f/0x4d0 kernel/locking/lockdep.c:5639 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x31/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:354 [inline] j1939_sk_errqueue+0x92/0x160 net/can/j1939/socket.c:1078 __j1939_session_cancel+0x6fc/0xa20 net/can/j1939/transport.c:1124 j1939_tp_rxtimer+0x479/0xa20 net/can/j1939/transport.c:1249 __run_hrtimer kernel/time/hrtimer.c:1685 [inline] __hrtimer_run_queues+0x50b/0xa60 kernel/time/hrtimer.c:1749 hrtimer_run_softirq+0x1b7/0x5d0 kernel/time/hrtimer.c:1766 __do_softirq+0x392/0x7a3 kernel/softirq.c:558 __irq_exit_rcu+0xec/0x170 kernel/softirq.c:637 irq_exit_rcu+0x5/0x20 kernel/softirq.c:649 sysvec_apic_timer_interrupt+0x91/0xb0 arch/x86/kernel/apic/apic.c:1097 asm_sysvec_apic_timer_interrupt+0x12/0x20 native_safe_halt arch/x86/include/asm/irqflags.h:51 [inline] arch_safe_halt arch/x86/include/asm/irqflags.h:89 [inline] acpi_safe_halt drivers/acpi/processor_idle.c:110 [inline] acpi_idle_do_entry drivers/acpi/processor_idle.c:551 [inline] acpi_idle_enter+0x42d/0x790 drivers/acpi/processor_idle.c:687 cpuidle_enter_state+0x507/0xea0 drivers/cpuidle/cpuidle.c:237 cpuidle_enter+0x59/0x90 drivers/cpuidle/cpuidle.c:351 call_cpuidle kernel/sched/idle.c:158 [inline] cpuidle_idle_call kernel/sched/idle.c:239 [inline] do_idle+0x3e8/0x670 kernel/sched/idle.c:306 cpu_startup_entry+0x15/0x20 kernel/sched/idle.c:403 start_kernel+0x4bf/0x56e init/main.c:1138 secondary_startup_64_no_verify+0xc4/0xcb -> #0 (&priv->active_session_list_lock){+.-.}-{2:2}: check_prev_add kernel/locking/lockdep.c:3063 [inline] check_prevs_add kernel/locking/lockdep.c:3186 [inline] validate_chain+0x1dfb/0x8240 kernel/locking/lockdep.c:3801 __lock_acquire+0x1382/0x2b00 kernel/locking/lockdep.c:5027 lock_acquire+0x19f/0x4d0 kernel/locking/lockdep.c:5639 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x31/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:354 [inline] j1939_session_list_lock net/can/j1939/transport.c:238 [inline] j1939_session_activate+0x4d/0x450 net/can/j1939/transport.c:1553 j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:181 [inline] j1939_sk_queue_activate_next+0x292/0x390 net/can/j1939/socket.c:205 j1939_session_deactivate_activate_next net/can/j1939/transport.c:1101 [inline] j1939_xtp_rx_abort_one+0x649/0x7a0 net/can/j1939/transport.c:1340 j1939_xtp_rx_abort net/can/j1939/transport.c:1351 [inline] j1939_tp_cmd_recv net/can/j1939/transport.c:2100 [inline] j1939_tp_recv+0x8a0/0x11d0 net/can/j1939/transport.c:2133 j1939_can_recv+0x67c/0xa90 net/can/j1939/main.c:108 deliver net/can/af_can.c:574 [inline] can_rcv_filter+0x35e/0x800 net/can/af_can.c:608 can_receive+0x2e8/0x410 net/can/af_can.c:665 can_rcv+0xda/0x200 net/can/af_can.c:696 __netif_receive_skb_one_core net/core/dev.c:5351 [inline] __netif_receive_skb+0x1d1/0x500 net/core/dev.c:5465 process_backlog+0x518/0x9a0 net/core/dev.c:5797 __napi_poll+0xbd/0x520 net/core/dev.c:6365 napi_poll net/core/dev.c:6432 [inline] net_rx_action+0x61c/0xf30 net/core/dev.c:6519 __do_softirq+0x392/0x7a3 kernel/softirq.c:558 run_ksoftirqd+0xc1/0x120 kernel/softirq.c:921 smpboot_thread_fn+0x533/0x9d0 kernel/smpboot.c:164 kthread+0x2a3/0x2d0 kernel/kthread.c:377 ret_from_fork+0x1f/0x30 other info that might help us debug this: Chain exists of: &priv->active_session_list_lock --> &priv->j1939_socks_lock --> &jsk->sk_session_queue_lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&jsk->sk_session_queue_lock ); lock( &priv->j1939_socks_lock); lock(&jsk->sk_session_queue_lock); lock(&priv->active_session_list_lock ); *** DEADLOCK *** 3 locks held by ksoftirqd/1/19: #0: ffffffff8cb1d9e0 (rcu_read_lock){....}-{1:2} , at: rcu_lock_acquire+0x9/0x30 include/linux/rcupdate.h:268 #1: ffffffff8cb1d9e0 (rcu_read_lock){....}-{1:2} , at: rcu_lock_acquire+0x5/0x30 include/linux/rcupdate.h:267 #2: ffff88807cbdc5c0 ( &jsk->sk_session_queue_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:354 [inline] &jsk->sk_session_queue_lock){+.-.}-{2:2}, at: j1939_sk_queue_activate_next+0x52/0x390 net/can/j1939/socket.c:204 stack backtrace: CPU: 1 PID: 19 Comm: ksoftirqd/1 Not tainted 5.17.0-rc1-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1dc/0x2d8 lib/dump_stack.c:106 check_noncircular+0x2f9/0x3b0 kernel/locking/lockdep.c:2143 check_prev_add kernel/locking/lockdep.c:3063 [inline] check_prevs_add kernel/locking/lockdep.c:3186 [inline] validate_chain+0x1dfb/0x8240 kernel/locking/lockdep.c:3801 __lock_acquire+0x1382/0x2b00 kernel/locking/lockdep.c:5027 lock_acquire+0x19f/0x4d0 kernel/locking/lockdep.c:5639 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x31/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:354 [inline] j1939_session_list_lock net/can/j1939/transport.c:238 [inline] j1939_session_activate+0x4d/0x450 net/can/j1939/transport.c:1553 j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:181 [inline] j1939_sk_queue_activate_next+0x292/0x390 net/can/j1939/socket.c:205 j1939_session_deactivate_activate_next net/can/j1939/transport.c:1101 [inline] j1939_xtp_rx_abort_one+0x649/0x7a0 net/can/j1939/transport.c:1340 j1939_xtp_rx_abort net/can/j1939/transport.c:1351 [inline] j1939_tp_cmd_recv net/can/j1939/transport.c:2100 [inline] j1939_tp_recv+0x8a0/0x11d0 net/can/j1939/transport.c:2133 j1939_can_recv+0x67c/0xa90 net/can/j1939/main.c:108 deliver net/can/af_can.c:574 [inline] can_rcv_filter+0x35e/0x800 net/can/af_can.c:608 can_receive+0x2e8/0x410 net/can/af_can.c:665 can_rcv+0xda/0x200 net/can/af_can.c:696 __netif_receive_skb_one_core net/core/dev.c:5351 [inline] __netif_receive_skb+0x1d1/0x500 net/core/dev.c:5465 process_backlog+0x518/0x9a0 net/core/dev.c:5797 __napi_poll+0xbd/0x520 net/core/dev.c:6365 napi_poll net/core/dev.c:6432 [inline] net_rx_action+0x61c/0xf30 net/core/dev.c:6519 __do_softirq+0x392/0x7a3 kernel/softirq.c:558 run_ksoftirqd+0xc1/0x120 kernel/softirq.c:921 smpboot_thread_fn+0x533/0x9d0 kernel/smpboot.c:164 kthread+0x2a3/0x2d0 kernel/kthread.c:377 ret_from_fork+0x1f/0x30 vcan0: j1939_xtp_rx_abort_one: 0xffff88806df0e000: 0x00000: (3) A timeout occurred and this is the connection abort to close the session. vcan0: j1939_xtp_rx_abort_one: 0xffff888073d84400: 0x00000: (3) A timeout occurred and this is the connection abort to close the session. vcan0: j1939_tp_rxtimer: 0xffff888078f0a800: abort rx timeout. Force session deactivation vcan0: j1939_tp_rxtimer: 0xffff88807eaa5000: rx timeout, send abort vcan0: j1939_tp_rxtimer: 0xffff88807eaa5000: abort rx timeout. Force session deactivation