====================================================== WARNING: possible circular locking dependency detected 6.1.0-syzkaller-09941-ge2ca6ba6ba01 #0 Not tainted ------------------------------------------------------ syz-executor.3/21811 is trying to acquire lock: ffff8880765de6d8 (&ei->i_data_sem/1){+.+.}-{3:3}, at: swap_inode_boot_loader fs/ext4/ioctl.c:426 [inline] ffff8880765de6d8 (&ei->i_data_sem/1){+.+.}-{3:3}, at: __ext4_ioctl fs/ext4/ioctl.c:1420 [inline] ffff8880765de6d8 (&ei->i_data_sem/1){+.+.}-{3:3}, at: ext4_ioctl+0x4132/0x54f0 fs/ext4/ioctl.c:1610 but task is already holding lock: ffff8880765ddcd0 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_double_down_write_data_sem+0x28/0x40 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&ei->i_data_sem/2){++++}-{3:3}: lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668 down_write+0x9c/0x270 kernel/locking/rwsem.c:1562 ext4_map_blocks+0x971/0x1cc0 fs/ext4/inode.c:644 ext4_getblk+0x1b9/0x770 fs/ext4/inode.c:864 ext4_bread+0x2a/0x170 fs/ext4/inode.c:920 ext4_quota_write+0x225/0x570 fs/ext4/super.c:7105 write_blk fs/quota/quota_tree.c:64 [inline] find_free_dqentry fs/quota/quota_tree.c:312 [inline] do_insert_tree+0xde7/0x1aa0 fs/quota/quota_tree.c:373 do_insert_tree+0x722/0x1aa0 fs/quota/quota_tree.c:375 do_insert_tree+0x722/0x1aa0 fs/quota/quota_tree.c:375 do_insert_tree+0x722/0x1aa0 fs/quota/quota_tree.c:375 dq_insert_tree fs/quota/quota_tree.c:401 [inline] qtree_write_dquot+0x3b6/0x530 fs/quota/quota_tree.c:420 v2_write_dquot+0x11b/0x190 fs/quota/quota_v2.c:358 dquot_acquire+0x348/0x670 fs/quota/dquot.c:444 ext4_acquire_dquot+0x2dc/0x400 fs/ext4/super.c:6740 dqget+0x999/0xdc0 fs/quota/dquot.c:914 __dquot_initialize+0x3d0/0xcf0 fs/quota/dquot.c:1492 ext4_create+0xb0/0x560 fs/ext4/namei.c:2802 lookup_open fs/namei.c:3413 [inline] open_last_lookups fs/namei.c:3481 [inline] path_openat+0x12ac/0x2dd0 fs/namei.c:3711 do_filp_open+0x264/0x4f0 fs/namei.c:3741 do_sys_openat2+0x124/0x4e0 fs/open.c:1310 do_sys_open fs/open.c:1326 [inline] __do_sys_openat fs/open.c:1342 [inline] __se_sys_openat fs/open.c:1337 [inline] __x64_sys_openat+0x243/0x290 fs/open.c:1337 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}: lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668 down_read+0x39/0x50 kernel/locking/rwsem.c:1509 v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:332 dquot_acquire+0x186/0x670 fs/quota/dquot.c:435 ext4_acquire_dquot+0x2dc/0x400 fs/ext4/super.c:6740 dqget+0x999/0xdc0 fs/quota/dquot.c:914 __dquot_initialize+0x291/0xcf0 fs/quota/dquot.c:1492 ext4_mkdir+0x194/0xcf0 fs/ext4/namei.c:2985 vfs_mkdir+0x3b3/0x590 fs/namei.c:4036 do_mkdirat+0x25b/0x530 fs/namei.c:4061 __do_sys_mkdirat fs/namei.c:4076 [inline] __se_sys_mkdirat fs/namei.c:4074 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4074 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (&dquot->dq_lock){+.+.}-{3:3}: lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668 __mutex_lock_common+0x1bd/0x26e0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799 dquot_commit+0x58/0x4e0 fs/quota/dquot.c:479 ext4_write_dquot+0x1ea/0x2b0 fs/ext4/super.c:6724 mark_dquot_dirty fs/quota/dquot.c:346 [inline] mark_all_dquot_dirty fs/quota/dquot.c:384 [inline] __dquot_alloc_space+0xa19/0x1050 fs/quota/dquot.c:1722 dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline] dquot_alloc_space include/linux/quotaops.h:313 [inline] dquot_alloc_block include/linux/quotaops.h:337 [inline] ext4_mb_new_blocks+0x102f/0x3db0 fs/ext4/mballoc.c:5571 ext4_new_meta_blocks+0x175/0x450 fs/ext4/balloc.c:700 ext4_ext_grow_indepth fs/ext4/extents.c:1329 [inline] ext4_ext_create_new_leaf fs/ext4/extents.c:1435 [inline] ext4_ext_insert_extent+0xdef/0x4e40 fs/ext4/extents.c:2102 ext4_split_extent_at+0x84b/0x1400 fs/ext4/extents.c:3253 ext4_force_split_extent_at fs/ext4/extents.c:338 [inline] ext4_swap_extents+0x13e9/0x2350 fs/ext4/extents.c:5715 move_extent_per_page+0x1333/0x2b00 fs/ext4/move_extent.c:372 ext4_move_extents+0x983/0xe70 fs/ext4/move_extent.c:682 __ext4_ioctl fs/ext4/ioctl.c:1354 [inline] ext4_ioctl+0x375a/0x54f0 fs/ext4/ioctl.c:1610 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl+0xfb/0x170 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&ei->i_data_sem/1){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain+0x1898/0x6ae0 kernel/locking/lockdep.c:3831 __lock_acquire+0x1292/0x1f60 kernel/locking/lockdep.c:5055 lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668 down_write_nested+0xa2/0x280 kernel/locking/rwsem.c:1672 swap_inode_boot_loader fs/ext4/ioctl.c:426 [inline] __ext4_ioctl fs/ext4/ioctl.c:1420 [inline] ext4_ioctl+0x4132/0x54f0 fs/ext4/ioctl.c:1610 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl+0xfb/0x170 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &ei->i_data_sem/1 --> &s->s_dquot.dqio_sem --> &ei->i_data_sem/2 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ei->i_data_sem/2); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); lock(&ei->i_data_sem/1); *** DEADLOCK *** 6 locks held by syz-executor.3/21811: #0: ffff88807f944460 (sb_writers#4){.+.+}-{0:0}, at: mnt_want_write_file+0x5a/0x1f0 fs/namespace.c:552 #1: ffff8880765dde48 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: inode_lock include/linux/fs.h:756 [inline] #1: ffff8880765dde48 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: lock_two_nondirectories+0xdd/0x130 fs/inode.c:1121 #2: ffff8880765de850 (&sb->s_type->i_mutex_key#8/4){+.+.}-{3:3}, at: swap_inode_boot_loader fs/ext4/ioctl.c:385 [inline] #2: ffff8880765de850 (&sb->s_type->i_mutex_key#8/4){+.+.}-{3:3}, at: __ext4_ioctl fs/ext4/ioctl.c:1420 [inline] #2: ffff8880765de850 (&sb->s_type->i_mutex_key#8/4){+.+.}-{3:3}, at: ext4_ioctl+0x23b5/0x54f0 fs/ext4/ioctl.c:1610 #3: ffff8880765ddfe8 (mapping.invalidate_lock){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:801 [inline] #3: ffff8880765ddfe8 (mapping.invalidate_lock){++++}-{3:3}, at: swap_inode_boot_loader fs/ext4/ioctl.c:402 [inline] #3: ffff8880765ddfe8 (mapping.invalidate_lock){++++}-{3:3}, at: __ext4_ioctl fs/ext4/ioctl.c:1420 [inline] #3: ffff8880765ddfe8 (mapping.invalidate_lock){++++}-{3:3}, at: ext4_ioctl+0x3e1d/0x54f0 fs/ext4/ioctl.c:1610 #4: ffff88807f948990 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x13f9/0x1670 fs/jbd2/transaction.c:461 #5: ffff8880765ddcd0 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_double_down_write_data_sem+0x28/0x40 stack backtrace: CPU: 1 PID: 21811 Comm: syz-executor.3 Not tainted 6.1.0-syzkaller-09941-ge2ca6ba6ba01 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1b1/0x28e lib/dump_stack.c:106 check_noncircular+0x2cc/0x390 kernel/locking/lockdep.c:2177 check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain+0x1898/0x6ae0 kernel/locking/lockdep.c:3831 __lock_acquire+0x1292/0x1f60 kernel/locking/lockdep.c:5055 lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668 down_write_nested+0xa2/0x280 kernel/locking/rwsem.c:1672 swap_inode_boot_loader fs/ext4/ioctl.c:426 [inline] __ext4_ioctl fs/ext4/ioctl.c:1420 [inline] ext4_ioctl+0x4132/0x54f0 fs/ext4/ioctl.c:1610 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl+0xfb/0x170 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f0fa728c0d9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f0fa7fad168 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007f0fa73ac120 RCX: 00007f0fa728c0d9 RDX: 0000000000000000 RSI: 0000000000006611 RDI: 0000000000000004 RBP: 00007f0fa72e7ae9 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffea43479bf R14: 00007f0fa7fad300 R15: 0000000000022000