====================================================== WARNING: possible circular locking dependency detected 6.12.0-next-20241119-syzkaller #0 Not tainted ------------------------------------------------------ syz.5.2669/19818 is trying to acquire lock: ffff88805bd94950 (&sb->s_type->i_mutex_key#8/1){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:818 [inline] ffff88805bd94950 (&sb->s_type->i_mutex_key#8/1){+.+.}-{4:4}, at: ext4_xattr_inode_create fs/ext4/xattr.c:1514 [inline] ffff88805bd94950 (&sb->s_type->i_mutex_key#8/1){+.+.}-{4:4}, at: ext4_xattr_inode_lookup_create+0x1af1/0x2030 fs/ext4/xattr.c:1596 but task is already holding lock: ffff8880789ab410 (&ei->i_data_sem/3){++++}-{4:4}, at: ext4_setattr+0x16e1/0x1da0 fs/ext4/inode.c:5504 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ei->i_data_sem/3){++++}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 ext4_update_i_disksize fs/ext4/ext4.h:3394 [inline] ext4_xattr_inode_write fs/ext4/xattr.c:1452 [inline] ext4_xattr_inode_lookup_create+0x1798/0x2030 fs/ext4/xattr.c:1602 ext4_xattr_ibody_set+0x214/0x730 fs/ext4/xattr.c:2269 ext4_xattr_set_handle+0xba6/0x1580 fs/ext4/xattr.c:2446 ext4_xattr_set+0x280/0x3e0 fs/ext4/xattr.c:2560 __vfs_setxattr+0x468/0x4a0 fs/xattr.c:200 __vfs_setxattr_noperm+0x12e/0x660 fs/xattr.c:234 vfs_setxattr+0x221/0x430 fs/xattr.c:321 do_setxattr fs/xattr.c:636 [inline] filename_setxattr+0x2af/0x430 fs/xattr.c:665 path_setxattrat+0x440/0x510 fs/xattr.c:713 __do_sys_setxattr fs/xattr.c:747 [inline] __se_sys_setxattr fs/xattr.c:743 [inline] __x64_sys_setxattr+0xbc/0xe0 fs/xattr.c:743 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&sb->s_type->i_mutex_key#8/1){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:818 [inline] ext4_xattr_inode_create fs/ext4/xattr.c:1514 [inline] ext4_xattr_inode_lookup_create+0x1af1/0x2030 fs/ext4/xattr.c:1596 ext4_xattr_block_set+0x274/0x3980 fs/ext4/xattr.c:1916 ext4_xattr_move_to_block fs/ext4/xattr.c:2670 [inline] ext4_xattr_make_inode_space fs/ext4/xattr.c:2745 [inline] ext4_expand_extra_isize_ea+0x12d7/0x1cf0 fs/ext4/xattr.c:2837 __ext4_expand_extra_isize+0x2fb/0x3e0 fs/ext4/inode.c:5888 ext4_try_to_expand_extra_isize fs/ext4/inode.c:5931 [inline] __ext4_mark_inode_dirty+0x524/0x880 fs/ext4/inode.c:6009 ext4_setattr+0x1780/0x1da0 fs/ext4/inode.c:5507 notify_change+0xbca/0xe90 fs/attr.c:552 do_truncate+0x220/0x310 fs/open.c:65 vfs_truncate+0x2e1/0x3b0 fs/open.c:111 do_sys_truncate+0xdb/0x190 fs/open.c:134 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ei->i_data_sem/3); lock(&sb->s_type->i_mutex_key#8/1); lock(&ei->i_data_sem/3); lock(&sb->s_type->i_mutex_key#8/1); *** DEADLOCK *** 5 locks held by syz.5.2669/19818: #0: ffff888027238420 (sb_writers#4){.+.+}-{0:0}, at: mnt_want_write+0x3f/0x90 fs/namespace.c:515 #1: ffff8880789ab580 (&sb->s_type->i_mutex_key#8){++++}-{4:4}, at: inode_lock include/linux/fs.h:818 [inline] #1: ffff8880789ab580 (&sb->s_type->i_mutex_key#8){++++}-{4:4}, at: do_truncate+0x20c/0x310 fs/open.c:63 #2: ffff8880789ab720 (mapping.invalidate_lock){++++}-{4:4}, at: filemap_invalidate_lock include/linux/fs.h:863 [inline] #2: ffff8880789ab720 (mapping.invalidate_lock){++++}-{4:4}, at: ext4_setattr+0xf94/0x1da0 fs/ext4/inode.c:5452 #3: ffff8880789ab410 (&ei->i_data_sem/3){++++}-{4:4}, at: ext4_setattr+0x16e1/0x1da0 fs/ext4/inode.c:5504 #4: ffff8880789ab250 (&ei->xattr_sem){++++}-{4:4}, at: ext4_write_trylock_xattr fs/ext4/xattr.h:161 [inline] #4: ffff8880789ab250 (&ei->xattr_sem){++++}-{4:4}, at: ext4_try_to_expand_extra_isize fs/ext4/inode.c:5928 [inline] #4: ffff8880789ab250 (&ei->xattr_sem){++++}-{4:4}, at: __ext4_mark_inode_dirty+0x491/0x880 fs/ext4/inode.c:6009 stack backtrace: CPU: 1 UID: 0 PID: 19818 Comm: syz.5.2669 Not tainted 6.12.0-next-20241119-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2074 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2206 check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:818 [inline] ext4_xattr_inode_create fs/ext4/xattr.c:1514 [inline] ext4_xattr_inode_lookup_create+0x1af1/0x2030 fs/ext4/xattr.c:1596 ext4_xattr_block_set+0x274/0x3980 fs/ext4/xattr.c:1916 ext4_xattr_move_to_block fs/ext4/xattr.c:2670 [inline] ext4_xattr_make_inode_space fs/ext4/xattr.c:2745 [inline] ext4_expand_extra_isize_ea+0x12d7/0x1cf0 fs/ext4/xattr.c:2837 __ext4_expand_extra_isize+0x2fb/0x3e0 fs/ext4/inode.c:5888 ext4_try_to_expand_extra_isize fs/ext4/inode.c:5931 [inline] __ext4_mark_inode_dirty+0x524/0x880 fs/ext4/inode.c:6009 ext4_setattr+0x1780/0x1da0 fs/ext4/inode.c:5507 notify_change+0xbca/0xe90 fs/attr.c:552 do_truncate+0x220/0x310 fs/open.c:65 vfs_truncate+0x2e1/0x3b0 fs/open.c:111 do_sys_truncate+0xdb/0x190 fs/open.c:134 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fb9beb7e759 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fb9bf97f038 EFLAGS: 00000246 ORIG_RAX: 000000000000004c RAX: ffffffffffffffda RBX: 00007fb9bed36058 RCX: 00007fb9beb7e759 RDX: 0000000000000000 RSI: 000000000000003b RDI: 0000000020000180 RBP: 00007fb9bebf175e R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000001 R14: 00007fb9bed36058 R15: 00007fffa19b18c8 EXT4-fs error (device loop5): ext4_xattr_inode_iget:440: comm syz.5.2669: inode #1073372648: comm syz.5.2669: iget: illegal inode # EXT4-fs error (device loop5): ext4_xattr_inode_iget:445: comm syz.5.2669: error while reading EA inode 1073372648 err=-117