====================================================== WARNING: possible circular locking dependency detected 5.15.131-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.1/23233 is trying to acquire lock: ffff888076970c70 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x3a6/0x1e00 fs/ext4/inode.c:568 but task is already holding lock: ffff88808a780208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x9b/0x190 fs/quota/quota_v2.c:354 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1488 v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:332 dquot_acquire+0x188/0x680 fs/quota/dquot.c:435 ext4_acquire_dquot+0x2e6/0x400 fs/ext4/super.c:6180 dqget+0x98b/0xdb0 fs/quota/dquot.c:914 __dquot_initialize+0x2d9/0xe10 fs/quota/dquot.c:1492 ext4_process_orphan+0x57/0x2d0 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0x9d9/0x1240 fs/ext4/orphan.c:474 ext4_fill_super+0x98de/0xa110 fs/ext4/super.c:4966 mount_bdev+0x2c9/0x3f0 fs/super.c:1387 legacy_get_tree+0xeb/0x180 fs/fs_context.c:611 vfs_get_tree+0x88/0x270 fs/super.c:1517 do_new_mount+0x28b/0xae0 fs/namespace.c:2994 do_mount fs/namespace.c:3337 [inline] __do_sys_mount fs/namespace.c:3545 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3522 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb -> #1 (&dquot->dq_lock){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 dquot_commit+0x57/0x510 fs/quota/dquot.c:479 ext4_write_dquot+0x1e8/0x2b0 fs/ext4/super.c:6164 mark_dquot_dirty fs/quota/dquot.c:346 [inline] mark_all_dquot_dirty fs/quota/dquot.c:384 [inline] __dquot_alloc_space+0x53a/0xf30 fs/quota/dquot.c:1722 dquot_alloc_space_nodirty include/linux/quotaops.h:297 [inline] dquot_alloc_space include/linux/quotaops.h:310 [inline] dquot_alloc_block include/linux/quotaops.h:334 [inline] ext4_mb_new_blocks+0x12bb/0x4d50 fs/ext4/mballoc.c:5645 ext4_ext_map_blocks+0x1986/0x7220 fs/ext4/extents.c:4287 ext4_map_blocks+0xaad/0x1e00 fs/ext4/inode.c:645 ext4_getblk+0x19f/0x710 fs/ext4/inode.c:846 ext4_bread+0x2a/0x170 fs/ext4/inode.c:899 ext4_append+0x31f/0x5c0 fs/ext4/namei.c:83 ext4_init_new_dir+0x33a/0xa20 fs/ext4/namei.c:2976 ext4_mkdir+0x4f2/0xce0 fs/ext4/namei.c:3022 vfs_mkdir+0x419/0x640 fs/namei.c:3994 do_mkdirat+0x260/0x520 fs/namei.c:4019 __do_sys_mkdirat fs/namei.c:4034 [inline] __se_sys_mkdirat fs/namei.c:4032 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4032 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb -> #0 (&ei->i_data_sem/2){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1488 ext4_map_blocks+0x3a6/0x1e00 fs/ext4/inode.c:568 ext4_getblk+0x19f/0x710 fs/ext4/inode.c:846 ext4_bread+0x2a/0x170 fs/ext4/inode.c:899 ext4_quota_write+0x21e/0x580 fs/ext4/super.c:6546 write_blk fs/quota/quota_tree.c:64 [inline] get_free_dqblk+0x3a9/0x800 fs/quota/quota_tree.c:125 do_insert_tree+0x2b4/0x1c20 fs/quota/quota_tree.c:335 do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366 do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366 do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366 dq_insert_tree fs/quota/quota_tree.c:392 [inline] qtree_write_dquot+0x3b9/0x530 fs/quota/quota_tree.c:411 v2_write_dquot+0x11c/0x190 fs/quota/quota_v2.c:358 dquot_acquire+0x34d/0x680 fs/quota/dquot.c:444 ext4_acquire_dquot+0x2e6/0x400 fs/ext4/super.c:6180 dqget+0x98b/0xdb0 fs/quota/dquot.c:914 __dquot_initialize+0x2d9/0xe10 fs/quota/dquot.c:1492 ext4_process_orphan+0x57/0x2d0 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0x9d9/0x1240 fs/ext4/orphan.c:474 ext4_fill_super+0x98de/0xa110 fs/ext4/super.c:4966 mount_bdev+0x2c9/0x3f0 fs/super.c:1387 legacy_get_tree+0xeb/0x180 fs/fs_context.c:611 vfs_get_tree+0x88/0x270 fs/super.c:1517 do_new_mount+0x28b/0xae0 fs/namespace.c:2994 do_mount fs/namespace.c:3337 [inline] __do_sys_mount fs/namespace.c:3545 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3522 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb other info that might help us debug this: Chain exists of: &ei->i_data_sem/2 --> &dquot->dq_lock --> &s->s_dquot.dqio_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&s->s_dquot.dqio_sem); lock(&dquot->dq_lock); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); *** DEADLOCK *** 3 locks held by syz-executor.1/23233: #0: ffff88808a7800e0 (&type->s_umount_key#28/1){+.+.}-{3:3}, at: alloc_super+0x210/0x940 fs/super.c:229 #1: ffff8880304a6b28 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_acquire+0x64/0x680 fs/quota/dquot.c:432 #2: ffff88808a780208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x9b/0x190 fs/quota/quota_v2.c:354 stack backtrace: CPU: 1 PID: 23233 Comm: syz-executor.1 Not tainted 5.15.131-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/26/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1488 ext4_map_blocks+0x3a6/0x1e00 fs/ext4/inode.c:568 ext4_getblk+0x19f/0x710 fs/ext4/inode.c:846 ext4_bread+0x2a/0x170 fs/ext4/inode.c:899 ext4_quota_write+0x21e/0x580 fs/ext4/super.c:6546 write_blk fs/quota/quota_tree.c:64 [inline] get_free_dqblk+0x3a9/0x800 fs/quota/quota_tree.c:125 do_insert_tree+0x2b4/0x1c20 fs/quota/quota_tree.c:335 do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366 do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366 do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366 dq_insert_tree fs/quota/quota_tree.c:392 [inline] qtree_write_dquot+0x3b9/0x530 fs/quota/quota_tree.c:411 v2_write_dquot+0x11c/0x190 fs/quota/quota_v2.c:358 dquot_acquire+0x34d/0x680 fs/quota/dquot.c:444 ext4_acquire_dquot+0x2e6/0x400 fs/ext4/super.c:6180 dqget+0x98b/0xdb0 fs/quota/dquot.c:914 __dquot_initialize+0x2d9/0xe10 fs/quota/dquot.c:1492 ext4_process_orphan+0x57/0x2d0 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0x9d9/0x1240 fs/ext4/orphan.c:474 ext4_fill_super+0x98de/0xa110 fs/ext4/super.c:4966 mount_bdev+0x2c9/0x3f0 fs/super.c:1387 legacy_get_tree+0xeb/0x180 fs/fs_context.c:611 vfs_get_tree+0x88/0x270 fs/super.c:1517 do_new_mount+0x28b/0xae0 fs/namespace.c:2994 do_mount fs/namespace.c:3337 [inline] __do_sys_mount fs/namespace.c:3545 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3522 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb RIP: 0033:0x7f9eb93361ea Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 de 09 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f9eb78b5ee8 EFLAGS: 00000202 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00007f9eb78b5f80 RCX: 00007f9eb93361ea RDX: 0000000020000040 RSI: 0000000020000500 RDI: 00007f9eb78b5f40 RBP: 0000000020000040 R08: 00007f9eb78b5f80 R09: 0000000002000000 R10: 0000000002000000 R11: 0000000000000202 R12: 0000000020000500 R13: 00007f9eb78b5f40 R14: 00000000000004c6 R15: 0000000020000240 EXT4-fs error (device loop1): ext4_do_update_inode:5160: inode #3: comm syz-executor.1: corrupted inode contents EXT4-fs error (device loop1): ext4_dirty_inode:5993: inode #3: comm syz-executor.1: mark_inode_dirty error EXT4-fs error (device loop1): ext4_validate_block_bitmap:438: comm syz-executor.1: bg 0: block 64: padding at end of block bitmap is not set Quota error (device loop1): write_blk: dquota write failed Quota error (device loop1): qtree_write_dquot: Error -117 occurred while creating quota Quota error (device loop1): write_blk: dquota write failed Quota error (device loop1): qtree_write_dquot: Error -28 occurred while creating quota Quota error (device loop1): write_blk: dquota write failed Quota error (device loop1): qtree_write_dquot: Error -28 occurred while creating quota EXT4-fs (loop1): 1 orphan inode deleted EXT4-fs (loop1): mounted filesystem without journal. Opts: ,errors=continue. Quota mode: writeback. ext4 filesystem being mounted at /root/syzkaller-testdir1689685979/syzkaller.In3HV0/992/file1 supports timestamps until 2038 (0x7fffffff) Quota error (device loop1): write_blk: dquota write failed Quota error (device loop1): qtree_write_dquot: Error -28 occurred while creating quota