====================================================== WARNING: possible circular locking dependency detected 6.16.0-rc3-syzkaller #0 Not tainted ------------------------------------------------------ syz.5.453/10184 is trying to acquire lock: ffff888059983480 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline] ffff888059983480 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: ocfs2_del_inode_from_orphan+0x134/0x740 fs/ocfs2/namei.c:2727 but task is already holding lock: ffff8880599c6a20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_dio_end_io_write fs/ocfs2/aops.c:2295 [inline] ffff8880599c6a20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_dio_end_io+0x389/0x10f0 fs/ocfs2/aops.c:2401 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}: lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871 down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577 ocfs2_create_local_dquot+0x19d/0x1a40 fs/ocfs2/quota_local.c:1227 ocfs2_acquire_dquot+0x80f/0xb30 fs/ocfs2/quota_global.c:883 dqget+0x7b1/0xf10 fs/quota/dquot.c:977 dquot_get_next_dqblk+0xb2/0x150 fs/quota/dquot.c:2705 quota_getnextquota+0x2b9/0x4a0 fs/quota/quota.c:250 __do_sys_quotactl fs/quota/quota.c:961 [inline] __se_sys_quotactl+0x279/0x950 fs/quota/quota.c:917 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (&dquot->dq_lock){+.+.}-{4:4}: lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871 __mutex_lock_common kernel/locking/mutex.c:602 [inline] __mutex_lock+0x182/0xe80 kernel/locking/mutex.c:747 wait_on_dquot fs/quota/dquot.c:354 [inline] dqget+0x72a/0xf10 fs/quota/dquot.c:972 __dquot_initialize+0x3b3/0xcb0 fs/quota/dquot.c:1505 ocfs2_get_init_inode+0x13b/0x1b0 fs/ocfs2/namei.c:202 ocfs2_mknod+0x863/0x2050 fs/ocfs2/namei.c:310 ocfs2_mkdir+0x191/0x440 fs/ocfs2/namei.c:656 vfs_mkdir+0x303/0x510 fs/namei.c:4375 do_mkdirat+0x247/0x590 fs/namei.c:4408 __do_sys_mkdirat fs/namei.c:4425 [inline] __se_sys_mkdirat fs/namei.c:4423 [inline] __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:4423 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}: lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871 down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:869 [inline] ocfs2_remove_inode fs/ocfs2/inode.c:669 [inline] ocfs2_wipe_inode fs/ocfs2/inode.c:832 [inline] ocfs2_delete_inode fs/ocfs2/inode.c:1093 [inline] ocfs2_evict_inode+0x153d/0x40e0 fs/ocfs2/inode.c:1230 evict+0x501/0x9c0 fs/inode.c:810 d_delete_notify include/linux/fsnotify.h:402 [inline] vfs_rmdir+0x3ec/0x520 fs/namei.c:4483 do_rmdir+0x2ac/0x630 fs/namei.c:4525 __do_sys_unlinkat fs/namei.c:4699 [inline] __se_sys_unlinkat fs/namei.c:4693 [inline] __x64_sys_unlinkat+0xc2/0xf0 fs/namei.c:4693 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3168 [inline] check_prevs_add kernel/locking/lockdep.c:3287 [inline] validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3911 __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5240 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871 down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:869 [inline] ocfs2_del_inode_from_orphan+0x134/0x740 fs/ocfs2/namei.c:2727 ocfs2_dio_end_io_write fs/ocfs2/aops.c:2303 [inline] ocfs2_dio_end_io+0x479/0x10f0 fs/ocfs2/aops.c:2401 dio_complete+0x258/0x790 fs/direct-io.c:281 __blockdev_direct_IO+0x2db6/0x33d0 fs/direct-io.c:1303 ocfs2_direct_IO+0x25f/0x2d0 fs/ocfs2/aops.c:2438 generic_file_direct_write+0x1d8/0x3e0 mm/filemap.c:4046 __generic_file_write_iter+0x11d/0x230 mm/filemap.c:4215 ocfs2_file_write_iter+0x157a/0x1d10 fs/ocfs2/file.c:2469 iter_file_splice_write+0x937/0x1000 fs/splice.c:738 do_splice_from fs/splice.c:935 [inline] direct_splice_actor+0xfe/0x160 fs/splice.c:1158 splice_direct_to_actor+0x5a8/0xcc0 fs/splice.c:1102 do_splice_direct_actor fs/splice.c:1201 [inline] do_splice_direct+0x181/0x270 fs/splice.c:1227 do_sendfile+0x4da/0x7e0 fs/read_write.c:1370 __do_sys_sendfile64 fs/read_write.c:1431 [inline] __se_sys_sendfile64+0x13e/0x190 fs/read_write.c:1417 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &ocfs2_sysfile_lock_key[args->fi_sysfile_type] --> &dquot->dq_lock --> &ocfs2_quota_ip_alloc_sem_key Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_quota_ip_alloc_sem_key); lock(&dquot->dq_lock); lock(&ocfs2_quota_ip_alloc_sem_key); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]); *** DEADLOCK *** 3 locks held by syz.5.453/10184: #0: ffff888029b78428 (sb_writers#13){.+.+}-{0:0}, at: direct_splice_actor+0x49/0x160 fs/splice.c:1157 #1: ffff8880599c6d80 (&sb->s_type->i_mutex_key#28){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline] #1: ffff8880599c6d80 (&sb->s_type->i_mutex_key#28){+.+.}-{4:4}, at: ocfs2_file_write_iter+0x429/0x1d10 fs/ocfs2/file.c:2399 #2: ffff8880599c6a20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_dio_end_io_write fs/ocfs2/aops.c:2295 [inline] #2: ffff8880599c6a20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_dio_end_io+0x389/0x10f0 fs/ocfs2/aops.c:2401 stack backtrace: CPU: 0 UID: 0 PID: 10184 Comm: syz.5.453 Not tainted 6.16.0-rc3-syzkaller #0 PREEMPT(full) Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025 Call Trace: dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120 print_circular_bug+0x2ee/0x310 kernel/locking/lockdep.c:2046 check_noncircular+0x134/0x160 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3168 [inline] check_prevs_add kernel/locking/lockdep.c:3287 [inline] validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3911 __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5240 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871 down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:869 [inline] ocfs2_del_inode_from_orphan+0x134/0x740 fs/ocfs2/namei.c:2727 ocfs2_dio_end_io_write fs/ocfs2/aops.c:2303 [inline] ocfs2_dio_end_io+0x479/0x10f0 fs/ocfs2/aops.c:2401 dio_complete+0x258/0x790 fs/direct-io.c:281 __blockdev_direct_IO+0x2db6/0x33d0 fs/direct-io.c:1303 ocfs2_direct_IO+0x25f/0x2d0 fs/ocfs2/aops.c:2438 generic_file_direct_write+0x1d8/0x3e0 mm/filemap.c:4046 __generic_file_write_iter+0x11d/0x230 mm/filemap.c:4215 ocfs2_file_write_iter+0x157a/0x1d10 fs/ocfs2/file.c:2469 iter_file_splice_write+0x937/0x1000 fs/splice.c:738 do_splice_from fs/splice.c:935 [inline] direct_splice_actor+0xfe/0x160 fs/splice.c:1158 splice_direct_to_actor+0x5a8/0xcc0 fs/splice.c:1102 do_splice_direct_actor fs/splice.c:1201 [inline] do_splice_direct+0x181/0x270 fs/splice.c:1227 do_sendfile+0x4da/0x7e0 fs/read_write.c:1370 __do_sys_sendfile64 fs/read_write.c:1431 [inline] __se_sys_sendfile64+0x13e/0x190 fs/read_write.c:1417 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f1b0e98e929 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f1b0f736038 EFLAGS: 00000246 ORIG_RAX: 0000000000000028 RAX: ffffffffffffffda RBX: 00007f1b0ebb5fa0 RCX: 00007f1b0e98e929 RDX: 0000000000000000 RSI: 0000000000000006 RDI: 0000000000000005 RBP: 00007f1b0ea10b39 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000020fffe82 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f1b0ebb5fa0 R15: 00007ffe1145efd8