====================================================== WARNING: possible circular locking dependency detected 6.9.0-rc7-syzkaller-00012-gdccb07f2914c #0 Not tainted ------------------------------------------------------ syz-executor.4/17651 is trying to acquire lock: ffff88801d293120 (&mm->mmap_lock){++++}-{3:3}, at: mmap_read_lock_killable+0x1d/0x70 include/linux/mmap_lock.h:155 but task is already holding lock: ffff888066f420b0 (&tree->tree_lock #2){+.+.}-{3:3}, at: hfsplus_find_init+0x14a/0x1c0 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&tree->tree_lock #2){+.+.}-{3:3}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 hfsplus_file_truncate+0x811/0xb50 fs/hfsplus/extents.c:595 hfsplus_setattr+0x1ce/0x280 fs/hfsplus/inode.c:265 notify_change+0xb9d/0xe70 fs/attr.c:497 do_truncate fs/open.c:65 [inline] do_ftruncate+0x46b/0x590 fs/open.c:181 do_sys_ftruncate fs/open.c:199 [inline] __do_sys_ftruncate fs/open.c:207 [inline] __se_sys_ftruncate fs/open.c:205 [inline] __x64_sys_ftruncate+0x95/0xf0 fs/open.c:205 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (&hip->extents_lock){+.+.}-{3:3}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 hfsplus_get_block+0x383/0x14f0 fs/hfsplus/extents.c:260 block_read_full_folio+0x42e/0xe10 fs/buffer.c:2384 read_pages+0x5f9/0x840 mm/readahead.c:180 page_cache_ra_unbounded+0x67f/0x7a0 mm/readahead.c:269 do_sync_mmap_readahead+0x444/0x850 filemap_fault+0x7e5/0x16a0 mm/filemap.c:3289 __do_fault+0x135/0x460 mm/memory.c:4531 do_read_fault mm/memory.c:4894 [inline] do_fault mm/memory.c:5024 [inline] do_pte_missing mm/memory.c:3880 [inline] handle_pte_fault mm/memory.c:5300 [inline] __handle_mm_fault+0x45fe/0x7250 mm/memory.c:5441 handle_mm_fault+0x27f/0x770 mm/memory.c:5606 do_user_addr_fault arch/x86/mm/fault.c:1382 [inline] handle_page_fault arch/x86/mm/fault.c:1474 [inline] exc_page_fault+0x2a8/0x8a0 arch/x86/mm/fault.c:1532 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623 fault_in_readable+0x165/0x2b0 fault_in_iov_iter_readable+0x229/0x280 lib/iov_iter.c:94 generic_perform_write+0x220/0x640 mm/filemap.c:3964 generic_file_write_iter+0xaf/0x310 mm/filemap.c:4095 call_write_iter include/linux/fs.h:2110 [inline] new_sync_write fs/read_write.c:497 [inline] vfs_write+0xa84/0xcb0 fs/read_write.c:590 ksys_write+0x1a0/0x2c0 fs/read_write.c:643 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (mapping.invalidate_lock#15){.+.+}-{3:3}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1526 filemap_invalidate_lock_shared include/linux/fs.h:850 [inline] filemap_fault+0x646/0x16a0 mm/filemap.c:3277 __do_fault+0x135/0x460 mm/memory.c:4531 do_read_fault mm/memory.c:4894 [inline] do_fault mm/memory.c:5024 [inline] do_pte_missing mm/memory.c:3880 [inline] handle_pte_fault mm/memory.c:5300 [inline] __handle_mm_fault+0x45fe/0x7250 mm/memory.c:5441 handle_mm_fault+0x27f/0x770 mm/memory.c:5606 do_user_addr_fault arch/x86/mm/fault.c:1382 [inline] handle_page_fault arch/x86/mm/fault.c:1474 [inline] exc_page_fault+0x2a8/0x8a0 arch/x86/mm/fault.c:1532 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623 strncpy_from_user+0x110/0x2f0 lib/strncpy_from_user.c:139 getname_flags+0xfa/0x4f0 fs/namei.c:150 do_sys_openat2+0xd2/0x1d0 fs/open.c:1400 do_sys_open fs/open.c:1421 [inline] __do_sys_openat fs/open.c:1437 [inline] __se_sys_openat fs/open.c:1432 [inline] __x64_sys_openat+0x247/0x2a0 fs/open.c:1432 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&mm->mmap_lock){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18cb/0x58e0 kernel/locking/lockdep.c:3869 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 down_read_killable+0xca/0xd30 kernel/locking/rwsem.c:1549 mmap_read_lock_killable+0x1d/0x70 include/linux/mmap_lock.h:155 get_mmap_lock_carefully mm/memory.c:5642 [inline] lock_mm_and_find_vma+0x29c/0x2f0 mm/memory.c:5693 do_user_addr_fault arch/x86/mm/fault.c:1354 [inline] handle_page_fault arch/x86/mm/fault.c:1474 [inline] exc_page_fault+0x1a9/0x8a0 arch/x86/mm/fault.c:1532 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623 filldir64+0x2a6/0x6a0 fs/readdir.c:371 dir_emit_dot include/linux/fs.h:3574 [inline] hfsplus_readdir+0x499/0x1320 fs/hfsplus/dir.c:159 iterate_dir+0x539/0x6f0 fs/readdir.c:110 __do_sys_getdents64 fs/readdir.c:409 [inline] __se_sys_getdents64+0x20d/0x4f0 fs/readdir.c:394 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &mm->mmap_lock --> &hip->extents_lock --> &tree->tree_lock#2 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&tree->tree_lock#2); lock(&hip->extents_lock); lock(&tree->tree_lock#2); rlock(&mm->mmap_lock); *** DEADLOCK *** 3 locks held by syz-executor.4/17651: #0: ffff88806872d9c8 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x259/0x320 fs/file.c:1191 #1: ffff8880602909c0 (&type->i_mutex_dir_key#24){++++}-{3:3}, at: iterate_dir+0x436/0x6f0 fs/readdir.c:103 #2: ffff888066f420b0 (&tree->tree_lock#2){+.+.}-{3:3}, at: hfsplus_find_init+0x14a/0x1c0 stack backtrace: CPU: 1 PID: 17651 Comm: syz-executor.4 Not tainted 6.9.0-rc7-syzkaller-00012-gdccb07f2914c #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18cb/0x58e0 kernel/locking/lockdep.c:3869 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 down_read_killable+0xca/0xd30 kernel/locking/rwsem.c:1549 mmap_read_lock_killable+0x1d/0x70 include/linux/mmap_lock.h:155 get_mmap_lock_carefully mm/memory.c:5642 [inline] lock_mm_and_find_vma+0x29c/0x2f0 mm/memory.c:5693 do_user_addr_fault arch/x86/mm/fault.c:1354 [inline] handle_page_fault arch/x86/mm/fault.c:1474 [inline] exc_page_fault+0x1a9/0x8a0 arch/x86/mm/fault.c:1532 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623 RIP: 0010:filldir64+0x2a6/0x6a0 fs/readdir.c:375 Code: 87 ff 4c 89 f7 48 89 de e8 87 db 87 ff 49 01 df 0f 88 5a 02 00 00 49 39 df 0f 82 51 02 00 00 0f 01 cb 0f ae e8 48 8b 44 24 60 <48> 89 43 08 48 8b 4c 24 10 48 8b 44 24 58 48 89 01 48 8b 44 24 18 RSP: 0018:ffffc90009bcf880 EFLAGS: 00050206 RAX: 0000000000000000 RBX: 0000000020001900 RCX: ffff888023955a00 RDX: 0000000000000000 RSI: 0000000020001900 RDI: 0000000020001918 RBP: 0000000000000000 R08: ffffffff820e2e69 R09: 0000000000000004 R10: 0000000000000002 R11: ffffffff820e2be0 R12: ffffffff8be130a0 R13: 0000000000000001 R14: 0000000020001918 R15: 0000000020001918 dir_emit_dot include/linux/fs.h:3574 [inline] hfsplus_readdir+0x499/0x1320 fs/hfsplus/dir.c:159 iterate_dir+0x539/0x6f0 fs/readdir.c:110 __do_sys_getdents64 fs/readdir.c:409 [inline] __se_sys_getdents64+0x20d/0x4f0 fs/readdir.c:394 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fefc187dd69 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fefc25d00c8 EFLAGS: 00000246 ORIG_RAX: 00000000000000d9 RAX: ffffffffffffffda RBX: 00007fefc19abf80 RCX: 00007fefc187dd69 RDX: 0000000000000ff9 RSI: 0000000020001900 RDI: 0000000000000004 RBP: 00007fefc18ca49e R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007fefc19abf80 R15: 00007ffda5fc27b8 ---------------- Code disassembly (best guess): 0: 87 ff xchg %edi,%edi 2: 4c 89 f7 mov %r14,%rdi 5: 48 89 de mov %rbx,%rsi 8: e8 87 db 87 ff call 0xff87db94 d: 49 01 df add %rbx,%r15 10: 0f 88 5a 02 00 00 js 0x270 16: 49 39 df cmp %rbx,%r15 19: 0f 82 51 02 00 00 jb 0x270 1f: 0f 01 cb stac 22: 0f ae e8 lfence 25: 48 8b 44 24 60 mov 0x60(%rsp),%rax * 2a: 48 89 43 08 mov %rax,0x8(%rbx) <-- trapping instruction 2e: 48 8b 4c 24 10 mov 0x10(%rsp),%rcx 33: 48 8b 44 24 58 mov 0x58(%rsp),%rax 38: 48 89 01 mov %rax,(%rcx) 3b: 48 8b 44 24 18 mov 0x18(%rsp),%rax