====================================================== WARNING: possible circular locking dependency detected 4.14.305-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.3/10379 is trying to acquire lock: (sb_writers#3){.+.+}, at: [] sb_start_write include/linux/fs.h:1551 [inline] (sb_writers#3){.+.+}, at: [] mnt_want_write+0x3a/0xb0 fs/namespace.c:386 but task is already holding lock: (&ovl_i_mutex_dir_key[depth]#2){++++}, at: [] inode_lock include/linux/fs.h:719 [inline] (&ovl_i_mutex_dir_key[depth]#2){++++}, at: [] do_last fs/namei.c:3331 [inline] (&ovl_i_mutex_dir_key[depth]#2){++++}, at: [] path_openat+0xde2/0x2970 fs/namei.c:3571 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ovl_i_mutex_dir_key[depth]#2){++++}: down_write_killable+0x37/0xb0 kernel/locking/rwsem.c:68 iterate_dir+0x387/0x5e0 fs/readdir.c:43 ovl_dir_read fs/overlayfs/readdir.c:306 [inline] ovl_dir_read_merged+0x2c5/0x430 fs/overlayfs/readdir.c:365 ovl_check_empty_dir+0x6e/0x200 fs/overlayfs/readdir.c:870 ovl_check_empty_and_clear+0x72/0xe0 fs/overlayfs/dir.c:306 ovl_rename+0x57d/0xe50 fs/overlayfs/dir.c:959 vfs_rename+0x560/0x1820 fs/namei.c:4498 SYSC_renameat2 fs/namei.c:4646 [inline] SyS_renameat2+0x95b/0xad0 fs/namei.c:4535 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x5e/0xd3 -> #0 (sb_writers#3){.+.+}: lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998 percpu_down_read_preempt_disable include/linux/percpu-rwsem.h:36 [inline] percpu_down_read include/linux/percpu-rwsem.h:59 [inline] __sb_start_write+0x64/0x260 fs/super.c:1342 sb_start_write include/linux/fs.h:1551 [inline] mnt_want_write+0x3a/0xb0 fs/namespace.c:386 ovl_create_object+0x75/0x1d0 fs/overlayfs/dir.c:538 lookup_open+0x77a/0x1750 fs/namei.c:3241 do_last fs/namei.c:3334 [inline] path_openat+0xe08/0x2970 fs/namei.c:3571 do_filp_open+0x179/0x3c0 fs/namei.c:3605 do_sys_open+0x296/0x410 fs/open.c:1081 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x5e/0xd3 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ovl_i_mutex_dir_key[depth]#2); lock(sb_writers#3); lock(&ovl_i_mutex_dir_key[depth]#2); lock(sb_writers#3); *** DEADLOCK *** 2 locks held by syz-executor.3/10379: #0: (sb_writers#14){.+.+}, at: [] sb_start_write include/linux/fs.h:1551 [inline] #0: (sb_writers#14){.+.+}, at: [] mnt_want_write+0x3a/0xb0 fs/namespace.c:386 #1: (&ovl_i_mutex_dir_key[depth]#2){++++}, at: [] inode_lock include/linux/fs.h:719 [inline] #1: (&ovl_i_mutex_dir_key[depth]#2){++++}, at: [] do_last fs/namei.c:3331 [inline] #1: (&ovl_i_mutex_dir_key[depth]#2){++++}, at: [] path_openat+0xde2/0x2970 fs/namei.c:3571 stack backtrace: CPU: 1 PID: 10379 Comm: syz-executor.3 Not tainted 4.14.305-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/21/2023 Call Trace: __dump_stack lib/dump_stack.c:17 [inline] dump_stack+0x1b2/0x281 lib/dump_stack.c:58 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1258 check_prev_add kernel/locking/lockdep.c:1905 [inline] check_prevs_add kernel/locking/lockdep.c:2022 [inline] validate_chain kernel/locking/lockdep.c:2464 [inline] __lock_acquire+0x2e0e/0x3f20 kernel/locking/lockdep.c:3491 lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998 percpu_down_read_preempt_disable include/linux/percpu-rwsem.h:36 [inline] percpu_down_read include/linux/percpu-rwsem.h:59 [inline] __sb_start_write+0x64/0x260 fs/super.c:1342 sb_start_write include/linux/fs.h:1551 [inline] mnt_want_write+0x3a/0xb0 fs/namespace.c:386 ovl_create_object+0x75/0x1d0 fs/overlayfs/dir.c:538 lookup_open+0x77a/0x1750 fs/namei.c:3241 do_last fs/namei.c:3334 [inline] path_openat+0xe08/0x2970 fs/namei.c:3571 do_filp_open+0x179/0x3c0 fs/namei.c:3605 do_sys_open+0x296/0x410 fs/open.c:1081 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x5e/0xd3 RIP: 0033:0x7ff0df0750f9 RSP: 002b:00007ff0dd5a5168 EFLAGS: 00000246 ORIG_RAX: 0000000000000055 RAX: ffffffffffffffda RBX: 00007ff0df195120 RCX: 00007ff0df0750f9 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000020000240 RBP: 00007ff0df0d0ae9 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007fff7638ce1f R14: 00007ff0dd5a5300 R15: 0000000000022000 netlink: 24 bytes leftover after parsing attributes in process `syz-executor.2'. netlink: 24 bytes leftover after parsing attributes in process `syz-executor.2'. netlink: 24 bytes leftover after parsing attributes in process `syz-executor.0'. netlink: 24 bytes leftover after parsing attributes in process `syz-executor.3'. netlink: 24 bytes leftover after parsing attributes in process `syz-executor.2'. netlink: 24 bytes leftover after parsing attributes in process `syz-executor.2'. netlink: 24 bytes leftover after parsing attributes in process `syz-executor.3'. netlink: 24 bytes leftover after parsing attributes in process `syz-executor.0'. netlink: 24 bytes leftover after parsing attributes in process `syz-executor.3'. netlink: 24 bytes leftover after parsing attributes in process `syz-executor.0'. hfsplus: bad catalog entry type hfsplus: bad catalog entry type hfsplus: bad catalog entry type hfsplus: bad catalog entry type hfsplus: bad catalog entry type hfsplus: bad catalog entry type hfsplus: bad catalog entry type caif:caif_disconnect_client(): nothing to disconnect dccp_close: ABORT with 67 bytes unread caif:caif_disconnect_client(): nothing to disconnect dccp_close: ABORT with 67 bytes unread caif:caif_disconnect_client(): nothing to disconnect caif:caif_disconnect_client(): nothing to disconnect dccp_close: ABORT with 67 bytes unread caif:caif_disconnect_client(): nothing to disconnect caif:caif_disconnect_client(): nothing to disconnect caif:caif_disconnect_client(): nothing to disconnect caif:caif_disconnect_client(): nothing to disconnect caif:caif_disconnect_client(): nothing to disconnect caif:caif_disconnect_client(): nothing to disconnect dccp_close: ABORT with 67 bytes unread caif:caif_disconnect_client(): nothing to disconnect caif:caif_disconnect_client(): nothing to disconnect dccp_close: ABORT with 67 bytes unread caif:caif_disconnect_client(): nothing to disconnect caif:caif_disconnect_client(): nothing to disconnect dccp_close: ABORT with 67 bytes unread caif:caif_disconnect_client(): nothing to disconnect caif:caif_disconnect_client(): nothing to disconnect caif:caif_disconnect_client(): nothing to disconnect caif:caif_disconnect_client(): nothing to disconnect caif:caif_disconnect_client(): nothing to disconnect caif:caif_disconnect_client(): nothing to disconnect caif:caif_disconnect_client(): nothing to disconnect caif:caif_disconnect_client(): nothing to disconnect caif:caif_disconnect_client(): nothing to disconnect caif:caif_disconnect_client(): nothing to disconnect REISERFS (device loop4): found reiserfs format "3.5" with non-standard journal REISERFS (device loop4): using ordered data mode reiserfs: using flush barriers REISERFS (device loop4): journal params: device loop4, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30 caif:caif_disconnect_client(): nothing to disconnect REISERFS (device loop4): checking transaction log (loop4) REISERFS (device loop4): Using r5 hash to sort names reiserfs: enabling write barrier flush mode REISERFS (device loop4): Created .reiserfs_priv - reserved for xattr storage. kauditd_printk_skb: 10 callbacks suppressed audit: type=1804 audit(1676972694.511:67): pid=10883 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.4" name="/root/syzkaller-testdir2967466721/syzkaller.TzJYeu/31/file0/bus" dev="loop4" ino=2 res=1 audit: type=1804 audit(1676972694.511:68): pid=10883 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="ToMToU" comm="syz-executor.4" name="/root/syzkaller-testdir2967466721/syzkaller.TzJYeu/31/file0/bus" dev="loop4" ino=2 res=1 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 REISERFS (device loop2): found reiserfs format "3.5" with non-standard journal hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: hidraw0: HID v0.00 Device [syz1] on syz0 REISERFS (device loop2): using ordered data mode REISERFS (device loop4): found reiserfs format "3.5" with non-standard journal REISERFS (device loop4): using ordered data mode reiserfs: using flush barriers hid-generic 0000:0000:0000.0002: unknown main item tag 0x0 hid-generic 0000:0000:0000.0002: unknown main item tag 0x0 REISERFS (device loop4): journal params: device loop4, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30 hid-generic 0000:0000:0000.0002: unknown main item tag 0x0 reiserfs: using flush barriers hid-generic 0000:0000:0000.0002: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 REISERFS (device loop2): journal params: device loop2, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30 hub 9-0:1.0: USB hub found hub 9-0:1.0: 8 ports detected hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 REISERFS (device loop4): checking transaction log (loop4) hid-generic 0000:0000:0000.0002: unknown main item tag 0x0 REISERFS (device loop4): Using r5 hash to sort names hid-generic 0000:0000:0000.0002: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0002: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 REISERFS (device loop2): checking transaction log (loop2) reiserfs: enabling write barrier flush mode hid-generic 0000:0000:0000.0002: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 REISERFS (device loop4): Created .reiserfs_priv - reserved for xattr storage. REISERFS (device loop2): Using r5 hash to sort names hid-generic 0000:0000:0000.0002: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0002: hidraw0: HID v0.00 Device [syz1] on syz0 audit: type=1804 audit(1676972695.472:69): pid=10940 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.4" name="/root/syzkaller-testdir2967466721/syzkaller.TzJYeu/32/file0/bus" dev="loop4" ino=2 res=1 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 reiserfs: enabling write barrier flush mode audit: type=1804 audit(1676972695.502:70): pid=10940 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="ToMToU" comm="syz-executor.4" name="/root/syzkaller-testdir2967466721/syzkaller.TzJYeu/32/file0/bus" dev="loop4" ino=2 res=1 REISERFS (device loop2): Created .reiserfs_priv - reserved for xattr storage. hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: hidraw0: HID v0.00 Device [syz1] on syz0 audit: type=1804 audit(1676972695.612:71): pid=10939 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.2" name="/root/syzkaller-testdir979731928/syzkaller.kVlUI9/37/file0/bus" dev="loop2" ino=2 res=1 audit: type=1804 audit(1676972695.612:72): pid=10939 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="ToMToU" comm="syz-executor.2" name="/root/syzkaller-testdir979731928/syzkaller.kVlUI9/37/file0/bus" dev="loop2" ino=2 res=1 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0005: unknown main item tag 0x0 hid-generic 0000:0000:0000.0005: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0005: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0005: unknown main item tag 0x0 hid-generic 0000:0000:0000.0005: unknown main item tag 0x0 hid-generic 0000:0000:0000.0005: unknown main item tag 0x0 hid-generic 0000:0000:0000.0005: unknown main item tag 0x0 hid-generic 0000:0000:0000.0005: unknown main item tag 0x0 hub 9-0:1.0: USB hub found hub 9-0:1.0: 8 ports detected hid-generic 0000:0000:0000.0005: unknown main item tag 0x0 hid-generic 0000:0000:0000.0005: hidraw0: HID v0.00 Device [syz1] on syz0