======================================================
WARNING: possible circular locking dependency detected
5.15.180-syzkaller #0 Not tainted
------------------------------------------------------
syz.4.390/6174 is trying to acquire lock:
ffff88806161df88 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_get_block+0x39b/0x1530 fs/hfsplus/extents.c:260

but task is already holding lock:
ffff8880221ed0f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_allocate+0x91/0x900 fs/hfsplus/bitmap.c:35

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1
 (&sbi->alloc_mutex){+.+.}-{3:3}:
       __mutex_lock_common+0x1eb/0x2390 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       hfsplus_block_free+0xc1/0x4d0 fs/hfsplus/bitmap.c:182
       hfsplus_free_extents+0x176/0xac0 fs/hfsplus/extents.c:363
       hfsplus_file_truncate+0x745/0xb40 fs/hfsplus/extents.c:592
       hfsplus_delete_inode+0x17c/0x230 fs/hfsplus/inode.c:-1
       hfsplus_unlink+0x4c0/0x760 fs/hfsplus/dir.c:405
       vfs_unlink+0x385/0x600 fs/namei.c:4280
       do_unlinkat+0x382/0x6f0 fs/namei.c:4348
       __do_sys_unlinkat fs/namei.c:4391 [inline]
       __se_sys_unlinkat fs/namei.c:4384 [inline]
       __x64_sys_unlinkat+0xd1/0xe0 fs/namei.c:4384
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012
       lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1eb/0x2390 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       hfsplus_get_block+0x39b/0x1530 fs/hfsplus/extents.c:260
       block_read_full_page+0x2e8/0xd10 fs/buffer.c:2290
       do_read_cache_page+0x8a1/0x1030 mm/filemap.c:-1
       read_mapping_page include/linux/pagemap.h:515 [inline]
       hfsplus_block_allocate+0xf4/0x900 fs/hfsplus/bitmap.c:37
       hfsplus_file_extend+0xa8e/0x1950 fs/hfsplus/extents.c:469
       hfsplus_get_block+0x40e/0x1530 fs/hfsplus/extents.c:245
       __block_write_begin_int+0x54e/0x15a0 fs/buffer.c:2012
       __block_write_begin fs/buffer.c:2062 [inline]
       block_write_begin fs/buffer.c:2122 [inline]
       cont_write_begin+0x58a/0x7b0 fs/buffer.c:2471
       hfsplus_write_begin+0x92/0xe0 fs/hfsplus/inode.c:53
       generic_perform_write+0x2aa/0x530 mm/filemap.c:3785
       __generic_file_write_iter+0x25f/0x4e0 mm/filemap.c:3912
       generic_file_write_iter+0xa6/0x1b0 mm/filemap.c:3944
       call_write_iter include/linux/fs.h:2172 [inline]
       new_sync_write fs/read_write.c:507 [inline]
       vfs_write+0x712/0xd00 fs/read_write.c:594
       ksys_write+0x14d/0x250 fs/read_write.c:647
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&sbi->alloc_mutex);
                               lock(&HFSPLUS_I(inode)->extents_lock);
                               lock(&sbi->alloc_mutex);
  lock(&HFSPLUS_I(inode)->extents_lock);

 *** DEADLOCK ***

5 locks held by syz.4.390/6174:
 #0: ffff8880778d7c70 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x2bf/0x370 fs/file.c:1058
 #1: ffff888076778460 (sb_writers#15){.+.+}-{0:0}, at: vfs_write+0x28a/0xd00 fs/read_write.c:590
 #2: ffff88806161f5c0 (&sb->s_type->i_mutex_key#23){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #2: ffff88806161f5c0 (&sb->s_type->i_mutex_key#23){+.+.}-{3:3}, at: generic_file_write_iter+0x7e/0x1b0 mm/filemap.c:3941
 #3: ffff88806161f3c8 (&hip->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1b3/0x1950 fs/hfsplus/extents.c:458
 #4: ffff8880221ed0f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_allocate+0x91/0x900 fs/hfsplus/bitmap.c:35

stack backtrace:
CPU: 1 PID: 6174 Comm: syz.4.390 Not tainted 5.15.180-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x168/0x230 lib/dump_stack.c:106
 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012
 lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623
 __mutex_lock_common+0x1eb/0x2390 kernel/locking/mutex.c:596
 __mutex_lock kernel/locking/mutex.c:729 [inline]
 mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
 hfsplus_get_block+0x39b/0x1530 fs/hfsplus/extents.c:260
 block_read_full_page+0x2e8/0xd10 fs/buffer.c:2290
 do_read_cache_page+0x8a1/0x1030 mm/filemap.c:-1
 read_mapping_page include/linux/pagemap.h:515 [inline]
 hfsplus_block_allocate+0xf4/0x900 fs/hfsplus/bitmap.c:37
 hfsplus_file_extend+0xa8e/0x1950 fs/hfsplus/extents.c:469
 hfsplus_get_block+0x40e/0x1530 fs/hfsplus/extents.c:245
 __block_write_begin_int+0x54e/0x15a0 fs/buffer.c:2012
 __block_write_begin fs/buffer.c:2062 [inline]
 block_write_begin fs/buffer.c:2122 [inline]
 cont_write_begin+0x58a/0x7b0 fs/buffer.c:2471
 hfsplus_write_begin+0x92/0xe0 fs/hfsplus/inode.c:53
 generic_perform_write+0x2aa/0x530 mm/filemap.c:3785
 __generic_file_write_iter+0x25f/0x4e0 mm/filemap.c:3912
 generic_file_write_iter+0xa6/0x1b0 mm/filemap.c:3944
 call_write_iter include/linux/fs.h:2172 [inline]
 new_sync_write fs/read_write.c:507 [inline]
 vfs_write+0x712/0xd00 fs/read_write.c:594
 ksys_write+0x14d/0x250 fs/read_write.c:647
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7ff5ba555969
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ff5b83bd038 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007ff5ba77cfa0 RCX: 00007ff5ba555969
RDX: 000000000208e24b RSI: 0000200000000040 RDI: 0000000000000004
RBP: 00007ff5ba5d7ab1 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007ff5ba77cfa0 R15: 00007ffda5c3c808
 </TASK>