====================================================== WARNING: possible circular locking dependency detected 6.1.56-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.2/22226 is trying to acquire lock: ffff88804ac3e6d8 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x37a/0x1ca0 fs/ext4/inode.c:574 but task is already holding lock: ffff888021b8c208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x9b/0x190 fs/quota/quota_v2.c:354 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5661 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:332 dquot_acquire+0x188/0x680 fs/quota/dquot.c:459 ext4_acquire_dquot+0x2e6/0x400 fs/ext4/super.c:6769 dqget+0x752/0xe30 fs/quota/dquot.c:972 __dquot_initialize+0x2d9/0xe10 fs/quota/dquot.c:1550 ext4_create+0xb1/0x550 fs/ext4/namei.c:2827 lookup_open fs/namei.c:3413 [inline] open_last_lookups fs/namei.c:3481 [inline] path_openat+0x12f1/0x2e60 fs/namei.c:3711 do_filp_open+0x230/0x480 fs/namei.c:3741 do_sys_openat2+0x13b/0x500 fs/open.c:1318 do_sys_open fs/open.c:1334 [inline] __do_sys_openat fs/open.c:1350 [inline] __se_sys_openat fs/open.c:1345 [inline] __x64_sys_openat+0x243/0x290 fs/open.c:1345 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (&dquot->dq_lock){+.+.}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5661 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 dquot_commit+0x57/0x510 fs/quota/dquot.c:503 ext4_write_dquot+0x1e8/0x2b0 fs/ext4/super.c:6753 mark_dquot_dirty fs/quota/dquot.c:370 [inline] mark_all_dquot_dirty fs/quota/dquot.c:408 [inline] __dquot_alloc_space+0x574/0xf80 fs/quota/dquot.c:1780 dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline] dquot_alloc_space include/linux/quotaops.h:313 [inline] dquot_alloc_block include/linux/quotaops.h:337 [inline] ext4_mb_new_blocks+0x1160/0x4820 fs/ext4/mballoc.c:5635 ext4_ext_map_blocks+0x1b0c/0x77c0 fs/ext4/extents.c:4287 ext4_map_blocks+0xa3c/0x1ca0 fs/ext4/inode.c:651 ext4_getblk+0x1eb/0x7c0 fs/ext4/inode.c:854 ext4_bread+0x2a/0x170 fs/ext4/inode.c:910 ext4_append+0x31f/0x5c0 fs/ext4/namei.c:83 ext4_init_new_dir+0x33a/0xa20 fs/ext4/namei.c:2981 ext4_mkdir+0x4f2/0xce0 fs/ext4/namei.c:3027 vfs_mkdir+0x3b6/0x590 fs/namei.c:4036 do_mkdirat+0x260/0x520 fs/namei.c:4061 __do_sys_mkdirat fs/namei.c:4076 [inline] __se_sys_mkdirat fs/namei.c:4074 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4074 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&ei->i_data_sem/2){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1667/0x58e0 kernel/locking/lockdep.c:3824 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5048 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5661 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 ext4_map_blocks+0x37a/0x1ca0 fs/ext4/inode.c:574 ext4_getblk+0x1eb/0x7c0 fs/ext4/inode.c:854 ext4_bread+0x2a/0x170 fs/ext4/inode.c:910 ext4_quota_write+0x21e/0x570 fs/ext4/super.c:7135 write_blk fs/quota/quota_tree.c:64 [inline] get_free_dqblk+0x340/0x6c0 fs/quota/quota_tree.c:130 do_insert_tree+0x299/0x1ae0 fs/quota/quota_tree.c:340 do_insert_tree+0x72a/0x1ae0 fs/quota/quota_tree.c:375 do_insert_tree+0x72a/0x1ae0 fs/quota/quota_tree.c:375 do_insert_tree+0x72a/0x1ae0 fs/quota/quota_tree.c:375 dq_insert_tree fs/quota/quota_tree.c:401 [inline] qtree_write_dquot+0x3b9/0x530 fs/quota/quota_tree.c:420 v2_write_dquot+0x11c/0x190 fs/quota/quota_v2.c:358 dquot_acquire+0x34d/0x680 fs/quota/dquot.c:468 ext4_acquire_dquot+0x2e6/0x400 fs/ext4/super.c:6769 dqget+0x752/0xe30 fs/quota/dquot.c:972 __dquot_initialize+0x2d9/0xe10 fs/quota/dquot.c:1550 ext4_mkdir+0x197/0xce0 fs/ext4/namei.c:3010 vfs_mkdir+0x3b6/0x590 fs/namei.c:4036 do_mkdirat+0x260/0x520 fs/namei.c:4061 __do_sys_mkdirat fs/namei.c:4076 [inline] __se_sys_mkdirat fs/namei.c:4074 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4074 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &ei->i_data_sem/2 --> &dquot->dq_lock --> &s->s_dquot.dqio_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&s->s_dquot.dqio_sem); lock(&dquot->dq_lock); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); *** DEADLOCK *** 4 locks held by syz-executor.2/22226: #0: ffff888021b8c460 (sb_writers#4){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:393 #1: ffff88804ac3d440 (&type->i_mutex_dir_key#3/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:791 [inline] #1: ffff88804ac3d440 (&type->i_mutex_dir_key#3/1){+.+.}-{3:3}, at: filename_create+0x256/0x530 fs/namei.c:3807 #2: ffff88806faa2ea8 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_acquire+0x64/0x680 fs/quota/dquot.c:456 #3: ffff888021b8c208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x9b/0x190 fs/quota/quota_v2.c:354 stack backtrace: CPU: 0 PID: 22226 Comm: syz-executor.2 Not tainted 6.1.56-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/06/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1667/0x58e0 kernel/locking/lockdep.c:3824 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5048 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5661 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 ext4_map_blocks+0x37a/0x1ca0 fs/ext4/inode.c:574 ext4_getblk+0x1eb/0x7c0 fs/ext4/inode.c:854 ext4_bread+0x2a/0x170 fs/ext4/inode.c:910 ext4_quota_write+0x21e/0x570 fs/ext4/super.c:7135 write_blk fs/quota/quota_tree.c:64 [inline] get_free_dqblk+0x340/0x6c0 fs/quota/quota_tree.c:130 do_insert_tree+0x299/0x1ae0 fs/quota/quota_tree.c:340 do_insert_tree+0x72a/0x1ae0 fs/quota/quota_tree.c:375 do_insert_tree+0x72a/0x1ae0 fs/quota/quota_tree.c:375 do_insert_tree+0x72a/0x1ae0 fs/quota/quota_tree.c:375 dq_insert_tree fs/quota/quota_tree.c:401 [inline] qtree_write_dquot+0x3b9/0x530 fs/quota/quota_tree.c:420 v2_write_dquot+0x11c/0x190 fs/quota/quota_v2.c:358 dquot_acquire+0x34d/0x680 fs/quota/dquot.c:468 ext4_acquire_dquot+0x2e6/0x400 fs/ext4/super.c:6769 dqget+0x752/0xe30 fs/quota/dquot.c:972 __dquot_initialize+0x2d9/0xe10 fs/quota/dquot.c:1550 ext4_mkdir+0x197/0xce0 fs/ext4/namei.c:3010 vfs_mkdir+0x3b6/0x590 fs/namei.c:4036 do_mkdirat+0x260/0x520 fs/namei.c:4061 __do_sys_mkdirat fs/namei.c:4076 [inline] __se_sys_mkdirat fs/namei.c:4074 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4074 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7fd0f5c7cae9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fd0f69c20c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000102 RAX: ffffffffffffffda RBX: 00007fd0f5d9c050 RCX: 00007fd0f5c7cae9 RDX: 0000000000000000 RSI: 0000000020000000 RDI: 0000000000000004 RBP: 00007fd0f5cc847a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000006e R14: 00007fd0f5d9c050 R15: 00007fff31c4e7d8