====================================================== WARNING: possible circular locking dependency detected 5.15.173-syzkaller #0 Not tainted ------------------------------------------------------ syz.8.801/7845 is trying to acquire lock: ffff0000e941c428 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_commit+0x54/0x240 fs/quota/dquot.c:507 but task is already holding lock: ffff0000d214c840 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x830/0x1a44 fs/ext4/inode.c:665 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&ei->i_data_sem/2){++++}-{3:3}: down_read+0xc0/0x398 kernel/locking/rwsem.c:1498 ext4_map_blocks+0x2bc/0x1a44 fs/ext4/inode.c:597 ext4_getblk+0x160/0x688 fs/ext4/inode.c:869 ext4_bread+0x3c/0x1d4 fs/ext4/inode.c:922 ext4_quota_write+0x238/0x564 fs/ext4/super.c:6567 write_blk fs/quota/quota_tree.c:64 [inline] get_free_dqblk+0x2dc/0x6a0 fs/quota/quota_tree.c:125 do_insert_tree+0x238/0x14cc fs/quota/quota_tree.c:335 do_insert_tree+0x4b8/0x14cc fs/quota/quota_tree.c:366 do_insert_tree+0x4b8/0x14cc fs/quota/quota_tree.c:366 do_insert_tree+0x4b8/0x14cc fs/quota/quota_tree.c:366 dq_insert_tree fs/quota/quota_tree.c:392 [inline] qtree_write_dquot+0x318/0x488 fs/quota/quota_tree.c:411 v2_write_dquot+0xf4/0x188 fs/quota/quota_v2.c:358 dquot_acquire+0x2cc/0x5e4 fs/quota/dquot.c:472 ext4_acquire_dquot+0x270/0x420 fs/ext4/super.c:6193 dqget+0x664/0xd0c fs/quota/dquot.c:986 __dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1515 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1577 ext4_setattr+0x228/0x1440 fs/ext4/inode.c:5399 notify_change+0xa34/0xcf8 fs/attr.c:505 do_truncate+0x1c0/0x28c fs/open.c:65 vfs_truncate+0x2e0/0x388 fs/open.c:111 do_sys_truncate+0xec/0x1b4 fs/open.c:134 __do_sys_truncate fs/open.c:146 [inline] __se_sys_truncate fs/open.c:144 [inline] __arm64_sys_truncate+0x5c/0x70 fs/open.c:144 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #1 (&s->s_dquot.dqio_sem){++++}-{3:3}: down_read+0xc0/0x398 kernel/locking/rwsem.c:1498 v2_read_dquot+0x50/0x11c fs/quota/quota_v2.c:332 dquot_acquire+0x130/0x5e4 fs/quota/dquot.c:463 ext4_acquire_dquot+0x270/0x420 fs/ext4/super.c:6193 dqget+0x664/0xd0c fs/quota/dquot.c:986 __dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1515 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1577 ext4_setattr+0x228/0x1440 fs/ext4/inode.c:5399 notify_change+0xa34/0xcf8 fs/attr.c:505 do_truncate+0x1c0/0x28c fs/open.c:65 vfs_truncate+0x2e0/0x388 fs/open.c:111 do_sys_truncate+0xec/0x1b4 fs/open.c:134 __do_sys_truncate fs/open.c:146 [inline] __se_sys_truncate fs/open.c:144 [inline] __arm64_sys_truncate+0x5c/0x70 fs/open.c:144 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #0 (&dquot->dq_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 dquot_commit+0x54/0x240 fs/quota/dquot.c:507 ext4_write_dquot+0x1b4/0x314 fs/ext4/super.c:6173 ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6233 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0x108/0x424 fs/quota/dquot.c:412 __dquot_alloc_space+0xb54/0xf7c fs/quota/dquot.c:1750 dquot_alloc_space_nodirty include/linux/quotaops.h:297 [inline] dquot_alloc_space include/linux/quotaops.h:310 [inline] dquot_alloc_block include/linux/quotaops.h:334 [inline] ext4_mb_new_blocks+0xe78/0x4278 fs/ext4/mballoc.c:5739 ext4_ext_map_blocks+0x1500/0x6418 fs/ext4/extents.c:4339 ext4_map_blocks+0x8d0/0x1a44 fs/ext4/inode.c:672 ext4_getblk+0x160/0x688 fs/ext4/inode.c:869 ext4_bread+0x3c/0x1d4 fs/ext4/inode.c:922 ext4_append+0x260/0x4cc fs/ext4/namei.c:83 ext4_init_new_dir+0x294/0x8f4 fs/ext4/namei.c:3030 ext4_mkdir+0x3d4/0xa74 fs/ext4/namei.c:3076 vfs_mkdir+0x334/0x4e4 fs/namei.c:4065 do_mkdirat+0x20c/0x610 fs/namei.c:4090 __do_sys_mkdirat fs/namei.c:4105 [inline] __se_sys_mkdirat fs/namei.c:4103 [inline] __arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4103 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 other info that might help us debug this: Chain exists of: &dquot->dq_lock --> &s->s_dquot.dqio_sem --> &ei->i_data_sem/2 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ei->i_data_sem/2); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); lock(&dquot->dq_lock); *** DEADLOCK *** 4 locks held by syz.8.801/7845: #0: ffff0000e8178460 (sb_writers#3){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:377 #1: ffff0000d214d3b0 (&type->i_mutex_dir_key#3/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline] #1: ffff0000d214d3b0 (&type->i_mutex_dir_key#3/1){+.+.}-{3:3}, at: filename_create+0x204/0x468 fs/namei.c:3835 #2: ffff0000d214c840 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x830/0x1a44 fs/ext4/inode.c:665 #3: ffff800014da9b38 (dquot_srcu){....}-{0:0}, at: rcu_lock_acquire+0x10/0x4c include/linux/rcupdate.h:311 stack backtrace: CPU: 0 PID: 7845 Comm: syz.8.801 Not tainted 5.15.173-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024 Call trace: dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 dquot_commit+0x54/0x240 fs/quota/dquot.c:507 ext4_write_dquot+0x1b4/0x314 fs/ext4/super.c:6173 ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6233 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0x108/0x424 fs/quota/dquot.c:412 __dquot_alloc_space+0xb54/0xf7c fs/quota/dquot.c:1750 dquot_alloc_space_nodirty include/linux/quotaops.h:297 [inline] dquot_alloc_space include/linux/quotaops.h:310 [inline] dquot_alloc_block include/linux/quotaops.h:334 [inline] ext4_mb_new_blocks+0xe78/0x4278 fs/ext4/mballoc.c:5739 ext4_ext_map_blocks+0x1500/0x6418 fs/ext4/extents.c:4339 ext4_map_blocks+0x8d0/0x1a44 fs/ext4/inode.c:672 ext4_getblk+0x160/0x688 fs/ext4/inode.c:869 ext4_bread+0x3c/0x1d4 fs/ext4/inode.c:922 ext4_append+0x260/0x4cc fs/ext4/namei.c:83 ext4_init_new_dir+0x294/0x8f4 fs/ext4/namei.c:3030 ext4_mkdir+0x3d4/0xa74 fs/ext4/namei.c:3076 vfs_mkdir+0x334/0x4e4 fs/namei.c:4065 do_mkdirat+0x20c/0x610 fs/namei.c:4090 __do_sys_mkdirat fs/namei.c:4105 [inline] __se_sys_mkdirat fs/namei.c:4103 [inline] __arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4103 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584