======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.4.106/6922 is trying to acquire lock:
ffff88801ebb4800 (sb_internal#4){.+.+}-{0:0}, at: ocfs2_setattr+0x9eb/0x1d10 fs/ocfs2/file.c:1275

but task is already holding lock:
ffff8880686b1890 (&oi->ip_alloc_sem){+.+.}-{4:4}, at: ocfs2_setattr+0x9dc/0x1d10 fs/ocfs2/file.c:1274

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&oi->ip_alloc_sem){+.+.}-{4:4}:
       down_write+0x35/0x50 kernel/locking/rwsem.c:1631
       ocfs2_try_remove_refcount_tree+0xb6/0x360 fs/ocfs2/refcounttree.c:959
       ocfs2_xattr_set+0x639/0x13a0 fs/ocfs2/xattr.c:3915
       ocfs2_set_acl+0x6fd/0x7b0 fs/ocfs2/acl.c:254
       ocfs2_iop_set_acl+0x1b1/0x2b0 fs/ocfs2/acl.c:286
       set_posix_acl fs/posix_acl.c:960 [inline]
       vfs_remove_acl+0x56e/0x870 fs/posix_acl.c:1247
       ovl_do_remove_acl fs/overlayfs/overlayfs.h:366 [inline]
       ovl_workdir_create+0x58e/0x970 fs/overlayfs/super.c:388
       ovl_make_workdir fs/overlayfs/super.c:697 [inline]
       ovl_get_workdir+0x339/0x1980 fs/overlayfs/super.c:855
       ovl_fill_super_creds fs/overlayfs/super.c:1468 [inline]
       ovl_fill_super+0x1671/0x4370 fs/overlayfs/super.c:1580
       get_tree_super fs/super.c:1400 [inline]
       get_tree_nodev+0xbb/0x150 fs/super.c:1420
       vfs_get_tree+0x92/0x2a0 fs/super.c:1943
       fc_mount fs/namespace.c:1282 [inline]
       do_new_mount_fc fs/namespace.c:3910 [inline]
       do_new_mount+0x325/0xb00 fs/namespace.c:3986
       do_mount fs/namespace.c:4350 [inline]
       __do_sys_mount fs/namespace.c:4565 [inline]
       __se_sys_mount+0x31d/0x420 fs/namespace.c:4542
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&oi->ip_xattr_sem){++++}-{4:4}:
       down_read+0x92/0x200 kernel/locking/rwsem.c:1574
       ocfs2_xattr_get+0xf4/0x260 fs/ocfs2/xattr.c:1575
       __vfs_getxattr+0x412/0x440 fs/xattr.c:446
       smk_fetch+0xb4/0x140 security/smack/smack_lsm.c:298
       smack_d_instantiate+0x5b5/0x810 security/smack/smack_lsm.c:3682
       security_d_instantiate+0x106/0x1d0 security/security.c:3782
       d_instantiate+0x54/0xb0 fs/dcache.c:2251
       ocfs2_mknod+0x199c/0x21a0 fs/ocfs2/namei.c:454
       ocfs2_mkdir+0x180/0x430 fs/ocfs2/namei.c:662
       vfs_mkdir+0x414/0x630 fs/namei.c:5420
       filename_mkdirat+0x289/0x520 fs/namei.c:5453
       __do_sys_mkdirat fs/namei.c:5474 [inline]
       __se_sys_mkdirat+0x35/0x150 fs/namei.c:5471
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&journal->j_trans_barrier){.+.+}-{4:4}:
       down_read+0x92/0x200 kernel/locking/rwsem.c:1574
       ocfs2_start_trans+0x3aa/0x700 fs/ocfs2/journal.c:369
       ocfs2_block_group_alloc fs/ocfs2/suballoc.c:801 [inline]
       ocfs2_reserve_suballoc_bits+0x7b7/0x4850 fs/ocfs2/suballoc.c:950
       ocfs2_reserve_new_metadata_blocks+0x415/0x9a0 fs/ocfs2/suballoc.c:1100
       ocfs2_calc_security_init+0x37a/0x5d0 fs/ocfs2/xattr.c:618
       ocfs2_symlink+0xf22/0x25f0 fs/ocfs2/namei.c:1915
       vfs_symlink+0x18e/0x340 fs/namei.c:5804
       filename_symlinkat+0x1cd/0x420 fs/namei.c:5829
       __do_sys_symlink fs/namei.c:5856 [inline]
       __se_sys_symlink+0x4d/0x2b0 fs/namei.c:5852
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (sb_internal#4){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3209 [inline]
       check_prevs_add kernel/locking/lockdep.c:3328 [inline]
       validate_chain kernel/locking/lockdep.c:3952 [inline]
       __lock_acquire+0x164c/0x2de0 kernel/locking/lockdep.c:5288
       lock_acquire+0x115/0x350 kernel/locking/lockdep.c:5942
       percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
       percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
       __sb_start_write include/linux/fs/super.h:19 [inline]
       sb_start_intwrite include/linux/fs/super.h:177 [inline]
       ocfs2_start_trans+0x2a7/0x700 fs/ocfs2/journal.c:367
       ocfs2_setattr+0x9eb/0x1d10 fs/ocfs2/file.c:1275
       notify_change+0xbb8/0xec0 fs/attr.c:556
       ovl_do_notify_change fs/overlayfs/overlayfs.h:211 [inline]
       ovl_workdir_create+0x6dd/0x970 fs/overlayfs/super.c:398
       ovl_make_workdir fs/overlayfs/super.c:697 [inline]
       ovl_get_workdir+0x339/0x1980 fs/overlayfs/super.c:855
       ovl_fill_super_creds fs/overlayfs/super.c:1468 [inline]
       ovl_fill_super+0x1671/0x4370 fs/overlayfs/super.c:1580
       get_tree_super fs/super.c:1400 [inline]
       get_tree_nodev+0xbb/0x150 fs/super.c:1420
       vfs_get_tree+0x92/0x2a0 fs/super.c:1943
       fc_mount fs/namespace.c:1282 [inline]
       do_new_mount_fc fs/namespace.c:3910 [inline]
       do_new_mount+0x325/0xb00 fs/namespace.c:3986
       do_mount fs/namespace.c:4350 [inline]
       __do_sys_mount fs/namespace.c:4565 [inline]
       __se_sys_mount+0x31d/0x420 fs/namespace.c:4542
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  sb_internal#4 --> &oi->ip_xattr_sem --> &oi->ip_alloc_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_alloc_sem);
                               lock(&oi->ip_xattr_sem);
                               lock(&oi->ip_alloc_sem);
  rlock(sb_internal#4);

 *** DEADLOCK ***

locks held by syz.4.106/6922: 4, last CPU#0:
 #0: ffff88802b37e0e0 (&type->s_umount_key#85/1){+.+.}-{4:4}, at: alloc_super fs/super.c:351 [inline]
 #0: ffff88802b37e0e0 (&type->s_umount_key#85/1){+.+.}-{4:4}, at: sget_fc+0x9cf/0x1a70 fs/super.c:874
 #1: ffff88801ebb4510 (sb_writers#20){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:531
 #2: ffff8880686b1c40 (&sb->s_type->i_mutex_key#36){++++}-{4:4}, at: inode_lock include/linux/fs.h:1024 [inline]
 #2: ffff8880686b1c40 (&sb->s_type->i_mutex_key#36){++++}-{4:4}, at: ovl_workdir_create+0x679/0x970 fs/overlayfs/super.c:397
 #3: ffff8880686b1890 (&oi->ip_alloc_sem){+.+.}-{4:4}, at: ocfs2_setattr+0x9dc/0x1d10 fs/ocfs2/file.c:1274

stack backtrace:
CPU: 0 UID: 0 PID: 6922 Comm: syz.4.106 Not tainted syzkaller #0 PREEMPT_{RT,(full)} 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/07/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e2/0x300 kernel/locking/lockdep.c:2087
 check_noncircular+0x12f/0x150 kernel/locking/lockdep.c:2219
 check_prev_add kernel/locking/lockdep.c:3209 [inline]
 check_prevs_add kernel/locking/lockdep.c:3328 [inline]
 validate_chain kernel/locking/lockdep.c:3952 [inline]
 __lock_acquire+0x164c/0x2de0 kernel/locking/lockdep.c:5288
 lock_acquire+0x115/0x350 kernel/locking/lockdep.c:5942
 percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
 percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
 __sb_start_write include/linux/fs/super.h:19 [inline]
 sb_start_intwrite include/linux/fs/super.h:177 [inline]
 ocfs2_start_trans+0x2a7/0x700 fs/ocfs2/journal.c:367
 ocfs2_setattr+0x9eb/0x1d10 fs/ocfs2/file.c:1275
 notify_change+0xbb8/0xec0 fs/attr.c:556
 ovl_do_notify_change fs/overlayfs/overlayfs.h:211 [inline]
 ovl_workdir_create+0x6dd/0x970 fs/overlayfs/super.c:398
 ovl_make_workdir fs/overlayfs/super.c:697 [inline]
 ovl_get_workdir+0x339/0x1980 fs/overlayfs/super.c:855
 ovl_fill_super_creds fs/overlayfs/super.c:1468 [inline]
 ovl_fill_super+0x1671/0x4370 fs/overlayfs/super.c:1580
 get_tree_super fs/super.c:1400 [inline]
 get_tree_nodev+0xbb/0x150 fs/super.c:1420
 vfs_get_tree+0x92/0x2a0 fs/super.c:1943
 fc_mount fs/namespace.c:1282 [inline]
 do_new_mount_fc fs/namespace.c:3910 [inline]
 do_new_mount+0x325/0xb00 fs/namespace.c:3986
 do_mount fs/namespace.c:4350 [inline]
 __do_sys_mount fs/namespace.c:4565 [inline]
 __se_sys_mount+0x31d/0x420 fs/namespace.c:4542
 do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
 do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f4e1850f559
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f4e15ede028 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007f4e18796360 RCX: 00007f4e1850f559
RDX: 0000200000000100 RSI: 00002000000000c0 RDI: 0000000000000000
RBP: 00007f4e185a6b20 R08: 0000200000000140 R09: 0000000000000000
R10: 0000000000000008 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f4e187963f8 R14: 00007f4e18796360 R15: 00007ffd987fd7a8
 </TASK>
overlayfs: upper fs does not support tmpfile.
overlayfs: upper fs does not support RENAME_WHITEOUT.
overlayfs: upper fs missing required features.