gfs2: fsid=syz:syz.0: first mount done, others may mount ====================================================== WARNING: possible circular locking dependency detected 5.15.173-syzkaller #0 Not tainted ------------------------------------------------------ syz.1.2414/12715 is trying to acquire lock: ffff888074f28ae0 (&sdp->sd_quota_mutex){+.+.}-{3:3}, at: do_qc+0xc8/0x720 fs/gfs2/quota.c:678 but task is already holding lock: ffff88805a925e10 (&ip->i_rw_mutex){++++}-{3:3}, at: __gfs2_iomap_alloc+0x2b7/0x2090 fs/gfs2/bmap.c:681 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ip->i_rw_mutex){++++}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498 __gfs2_iomap_get+0x178/0x1480 fs/gfs2/bmap.c:858 gfs2_iomap_get fs/gfs2/bmap.c:1398 [inline] gfs2_block_map+0x292/0x830 fs/gfs2/bmap.c:1213 bh_get+0x26d/0x6a0 fs/gfs2/quota.c:385 qdsb_get+0x209/0x3b0 fs/gfs2/quota.c:518 gfs2_quota_hold+0x19d/0x5c0 fs/gfs2/quota.c:604 gfs2_quota_lock+0x9f/0x450 fs/gfs2/quota.c:1076 gfs2_quota_lock_check fs/gfs2/quota.h:50 [inline] do_grow fs/gfs2/bmap.c:2065 [inline] gfs2_setattr_size+0x3f6/0x8d0 fs/gfs2/bmap.c:2140 gfs2_setattr+0x254/0x400 fs/gfs2/inode.c:2005 notify_change+0xc6d/0xf50 fs/attr.c:505 do_truncate+0x21c/0x300 fs/open.c:65 do_sys_ftruncate+0x2eb/0x390 fs/open.c:193 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #0 (&sdp->sd_quota_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 do_qc+0xc8/0x720 fs/gfs2/quota.c:678 gfs2_quota_change+0x2db/0x8c0 fs/gfs2/quota.c:1295 gfs2_alloc_blocks+0x1f0a/0x2970 fs/gfs2/rgrp.c:2504 __gfs2_iomap_alloc+0x4f0/0x2090 fs/gfs2/bmap.c:707 gfs2_iomap_alloc+0x155/0x1f0 fs/gfs2/bmap.c:1411 gfs2_allocate_page_backing+0x134/0x250 fs/gfs2/file.c:401 gfs2_page_mkwrite+0x1245/0x1590 fs/gfs2/file.c:531 do_page_mkwrite+0x1a9/0x440 mm/memory.c:2920 do_shared_fault mm/memory.c:4326 [inline] do_fault mm/memory.c:4394 [inline] handle_pte_fault mm/memory.c:4648 [inline] __handle_mm_fault mm/memory.c:4783 [inline] handle_mm_fault+0x2803/0x5960 mm/memory.c:4881 fixup_user_fault+0x2cc/0x450 mm/gup.c:1322 fault_in_safe_writeable+0x138/0x250 mm/gup.c:1765 fault_in_iov_iter_writeable+0x14a/0x1d0 lib/iov_iter.c:499 gfs2_file_read_iter+0xa73/0xe40 fs/gfs2/file.c:998 call_read_iter include/linux/fs.h:2168 [inline] new_sync_read fs/read_write.c:404 [inline] vfs_read+0xa93/0xe10 fs/read_write.c:485 ksys_read+0x1a2/0x2c0 fs/read_write.c:623 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ip->i_rw_mutex); lock(&sdp->sd_quota_mutex); lock(&ip->i_rw_mutex); lock(&sdp->sd_quota_mutex); *** DEADLOCK *** 6 locks held by syz.1.2414/12715: #0: ffff888079f3b770 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x2cb/0x380 fs/file.c:1057 #1: ffff88807abe4728 (&mm->mmap_lock){++++}-{3:3}, at: mmap_read_lock include/linux/mmap_lock.h:117 [inline] #1: ffff88807abe4728 (&mm->mmap_lock){++++}-{3:3}, at: fixup_user_fault+0x31b/0x450 mm/gup.c:1332 #2: ffff8880258a0558 (sb_pagefaults#4){.+.+}-{0:0}, at: do_page_mkwrite+0x1a9/0x440 mm/memory.c:2920 #3: ffff8880258a0650 (sb_internal#7){.+.+}-{0:0}, at: gfs2_trans_begin+0x6d/0xe0 fs/gfs2/trans.c:118 #4: ffff888074f290a8 (&sdp->sd_log_flush_lock){++++}-{3:3}, at: __gfs2_trans_begin+0x55a/0x940 fs/gfs2/trans.c:87 #5: ffff88805a925e10 (&ip->i_rw_mutex){++++}-{3:3}, at: __gfs2_iomap_alloc+0x2b7/0x2090 fs/gfs2/bmap.c:681 stack backtrace: CPU: 1 PID: 12715 Comm: syz.1.2414 Not tainted 5.15.173-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 do_qc+0xc8/0x720 fs/gfs2/quota.c:678 gfs2_quota_change+0x2db/0x8c0 fs/gfs2/quota.c:1295 gfs2_alloc_blocks+0x1f0a/0x2970 fs/gfs2/rgrp.c:2504 __gfs2_iomap_alloc+0x4f0/0x2090 fs/gfs2/bmap.c:707 gfs2_iomap_alloc+0x155/0x1f0 fs/gfs2/bmap.c:1411 gfs2_allocate_page_backing+0x134/0x250 fs/gfs2/file.c:401 gfs2_page_mkwrite+0x1245/0x1590 fs/gfs2/file.c:531 do_page_mkwrite+0x1a9/0x440 mm/memory.c:2920 do_shared_fault mm/memory.c:4326 [inline] do_fault mm/memory.c:4394 [inline] handle_pte_fault mm/memory.c:4648 [inline] __handle_mm_fault mm/memory.c:4783 [inline] handle_mm_fault+0x2803/0x5960 mm/memory.c:4881 fixup_user_fault+0x2cc/0x450 mm/gup.c:1322 fault_in_safe_writeable+0x138/0x250 mm/gup.c:1765 fault_in_iov_iter_writeable+0x14a/0x1d0 lib/iov_iter.c:499 gfs2_file_read_iter+0xa73/0xe40 fs/gfs2/file.c:998 call_read_iter include/linux/fs.h:2168 [inline] new_sync_read fs/read_write.c:404 [inline] vfs_read+0xa93/0xe10 fs/read_write.c:485 ksys_read+0x1a2/0x2c0 fs/read_write.c:623 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 RIP: 0033:0x7fc0876ad919 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fc085525038 EFLAGS: 00000246 ORIG_RAX: 0000000000000000 RAX: ffffffffffffffda RBX: 00007fc087864fa0 RCX: 00007fc0876ad919 RDX: 0000000000002020 RSI: 000000002000ac40 RDI: 0000000000000004 RBP: 00007fc08772097e R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007fc087864fa0 R15: 00007fffeae870b8