overlayfs: upper fs needs to support d_type. overlayfs: upper fs does not support tmpfile. overlayfs: upper fs does not support RENAME_WHITEOUT. ====================================================== WARNING: possible circular locking dependency detected 5.15.176-syzkaller #0 Not tainted ------------------------------------------------------ syz.5.462/6770 is trying to acquire lock: ffff888059f51090 (&sbi->lock){+.+.}-{3:3}, at: reiserfs_write_lock+0x76/0xd0 fs/reiserfs/lock.c:27 but task is already holding lock: ffff888063acbe80 (&type->i_mutex_dir_key#13/3){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline] ffff888063acbe80 (&type->i_mutex_dir_key#13/3){+.+.}-{3:3}, at: open_xa_root fs/reiserfs/xattr.c:127 [inline] ffff888063acbe80 (&type->i_mutex_dir_key#13/3){+.+.}-{3:3}, at: open_xa_dir+0x132/0x610 fs/reiserfs/xattr.c:152 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&type->i_mutex_dir_key#13/3){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_write_nested+0x3b/0x60 kernel/locking/rwsem.c:1667 inode_lock_nested include/linux/fs.h:824 [inline] open_xa_root fs/reiserfs/xattr.c:127 [inline] open_xa_dir+0x132/0x610 fs/reiserfs/xattr.c:152 reiserfs_for_each_xattr+0x1a4/0xb40 fs/reiserfs/xattr.c:252 reiserfs_delete_xattrs+0x1b/0x80 fs/reiserfs/xattr.c:364 reiserfs_evict_inode+0x20c/0x460 fs/reiserfs/inode.c:53 evict+0x529/0x930 fs/inode.c:622 reiserfs_mkdir+0x39e/0x8f0 vfs_mkdir+0x3b6/0x590 fs/namei.c:4065 do_mkdirat+0x260/0x520 fs/namei.c:4090 __do_sys_mkdirat fs/namei.c:4105 [inline] __se_sys_mkdirat fs/namei.c:4103 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4103 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #0 (&sbi->lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 reiserfs_write_lock+0x76/0xd0 fs/reiserfs/lock.c:27 reiserfs_mkdir+0x31d/0x8f0 fs/reiserfs/namei.c:831 xattr_mkdir fs/reiserfs/xattr.c:76 [inline] open_xa_root fs/reiserfs/xattr.c:136 [inline] open_xa_dir+0x2c9/0x610 fs/reiserfs/xattr.c:152 xattr_lookup+0x24/0x280 fs/reiserfs/xattr.c:395 reiserfs_xattr_set_handle+0x100/0x10b0 fs/reiserfs/xattr.c:540 reiserfs_xattr_set+0x44e/0x570 fs/reiserfs/xattr.c:640 __vfs_setxattr+0x3e7/0x420 fs/xattr.c:182 __vfs_setxattr_noperm+0x12a/0x5e0 fs/xattr.c:216 vfs_setxattr+0x21d/0x420 fs/xattr.c:303 ovl_do_setxattr fs/overlayfs/overlayfs.h:203 [inline] ovl_make_workdir fs/overlayfs/super.c:1420 [inline] ovl_get_workdir+0xa7d/0x1350 fs/overlayfs/super.c:1524 ovl_fill_super+0x1b85/0x2a20 fs/overlayfs/super.c:2080 mount_nodev+0x52/0xe0 fs/super.c:1446 legacy_get_tree+0xeb/0x180 fs/fs_context.c:611 vfs_get_tree+0x88/0x270 fs/super.c:1530 do_new_mount+0x2ba/0xb40 fs/namespace.c:3012 do_mount fs/namespace.c:3355 [inline] __do_sys_mount fs/namespace.c:3563 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3540 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&type->i_mutex_dir_key#13/3); lock(&sbi->lock); lock(&type->i_mutex_dir_key#13/3); lock(&sbi->lock); *** DEADLOCK *** 4 locks held by syz.5.462/6770: #0: ffff8880565640e0 (&type->s_umount_key#70/1){+.+.}-{3:3}, at: alloc_super+0x210/0x940 fs/super.c:229 #1: ffff888069914460 (sb_writers#20){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377 #2: ffff888056821020 (&type->i_mutex_dir_key#13){++++}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #2: ffff888056821020 (&type->i_mutex_dir_key#13){++++}-{3:3}, at: vfs_setxattr+0x1dd/0x420 fs/xattr.c:302 #3: ffff888063acbe80 (&type->i_mutex_dir_key#13/3){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline] #3: ffff888063acbe80 (&type->i_mutex_dir_key#13/3){+.+.}-{3:3}, at: open_xa_root fs/reiserfs/xattr.c:127 [inline] #3: ffff888063acbe80 (&type->i_mutex_dir_key#13/3){+.+.}-{3:3}, at: open_xa_dir+0x132/0x610 fs/reiserfs/xattr.c:152 stack backtrace: CPU: 0 PID: 6770 Comm: syz.5.462 Not tainted 5.15.176-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 reiserfs_write_lock+0x76/0xd0 fs/reiserfs/lock.c:27 reiserfs_mkdir+0x31d/0x8f0 fs/reiserfs/namei.c:831 xattr_mkdir fs/reiserfs/xattr.c:76 [inline] open_xa_root fs/reiserfs/xattr.c:136 [inline] open_xa_dir+0x2c9/0x610 fs/reiserfs/xattr.c:152 xattr_lookup+0x24/0x280 fs/reiserfs/xattr.c:395 reiserfs_xattr_set_handle+0x100/0x10b0 fs/reiserfs/xattr.c:540 reiserfs_xattr_set+0x44e/0x570 fs/reiserfs/xattr.c:640 __vfs_setxattr+0x3e7/0x420 fs/xattr.c:182 __vfs_setxattr_noperm+0x12a/0x5e0 fs/xattr.c:216 vfs_setxattr+0x21d/0x420 fs/xattr.c:303 ovl_do_setxattr fs/overlayfs/overlayfs.h:203 [inline] ovl_make_workdir fs/overlayfs/super.c:1420 [inline] ovl_get_workdir+0xa7d/0x1350 fs/overlayfs/super.c:1524 ovl_fill_super+0x1b85/0x2a20 fs/overlayfs/super.c:2080 mount_nodev+0x52/0xe0 fs/super.c:1446 legacy_get_tree+0xeb/0x180 fs/fs_context.c:611 vfs_get_tree+0x88/0x270 fs/super.c:1530 do_new_mount+0x2ba/0xb40 fs/namespace.c:3012 do_mount fs/namespace.c:3355 [inline] __do_sys_mount fs/namespace.c:3563 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3540 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 RIP: 0033:0x7fd0153eed29 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fd01325f038 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00007fd0155defa0 RCX: 00007fd0153eed29 RDX: 0000000020000000 RSI: 0000000020000100 RDI: 0000000000000000 RBP: 00007fd01546ab08 R08: 0000000020000780 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007fd0155defa0 R15: 00007ffc3ab65c48