hfsplus: xattr search failed hfsplus: inconsistency in B*Tree (1,0,1,0,2) hfsplus: xattr searching failed ====================================================== WARNING: possible circular locking dependency detected 6.4.0-rc7-syzkaller-ge40939bbfc68 #0 Not tainted ------------------------------------------------------ syz-executor118/5971 is trying to acquire lock: ffff0000de1787c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x198/0x14cc fs/hfsplus/extents.c:457 but task is already holding lock: ffff0000de1980b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x144/0x1bc which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&tree->tree_lock){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:799 hfsplus_file_truncate+0x6d0/0x9b8 fs/hfsplus/extents.c:595 hfsplus_setattr+0x18c/0x25c fs/hfsplus/inode.c:269 notify_change+0xa84/0xd20 fs/attr.c:483 do_truncate+0x1c0/0x28c fs/open.c:66 handle_truncate fs/namei.c:3295 [inline] do_open fs/namei.c:3640 [inline] path_openat+0x2130/0x27f8 fs/namei.c:3791 do_filp_open+0x1bc/0x3cc fs/namei.c:3818 do_sys_openat2+0x128/0x3d8 fs/open.c:1356 __do_sys_openat2 fs/open.c:1413 [inline] __se_sys_openat2 fs/open.c:1391 [inline] __arm64_sys_openat2+0x308/0x3b8 fs/open.c:1391 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x244 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x198 arch/arm64/kernel/syscall.c:191 el0_svc+0x4c/0x160 arch/arm64/kernel/entry-common.c:647 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:665 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:591 -> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3113 [inline] check_prevs_add kernel/locking/lockdep.c:3232 [inline] validate_chain kernel/locking/lockdep.c:3847 [inline] __lock_acquire+0x3308/0x7604 kernel/locking/lockdep.c:5088 lock_acquire+0x23c/0x71c kernel/locking/lockdep.c:5705 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:799 hfsplus_file_extend+0x198/0x14cc fs/hfsplus/extents.c:457 hfsplus_bmap_reserve+0xec/0x474 fs/hfsplus/btree.c:358 hfsplus_rename_cat+0x1ac/0xf30 fs/hfsplus/catalog.c:456 hfsplus_rename+0x120/0x1b0 fs/hfsplus/dir.c:552 vfs_rename+0x908/0xcd4 fs/namei.c:4849 do_renameat2+0x9f4/0x10b0 fs/namei.c:5002 __do_sys_renameat2 fs/namei.c:5035 [inline] __se_sys_renameat2 fs/namei.c:5032 [inline] __arm64_sys_renameat2+0xe0/0xfc fs/namei.c:5032 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x244 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x198 arch/arm64/kernel/syscall.c:191 el0_svc+0x4c/0x160 arch/arm64/kernel/entry-common.c:647 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:665 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:591 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&tree->tree_lock); lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock); lock(&HFSPLUS_I(inode)->extents_lock); *** DEADLOCK *** 3 locks held by syz-executor118/5971: #0: ffff0000de184460 (sb_writers#8){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:394 #1: ffff0000de179e00 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:810 [inline] #1: ffff0000de179e00 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: lock_rename fs/namei.c:3042 [inline] #1: ffff0000de179e00 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: do_renameat2+0x50c/0x10b0 fs/namei.c:4941 #2: ffff0000de1980b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x144/0x1bc stack backtrace: CPU: 0 PID: 5971 Comm: syz-executor118 Not tainted 6.4.0-rc7-syzkaller-ge40939bbfc68 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/27/2023 Call trace: dump_backtrace+0x1b8/0x1e4 arch/arm64/kernel/stacktrace.c:233 show_stack+0x2c/0x44 arch/arm64/kernel/stacktrace.c:240 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd0/0x124 lib/dump_stack.c:106 dump_stack+0x1c/0x28 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2066 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2188 check_prev_add kernel/locking/lockdep.c:3113 [inline] check_prevs_add kernel/locking/lockdep.c:3232 [inline] validate_chain kernel/locking/lockdep.c:3847 [inline] __lock_acquire+0x3308/0x7604 kernel/locking/lockdep.c:5088 lock_acquire+0x23c/0x71c kernel/locking/lockdep.c:5705 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:799 hfsplus_file_extend+0x198/0x14cc fs/hfsplus/extents.c:457 hfsplus_bmap_reserve+0xec/0x474 fs/hfsplus/btree.c:358 hfsplus_rename_cat+0x1ac/0xf30 fs/hfsplus/catalog.c:456 hfsplus_rename+0x120/0x1b0 fs/hfsplus/dir.c:552 vfs_rename+0x908/0xcd4 fs/namei.c:4849 do_renameat2+0x9f4/0x10b0 fs/namei.c:5002 __do_sys_renameat2 fs/namei.c:5035 [inline] __se_sys_renameat2 fs/namei.c:5032 [inline] __arm64_sys_renameat2+0xe0/0xfc fs/namei.c:5032 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x244 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x198 arch/arm64/kernel/syscall.c:191 el0_svc+0x4c/0x160 arch/arm64/kernel/entry-common.c:647 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:665 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:591