ip_tables: iptables: counters copy to user failed while replacing table ====================================================== WARNING: possible circular locking dependency detected 4.14.295-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.5/7979 is trying to acquire lock: (rtnl_mutex){+.+.}, at: [] unregister_netdevice_notifier+0x5e/0x2b0 net/core/dev.c:1630 but task is already holding lock: (&xt[i].mutex){+.+.}, at: [] xt_find_table_lock+0x38/0x3d0 net/netfilter/x_tables.c:1088 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&xt[i].mutex){+.+.}: __mutex_lock_common kernel/locking/mutex.c:756 [inline] __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893 target_revfn+0x43/0x210 net/netfilter/x_tables.c:354 xt_find_revision+0x15e/0x1d0 net/netfilter/x_tables.c:378 nfnl_compat_get+0x1f7/0x870 net/netfilter/nft_compat.c:678 nfnetlink_rcv_msg+0x9bb/0xc00 net/netfilter/nfnetlink.c:214 netlink_rcv_skb+0x125/0x390 net/netlink/af_netlink.c:2454 nfnetlink_rcv+0x1ab/0x1da0 net/netfilter/nfnetlink.c:515 netlink_unicast_kernel net/netlink/af_netlink.c:1296 [inline] netlink_unicast+0x437/0x610 net/netlink/af_netlink.c:1322 netlink_sendmsg+0x648/0xbc0 net/netlink/af_netlink.c:1893 sock_sendmsg_nosec net/socket.c:646 [inline] sock_sendmsg+0xb5/0x100 net/socket.c:656 ___sys_sendmsg+0x6c8/0x800 net/socket.c:2062 __sys_sendmsg+0xa3/0x120 net/socket.c:2096 SYSC_sendmsg net/socket.c:2107 [inline] SyS_sendmsg+0x27/0x40 net/socket.c:2103 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x46/0xbb -> #1 (&table[i].mutex){+.+.}: __mutex_lock_common kernel/locking/mutex.c:756 [inline] __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893 nf_tables_netdev_event+0x10d/0x4d0 net/netfilter/nf_tables_netdev.c:122 notifier_call_chain+0x108/0x1a0 kernel/notifier.c:93 call_netdevice_notifiers_info net/core/dev.c:1667 [inline] call_netdevice_notifiers net/core/dev.c:1683 [inline] rollback_registered_many+0x765/0xbb0 net/core/dev.c:7211 rollback_registered+0xca/0x170 net/core/dev.c:7253 unregister_netdevice_queue+0x1b4/0x360 net/core/dev.c:8274 vif_delete+0x36b/0x4b0 net/ipv4/ipmr.c:651 ip_mroute_setsockopt+0x4b5/0x1ba0 net/ipv4/ipmr.c:1396 do_ip_setsockopt.constprop.0+0x1e5/0x2900 net/ipv4/ip_sockglue.c:641 ip_setsockopt+0x36/0xb0 net/ipv4/ip_sockglue.c:1248 raw_setsockopt+0xac/0xd0 net/ipv4/raw.c:860 SYSC_setsockopt net/socket.c:1865 [inline] SyS_setsockopt+0x110/0x1e0 net/socket.c:1844 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x46/0xbb -> #0 (rtnl_mutex){+.+.}: lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998 __mutex_lock_common kernel/locking/mutex.c:756 [inline] __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893 unregister_netdevice_notifier+0x5e/0x2b0 net/core/dev.c:1630 tee_tg_destroy+0x5c/0xb0 net/netfilter/xt_TEE.c:123 cleanup_entry+0x1fd/0x2d0 net/ipv4/netfilter/ip_tables.c:666 __do_replace+0x38d/0x570 net/ipv4/netfilter/ip_tables.c:1086 do_replace net/ipv4/netfilter/ip_tables.c:1142 [inline] do_ipt_set_ctl+0x256/0x3a0 net/ipv4/netfilter/ip_tables.c:1676 nf_sockopt net/netfilter/nf_sockopt.c:106 [inline] nf_setsockopt+0x5f/0xb0 net/netfilter/nf_sockopt.c:115 ip_setsockopt net/ipv4/ip_sockglue.c:1255 [inline] ip_setsockopt+0x94/0xb0 net/ipv4/ip_sockglue.c:1240 tcp_setsockopt+0x7b/0xc0 net/ipv4/tcp.c:2830 SYSC_setsockopt net/socket.c:1865 [inline] SyS_setsockopt+0x110/0x1e0 net/socket.c:1844 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x46/0xbb other info that might help us debug this: Chain exists of: rtnl_mutex --> &table[i].mutex --> &xt[i].mutex Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&xt[i].mutex); lock(&table[i].mutex); lock(&xt[i].mutex); lock(rtnl_mutex); *** DEADLOCK *** 1 lock held by syz-executor.5/7979: #0: (&xt[i].mutex){+.+.}, at: [] xt_find_table_lock+0x38/0x3d0 net/netfilter/x_tables.c:1088 stack backtrace: CPU: 0 PID: 7979 Comm: syz-executor.5 Not tainted 4.14.295-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/22/2022 Call Trace: __dump_stack lib/dump_stack.c:17 [inline] dump_stack+0x1b2/0x281 lib/dump_stack.c:58 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1258 check_prev_add kernel/locking/lockdep.c:1905 [inline] check_prevs_add kernel/locking/lockdep.c:2022 [inline] validate_chain kernel/locking/lockdep.c:2464 [inline] __lock_acquire+0x2e0e/0x3f20 kernel/locking/lockdep.c:3491 lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998 __mutex_lock_common kernel/locking/mutex.c:756 [inline] __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893 unregister_netdevice_notifier+0x5e/0x2b0 net/core/dev.c:1630 tee_tg_destroy+0x5c/0xb0 net/netfilter/xt_TEE.c:123 cleanup_entry+0x1fd/0x2d0 net/ipv4/netfilter/ip_tables.c:666 __do_replace+0x38d/0x570 net/ipv4/netfilter/ip_tables.c:1086 do_replace net/ipv4/netfilter/ip_tables.c:1142 [inline] do_ipt_set_ctl+0x256/0x3a0 net/ipv4/netfilter/ip_tables.c:1676 nf_sockopt net/netfilter/nf_sockopt.c:106 [inline] nf_setsockopt+0x5f/0xb0 net/netfilter/nf_sockopt.c:115 ip_setsockopt net/ipv4/ip_sockglue.c:1255 [inline] ip_setsockopt+0x94/0xb0 net/ipv4/ip_sockglue.c:1240 tcp_setsockopt+0x7b/0xc0 net/ipv4/tcp.c:2830 SYSC_setsockopt net/socket.c:1865 [inline] SyS_setsockopt+0x110/0x1e0 net/socket.c:1844 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x46/0xbb RIP: 0033:0x7f4bff235bfa RSP: 002b:00007ffda3e43e88 EFLAGS: 00000202 ORIG_RAX: 0000000000000036 RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f4bff235bfa RDX: 0000000000000040 RSI: 0000000000000000 RDI: 0000000000000003 RBP: 00007ffda3e43eb0 R08: 00000000000002d8 R09: ffffffffffff0000 R10: 00007f4bff32bd80 R11: 0000000000000202 R12: 00007ffda3e43f10 R13: 0000000000000003 R14: 00007ffda3e43eac R15: 00007f4bff32bd20 FAT-fs (loop1): Directory bread(block 3) failed BTRFS info (device loop4): disk space caching is enabled BTRFS info (device loop4): has skinny extents FAT-fs (loop1): Directory bread(block 4) failed FAT-fs (loop1): Directory bread(block 5) failed FAT-fs (loop1): Directory bread(block 6) failed BTRFS error (device loop4): open_ctree failed BTRFS info (device loop4): disk space caching is enabled FAT-fs (loop1): Directory bread(block 3) failed BTRFS info (device loop4): has skinny extents FAT-fs (loop1): Directory bread(block 4) failed FAT-fs (loop2): Directory bread(block 3) failed FAT-fs (loop1): Directory bread(block 5) failed FAT-fs (loop2): Directory bread(block 4) failed FAT-fs (loop1): Directory bread(block 6) failed FAT-fs (loop2): Directory bread(block 5) failed FAT-fs (loop2): Directory bread(block 6) failed FAT-fs (loop2): Directory bread(block 3) failed FAT-fs (loop2): Directory bread(block 4) failed FAT-fs (loop2): Directory bread(block 5) failed FAT-fs (loop2): Directory bread(block 6) failed FAT-fs (loop1): Directory bread(block 3) failed BTRFS info (device loop4): disk space caching is enabled FAT-fs (loop1): Directory bread(block 4) failed BTRFS info (device loop4): has skinny extents FAT-fs (loop1): Directory bread(block 5) failed FAT-fs (loop1): Directory bread(block 6) failed FAT-fs (loop2): Directory bread(block 3) failed FAT-fs (loop2): Directory bread(block 4) failed print_req_error: I/O error, dev loop1, sector 0 FAT-fs (loop2): Directory bread(block 5) failed FAT-fs (loop1): Directory bread(block 3) failed FAT-fs (loop2): Directory bread(block 6) failed BTRFS info (device loop4): disk space caching is enabled FAT-fs (loop1): Directory bread(block 4) failed FAT-fs (loop1): Directory bread(block 5) failed BTRFS info (device loop4): has skinny extents FAT-fs (loop1): Directory bread(block 6) failed sd 0:0:1:0: PR command failed: 134217730 sd 0:0:1:0: Sense Key : Illegal Request [current] sd 0:0:1:0: Add. Sense: Invalid command operation code EXT4-fs (loop4): mounted filesystem without journal. Opts: ,errors=continue sd 0:0:1:0: PR command failed: 134217730 sd 0:0:1:0: Sense Key : Illegal Request [current] sd 0:0:1:0: Add. Sense: Invalid command operation code unregister_netdevice: waiting for ip6gre0 to become free. Usage count = -1 EXT4-fs (loop4): mounted filesystem without journal. Opts: ,errors=continue sd 0:0:1:0: PR command failed: 134217730 sd 0:0:1:0: Sense Key : Illegal Request [current] sd 0:0:1:0: Add. Sense: Invalid command operation code EXT4-fs (loop4): mounted filesystem without journal. Opts: ,errors=continue EXT4-fs (loop4): mounted filesystem without journal. Opts: ,errors=continue sd 0:0:1:0: PR command failed: 134217730 sd 0:0:1:0: Sense Key : Illegal Request [current] sd 0:0:1:0: Add. Sense: Invalid command operation code capability: warning: `syz-executor.5' uses deprecated v2 capabilities in a way that may be insecure device erspan1 entered promiscuous mode device erspan1 entered promiscuous mode FAT-fs (loop2): Invalid FSINFO signature: 0x00000000, 0x00000000 (sector = 1) device erspan1 entered promiscuous mode FAT-fs (loop2): Invalid FSINFO signature: 0x00000000, 0x00000000 (sector = 1) FAT-fs (loop2): Invalid FSINFO signature: 0x00000000, 0x00000000 (sector = 1) FAT-fs (loop2): Invalid FSINFO signature: 0x00000000, 0x00000000 (sector = 1) audit: type=1804 audit(1665087357.136:70): pid=14287 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.4" name="/root/syzkaller-testdir3256775005/syzkaller.GuPO78/157/file1/bus" dev="loop4" ino=26 res=1 FAT-fs (loop2): Invalid FSINFO signature: 0x00000000, 0x00000000 (sector = 1) attempt to access beyond end of device loop4: rw=0, want=88, limit=87 audit: type=1800 audit(1665087357.136:71): pid=14287 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.4" name="bus" dev="loop4" ino=26 res=0 audit: type=1804 audit(1665087357.436:72): pid=14317 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.4" name="/root/syzkaller-testdir3256775005/syzkaller.GuPO78/158/file1/bus" dev="loop4" ino=27 res=1 FAT-fs (loop2): Invalid FSINFO signature: 0x00000000, 0x00000000 (sector = 1) audit: type=1800 audit(1665087357.456:73): pid=14317 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.4" name="bus" dev="loop4" ino=27 res=0 attempt to access beyond end of device loop4: rw=0, want=88, limit=87 audit: type=1804 audit(1665087357.486:74): pid=14324 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.5" name="/root/syzkaller-testdir721744001/syzkaller.5BYL6L/203/bus" dev="sda1" ino=13907 res=1 audit: type=1800 audit(1665087357.486:75): pid=14324 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.5" name="bus" dev="sda1" ino=13907 res=0 audit: type=1804 audit(1665087357.756:76): pid=14356 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.4" name="/root/syzkaller-testdir3256775005/syzkaller.GuPO78/159/file1/bus" dev="loop4" ino=29 res=1 audit: type=1800 audit(1665087357.756:77): pid=14356 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.4" name="bus" dev="loop4" ino=29 res=0 attempt to access beyond end of device loop4: rw=0, want=88, limit=87 audit: type=1804 audit(1665087358.346:78): pid=14376 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.5" name="/root/syzkaller-testdir721744001/syzkaller.5BYL6L/204/bus" dev="sda1" ino=14393 res=1 attempt to access beyond end of device loop4: rw=0, want=88, limit=87 audit: type=1800 audit(1665087358.356:79): pid=14376 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.5" name="bus" dev="sda1" ino=14393 res=0