====================================================== WARNING: possible circular locking dependency detected 5.11.0-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor330/8045 is trying to acquire lock: ffff88802668a3d8 (&rs->rs_recv_lock){...-}-{2:2}, at: rds_wake_sk_sleep+0x1a/0xc0 net/rds/af_rds.c:109 but task is already holding lock: ffff88802bd09100 (&rm->m_rs_lock){..-.}-{2:2}, at: rds_send_remove_from_sock+0x1e6/0x960 net/rds/send.c:628 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&rm->m_rs_lock){..-.}-{2:2}: __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0x39/0x50 kernel/locking/spinlock.c:159 rds_message_purge net/rds/message.c:138 [inline] rds_message_put+0x16d/0xc60 net/rds/message.c:180 rds_clear_recv_queue+0x1c5/0x350 net/rds/recv.c:771 rds_release+0xca/0x350 net/rds/af_rds.c:73 __sock_release+0xbb/0x270 net/socket.c:597 sock_close+0xf/0x20 net/socket.c:1256 __fput+0x204/0x870 fs/file_table.c:280 task_work_run+0xc0/0x160 kernel/task_work.c:140 tracehook_notify_resume include/linux/tracehook.h:189 [inline] exit_to_user_mode_loop kernel/entry/common.c:174 [inline] exit_to_user_mode_prepare+0x249/0x250 kernel/entry/common.c:201 __syscall_exit_to_user_mode_work kernel/entry/common.c:283 [inline] syscall_exit_to_user_mode+0x19/0x60 kernel/entry/common.c:294 entry_SYSCALL_64_after_hwframe+0x44/0xa9 -> #0 (&rs->rs_recv_lock){...-}-{2:2}: check_prev_add kernel/locking/lockdep.c:2868 [inline] check_prevs_add kernel/locking/lockdep.c:2993 [inline] validate_chain kernel/locking/lockdep.c:3608 [inline] __lock_acquire+0x2b3b/0x57d0 kernel/locking/lockdep.c:4832 lock_acquire kernel/locking/lockdep.c:5442 [inline] lock_acquire+0x1a8/0x720 kernel/locking/lockdep.c:5407 __raw_read_lock_irqsave include/linux/rwlock_api_smp.h:159 [inline] _raw_read_lock_irqsave+0x45/0x90 kernel/locking/spinlock.c:231 rds_wake_sk_sleep+0x1a/0xc0 net/rds/af_rds.c:109 rds_send_remove_from_sock+0x250/0x960 net/rds/send.c:634 rds_send_path_drop_acked+0x276/0x360 net/rds/send.c:710 rds_tcp_write_space+0x196/0x5a0 net/rds/tcp_send.c:198 tcp_new_space net/ipv4/tcp_input.c:5378 [inline] tcp_check_space+0x353/0x5f0 net/ipv4/tcp_input.c:5387 tcp_data_snd_check net/ipv4/tcp_input.c:5396 [inline] tcp_rcv_established+0x776/0x1f50 net/ipv4/tcp_input.c:5890 tcp_v4_do_rcv+0x4f0/0x750 net/ipv4/tcp_ipv4.c:1676 sk_backlog_rcv include/net/sock.h:1016 [inline] __release_sock+0x113/0x350 net/core/sock.c:2542 release_sock+0x4a/0x170 net/core/sock.c:3066 rds_send_xmit+0x1010/0x2350 net/rds/send.c:422 rds_sendmsg+0x1d84/0x28d0 net/rds/send.c:1382 sock_sendmsg_nosec net/socket.c:652 [inline] sock_sendmsg+0xab/0xe0 net/socket.c:672 __sys_sendto+0x1a4/0x270 net/socket.c:1975 __do_sys_sendto net/socket.c:1987 [inline] __se_sys_sendto net/socket.c:1983 [inline] __x64_sys_sendto+0xd8/0x1b0 net/socket.c:1983 do_syscall_64+0x2d/0x40 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&rm->m_rs_lock); lock(&rs->rs_recv_lock); lock(&rm->m_rs_lock); lock(&rs->rs_recv_lock); *** DEADLOCK *** 3 locks held by syz-executor330/8045: #0: ffff888027a70ce0 (k-sk_lock-AF_INET){+.+.}-{0:0}, at: lock_sock include/net/sock.h:1594 [inline] #0: ffff888027a70ce0 (k-sk_lock-AF_INET){+.+.}-{0:0}, at: tcp_sock_set_cork+0xe/0x70 net/ipv4/tcp.c:3146 #1: ffff888027a70f88 (k-clock-AF_INET){++.-}-{2:2}, at: rds_tcp_write_space+0x20/0x5a0 net/rds/tcp_send.c:184 #2: ffff88802bd09100 (&rm->m_rs_lock){..-.}-{2:2}, at: rds_send_remove_from_sock+0x1e6/0x960 net/rds/send.c:628 stack backtrace: CPU: 1 PID: 8045 Comm: syz-executor330 Not tainted 5.11.0-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:79 [inline] dump_stack+0x9a/0xcc lib/dump_stack.c:120 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2117 check_prev_add kernel/locking/lockdep.c:2868 [inline] check_prevs_add kernel/locking/lockdep.c:2993 [inline] validate_chain kernel/locking/lockdep.c:3608 [inline] __lock_acquire+0x2b3b/0x57d0 kernel/locking/lockdep.c:4832 lock_acquire kernel/locking/lockdep.c:5442 [inline] lock_acquire+0x1a8/0x720 kernel/locking/lockdep.c:5407 __raw_read_lock_irqsave include/linux/rwlock_api_smp.h:159 [inline] _raw_read_lock_irqsave+0x45/0x90 kernel/locking/spinlock.c:231 rds_wake_sk_sleep+0x1a/0xc0 net/rds/af_rds.c:109 rds_send_remove_from_sock+0x250/0x960 net/rds/send.c:634 rds_send_path_drop_acked+0x276/0x360 net/rds/send.c:710 rds_tcp_write_space+0x196/0x5a0 net/rds/tcp_send.c:198 tcp_new_space net/ipv4/tcp_input.c:5378 [inline] tcp_check_space+0x353/0x5f0 net/ipv4/tcp_input.c:5387 tcp_data_snd_check net/ipv4/tcp_input.c:5396 [inline] tcp_rcv_established+0x776/0x1f50 net/ipv4/tcp_input.c:5890 tcp_v4_do_rcv+0x4f0/0x750 net/ipv4/tcp_ipv4.c:1676 sk_backlog_rcv include/net/sock.h:1016 [inline] __release_sock+0x113/0x350 net/core/sock.c:2542 release_sock+0x4a/0x170 net/core/sock.c:3066 rds_send_xmit+0x1010/0x2350 net/rds/send.c:422 rds_sendmsg+0x1d84/0x28d0 net/rds/send.c:1382 sock_sendmsg_nosec net/socket.c:652 [inline] sock_sendmsg+0xab/0xe0 net/socket.c:672 __sys_sendto+0x1a4/0x270 net/socket.c:1975 __do_sys_sendto net/socket.c:1987 [inline] __se_sys_sendto net/socket.c:1983 [inline] __x64_sys_sendto+0xd8/0x1b0 net/socket.c:1983 do_syscall_64+0x2d/0x40 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 RIP: 0033:0x7f3ff6cbe7d9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 a1 15 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f3ff6c6c308 EFLAGS: 00000246 ORIG_RAX: 000000000000002c RAX: ffffffffffffffda RBX: 00007f3ff6d474c8 RCX: 00007f3ff6cbe7d9 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000005 RBP: 00007f3ff6d474c0 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 00007f3ff6d14494 R13: 00007ffe84ee5f8f R14: 00007f3ff6c6c400 R15: 0000000000022000