====================================================== WARNING: possible circular locking dependency detected 6.9.0-syzkaller-10323-g8f6a15f095a6 #0 Not tainted ------------------------------------------------------ syz-executor.1/15343 is trying to acquire lock: ffff88802aab8ae8 (&sdp->sd_quota_mutex){+.+.}-{3:3}, at: do_qc+0xac/0x5e0 fs/gfs2/quota.c:720 but task is already holding lock: ffff888058324260 (&ip->i_rw_mutex){++++}-{3:3}, at: sweep_bh_for_rgrps fs/gfs2/bmap.c:1529 [inline] ffff888058324260 (&ip->i_rw_mutex){++++}-{3:3}, at: punch_hole+0x1bb6/0x37b0 fs/gfs2/bmap.c:1853 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ip->i_rw_mutex){++++}-{3:3}: down_read+0x9a/0x330 kernel/locking/rwsem.c:1526 __gfs2_iomap_get+0x146/0x1850 fs/gfs2/bmap.c:859 gfs2_iomap_get+0xb1/0x1f0 fs/gfs2/bmap.c:1413 bh_get+0x25e/0x6e0 fs/gfs2/quota.c:417 qdsb_get.part.0+0x116/0x3e0 fs/gfs2/quota.c:566 qdsb_get fs/gfs2/quota.c:678 [inline] gfs2_quota_hold+0x2be/0x7d0 fs/gfs2/quota.c:646 punch_hole+0xe3c/0x37b0 fs/gfs2/bmap.c:1814 gfs2_iomap_end+0x422/0x780 fs/gfs2/bmap.c:1174 iomap_iter+0x249/0x10b0 fs/iomap/iter.c:79 iomap_file_buffered_write+0x219/0xc20 fs/iomap/buffered-io.c:1025 gfs2_file_buffered_write+0x3ee/0xaa0 fs/gfs2/file.c:1060 gfs2_file_write_iter+0x97d/0x10b0 fs/gfs2/file.c:1164 call_write_iter include/linux/fs.h:2114 [inline] new_sync_write fs/read_write.c:497 [inline] vfs_write+0x6b6/0x1140 fs/read_write.c:590 ksys_write+0x12f/0x260 fs/read_write.c:643 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x260 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&sdp->sd_quota_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x2478/0x3b30 kernel/locking/lockdep.c:5137 lock_acquire kernel/locking/lockdep.c:5754 [inline] lock_acquire+0x1b1/0x560 kernel/locking/lockdep.c:5719 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752 do_qc+0xac/0x5e0 fs/gfs2/quota.c:720 gfs2_quota_change+0x36a/0x550 fs/gfs2/quota.c:1315 punch_hole+0x29c0/0x37b0 fs/gfs2/bmap.c:1954 gfs2_iomap_end+0x422/0x780 fs/gfs2/bmap.c:1174 iomap_iter+0x249/0x10b0 fs/iomap/iter.c:79 iomap_file_buffered_write+0x219/0xc20 fs/iomap/buffered-io.c:1025 gfs2_file_buffered_write+0x3ee/0xaa0 fs/gfs2/file.c:1060 gfs2_file_write_iter+0x97d/0x10b0 fs/gfs2/file.c:1164 call_write_iter include/linux/fs.h:2114 [inline] new_sync_write fs/read_write.c:497 [inline] vfs_write+0x6b6/0x1140 fs/read_write.c:590 ksys_write+0x12f/0x260 fs/read_write.c:643 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x260 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ip->i_rw_mutex); lock(&sdp->sd_quota_mutex); lock(&ip->i_rw_mutex); lock(&sdp->sd_quota_mutex); *** DEADLOCK *** 6 locks held by syz-executor.1/15343: #0: ffff88807e5320c8 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0xeb/0x180 fs/file.c:1191 #1: ffff888020402420 (sb_writers#35){.+.+}-{0:0}, at: ksys_write+0x12f/0x260 fs/read_write.c:643 #2: ffff888058323dc8 (&sb->s_type->i_mutex_key#42){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:791 [inline] #2: ffff888058323dc8 (&sb->s_type->i_mutex_key#42){+.+.}-{3:3}, at: gfs2_file_write_iter+0x1fb/0x10b0 fs/gfs2/file.c:1115 #3: ffff888020402610 (sb_internal#5){.+.+}-{0:0}, at: gfs2_trans_begin+0x74/0x100 fs/gfs2/trans.c:118 #4: ffff88802aab9060 (&sdp->sd_log_flush_lock){++++}-{3:3}, at: __gfs2_trans_begin+0x533/0xb80 fs/gfs2/trans.c:87 #5: ffff888058324260 (&ip->i_rw_mutex){++++}-{3:3}, at: sweep_bh_for_rgrps fs/gfs2/bmap.c:1529 [inline] #5: ffff888058324260 (&ip->i_rw_mutex){++++}-{3:3}, at: punch_hole+0x1bb6/0x37b0 fs/gfs2/bmap.c:1853 stack backtrace: CPU: 1 PID: 15343 Comm: syz-executor.1 Not tainted 6.9.0-syzkaller-10323-g8f6a15f095a6 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:114 check_noncircular+0x31a/0x400 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x2478/0x3b30 kernel/locking/lockdep.c:5137 lock_acquire kernel/locking/lockdep.c:5754 [inline] lock_acquire+0x1b1/0x560 kernel/locking/lockdep.c:5719 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752 do_qc+0xac/0x5e0 fs/gfs2/quota.c:720 gfs2_quota_change+0x36a/0x550 fs/gfs2/quota.c:1315 punch_hole+0x29c0/0x37b0 fs/gfs2/bmap.c:1954 gfs2_iomap_end+0x422/0x780 fs/gfs2/bmap.c:1174 iomap_iter+0x249/0x10b0 fs/iomap/iter.c:79 iomap_file_buffered_write+0x219/0xc20 fs/iomap/buffered-io.c:1025 gfs2_file_buffered_write+0x3ee/0xaa0 fs/gfs2/file.c:1060 gfs2_file_write_iter+0x97d/0x10b0 fs/gfs2/file.c:1164 call_write_iter include/linux/fs.h:2114 [inline] new_sync_write fs/read_write.c:497 [inline] vfs_write+0x6b6/0x1140 fs/read_write.c:590 ksys_write+0x12f/0x260 fs/read_write.c:643 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x260 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f54d387cee9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f54d466c0c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 00007f54d39abf80 RCX: 00007f54d387cee9 RDX: 00000000ffffff6a RSI: 0000000020000000 RDI: 0000000000000005 RBP: 00007f54d38c949e R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007f54d39abf80 R15: 00007ffc7d399288