======================================================
WARNING: possible circular locking dependency detected
6.2.0-next-20230223-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.3/22884 is trying to acquire lock:
ffff888040278288 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x707/0x18d0 fs/ext4/inode.c:644

but task is already holding lock:
ffff888027dae208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x8f/0x250 fs/quota/quota_v2.c:354

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}:
       down_read+0x3d/0x50 kernel/locking/rwsem.c:1520
       v2_read_dquot+0x4d/0x120 fs/quota/quota_v2.c:332
       dquot_acquire+0x1b3/0x6c0 fs/quota/dquot.c:435
       ext4_acquire_dquot+0x2b1/0x3d0 fs/ext4/super.c:6724
       dqget+0x67d/0x1080 fs/quota/dquot.c:914
       __dquot_initialize+0x560/0xbe0 fs/quota/dquot.c:1492
       ext4_process_orphan+0x47/0x410 fs/ext4/orphan.c:329
       ext4_orphan_cleanup+0x6e5/0x1110 fs/ext4/orphan.c:474
       __ext4_fill_super fs/ext4/super.c:5500 [inline]
       ext4_fill_super+0xa22c/0xb1f0 fs/ext4/super.c:5628
       get_tree_bdev+0x444/0x760 fs/super.c:1294
       vfs_get_tree+0x8d/0x350 fs/super.c:1501
       do_new_mount fs/namespace.c:3042 [inline]
       path_mount+0x1342/0x1e40 fs/namespace.c:3372
       do_mount fs/namespace.c:3385 [inline]
       __do_sys_mount fs/namespace.c:3594 [inline]
       __se_sys_mount fs/namespace.c:3571 [inline]
       __x64_sys_mount+0x283/0x300 fs/namespace.c:3571
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #1 (&dquot->dq_lock){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x12f/0x1350 kernel/locking/mutex.c:747
       dquot_commit+0x51/0x570 fs/quota/dquot.c:479
       ext4_write_dquot+0x25f/0x330 fs/ext4/super.c:6708
       ext4_mark_dquot_dirty fs/ext4/super.c:6756 [inline]
       ext4_mark_dquot_dirty+0x115/0x1b0 fs/ext4/super.c:6750
       mark_dquot_dirty fs/quota/dquot.c:346 [inline]
       mark_all_dquot_dirty fs/quota/dquot.c:384 [inline]
       __dquot_alloc_space+0x5f9/0xb80 fs/quota/dquot.c:1722
       dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline]
       dquot_alloc_space include/linux/quotaops.h:313 [inline]
       dquot_alloc_block include/linux/quotaops.h:337 [inline]
       ext4_mb_new_blocks+0x60f/0x51f0 fs/ext4/mballoc.c:5571
       ext4_ext_map_blocks+0x233d/0x6310 fs/ext4/extents.c:4286
       ext4_map_blocks+0x779/0x18d0 fs/ext4/inode.c:651
       ext4_getblk+0x61f/0x850 fs/ext4/inode.c:863
       ext4_bread+0x2e/0x190 fs/ext4/inode.c:919
       ext4_append+0x23b/0x540 fs/ext4/namei.c:83
       ext4_init_new_dir+0x262/0x4c0 fs/ext4/namei.c:2956
       ext4_mkdir+0x3d3/0xb20 fs/ext4/namei.c:3002
       vfs_mkdir+0x242/0x460 fs/namei.c:4038
       do_mkdirat+0x28d/0x310 fs/namei.c:4061
       __do_sys_mkdirat fs/namei.c:4076 [inline]
       __se_sys_mkdirat fs/namei.c:4074 [inline]
       __x64_sys_mkdirat+0x119/0x170 fs/namei.c:4074
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (&ei->i_data_sem/2){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3098 [inline]
       check_prevs_add kernel/locking/lockdep.c:3217 [inline]
       validate_chain kernel/locking/lockdep.c:3832 [inline]
       __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056
       lock_acquire.part.0+0x11a/0x370 kernel/locking/lockdep.c:5669
       down_write+0x92/0x200 kernel/locking/rwsem.c:1573
       ext4_map_blocks+0x707/0x18d0 fs/ext4/inode.c:644
       ext4_getblk+0x61f/0x850 fs/ext4/inode.c:863
       ext4_bread+0x2e/0x190 fs/ext4/inode.c:919
       ext4_quota_write+0x218/0x620 fs/ext4/super.c:7089
       write_blk+0x12e/0x220 fs/quota/quota_tree.c:64
       find_free_dqentry fs/quota/quota_tree.c:312 [inline]
       do_insert_tree+0xd82/0x12d0 fs/quota/quota_tree.c:373
       do_insert_tree+0x488/0x12d0 fs/quota/quota_tree.c:375
       do_insert_tree+0x488/0x12d0 fs/quota/quota_tree.c:375
       do_insert_tree+0x488/0x12d0 fs/quota/quota_tree.c:375
       dq_insert_tree fs/quota/quota_tree.c:401 [inline]
       qtree_write_dquot+0x3b4/0x570 fs/quota/quota_tree.c:420
       v2_write_dquot+0x120/0x250 fs/quota/quota_v2.c:358
       dquot_acquire+0x3d1/0x6c0 fs/quota/dquot.c:444
       ext4_acquire_dquot+0x2b1/0x3d0 fs/ext4/super.c:6724
       dqget+0x67d/0x1080 fs/quota/dquot.c:914
       __dquot_initialize+0x560/0xbe0 fs/quota/dquot.c:1492
       ext4_create+0x94/0x4e0 fs/ext4/namei.c:2802
       lookup_open.isra.0+0x105a/0x1400 fs/namei.c:3416
       open_last_lookups fs/namei.c:3484 [inline]
       path_openat+0x975/0x2750 fs/namei.c:3712
       do_filp_open+0x1ba/0x410 fs/namei.c:3742
       do_sys_openat2+0x16d/0x4c0 fs/open.c:1312
       do_sys_open fs/open.c:1328 [inline]
       __do_sys_open fs/open.c:1336 [inline]
       __se_sys_open fs/open.c:1332 [inline]
       __x64_sys_open+0x11d/0x1c0 fs/open.c:1332
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

Chain exists of:
  &ei->i_data_sem/2 --> &dquot->dq_lock --> &s->s_dquot.dqio_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&s->s_dquot.dqio_sem);
                               lock(&dquot->dq_lock);
                               lock(&s->s_dquot.dqio_sem);
  lock(&ei->i_data_sem/2);

 *** DEADLOCK ***

4 locks held by syz-executor.3/22884:
 #0: ffff888027dae460 (sb_writers#4){.+.+}-{0:0}, at: open_last_lookups fs/namei.c:3473 [inline]
 #0: ffff888027dae460 (sb_writers#4){.+.+}-{0:0}, at: path_openat+0x2716/0x2750 fs/namei.c:3712
 #1: ffff88803035e850 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #1: ffff88803035e850 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: open_last_lookups fs/namei.c:3481 [inline]
 #1: ffff88803035e850 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: path_openat+0x90f/0x2750 fs/namei.c:3712
 #2: ffff88803000c7a8 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_acquire+0x51/0x6c0 fs/quota/dquot.c:432
 #3: ffff888027dae208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x8f/0x250 fs/quota/quota_v2.c:354

stack backtrace:
CPU: 0 PID: 22884 Comm: syz-executor.3 Not tainted 6.2.0-next-20230223-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/21/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xd9/0x150 lib/dump_stack.c:106
 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2178
 check_prev_add kernel/locking/lockdep.c:3098 [inline]
 check_prevs_add kernel/locking/lockdep.c:3217 [inline]
 validate_chain kernel/locking/lockdep.c:3832 [inline]
 __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056
 lock_acquire.part.0+0x11a/0x370 kernel/locking/lockdep.c:5669
 down_write+0x92/0x200 kernel/locking/rwsem.c:1573
 ext4_map_blocks+0x707/0x18d0 fs/ext4/inode.c:644
 ext4_getblk+0x61f/0x850 fs/ext4/inode.c:863
 ext4_bread+0x2e/0x190 fs/ext4/inode.c:919
 ext4_quota_write+0x218/0x620 fs/ext4/super.c:7089
 write_blk+0x12e/0x220 fs/quota/quota_tree.c:64
 find_free_dqentry fs/quota/quota_tree.c:312 [inline]
 do_insert_tree+0xd82/0x12d0 fs/quota/quota_tree.c:373
 do_insert_tree+0x488/0x12d0 fs/quota/quota_tree.c:375
 do_insert_tree+0x488/0x12d0 fs/quota/quota_tree.c:375
 do_insert_tree+0x488/0x12d0 fs/quota/quota_tree.c:375
 dq_insert_tree fs/quota/quota_tree.c:401 [inline]
 qtree_write_dquot+0x3b4/0x570 fs/quota/quota_tree.c:420
 v2_write_dquot+0x120/0x250 fs/quota/quota_v2.c:358
 dquot_acquire+0x3d1/0x6c0 fs/quota/dquot.c:444
 ext4_acquire_dquot+0x2b1/0x3d0 fs/ext4/super.c:6724
 dqget+0x67d/0x1080 fs/quota/dquot.c:914
 __dquot_initialize+0x560/0xbe0 fs/quota/dquot.c:1492
 ext4_create+0x94/0x4e0 fs/ext4/namei.c:2802
 lookup_open.isra.0+0x105a/0x1400 fs/namei.c:3416
 open_last_lookups fs/namei.c:3484 [inline]
 path_openat+0x975/0x2750 fs/namei.c:3712
 do_filp_open+0x1ba/0x410 fs/namei.c:3742
 do_sys_openat2+0x16d/0x4c0 fs/open.c:1312
 do_sys_open fs/open.c:1328 [inline]
 __do_sys_open fs/open.c:1336 [inline]
 __se_sys_open fs/open.c:1332 [inline]
 __x64_sys_open+0x11d/0x1c0 fs/open.c:1332
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f959688c0f9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f95975b6168 EFLAGS: 00000246 ORIG_RAX: 0000000000000002
RAX: ffffffffffffffda RBX: 00007f95969abf80 RCX: 00007f959688c0f9
RDX: 0000000000000000 RSI: 000000000014937e RDI: 0000000020000180
RBP: 00007f95968e7ae9 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffdc4b2a0ff R14: 00007f95975b6300 R15: 0000000000022000
 </TASK>