EXT4-fs (loop2): orphan cleanup on readonly fs ====================================================== WARNING: possible circular locking dependency detected 6.1.119-syzkaller #0 Not tainted ------------------------------------------------------ syz.2.581/5866 is trying to acquire lock: ffff888070ae20a0 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x379/0x1cb0 fs/ext4/inode.c:603 but task is already holding lock: ffff88801c2c4208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:335 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:335 dquot_acquire+0x188/0x680 fs/quota/dquot.c:463 ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6797 dqget+0x762/0xe90 fs/quota/dquot.c:986 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1515 ext4_mkdir+0x197/0xce0 fs/ext4/namei.c:3059 vfs_mkdir+0x3b6/0x590 fs/namei.c:4106 do_mkdirat+0x225/0x360 fs/namei.c:4131 __do_sys_mkdir fs/namei.c:4151 [inline] __se_sys_mkdir fs/namei.c:4149 [inline] __x64_sys_mkdir+0x6a/0x80 fs/namei.c:4149 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #1 (&dquot->dq_lock){+.+.}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 dquot_commit+0x57/0x510 fs/quota/dquot.c:507 ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6777 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412 __dquot_alloc_space+0xb68/0x10e0 fs/quota/dquot.c:1750 dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline] dquot_alloc_space include/linux/quotaops.h:313 [inline] dquot_alloc_block include/linux/quotaops.h:337 [inline] ext4_mb_new_blocks+0x1302/0x4b80 fs/ext4/mballoc.c:5727 ext4_ext_map_blocks+0x1c1c/0x7ab0 fs/ext4/extents.c:4339 ext4_map_blocks+0xa2b/0x1cb0 fs/ext4/inode.c:678 _ext4_get_block+0x23b/0x660 fs/ext4/inode.c:821 ext4_block_write_begin+0x631/0x1400 fs/ext4/inode.c:1123 ext4_write_begin+0x638/0xf80 ext4_da_write_begin+0x30a/0x9c0 fs/ext4/inode.c:2999 generic_perform_write+0x2fc/0x5e0 mm/filemap.c:3845 ext4_buffered_write_iter+0x122/0x3a0 fs/ext4/file.c:285 ext4_file_write_iter+0x1d7/0x1930 do_iter_write+0x6e6/0xc40 fs/read_write.c:861 vfs_writev fs/read_write.c:934 [inline] do_pwritev+0x216/0x360 fs/read_write.c:1031 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #0 (&ei->i_data_sem/2){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 ext4_map_blocks+0x379/0x1cb0 fs/ext4/inode.c:603 ext4_getblk+0x1eb/0x7c0 fs/ext4/inode.c:889 ext4_bread+0x2a/0x170 fs/ext4/inode.c:945 ext4_quota_read+0x1a1/0x2c0 fs/ext4/super.c:7125 read_blk fs/quota/quota_tree.c:61 [inline] find_tree_dqentry+0x1cd/0xf70 fs/quota/quota_tree.c:671 find_tree_dqentry+0x6a8/0xf70 fs/quota/quota_tree.c:698 find_tree_dqentry+0x6a8/0xf70 fs/quota/quota_tree.c:698 find_tree_dqentry+0x6a8/0xf70 fs/quota/quota_tree.c:698 find_dqentry fs/quota/quota_tree.c:716 [inline] qtree_read_dquot+0x546/0x7f0 fs/quota/quota_tree.c:736 v2_read_dquot+0xbe/0x100 fs/quota/quota_v2.c:336 dquot_acquire+0x188/0x680 fs/quota/dquot.c:463 ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6797 dqget+0x762/0xe90 fs/quota/dquot.c:986 __dquot_initialize+0x45e/0xea0 fs/quota/dquot.c:1515 ext4_process_orphan+0x57/0x2d0 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0xb70/0x1400 fs/ext4/orphan.c:474 __ext4_fill_super fs/ext4/super.c:5534 [inline] ext4_fill_super+0x83ff/0x8b50 fs/ext4/super.c:5665 get_tree_bdev+0x3fe/0x620 fs/super.c:1366 vfs_get_tree+0x88/0x270 fs/super.c:1573 do_new_mount+0x2ba/0xb40 fs/namespace.c:3056 do_mount fs/namespace.c:3399 [inline] __do_sys_mount fs/namespace.c:3607 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3584 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 other info that might help us debug this: Chain exists of: &ei->i_data_sem/2 --> &dquot->dq_lock --> &s->s_dquot.dqio_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&s->s_dquot.dqio_sem); lock(&dquot->dq_lock); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); *** DEADLOCK *** 3 locks held by syz.2.581/5866: #0: ffff88801c2c40e0 (&type->s_umount_key#28/1){+.+.}-{3:3}, at: alloc_super+0x217/0x930 fs/super.c:228 #1: ffff888071308968 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_acquire+0x64/0x680 fs/quota/dquot.c:460 #2: ffff88801c2c4208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:335 stack backtrace: CPU: 1 PID: 5866 Comm: syz.2.581 Not tainted 6.1.119-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 ext4_map_blocks+0x379/0x1cb0 fs/ext4/inode.c:603 ext4_getblk+0x1eb/0x7c0 fs/ext4/inode.c:889 ext4_bread+0x2a/0x170 fs/ext4/inode.c:945 ext4_quota_read+0x1a1/0x2c0 fs/ext4/super.c:7125 read_blk fs/quota/quota_tree.c:61 [inline] find_tree_dqentry+0x1cd/0xf70 fs/quota/quota_tree.c:671 find_tree_dqentry+0x6a8/0xf70 fs/quota/quota_tree.c:698 find_tree_dqentry+0x6a8/0xf70 fs/quota/quota_tree.c:698 find_tree_dqentry+0x6a8/0xf70 fs/quota/quota_tree.c:698 find_dqentry fs/quota/quota_tree.c:716 [inline] qtree_read_dquot+0x546/0x7f0 fs/quota/quota_tree.c:736 v2_read_dquot+0xbe/0x100 fs/quota/quota_v2.c:336 dquot_acquire+0x188/0x680 fs/quota/dquot.c:463 ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6797 dqget+0x762/0xe90 fs/quota/dquot.c:986 __dquot_initialize+0x45e/0xea0 fs/quota/dquot.c:1515 ext4_process_orphan+0x57/0x2d0 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0xb70/0x1400 fs/ext4/orphan.c:474 __ext4_fill_super fs/ext4/super.c:5534 [inline] ext4_fill_super+0x83ff/0x8b50 fs/ext4/super.c:5665 get_tree_bdev+0x3fe/0x620 fs/super.c:1366 vfs_get_tree+0x88/0x270 fs/super.c:1573 do_new_mount+0x2ba/0xb40 fs/namespace.c:3056 do_mount fs/namespace.c:3399 [inline] __do_sys_mount fs/namespace.c:3607 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3584 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 RIP: 0033:0x7f0676d7ffba Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 de 1a 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f0677bede68 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00007f0677bedef0 RCX: 00007f0676d7ffba RDX: 0000000020000040 RSI: 00000000200001c0 RDI: 00007f0677bedeb0 RBP: 0000000020000040 R08: 00007f0677bedef0 R09: 0000000000014001 R10: 0000000000014001 R11: 0000000000000246 R12: 00000000200001c0 R13: 00007f0677bedeb0 R14: 000000000000051c R15: 000000000000002c EXT4-fs error (device loop2): ext4_read_block_bitmap_nowait:477: comm syz.2.581: Invalid block bitmap block 0 in block_group 0 EXT4-fs (loop2): Remounting filesystem read-only Quota error (device loop2): write_blk: dquota write failed Quota error (device loop2): qtree_write_dquot: Error -28 occurred while creating quota EXT4-fs error (device loop2): ext4_acquire_dquot:6801: comm syz.2.581: Failed to acquire dquot type 1 EXT4-fs (loop2): Remounting filesystem read-only EXT4-fs (loop2): 1 orphan inode deleted EXT4-fs (loop2): mounted filesystem without journal. Quota mode: writeback.