======================================================
WARNING: possible circular locking dependency detected
5.15.184-syzkaller #0 Not tainted
------------------------------------------------------
syz.0.14/4319 is trying to acquire lock:
ffff888078ea4650 (sb_internal#3){.+.+}-{0:0}, at: ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1258 [inline]
ffff888078ea4650 (sb_internal#3){.+.+}-{0:0}, at: ocfs2_reserve_local_alloc_bits+0xaeb/0x24c0 fs/ocfs2/localalloc.c:668

but task is already holding lock:
ffff88805d83d108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
ffff88805d83d108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x161/0x4350 fs/ocfs2/suballoc.c:782

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}:
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:787 [inline]
       ocfs2_reserve_suballoc_bits+0x161/0x4350 fs/ocfs2/suballoc.c:782
       ocfs2_reserve_cluster_bitmap_bits+0xc1/0x1c0 fs/ocfs2/suballoc.c:1128
       ocfs2_local_alloc_reserve_for_window fs/ocfs2/localalloc.c:1112 [inline]
       ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1248 [inline]
       ocfs2_reserve_local_alloc_bits+0x876/0x24c0 fs/ocfs2/localalloc.c:668
       ocfs2_reserve_clusters_with_limit+0x1bb/0xba0 fs/ocfs2/suballoc.c:1162
       ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
       ocfs2_lock_allocators+0x2f7/0x5b0 fs/ocfs2/suballoc.c:2669
       ocfs2_extend_allocation+0x397/0x1760 fs/ocfs2/file.c:588
       ocfs2_extend_no_holes+0x20b/0x490 fs/ocfs2/file.c:1030
       ocfs2_acquire_dquot+0x5fe/0xaf0 fs/ocfs2/quota_global.c:841
       dqget+0x778/0xeb0 fs/quota/dquot.c:988
       ocfs2_setattr+0xc93/0x1a10 fs/ocfs2/file.c:1236
       notify_change+0xbcd/0xee0 fs/attr.c:505
       chown_common+0x483/0x610 fs/open.c:680
       do_fchownat+0x164/0x270 fs/open.c:711
       __do_sys_lchown fs/open.c:736 [inline]
       __se_sys_lchown fs/open.c:734 [inline]
       __x64_sys_lchown+0x81/0x90 fs/open.c:734
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #7 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}:
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:787 [inline]
       ocfs2_reserve_local_alloc_bits+0x122/0x24c0 fs/ocfs2/localalloc.c:635
       ocfs2_reserve_clusters_with_limit+0x1bb/0xba0 fs/ocfs2/suballoc.c:1162
       ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
       ocfs2_lock_allocators+0x2f7/0x5b0 fs/ocfs2/suballoc.c:2669
       ocfs2_extend_allocation+0x397/0x1760 fs/ocfs2/file.c:588
       ocfs2_extend_no_holes+0x20b/0x490 fs/ocfs2/file.c:1030
       ocfs2_acquire_dquot+0x5fe/0xaf0 fs/ocfs2/quota_global.c:841
       dqget+0x778/0xeb0 fs/quota/dquot.c:988
       ocfs2_setattr+0xc93/0x1a10 fs/ocfs2/file.c:1236
       notify_change+0xbcd/0xee0 fs/attr.c:505
       chown_common+0x483/0x610 fs/open.c:680
       do_fchownat+0x164/0x270 fs/open.c:711
       __do_sys_lchown fs/open.c:736 [inline]
       __se_sys_lchown fs/open.c:734 [inline]
       __x64_sys_lchown+0x81/0x90 fs/open.c:734
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #6 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       ocfs2_lock_global_qf+0x1e5/0x270 fs/ocfs2/quota_global.c:314
       ocfs2_acquire_dquot+0x29d/0xaf0 fs/ocfs2/quota_global.c:816
       dqget+0x778/0xeb0 fs/quota/dquot.c:988
       ocfs2_setattr+0xc93/0x1a10 fs/ocfs2/file.c:1236
       notify_change+0xbcd/0xee0 fs/attr.c:505
       chown_common+0x483/0x610 fs/open.c:680
       do_fchownat+0x164/0x270 fs/open.c:711
       __do_sys_lchown fs/open.c:736 [inline]
       __se_sys_lchown fs/open.c:734 [inline]
       __x64_sys_lchown+0x81/0x90 fs/open.c:734
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #5 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}:
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:787 [inline]
       ocfs2_lock_global_qf+0x1c7/0x270 fs/ocfs2/quota_global.c:313
       ocfs2_acquire_dquot+0x29d/0xaf0 fs/ocfs2/quota_global.c:816
       dqget+0x778/0xeb0 fs/quota/dquot.c:988
       ocfs2_setattr+0xc93/0x1a10 fs/ocfs2/file.c:1236
       notify_change+0xbcd/0xee0 fs/attr.c:505
       chown_common+0x483/0x610 fs/open.c:680
       do_fchownat+0x164/0x270 fs/open.c:711
       __do_sys_lchown fs/open.c:736 [inline]
       __se_sys_lchown fs/open.c:734 [inline]
       __x64_sys_lchown+0x81/0x90 fs/open.c:734
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #4 (&dquot->dq_lock){+.+.}-{3:3}:
       __mutex_lock_common+0x1eb/0x2390 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       dquot_commit+0x5a/0x410 fs/quota/dquot.c:507
       ext4_write_dquot+0x1f0/0x360 fs/ext4/super.c:6180
       mark_dquot_dirty fs/quota/dquot.c:372 [inline]
       mark_all_dquot_dirty+0xf9/0x400 fs/quota/dquot.c:412
       __dquot_alloc_space+0x5d0/0xe20 fs/quota/dquot.c:1752
       dquot_alloc_space_nodirty include/linux/quotaops.h:297 [inline]
       dquot_alloc_space include/linux/quotaops.h:310 [inline]
       dquot_alloc_block include/linux/quotaops.h:334 [inline]
       ext4_mb_new_blocks+0xf68/0x4940 fs/ext4/mballoc.c:5739
       ext4_ext_map_blocks+0x146c/0x64e0 fs/ext4/extents.c:4339
       ext4_map_blocks+0x981/0x1b30 fs/ext4/inode.c:673
       _ext4_get_block+0x1d7/0x4e0 fs/ext4/inode.c:816
       __block_write_begin_int+0x54e/0x15a0 fs/buffer.c:2012
       __block_write_begin fs/buffer.c:2062 [inline]
       block_page_mkwrite+0x210/0x280 fs/buffer.c:2525
       ext4_page_mkwrite+0x3ed/0x1240 fs/ext4/inode.c:6234
       do_page_mkwrite+0x168/0x3c0 mm/memory.c:2922
       wp_page_shared+0x16b/0x6d0 mm/memory.c:3259
       handle_pte_fault mm/memory.c:4668 [inline]
       __handle_mm_fault mm/memory.c:4785 [inline]
       handle_mm_fault+0x1eca/0x43c0 mm/memory.c:4883
       do_user_addr_fault+0x489/0xc80 arch/x86/mm/fault.c:1357
       handle_page_fault arch/x86/mm/fault.c:1445 [inline]
       exc_page_fault+0x60/0x100 arch/x86/mm/fault.c:1501
       asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:606
       copy_user_enhanced_fast_string+0xe/0x40 arch/x86/lib/copy_user_64.S:205
       copy_user_generic arch/x86/include/asm/uaccess_64.h:37 [inline]
       raw_copy_to_user arch/x86/include/asm/uaccess_64.h:58 [inline]
       _copy_to_user+0xf0/0x130 lib/usercopy.c:40
       copy_to_user include/linux/uaccess.h:200 [inline]
       rng_dev_read+0x397/0x6c0 drivers/char/hw_random/core.c:262
       do_loop_readv_writev fs/read_write.c:-1 [inline]
       do_iter_read+0x53e/0x7c0 fs/read_write.c:792
       vfs_readv fs/read_write.c:910 [inline]
       do_preadv+0x1f9/0x330 fs/read_write.c:1002
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #3 (&ei->i_data_sem){++++}-{3:3}:
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       ext4_truncate+0x96d/0x10d0 fs/ext4/inode.c:4245
       ext4_setattr+0xffe/0x19e0 fs/ext4/inode.c:5582
       notify_change+0xbcd/0xee0 fs/attr.c:505
       do_truncate+0x197/0x220 fs/open.c:65
       do_sys_ftruncate+0x31b/0x3d0 fs/open.c:193
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #2 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0x1338/0x15a0 fs/jbd2/transaction.c:464
       jbd2__journal_start+0x2b7/0x5a0 fs/jbd2/transaction.c:521
       jbd2_journal_start+0x26/0x30 fs/jbd2/transaction.c:560
       ocfs2_start_trans+0x374/0x6c0 fs/ocfs2/journal.c:376
       ocfs2_modify_bh+0xe5/0x470 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x13b1/0x16e0 fs/ocfs2/quota_local.c:764
       dquot_load_quota_sb+0x756/0xac0 fs/quota/dquot.c:2463
       dquot_load_quota_inode+0x2d8/0x5d0 fs/quota/dquot.c:2500
       ocfs2_enable_quotas+0x1c3/0x440 fs/ocfs2/super.c:927
       ocfs2_fill_super+0x3a1f/0x4d80 fs/ocfs2/super.c:1140
       mount_bdev+0x287/0x3c0 fs/super.c:1400
       legacy_get_tree+0xe6/0x180 fs/fs_context.c:611
       vfs_get_tree+0x88/0x270 fs/super.c:1530
       do_new_mount+0x24a/0xa40 fs/namespace.c:3014
       do_mount fs/namespace.c:3357 [inline]
       __do_sys_mount fs/namespace.c:3565 [inline]
       __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:3542
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_start_trans+0x368/0x6c0 fs/ocfs2/journal.c:374
       ocfs2_modify_bh+0xe5/0x470 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x13b1/0x16e0 fs/ocfs2/quota_local.c:764
       dquot_load_quota_sb+0x756/0xac0 fs/quota/dquot.c:2463
       dquot_load_quota_inode+0x2d8/0x5d0 fs/quota/dquot.c:2500
       ocfs2_enable_quotas+0x1c3/0x440 fs/ocfs2/super.c:927
       ocfs2_fill_super+0x3a1f/0x4d80 fs/ocfs2/super.c:1140
       mount_bdev+0x287/0x3c0 fs/super.c:1400
       legacy_get_tree+0xe6/0x180 fs/fs_context.c:611
       vfs_get_tree+0x88/0x270 fs/super.c:1530
       do_new_mount+0x24a/0xa40 fs/namespace.c:3014
       do_mount fs/namespace.c:3357 [inline]
       __do_sys_mount fs/namespace.c:3565 [inline]
       __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:3542
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (sb_internal#3){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012
       lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1811 [inline]
       sb_start_intwrite include/linux/fs.h:1928 [inline]
       ocfs2_start_trans+0x269/0x6c0 fs/ocfs2/journal.c:372
       ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1258 [inline]
       ocfs2_reserve_local_alloc_bits+0xaeb/0x24c0 fs/ocfs2/localalloc.c:668
       ocfs2_reserve_clusters_with_limit+0x1bb/0xba0 fs/ocfs2/suballoc.c:1162
       ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
       ocfs2_lock_allocators+0x2f7/0x5b0 fs/ocfs2/suballoc.c:2669
       ocfs2_extend_allocation+0x397/0x1760 fs/ocfs2/file.c:588
       ocfs2_extend_no_holes+0x20b/0x490 fs/ocfs2/file.c:1030
       ocfs2_acquire_dquot+0x5fe/0xaf0 fs/ocfs2/quota_global.c:841
       dqget+0x778/0xeb0 fs/quota/dquot.c:988
       ocfs2_setattr+0xc93/0x1a10 fs/ocfs2/file.c:1236
       notify_change+0xbcd/0xee0 fs/attr.c:505
       chown_common+0x483/0x610 fs/open.c:680
       do_fchownat+0x164/0x270 fs/open.c:711
       __do_sys_lchown fs/open.c:736 [inline]
       __se_sys_lchown fs/open.c:734 [inline]
       __x64_sys_lchown+0x81/0x90 fs/open.c:734
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  sb_internal#3 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4);
  lock(sb_internal#3);

 *** DEADLOCK ***

7 locks held by syz.0.14/4319:
 #0: ffff888078ea4460 (sb_writers#15){.+.+}-{0:0}, at: mnt_want_write+0x3d/0x90 fs/namespace.c:377
 #1: ffff88805d8389c8 (&type->i_mutex_dir_key#10){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #1: ffff88805d8389c8 (&type->i_mutex_dir_key#10){+.+.}-{3:3}, at: chown_common+0x3c6/0x610 fs/open.c:674
 #2: ffff888060a740a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x290/0xaf0 fs/ocfs2/quota_global.c:811
 #3: ffff88805d83df48 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #3: ffff88805d83df48 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x1c7/0x270 fs/ocfs2/quota_global.c:313
 #4: ffff88805d83dbe0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1e5/0x270 fs/ocfs2/quota_global.c:314
 #5: ffff88805d8442c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #5: ffff88805d8442c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: ocfs2_reserve_local_alloc_bits+0x122/0x24c0 fs/ocfs2/localalloc.c:635
 #6: ffff88805d83d108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #6: ffff88805d83d108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x161/0x4350 fs/ocfs2/suballoc.c:782

stack backtrace:
CPU: 1 PID: 4319 Comm: syz.0.14 Not tainted 5.15.184-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x168/0x230 lib/dump_stack.c:106
 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012
 lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623
 percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
 __sb_start_write include/linux/fs.h:1811 [inline]
 sb_start_intwrite include/linux/fs.h:1928 [inline]
 ocfs2_start_trans+0x269/0x6c0 fs/ocfs2/journal.c:372
 ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1258 [inline]
 ocfs2_reserve_local_alloc_bits+0xaeb/0x24c0 fs/ocfs2/localalloc.c:668
 ocfs2_reserve_clusters_with_limit+0x1bb/0xba0 fs/ocfs2/suballoc.c:1162
 ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
 ocfs2_lock_allocators+0x2f7/0x5b0 fs/ocfs2/suballoc.c:2669
 ocfs2_extend_allocation+0x397/0x1760 fs/ocfs2/file.c:588
 ocfs2_extend_no_holes+0x20b/0x490 fs/ocfs2/file.c:1030
 ocfs2_acquire_dquot+0x5fe/0xaf0 fs/ocfs2/quota_global.c:841
 dqget+0x778/0xeb0 fs/quota/dquot.c:988
 ocfs2_setattr+0xc93/0x1a10 fs/ocfs2/file.c:1236
 notify_change+0xbcd/0xee0 fs/attr.c:505
 chown_common+0x483/0x610 fs/open.c:680
 do_fchownat+0x164/0x270 fs/open.c:711
 __do_sys_lchown fs/open.c:736 [inline]
 __se_sys_lchown fs/open.c:734 [inline]
 __x64_sys_lchown+0x81/0x90 fs/open.c:734
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f3a9bc21969
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f3a99a89038 EFLAGS: 00000246 ORIG_RAX: 000000000000005e
RAX: ffffffffffffffda RBX: 00007f3a9be48fa0 RCX: 00007f3a9bc21969
RDX: 00000000ffffffff RSI: 000000000000ee00 RDI: 0000200000000340
RBP: 00007f3a9bca3ab1 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f3a9be48fa0 R15: 00007ffd2d4c98c8
 </TASK>