8021q: adding VLAN 0 to HW filter on device team0 ============================================ WARNING: possible recursive locking detected 4.14.287-syzkaller #0 Not tainted -------------------------------------------- syz-executor.3/14461 is trying to acquire lock: (&vlan_netdev_addr_lock_key#2/2){+...}, at: [] netif_addr_lock_nested include/linux/netdevice.h:3714 [inline] (&vlan_netdev_addr_lock_key#2/2){+...}, at: [] dev_uc_sync_multiple+0x10b/0x1c0 net/core/dev_addr_lists.c:574 but task is already holding lock: (&vlan_netdev_addr_lock_key#2/2){+...}, at: [] spin_lock_bh include/linux/spinlock.h:322 [inline] (&vlan_netdev_addr_lock_key#2/2){+...}, at: [] netif_addr_lock_bh include/linux/netdevice.h:3719 [inline] (&vlan_netdev_addr_lock_key#2/2){+...}, at: [] dev_set_rx_mode net/core/dev.c:6729 [inline] (&vlan_netdev_addr_lock_key#2/2){+...}, at: [] __dev_open+0x21b/0x310 net/core/dev.c:1375 other info that might help us debug this: Possible unsafe locking scenario: CPU0 ---- lock(&vlan_netdev_addr_lock_key#2/2); lock(&vlan_netdev_addr_lock_key#2/2); *** DEADLOCK *** May be due to missing lock nesting notation 4 locks held by syz-executor.3/14461: #0: (rtnl_mutex){+.+.}, at: [] rtnl_lock net/core/rtnetlink.c:72 [inline] #0: (rtnl_mutex){+.+.}, at: [] rtnetlink_rcv_msg+0x31d/0xb10 net/core/rtnetlink.c:4317 #1: (&vlan_netdev_addr_lock_key#2/2){+...}, at: [] spin_lock_bh include/linux/spinlock.h:322 [inline] #1: (&vlan_netdev_addr_lock_key#2/2){+...}, at: [] netif_addr_lock_bh include/linux/netdevice.h:3719 [inline] #1: (&vlan_netdev_addr_lock_key#2/2){+...}, at: [] dev_set_rx_mode net/core/dev.c:6729 [inline] #1: (&vlan_netdev_addr_lock_key#2/2){+...}, at: [] __dev_open+0x21b/0x310 net/core/dev.c:1375 #2: (&dev_addr_list_lock_key#2/1){+...}, at: [] netif_addr_lock_nested include/linux/netdevice.h:3714 [inline] #2: (&dev_addr_list_lock_key#2/1){+...}, at: [] dev_mc_sync+0x10b/0x1c0 net/core/dev_addr_lists.c:765 #3: (rcu_read_lock){....}, at: [] team_set_rx_mode+0x0/0x1e0 drivers/net/team/team.c:514 stack backtrace: CPU: 0 PID: 14461 Comm: syz-executor.3 Not tainted 4.14.287-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/29/2022 Call Trace: __dump_stack lib/dump_stack.c:17 [inline] dump_stack+0x1b2/0x281 lib/dump_stack.c:58 print_deadlock_bug kernel/locking/lockdep.c:1800 [inline] check_deadlock kernel/locking/lockdep.c:1847 [inline] validate_chain kernel/locking/lockdep.c:2448 [inline] __lock_acquire.cold+0x180/0x97c kernel/locking/lockdep.c:3491 lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998 _raw_spin_lock_nested+0x30/0x40 kernel/locking/spinlock.c:362 netif_addr_lock_nested include/linux/netdevice.h:3714 [inline] dev_uc_sync_multiple+0x10b/0x1c0 net/core/dev_addr_lists.c:574 team_set_rx_mode+0xb8/0x1e0 drivers/net/team/team.c:1781 __dev_set_rx_mode+0x191/0x2a0 net/core/dev.c:6724 dev_mc_sync+0x17a/0x1c0 net/core/dev_addr_lists.c:768 vlan_dev_set_rx_mode+0x38/0x80 net/8021q/vlan_dev.c:486 __dev_set_rx_mode+0x191/0x2a0 net/core/dev.c:6724 dev_set_rx_mode net/core/dev.c:6730 [inline] __dev_open+0x223/0x310 net/core/dev.c:1375 __dev_change_flags+0x43f/0x540 net/core/dev.c:6802 dev_change_flags+0x7e/0x130 net/core/dev.c:6868 vlan_device_event+0x1261/0x1ad0 net/8021q/vlan.c:454 notifier_call_chain+0x108/0x1a0 kernel/notifier.c:93 call_netdevice_notifiers_info net/core/dev.c:1667 [inline] call_netdevice_notifiers net/core/dev.c:1683 [inline] dev_open net/core/dev.c:1407 [inline] dev_open+0xf9/0x110 net/core/dev.c:1395 bond_enslave+0x8eb/0x4cf0 drivers/net/bonding/bond_main.c:1538 do_set_master+0x19e/0x200 net/core/rtnetlink.c:1961 do_setlink+0x8b8/0x2bf0 net/core/rtnetlink.c:2098 rtnl_newlink+0x1271/0x1830 net/core/rtnetlink.c:2662 rtnetlink_rcv_msg+0x3be/0xb10 net/core/rtnetlink.c:4322 netlink_rcv_skb+0x125/0x390 net/netlink/af_netlink.c:2454 netlink_unicast_kernel net/netlink/af_netlink.c:1296 [inline] netlink_unicast+0x437/0x610 net/netlink/af_netlink.c:1322 netlink_sendmsg+0x648/0xbc0 net/netlink/af_netlink.c:1893 sock_sendmsg_nosec net/socket.c:646 [inline] sock_sendmsg+0xb5/0x100 net/socket.c:656 ___sys_sendmsg+0x6c8/0x800 net/socket.c:2062 __sys_sendmsg+0xa3/0x120 net/socket.c:2096 SYSC_sendmsg net/socket.c:2107 [inline] SyS_sendmsg+0x27/0x40 net/socket.c:2103 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x46/0xbb RIP: 0033:0x7fb851906109 RSP: 002b:00007fb85027b168 EFLAGS: 00000246 ORIG_RAX: 000000000000002e RAX: ffffffffffffffda RBX: 00007fb851a18f60 RCX: 00007fb851906109 RDX: 0000000004004050 RSI: 0000000020000600 RDI: 0000000000000004 RBP: 00007fb85196005d R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffc9623c5af R14: 00007fb85027b300 R15: 0000000000022000