====================================================== WARNING: possible circular locking dependency detected 6.9.0-rc5-syzkaller-00036-g9d1ddab261f3 #0 Not tainted ------------------------------------------------------ syz-executor.4/14770 is trying to acquire lock: ffff888079b4d220 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1121 [inline] ffff888079b4d220 (&ni->ni_lock/4){+.+.}-{3:3}, at: ntfs_fallocate+0x9af/0x1120 fs/ntfs3/file.c:556 but task is already holding lock: ffff888079b4d660 (mapping.invalidate_lock#8){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:840 [inline] ffff888079b4d660 (mapping.invalidate_lock#8){++++}-{3:3}, at: ntfs_fallocate+0x6fb/0x1120 fs/ntfs3/file.c:486 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #4 (mapping.invalidate_lock#8){++++}-{3:3}: down_read+0x9a/0x330 kernel/locking/rwsem.c:1526 filemap_invalidate_lock_shared include/linux/fs.h:850 [inline] filemap_fault+0x277/0x38d0 mm/filemap.c:3277 __do_fault+0x10a/0x4a0 mm/memory.c:4531 do_read_fault mm/memory.c:4894 [inline] do_fault mm/memory.c:5024 [inline] do_pte_missing mm/memory.c:3880 [inline] handle_pte_fault mm/memory.c:5300 [inline] __handle_mm_fault+0x3750/0x4b40 mm/memory.c:5441 handle_mm_fault+0x476/0xa00 mm/memory.c:5606 do_user_addr_fault+0x426/0x1080 arch/x86/mm/fault.c:1362 handle_page_fault arch/x86/mm/fault.c:1505 [inline] exc_page_fault+0x5c/0xc0 arch/x86/mm/fault.c:1563 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623 -> #3 (&vma->vm_lock->lock){++++}-{3:3}: down_write+0x3a/0x50 kernel/locking/rwsem.c:1579 vma_start_write include/linux/mm.h:730 [inline] vma_link+0x2c8/0x4c0 mm/mmap.c:416 insert_vm_struct+0x1e3/0x460 mm/mmap.c:3339 __bprm_mm_init fs/exec.c:282 [inline] bprm_mm_init fs/exec.c:384 [inline] alloc_bprm+0x58d/0xc50 fs/exec.c:1580 kernel_execve+0xb0/0x4e0 fs/exec.c:2004 try_to_run_init_process init/main.c:1373 [inline] kernel_init+0x145/0x2b0 init/main.c:1500 ret_from_fork+0x45/0x80 arch/x86/kernel/process.c:147 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 -> #2 (&mm->mmap_lock){++++}-{3:3}: __might_fault mm/memory.c:6220 [inline] __might_fault+0x11b/0x190 mm/memory.c:6213 _copy_to_user+0x2b/0xc0 lib/usercopy.c:36 copy_to_user include/linux/uaccess.h:191 [inline] fiemap_fill_next_extent+0x232/0x390 fs/ioctl.c:145 ni_fiemap+0x444/0xc10 fs/ntfs3/frecord.c:2065 ntfs_fiemap+0xc9/0x120 fs/ntfs3/file.c:1206 ioctl_fiemap fs/ioctl.c:220 [inline] do_vfs_ioctl+0x404/0x1ac0 fs/ioctl.c:838 __do_sys_ioctl fs/ioctl.c:902 [inline] __se_sys_ioctl fs/ioctl.c:890 [inline] __x64_sys_ioctl+0x116/0x220 fs/ioctl.c:890 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x260 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (&ni->file.run_lock#3){++++}-{3:3}: down_write+0x3a/0x50 kernel/locking/rwsem.c:1579 ntfs_file_release+0x184/0x220 fs/ntfs3/file.c:1179 __fput+0x270/0xb80 fs/file_table.c:422 __fput_sync+0x47/0x50 fs/file_table.c:507 __do_sys_close fs/open.c:1556 [inline] __se_sys_close fs/open.c:1541 [inline] __x64_sys_close+0x86/0x100 fs/open.c:1541 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x260 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&ni->ni_lock/4){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x2478/0x3b30 kernel/locking/lockdep.c:5137 lock_acquire kernel/locking/lockdep.c:5754 [inline] lock_acquire+0x1b1/0x560 kernel/locking/lockdep.c:5719 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752 ni_lock fs/ntfs3/ntfs_fs.h:1121 [inline] ntfs_fallocate+0x9af/0x1120 fs/ntfs3/file.c:556 vfs_fallocate+0x4b8/0xf70 fs/open.c:330 ksys_fallocate fs/open.c:353 [inline] __do_sys_fallocate fs/open.c:361 [inline] __se_sys_fallocate fs/open.c:359 [inline] __x64_sys_fallocate+0xd5/0x140 fs/open.c:359 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x260 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &ni->ni_lock/4 --> &vma->vm_lock->lock --> mapping.invalidate_lock#8 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(mapping.invalidate_lock#8); lock(&vma->vm_lock->lock); lock(mapping.invalidate_lock#8); lock(&ni->ni_lock/4); *** DEADLOCK *** 3 locks held by syz-executor.4/14770: #0: ffff888067b80420 (sb_writers#20){.+.+}-{0:0}, at: ksys_fallocate fs/open.c:353 [inline] #0: ffff888067b80420 (sb_writers#20){.+.+}-{0:0}, at: __do_sys_fallocate fs/open.c:361 [inline] #0: ffff888067b80420 (sb_writers#20){.+.+}-{0:0}, at: __se_sys_fallocate fs/open.c:359 [inline] #0: ffff888067b80420 (sb_writers#20){.+.+}-{0:0}, at: __x64_sys_fallocate+0xd5/0x140 fs/open.c:359 #1: ffff888079b4d4c0 (&sb->s_type->i_mutex_key#24){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:795 [inline] #1: ffff888079b4d4c0 (&sb->s_type->i_mutex_key#24){+.+.}-{3:3}, at: ntfs_fallocate+0x2ac/0x1120 fs/ntfs3/file.c:472 #2: ffff888079b4d660 (mapping.invalidate_lock#8){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:840 [inline] #2: ffff888079b4d660 (mapping.invalidate_lock#8){++++}-{3:3}, at: ntfs_fallocate+0x6fb/0x1120 fs/ntfs3/file.c:486 stack backtrace: CPU: 1 PID: 14770 Comm: syz-executor.4 Not tainted 6.9.0-rc5-syzkaller-00036-g9d1ddab261f3 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:114 check_noncircular+0x31a/0x400 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x2478/0x3b30 kernel/locking/lockdep.c:5137 lock_acquire kernel/locking/lockdep.c:5754 [inline] lock_acquire+0x1b1/0x560 kernel/locking/lockdep.c:5719 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752 ni_lock fs/ntfs3/ntfs_fs.h:1121 [inline] ntfs_fallocate+0x9af/0x1120 fs/ntfs3/file.c:556 vfs_fallocate+0x4b8/0xf70 fs/open.c:330 ksys_fallocate fs/open.c:353 [inline] __do_sys_fallocate fs/open.c:361 [inline] __se_sys_fallocate fs/open.c:359 [inline] __x64_sys_fallocate+0xd5/0x140 fs/open.c:359 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x260 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fbf6567dea9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fbf663300c8 EFLAGS: 00000246 ORIG_RAX: 000000000000011d RAX: ffffffffffffffda RBX: 00007fbf657abf80 RCX: 00007fbf6567dea9 RDX: 0000000000004000 RSI: 0000000000000008 RDI: 0000000000000005 RBP: 00007fbf656ca4a4 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000002000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007fbf657abf80 R15: 00007ffe76d92db8