====================================================== WARNING: possible circular locking dependency detected 6.1.96-syzkaller #0 Not tainted ------------------------------------------------------ syz.4.303/4650 is trying to acquire lock: ffff88814c0223f8 (&journal->j_checkpoint_mutex){+.+.}-{3:3}, at: __jbd2_log_wait_for_space+0x213/0x760 fs/jbd2/checkpoint.c:71 but task is already holding lock: ffff88814c01e558 (sb_pagefaults){.+.+}-{0:0}, at: __sb_start_write include/linux/fs.h:1891 [inline] ffff88814c01e558 (sb_pagefaults){.+.+}-{0:0}, at: sb_start_pagefault include/linux/fs.h:1995 [inline] ffff88814c01e558 (sb_pagefaults){.+.+}-{0:0}, at: ext4_page_mkwrite+0x1ad/0x10d0 fs/ext4/inode.c:6189 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (sb_pagefaults){.+.+}-{0:0}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 percpu_down_read+0x44/0x1a0 include/linux/percpu-rwsem.h:51 __sb_start_write include/linux/fs.h:1891 [inline] sb_start_pagefault include/linux/fs.h:1995 [inline] ext4_page_mkwrite+0x1ad/0x10d0 fs/ext4/inode.c:6189 do_page_mkwrite+0x1a1/0x5f0 mm/memory.c:2992 wp_page_shared+0x164/0x380 mm/memory.c:3341 handle_pte_fault mm/memory.c:5031 [inline] __handle_mm_fault mm/memory.c:5155 [inline] handle_mm_fault+0x2525/0x5340 mm/memory.c:5276 do_user_addr_fault arch/x86/mm/fault.c:1340 [inline] handle_page_fault arch/x86/mm/fault.c:1431 [inline] exc_page_fault+0x26f/0x620 arch/x86/mm/fault.c:1487 asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:570 -> #2 (&mm->mmap_lock){++++}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 internal_get_user_pages_fast+0x224/0x2cf0 mm/gup.c:3031 __iov_iter_get_pages_alloc+0x3b1/0xa70 lib/iov_iter.c:1460 iov_iter_get_pages2+0xcb/0x120 lib/iov_iter.c:1503 __bio_iov_iter_get_pages block/bio.c:1217 [inline] bio_iov_iter_get_pages+0x359/0x1340 block/bio.c:1287 iomap_dio_bio_iter+0xc86/0x1600 fs/iomap/direct-io.c:331 __iomap_dio_rw+0x1271/0x2130 fs/iomap/direct-io.c:602 iomap_dio_rw+0x42/0xa0 fs/iomap/direct-io.c:690 ext4_dio_write_iter fs/ext4/file.c:557 [inline] ext4_file_write_iter+0x1464/0x1880 fs/ext4/file.c:677 do_iter_write+0x6e6/0xc50 fs/read_write.c:861 vfs_writev fs/read_write.c:934 [inline] do_pwritev+0x216/0x360 fs/read_write.c:1031 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #1 (&sb->s_type->i_mutex_key#8){++++}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 inode_lock_shared include/linux/fs.h:768 [inline] ext4_bmap+0x4b/0x410 fs/ext4/inode.c:3176 bmap+0xa1/0xd0 fs/inode.c:1842 jbd2_journal_bmap fs/jbd2/journal.c:977 [inline] __jbd2_journal_erase fs/jbd2/journal.c:1794 [inline] jbd2_journal_flush+0x5b5/0xc40 fs/jbd2/journal.c:2496 ext4_ioctl_checkpoint fs/ext4/ioctl.c:1086 [inline] __ext4_ioctl fs/ext4/ioctl.c:1594 [inline] ext4_ioctl+0x3986/0x5f60 fs/ext4/ioctl.c:1614 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #0 (&journal->j_checkpoint_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] mutex_lock_io_nested+0x134/0xab0 kernel/locking/mutex.c:833 __jbd2_log_wait_for_space+0x213/0x760 fs/jbd2/checkpoint.c:71 add_transaction_credits fs/jbd2/transaction.c:298 [inline] start_this_handle+0x1040/0x21b0 fs/jbd2/transaction.c:422 jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:520 __ext4_journal_start_sb+0x19b/0x410 fs/ext4/ext4_jbd2.c:105 __ext4_journal_start fs/ext4/ext4_jbd2.h:326 [inline] ext4_dirty_inode+0x8b/0x100 fs/ext4/inode.c:6069 __mark_inode_dirty+0x331/0xf80 fs/fs-writeback.c:2433 generic_update_time fs/inode.c:1903 [inline] inode_update_time fs/inode.c:1916 [inline] __file_update_time+0x221/0x240 fs/inode.c:2104 file_update_time+0x34c/0x3c0 fs/inode.c:2135 ext4_page_mkwrite+0x1c4/0x10d0 fs/ext4/inode.c:6190 do_page_mkwrite+0x1a1/0x5f0 mm/memory.c:2992 do_shared_fault mm/memory.c:4677 [inline] do_fault mm/memory.c:4745 [inline] handle_pte_fault mm/memory.c:5013 [inline] __handle_mm_fault mm/memory.c:5155 [inline] handle_mm_fault+0x22eb/0x5340 mm/memory.c:5276 do_user_addr_fault arch/x86/mm/fault.c:1340 [inline] handle_page_fault arch/x86/mm/fault.c:1431 [inline] exc_page_fault+0x26f/0x620 arch/x86/mm/fault.c:1487 asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:570 other info that might help us debug this: Chain exists of: &journal->j_checkpoint_mutex --> &mm->mmap_lock --> sb_pagefaults Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(sb_pagefaults); lock(&mm->mmap_lock); lock(sb_pagefaults); lock(&journal->j_checkpoint_mutex); *** DEADLOCK *** 2 locks held by syz.4.303/4650: #0: ffff88801a33f1d8 (&mm->mmap_lock){++++}-{3:3}, at: mmap_read_trylock include/linux/mmap_lock.h:136 [inline] #0: ffff88801a33f1d8 (&mm->mmap_lock){++++}-{3:3}, at: get_mmap_lock_carefully mm/memory.c:5304 [inline] #0: ffff88801a33f1d8 (&mm->mmap_lock){++++}-{3:3}, at: lock_mm_and_find_vma+0x2e/0x2e0 mm/memory.c:5366 #1: ffff88814c01e558 (sb_pagefaults){.+.+}-{0:0}, at: __sb_start_write include/linux/fs.h:1891 [inline] #1: ffff88814c01e558 (sb_pagefaults){.+.+}-{0:0}, at: sb_start_pagefault include/linux/fs.h:1995 [inline] #1: ffff88814c01e558 (sb_pagefaults){.+.+}-{0:0}, at: ext4_page_mkwrite+0x1ad/0x10d0 fs/ext4/inode.c:6189 stack backtrace: CPU: 0 PID: 4650 Comm: syz.4.303 Not tainted 6.1.96-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/07/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] mutex_lock_io_nested+0x134/0xab0 kernel/locking/mutex.c:833 __jbd2_log_wait_for_space+0x213/0x760 fs/jbd2/checkpoint.c:71 add_transaction_credits fs/jbd2/transaction.c:298 [inline] start_this_handle+0x1040/0x21b0 fs/jbd2/transaction.c:422 jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:520 __ext4_journal_start_sb+0x19b/0x410 fs/ext4/ext4_jbd2.c:105 __ext4_journal_start fs/ext4/ext4_jbd2.h:326 [inline] ext4_dirty_inode+0x8b/0x100 fs/ext4/inode.c:6069 __mark_inode_dirty+0x331/0xf80 fs/fs-writeback.c:2433 generic_update_time fs/inode.c:1903 [inline] inode_update_time fs/inode.c:1916 [inline] __file_update_time+0x221/0x240 fs/inode.c:2104 file_update_time+0x34c/0x3c0 fs/inode.c:2135 ext4_page_mkwrite+0x1c4/0x10d0 fs/ext4/inode.c:6190 do_page_mkwrite+0x1a1/0x5f0 mm/memory.c:2992 do_shared_fault mm/memory.c:4677 [inline] do_fault mm/memory.c:4745 [inline] handle_pte_fault mm/memory.c:5013 [inline] __handle_mm_fault mm/memory.c:5155 [inline] handle_mm_fault+0x22eb/0x5340 mm/memory.c:5276 do_user_addr_fault arch/x86/mm/fault.c:1340 [inline] handle_page_fault arch/x86/mm/fault.c:1431 [inline] exc_page_fault+0x26f/0x620 arch/x86/mm/fault.c:1487 asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:570 RIP: 0033:0x7f2c4bc55599 Code: ec 49 f7 dc 4d 89 e6 41 83 e6 03 75 3b 48 89 df be 04 00 00 00 e8 57 c1 fe ff 48 8b 43 38 83 43 28 04 48 8d 50 fc 48 89 53 38 <89> 68 fc 8b 43 28 48 83 c4 28 5b 5d 41 5c 41 5d 41 5e 41 5f c3 4c RSP: 002b:00007ffc0468c4e0 EFLAGS: 00010202 RAX: 0000001b2fc20000 RBX: 00007f2c4ca35720 RCX: 0000001b2f820210 RDX: 0000001b2fc1fffc RSI: 00000000003ffdf0 RDI: 00007f2c4ca35700 RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000008 R10: 00007f2c4ca35700 R11: 000000008132a42a R12: 0000000000000000 R13: 0000000000000000 R14: 0000000000000000 R15: 00007f2c4b3ff000