======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.54/6110 is trying to acquire lock:
ffff88805d7d1bf8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_get_block+0x391/0x1610 fs/hfsplus/extents.c:264

but task is already holding lock:
ffff88803739f0e8 (&sbi->alloc_mutex){+.+.}-{4:4}, at: hfsplus_block_allocate+0xa9/0xd30 fs/hfsplus/bitmap.c:35

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&sbi->alloc_mutex){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/rtmutex_api.c:559 [inline]
       mutex_lock_nested+0x5a/0x1d0 kernel/locking/rtmutex_api.c:578
       hfsplus_block_allocate+0xa9/0xd30 fs/hfsplus/bitmap.c:35
       hfsplus_file_extend+0xb77/0x1df0 fs/hfsplus/extents.c:468
       hfsplus_create_attributes_file fs/hfsplus/xattr.c:277 [inline]
       __hfsplus_setxattr+0xd1d/0x2800 fs/hfsplus/xattr.c:431
       hfsplus_initxattrs+0x1ae/0x280 fs/hfsplus/xattr_security.c:59
       security_inode_init_security+0x29b/0x3e0 security/security.c:1370
       hfsplus_mknod+0x1de/0x3c0 fs/hfsplus/dir.c:536
       lookup_open+0xc17/0x1a60 fs/namei.c:4567
       open_last_lookups fs/namei.c:4767 [inline]
       path_openat+0x67c/0x1d60 fs/namei.c:4997
       do_file_open+0x23e/0x4a0 fs/namei.c:5029
       do_sys_openat2+0x115/0x200 fs/open.c:1417
       do_sys_open fs/open.c:1423 [inline]
       __do_sys_open fs/open.c:1431 [inline]
       __se_sys_open fs/open.c:1427 [inline]
       __x64_sys_open+0x11e/0x150 fs/open.c:1427
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3181 [inline]
       check_prevs_add kernel/locking/lockdep.c:3300 [inline]
       validate_chain kernel/locking/lockdep.c:3924 [inline]
       __lock_acquire+0x15ff/0x2e40 kernel/locking/lockdep.c:5254
       lock_acquire+0x115/0x350 kernel/locking/lockdep.c:5908
       __mutex_lock_common kernel/locking/rtmutex_api.c:559 [inline]
       mutex_lock_nested+0x5a/0x1d0 kernel/locking/rtmutex_api.c:578
       hfsplus_get_block+0x391/0x1610 fs/hfsplus/extents.c:264
       block_read_full_folio+0x29f/0x810 fs/buffer.c:2308
       filemap_read_folio+0x12c/0x3a0 mm/filemap.c:2520
       do_read_cache_folio+0x2bf/0x560 mm/filemap.c:4156
       do_read_cache_page mm/filemap.c:4222 [inline]
       read_cache_page+0x5d/0x170 mm/filemap.c:4231
       read_mapping_page include/linux/pagemap.h:1009 [inline]
       hfsplus_block_allocate+0xf7/0xd30 fs/hfsplus/bitmap.c:37
       hfsplus_file_extend+0xb77/0x1df0 fs/hfsplus/extents.c:468
       hfsplus_get_block+0x41f/0x1610 fs/hfsplus/extents.c:249
       __block_write_begin_int+0x6c2/0x1900 fs/buffer.c:2030
       block_write_begin fs/buffer.c:2144 [inline]
       cont_write_begin+0x71b/0xac0 fs/buffer.c:2506
       hfsplus_write_begin+0x126/0x1e0 fs/hfsplus/inode.c:56
       page_symlink+0x27a/0x440 fs/namei.c:6556
       hfsplus_symlink+0xd3/0x390 fs/hfsplus/dir.c:478
       vfs_symlink+0x18b/0x330 fs/namei.c:5794
       filename_symlinkat+0x1cd/0x420 fs/namei.c:5819
       __do_sys_symlink fs/namei.c:5846 [inline]
       __se_sys_symlink+0x4d/0x2b0 fs/namei.c:5842
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&sbi->alloc_mutex);
                               lock(&HFSPLUS_I(inode)->extents_lock);
                               lock(&sbi->alloc_mutex);
  lock(&HFSPLUS_I(inode)->extents_lock);

 *** DEADLOCK ***

locks held by syz.0.54/6110: 5, last CPU#1:
 #0: ffff888037548510 (sb_writers#21){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:494
 #1: ffff88805d7d1708 (&type->i_mutex_dir_key#18/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:1069 [inline]
 #1: ffff88805d7d1708 (&type->i_mutex_dir_key#18/1){+.+.}-{4:4}, at: __start_dirop fs/namei.c:2918 [inline]
 #1: ffff88805d7d1708 (&type->i_mutex_dir_key#18/1){+.+.}-{4:4}, at: start_dirop fs/namei.c:2942 [inline]
 #1: ffff88805d7d1708 (&type->i_mutex_dir_key#18/1){+.+.}-{4:4}, at: filename_create+0x200/0x370 fs/namei.c:5092
 #2: ffff88803739f178 (&sbi->vh_mutex){+.+.}-{4:4}, at: hfsplus_symlink+0x81/0x390 fs/hfsplus/dir.c:470
 #3: ffff88805db60e78 (&hip->extents_lock){+.+.}-{4:4}, at: hfsplus_file_extend+0x21c/0x1df0 fs/hfsplus/extents.c:457
 #4: ffff88803739f0e8 (&sbi->alloc_mutex){+.+.}-{4:4}, at: hfsplus_block_allocate+0xa9/0xd30 fs/hfsplus/bitmap.c:35

stack backtrace:
CPU: 1 UID: 0 PID: 6110 Comm: syz.0.54 Not tainted syzkaller #0 PREEMPT_{RT,(full)} 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/24/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e2/0x300 kernel/locking/lockdep.c:2059
 check_noncircular+0x12f/0x150 kernel/locking/lockdep.c:2191
 check_prev_add kernel/locking/lockdep.c:3181 [inline]
 check_prevs_add kernel/locking/lockdep.c:3300 [inline]
 validate_chain kernel/locking/lockdep.c:3924 [inline]
 __lock_acquire+0x15ff/0x2e40 kernel/locking/lockdep.c:5254
 lock_acquire+0x115/0x350 kernel/locking/lockdep.c:5908
 __mutex_lock_common kernel/locking/rtmutex_api.c:559 [inline]
 mutex_lock_nested+0x5a/0x1d0 kernel/locking/rtmutex_api.c:578
 hfsplus_get_block+0x391/0x1610 fs/hfsplus/extents.c:264
 block_read_full_folio+0x29f/0x810 fs/buffer.c:2308
 filemap_read_folio+0x12c/0x3a0 mm/filemap.c:2520
 do_read_cache_folio+0x2bf/0x560 mm/filemap.c:4156
 do_read_cache_page mm/filemap.c:4222 [inline]
 read_cache_page+0x5d/0x170 mm/filemap.c:4231
 read_mapping_page include/linux/pagemap.h:1009 [inline]
 hfsplus_block_allocate+0xf7/0xd30 fs/hfsplus/bitmap.c:37
 hfsplus_file_extend+0xb77/0x1df0 fs/hfsplus/extents.c:468
 hfsplus_get_block+0x41f/0x1610 fs/hfsplus/extents.c:249
 __block_write_begin_int+0x6c2/0x1900 fs/buffer.c:2030
 block_write_begin fs/buffer.c:2144 [inline]
 cont_write_begin+0x71b/0xac0 fs/buffer.c:2506
 hfsplus_write_begin+0x126/0x1e0 fs/hfsplus/inode.c:56
 page_symlink+0x27a/0x440 fs/namei.c:6556
 hfsplus_symlink+0xd3/0x390 fs/hfsplus/dir.c:478
 vfs_symlink+0x18b/0x330 fs/namei.c:5794
 filename_symlinkat+0x1cd/0x420 fs/namei.c:5819
 __do_sys_symlink fs/namei.c:5846 [inline]
 __se_sys_symlink+0x4d/0x2b0 fs/namei.c:5842
 do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
 do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f790d86e159
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f790bac6028 EFLAGS: 00000246 ORIG_RAX: 0000000000000058
RAX: ffffffffffffffda RBX: 00007f790daf5fa0 RCX: 00007f790d86e159
RDX: 0000000000000000 RSI: 0000200000000380 RDI: 00002000000003c0
RBP: 00007f790d905024 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f790daf6038 R14: 00007f790daf5fa0 R15: 00007fff97c69ee8
 </TASK>