====================================================== WARNING: possible circular locking dependency detected syzkaller #0 Tainted: G L ------------------------------------------------------ syz.9.11915/18476 is trying to acquire lock: ffff88801e4db0c0 (&sb->s_type->i_mutex_key#25){++++}-{4:4}, at: inode_lock include/linux/fs.h:1024 [inline] ffff88801e4db0c0 (&sb->s_type->i_mutex_key#25){++++}-{4:4}, at: configfs_depend_item_unlocked+0xf3/0x6a0 fs/configfs/dir.c:1259 but task is already holding lock: ffff888022e3d918 (&opts->dep_lock){+.+.}-{4:4}, at: usbg_make_tpg+0x1a4/0x620 drivers/usb/gadget/function/f_tcm.c:1678 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&opts->dep_lock){+.+.}-{4:4}: lock_acquire kernel/locking/lockdep.c:5868 [inline] lock_acquire+0x1b9/0x370 kernel/locking/lockdep.c:5825 __mutex_lock_common kernel/locking/mutex.c:646 [inline] __mutex_lock+0x1a4/0x1bd0 kernel/locking/mutex.c:821 tcm_set_name+0x29/0xb0 drivers/usb/gadget/function/f_tcm.c:2669 function_make+0x21c/0x3f0 drivers/usb/gadget/configfs.c:636 configfs_mkdir+0x51e/0xb70 fs/configfs/dir.c:1360 vfs_mkdir+0x361/0x850 fs/namei.c:5276 filename_mkdirat+0x48b/0x5e0 fs/namei.c:5309 __do_sys_mkdirat fs/namei.c:5330 [inline] __se_sys_mkdirat fs/namei.c:5327 [inline] __ia32_sys_mkdirat+0x88/0xc0 fs/namei.c:5327 do_syscall_32_irqs_on arch/x86/entry/syscall_32.c:83 [inline] __do_fast_syscall_32+0xe7/0x970 arch/x86/entry/syscall_32.c:307 do_fast_syscall_32+0x32/0x70 arch/x86/entry/syscall_32.c:332 entry_SYSENTER_compat_after_hwframe+0x84/0x8e -> #1 (gadget_subsys.su_mutex){+.+.}-{4:4}: lock_acquire kernel/locking/lockdep.c:5868 [inline] lock_acquire+0x1b9/0x370 kernel/locking/lockdep.c:5825 __mutex_lock_common kernel/locking/mutex.c:646 [inline] __mutex_lock+0x1a4/0x1bd0 kernel/locking/mutex.c:821 configfs_rmdir+0x5ae/0x950 fs/configfs/dir.c:1556 vfs_rmdir fs/namei.c:5381 [inline] vfs_rmdir+0x328/0x8a0 fs/namei.c:5354 filename_rmdir+0x31a/0x5c0 fs/namei.c:5438 __do_sys_rmdir fs/namei.c:5461 [inline] __se_sys_rmdir fs/namei.c:5458 [inline] __ia32_sys_rmdir+0x45/0x60 fs/namei.c:5458 do_syscall_32_irqs_on arch/x86/entry/syscall_32.c:83 [inline] __do_fast_syscall_32+0xe7/0x970 arch/x86/entry/syscall_32.c:307 do_fast_syscall_32+0x32/0x70 arch/x86/entry/syscall_32.c:332 entry_SYSENTER_compat_after_hwframe+0x84/0x8e -> #0 (&sb->s_type->i_mutex_key#25){++++}-{4:4}: check_prev_add+0xeb/0xe60 kernel/locking/lockdep.c:3165 check_prevs_add kernel/locking/lockdep.c:3284 [inline] validate_chain kernel/locking/lockdep.c:3908 [inline] __lock_acquire+0x136c/0x1a40 kernel/locking/lockdep.c:5237 lock_acquire kernel/locking/lockdep.c:5868 [inline] lock_acquire+0x1b9/0x370 kernel/locking/lockdep.c:5825 down_write+0x8b/0x1f0 kernel/locking/rwsem.c:1631 inode_lock include/linux/fs.h:1024 [inline] configfs_depend_item_unlocked+0xf3/0x6a0 fs/configfs/dir.c:1259 usbg_make_tpg+0x261/0x620 drivers/usb/gadget/function/f_tcm.c:1686 target_fabric_make_tpg+0xab/0x8c0 drivers/target/target_core_fabric_configfs.c:939 configfs_mkdir+0x51e/0xb70 fs/configfs/dir.c:1360 vfs_mkdir+0x361/0x850 fs/namei.c:5276 filename_mkdirat+0x48b/0x5e0 fs/namei.c:5309 __do_sys_mkdirat fs/namei.c:5330 [inline] __se_sys_mkdirat fs/namei.c:5327 [inline] __ia32_sys_mkdirat+0x88/0xc0 fs/namei.c:5327 do_syscall_32_irqs_on arch/x86/entry/syscall_32.c:83 [inline] __do_fast_syscall_32+0xe7/0x970 arch/x86/entry/syscall_32.c:307 do_fast_syscall_32+0x32/0x70 arch/x86/entry/syscall_32.c:332 entry_SYSENTER_compat_after_hwframe+0x84/0x8e other info that might help us debug this: Chain exists of: &sb->s_type->i_mutex_key#25 --> gadget_subsys.su_mutex --> &opts->dep_lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&opts->dep_lock); lock(gadget_subsys.su_mutex); lock(&opts->dep_lock); lock(&sb->s_type->i_mutex_key#25); *** DEADLOCK *** 5 locks held by syz.9.11915/18476: #0: ffff888022cb6450 (sb_writers#13){.+.+}-{0:0}, at: filename_create+0x10d/0x400 fs/namei.c:4948 #1: ffff888021f73a40 (&sb->s_type->i_mutex_key#8/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:1069 [inline] #1: ffff888021f73a40 (&sb->s_type->i_mutex_key#8/1){+.+.}-{4:4}, at: __start_dirop fs/namei.c:2918 [inline] #1: ffff888021f73a40 (&sb->s_type->i_mutex_key#8/1){+.+.}-{4:4}, at: start_dirop fs/namei.c:2942 [inline] #1: ffff888021f73a40 (&sb->s_type->i_mutex_key#8/1){+.+.}-{4:4}, at: filename_create+0x1c0/0x400 fs/namei.c:4955 #2: ffffffff8fd89ea8 (&subsys->su_mutex){+.+.}-{4:4}, at: configfs_mkdir+0x4b5/0xb70 fs/configfs/dir.c:1358 #3: ffffffff90254fa0 (tpg_instances_lock){+.+.}-{4:4}, at: usbg_make_tpg+0x10b/0x620 drivers/usb/gadget/function/f_tcm.c:1669 #4: ffff888022e3d918 (&opts->dep_lock){+.+.}-{4:4}, at: usbg_make_tpg+0x1a4/0x620 drivers/usb/gadget/function/f_tcm.c:1678 stack backtrace: CPU: 2 UID: 0 PID: 18476 Comm: syz.9.11915 Tainted: G L syzkaller #0 PREEMPT(full) Tainted: [L]=SOFTLOCKUP Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x100/0x190 lib/dump_stack.c:120 print_circular_bug.cold+0x178/0x1c7 kernel/locking/lockdep.c:2043 check_noncircular+0x146/0x160 kernel/locking/lockdep.c:2175 check_prev_add+0xeb/0xe60 kernel/locking/lockdep.c:3165 check_prevs_add kernel/locking/lockdep.c:3284 [inline] validate_chain kernel/locking/lockdep.c:3908 [inline] __lock_acquire+0x136c/0x1a40 kernel/locking/lockdep.c:5237 lock_acquire kernel/locking/lockdep.c:5868 [inline] lock_acquire+0x1b9/0x370 kernel/locking/lockdep.c:5825 down_write+0x8b/0x1f0 kernel/locking/rwsem.c:1631 inode_lock include/linux/fs.h:1024 [inline] configfs_depend_item_unlocked+0xf3/0x6a0 fs/configfs/dir.c:1259 usbg_make_tpg+0x261/0x620 drivers/usb/gadget/function/f_tcm.c:1686 target_fabric_make_tpg+0xab/0x8c0 drivers/target/target_core_fabric_configfs.c:939 configfs_mkdir+0x51e/0xb70 fs/configfs/dir.c:1360 vfs_mkdir+0x361/0x850 fs/namei.c:5276 filename_mkdirat+0x48b/0x5e0 fs/namei.c:5309 __do_sys_mkdirat fs/namei.c:5330 [inline] __se_sys_mkdirat fs/namei.c:5327 [inline] __ia32_sys_mkdirat+0x88/0xc0 fs/namei.c:5327 do_syscall_32_irqs_on arch/x86/entry/syscall_32.c:83 [inline] __do_fast_syscall_32+0xe7/0x970 arch/x86/entry/syscall_32.c:307 do_fast_syscall_32+0x32/0x70 arch/x86/entry/syscall_32.c:332 entry_SYSENTER_compat_after_hwframe+0x84/0x8e RIP: 0023:0xf7f92fec Code: Unable to access opcode bytes at 0xf7f92fc2. RSP: 002b:00000000f545650c EFLAGS: 00000292 ORIG_RAX: 0000000000000128 RAX: ffffffffffffffda RBX: 00000000ffffff9c RCX: 0000000080001000 RDX: 00000000000001ff RSI: 0000000000000000 RDI: 0000000000000000 RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000292 R12: 0000000000000000 R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000 bond0: (slave syz_tun): Releasing backup interface