====================================================== WARNING: possible circular locking dependency detected 5.15.145-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.5/18430 is trying to acquire lock: ffff8880795820f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_allocate+0x8a/0x8d0 fs/hfsplus/bitmap.c:35 but task is already holding lock: ffff8880b0ccbdc8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1d2/0x1b10 fs/hfsplus/extents.c:457 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfsplus_get_block+0x37f/0x14e0 fs/hfsplus/extents.c:260 block_read_full_page+0x2f9/0xde0 fs/buffer.c:2290 do_read_cache_page+0x752/0x1040 read_mapping_page include/linux/pagemap.h:515 [inline] hfsplus_block_allocate+0xfa/0x8d0 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0xa4c/0x1b10 fs/hfsplus/extents.c:468 hfsplus_get_block+0x402/0x14e0 fs/hfsplus/extents.c:245 __block_write_begin_int+0x60b/0x1650 fs/buffer.c:2012 __block_write_begin fs/buffer.c:2062 [inline] block_write_begin fs/buffer.c:2122 [inline] cont_write_begin+0x5d6/0x840 fs/buffer.c:2471 hfsplus_write_begin+0x92/0xd0 fs/hfsplus/inode.c:53 cont_expand_zero fs/buffer.c:2398 [inline] cont_write_begin+0x2ad/0x840 fs/buffer.c:2461 hfsplus_write_begin+0x92/0xd0 fs/hfsplus/inode.c:53 generic_perform_write+0x2bf/0x5b0 mm/filemap.c:3776 __generic_file_write_iter+0x243/0x4f0 mm/filemap.c:3903 generic_file_write_iter+0xa7/0x1b0 mm/filemap.c:3935 call_write_iter include/linux/fs.h:2146 [inline] aio_write+0x566/0x780 fs/aio.c:1583 io_submit_one+0x768/0x18d0 fs/aio.c:2002 __do_sys_io_submit fs/aio.c:2061 [inline] __se_sys_io_submit+0x17b/0x2f0 fs/aio.c:2031 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb -> #0 (&sbi->alloc_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfsplus_block_allocate+0x8a/0x8d0 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0xa4c/0x1b10 fs/hfsplus/extents.c:468 hfsplus_bmap_reserve+0x101/0x4e0 fs/hfsplus/btree.c:357 hfsplus_rename_cat+0x1cf/0x1090 fs/hfsplus/catalog.c:456 hfsplus_unlink+0x304/0x7f0 fs/hfsplus/dir.c:376 hfsplus_rename+0xc4/0x1b0 fs/hfsplus/dir.c:547 vfs_rename+0xbfc/0xf90 fs/namei.c:4819 do_renameat2+0xd74/0x1660 fs/namei.c:4971 __do_sys_rename fs/namei.c:5017 [inline] __se_sys_rename fs/namei.c:5015 [inline] __x64_sys_rename+0x82/0x90 fs/namei.c:5015 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 7 locks held by syz-executor.5/18430: #0: ffff8880796b6460 (sb_writers#17){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377 #1: ffff8880b0cc9080 (&type->i_mutex_dir_key#9/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:822 [inline] #1: ffff8880b0cc9080 (&type->i_mutex_dir_key#9/1){+.+.}-{3:3}, at: lock_rename fs/namei.c:3018 [inline] #1: ffff8880b0cc9080 (&type->i_mutex_dir_key#9/1){+.+.}-{3:3}, at: do_renameat2+0x611/0x1660 fs/namei.c:4910 #2: ffff8880774d4d40 (&sb->s_type->i_mutex_key#24){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:822 [inline] #2: ffff8880774d4d40 (&sb->s_type->i_mutex_key#24){+.+.}-{3:3}, at: lock_two_inodes+0xfc/0x180 fs/inode.c:1063 #3: ffff8880b0cc9e00 (&sb->s_type->i_mutex_key#24/4){+.+.}-{3:3}, at: vfs_rename+0x749/0xf90 fs/namei.c:4791 #4: ffff888079582198 (&sbi->vh_mutex){+.+.}-{3:3}, at: hfsplus_unlink+0x15d/0x7f0 fs/hfsplus/dir.c:370 #5: ffff8880aced40b0 (&tree->tree_lock#2){+.+.}-{3:3}, at: hfsplus_find_init+0x146/0x1c0 #6: ffff8880b0ccbdc8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1d2/0x1b10 fs/hfsplus/extents.c:457 stack backtrace: CPU: 0 PID: 18430 Comm: syz-executor.5 Not tainted 5.15.145-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/17/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfsplus_block_allocate+0x8a/0x8d0 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0xa4c/0x1b10 fs/hfsplus/extents.c:468 hfsplus_bmap_reserve+0x101/0x4e0 fs/hfsplus/btree.c:357 hfsplus_rename_cat+0x1cf/0x1090 fs/hfsplus/catalog.c:456 hfsplus_unlink+0x304/0x7f0 fs/hfsplus/dir.c:376 hfsplus_rename+0xc4/0x1b0 fs/hfsplus/dir.c:547 vfs_rename+0xbfc/0xf90 fs/namei.c:4819 do_renameat2+0xd74/0x1660 fs/namei.c:4971 __do_sys_rename fs/namei.c:5017 [inline] __se_sys_rename fs/namei.c:5015 [inline] __x64_sys_rename+0x82/0x90 fs/namei.c:5015 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb RIP: 0033:0x7fcaaec64ce9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fcaad1620c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000052 RAX: ffffffffffffffda RBX: 00007fcaaed842c0 RCX: 00007fcaaec64ce9 RDX: 0000000000000000 RSI: 0000000020000300 RDI: 0000000020000b00 RBP: 00007fcaaecb147a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000006e R14: 00007fcaaed842c0 R15: 00007ffe16a19ba8