ntfs3: loop0: ino=0, attr_set_size ====================================================== WARNING: possible circular locking dependency detected 6.5.0-rc7-syzkaller-00168-g7d2f353b2682 #0 Not tainted ------------------------------------------------------ syz-executor.0/26135 is trying to acquire lock: ffff888077d34ac0 (&ni->ni_lock){+.+.}-{3:3}, at: ntfs_set_state+0x1d2/0x6e0 fs/ntfs3/fsntfs.c:946 but task is already holding lock: ffff888077d36190 (&ni->file.run_lock#2){++++}-{3:3}, at: ntfs_extend_mft+0x138/0x430 fs/ntfs3/fsntfs.c:511 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&ni->file.run_lock#2){++++}-{3:3}: down_read+0x9c/0x470 kernel/locking/rwsem.c:1520 mi_read+0x301/0x650 fs/ntfs3/record.c:129 mi_format_new+0x39c/0x580 fs/ntfs3/record.c:378 ni_add_subrecord+0xd1/0x4f0 fs/ntfs3/frecord.c:372 ntfs_look_free_mft+0x209/0xdd0 fs/ntfs3/fsntfs.c:715 ni_create_attr_list+0x937/0x1520 fs/ntfs3/frecord.c:876 ni_ins_attr_ext+0x23f/0xaf0 fs/ntfs3/frecord.c:974 ni_insert_attr+0x310/0x870 fs/ntfs3/frecord.c:1141 ni_insert_nonresident+0x273/0x6d0 fs/ntfs3/frecord.c:1476 indx_create_allocate fs/ntfs3/index.c:1449 [inline] indx_insert_into_root+0xdd1/0x1a10 fs/ntfs3/index.c:1685 indx_insert_entry+0x263/0x460 fs/ntfs3/index.c:1972 ntfs_create_inode+0x20f7/0x4170 fs/ntfs3/inode.c:1650 ntfs_symlink+0x42/0x80 fs/ntfs3/namei.c:202 vfs_symlink fs/namei.c:4477 [inline] vfs_symlink+0x3e5/0x620 fs/namei.c:4461 do_symlinkat+0x28e/0x310 fs/namei.c:4503 __do_sys_symlinkat fs/namei.c:4519 [inline] __se_sys_symlinkat fs/namei.c:4516 [inline] __ia32_sys_symlinkat+0x97/0xc0 fs/namei.c:4516 do_syscall_32_irqs_on arch/x86/entry/common.c:112 [inline] __do_fast_syscall_32+0x61/0xe0 arch/x86/entry/common.c:178 do_fast_syscall_32+0x33/0x70 arch/x86/entry/common.c:203 entry_SYSENTER_compat_after_hwframe+0x70/0x82 -> #1 (&wnd->rw_lock/1){+.+.}-{3:3}: down_write_nested+0x97/0x200 kernel/locking/rwsem.c:1689 ntfs_mark_rec_free+0x2f4/0x400 fs/ntfs3/fsntfs.c:742 ni_write_inode+0x475/0x27e0 fs/ntfs3/frecord.c:3352 write_inode fs/fs-writeback.c:1456 [inline] __writeback_single_inode+0xa81/0xe70 fs/fs-writeback.c:1668 writeback_sb_inodes+0x599/0x1010 fs/fs-writeback.c:1894 wb_writeback+0x2a5/0xa90 fs/fs-writeback.c:2070 wb_do_writeback fs/fs-writeback.c:2217 [inline] wb_workfn+0x29c/0xfd0 fs/fs-writeback.c:2257 process_one_work+0xaa2/0x16f0 kernel/workqueue.c:2600 worker_thread+0x687/0x1110 kernel/workqueue.c:2751 kthread+0x33a/0x430 kernel/kthread.c:389 ret_from_fork+0x2c/0x70 arch/x86/kernel/process.c:145 ret_from_fork_asm+0x11/0x20 arch/x86/entry/entry_64.S:304 -> #0 (&ni->ni_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3142 [inline] check_prevs_add kernel/locking/lockdep.c:3261 [inline] validate_chain kernel/locking/lockdep.c:3876 [inline] __lock_acquire+0x2e3d/0x5de0 kernel/locking/lockdep.c:5144 lock_acquire kernel/locking/lockdep.c:5761 [inline] lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5726 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x181/0x1340 kernel/locking/mutex.c:747 ntfs_set_state+0x1d2/0x6e0 fs/ntfs3/fsntfs.c:946 attr_set_size+0x139c/0x2ca0 fs/ntfs3/attrib.c:866 ntfs_extend_mft+0x29f/0x430 fs/ntfs3/fsntfs.c:527 ntfs_look_free_mft+0x777/0xdd0 fs/ntfs3/fsntfs.c:590 ni_create_attr_list+0x937/0x1520 fs/ntfs3/frecord.c:876 ni_ins_attr_ext+0x23f/0xaf0 fs/ntfs3/frecord.c:974 ni_insert_attr+0x310/0x870 fs/ntfs3/frecord.c:1141 ni_insert_resident+0xd2/0x3a0 fs/ntfs3/frecord.c:1525 ntfs_set_ea+0xf46/0x13d0 fs/ntfs3/xattr.c:437 ntfs_save_wsl_perm+0x134/0x3d0 fs/ntfs3/xattr.c:946 ntfs3_setattr+0x961/0xb60 fs/ntfs3/file.c:708 notify_change+0x670/0x1160 fs/attr.c:483 chown_common+0x596/0x660 fs/open.c:768 do_fchownat+0x140/0x1f0 fs/open.c:799 ksys_chown include/linux/syscalls.h:1226 [inline] __do_sys_chown16 kernel/uid16.c:25 [inline] __se_sys_chown16 kernel/uid16.c:23 [inline] __ia32_sys_chown16+0xe3/0x110 kernel/uid16.c:23 do_syscall_32_irqs_on arch/x86/entry/common.c:112 [inline] __do_fast_syscall_32+0x61/0xe0 arch/x86/entry/common.c:178 do_fast_syscall_32+0x33/0x70 arch/x86/entry/common.c:203 entry_SYSENTER_compat_after_hwframe+0x70/0x82 other info that might help us debug this: Chain exists of: &ni->ni_lock --> &wnd->rw_lock/1 --> &ni->file.run_lock#2 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ni->file.run_lock#2); lock(&wnd->rw_lock/1); lock(&ni->file.run_lock#2); lock(&ni->ni_lock); *** DEADLOCK *** 5 locks held by syz-executor.0/26135: #0: ffff888043232410 (sb_writers#20){.+.+}-{0:0}, at: do_fchownat+0x11c/0x1f0 fs/open.c:796 #1: ffff888077d36ae0 (&sb->s_type->i_mutex_key#28){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:771 [inline] #1: ffff888077d36ae0 (&sb->s_type->i_mutex_key#28){+.+.}-{3:3}, at: chown_common+0x333/0x660 fs/open.c:758 #2: ffff888077d36840 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1124 [inline] #2: ffff888077d36840 (&ni->ni_lock/4){+.+.}-{3:3}, at: ntfs_save_wsl_perm+0x8c/0x3d0 fs/ntfs3/xattr.c:944 #3: ffff888043230120 (&wnd->rw_lock/1){+.+.}-{3:3}, at: ntfs_look_free_mft+0x342/0xdd0 fs/ntfs3/fsntfs.c:571 #4: ffff888077d36190 (&ni->file.run_lock#2){++++}-{3:3}, at: ntfs_extend_mft+0x138/0x430 fs/ntfs3/fsntfs.c:511 stack backtrace: CPU: 3 PID: 26135 Comm: syz-executor.0 Not tainted 6.5.0-rc7-syzkaller-00168-g7d2f353b2682 #0 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x1b0 lib/dump_stack.c:106 check_noncircular+0x311/0x3f0 kernel/locking/lockdep.c:2195 check_prev_add kernel/locking/lockdep.c:3142 [inline] check_prevs_add kernel/locking/lockdep.c:3261 [inline] validate_chain kernel/locking/lockdep.c:3876 [inline] __lock_acquire+0x2e3d/0x5de0 kernel/locking/lockdep.c:5144 lock_acquire kernel/locking/lockdep.c:5761 [inline] lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5726 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x181/0x1340 kernel/locking/mutex.c:747 ntfs_set_state+0x1d2/0x6e0 fs/ntfs3/fsntfs.c:946 attr_set_size+0x139c/0x2ca0 fs/ntfs3/attrib.c:866 ntfs_extend_mft+0x29f/0x430 fs/ntfs3/fsntfs.c:527 ntfs_look_free_mft+0x777/0xdd0 fs/ntfs3/fsntfs.c:590 ni_create_attr_list+0x937/0x1520 fs/ntfs3/frecord.c:876 ni_ins_attr_ext+0x23f/0xaf0 fs/ntfs3/frecord.c:974 ni_insert_attr+0x310/0x870 fs/ntfs3/frecord.c:1141 ni_insert_resident+0xd2/0x3a0 fs/ntfs3/frecord.c:1525 ntfs_set_ea+0xf46/0x13d0 fs/ntfs3/xattr.c:437 ntfs_save_wsl_perm+0x134/0x3d0 fs/ntfs3/xattr.c:946 ntfs3_setattr+0x961/0xb60 fs/ntfs3/file.c:708 notify_change+0x670/0x1160 fs/attr.c:483 chown_common+0x596/0x660 fs/open.c:768 do_fchownat+0x140/0x1f0 fs/open.c:799 ksys_chown include/linux/syscalls.h:1226 [inline] __do_sys_chown16 kernel/uid16.c:25 [inline] __se_sys_chown16 kernel/uid16.c:23 [inline] __ia32_sys_chown16+0xe3/0x110 kernel/uid16.c:23 do_syscall_32_irqs_on arch/x86/entry/common.c:112 [inline] __do_fast_syscall_32+0x61/0xe0 arch/x86/entry/common.c:178 do_fast_syscall_32+0x33/0x70 arch/x86/entry/common.c:203 entry_SYSENTER_compat_after_hwframe+0x70/0x82 RIP: 0023:0xf7f40579 Code: b8 01 10 06 03 74 b4 01 10 07 03 74 b0 01 10 08 03 74 d8 01 00 00 00 00 00 00 00 00 00 00 00 00 00 51 52 55 89 e5 0f 34 cd 80 <5d> 5a 59 c3 90 90 90 90 8d b4 26 00 00 00 00 8d b4 26 00 00 00 00 RSP: 002b:00000000f7f3b5ac EFLAGS: 00000292 ORIG_RAX: 00000000000000b6 RAX: ffffffffffffffda RBX: 0000000020000000 RCX: 0000000000000000 RDX: 000000000000ee01 RSI: 0000000000000000 RDI: 0000000000000000 RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000292 R12: 0000000000000000 R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000 ntfs3: loop0: Mark volume as dirty due to NTFS errors ---------------- Code disassembly (best guess), 2 bytes skipped: 0: 10 06 adc %al,(%rsi) 2: 03 74 b4 01 add 0x1(%rsp,%rsi,4),%esi 6: 10 07 adc %al,(%rdi) 8: 03 74 b0 01 add 0x1(%rax,%rsi,4),%esi c: 10 08 adc %cl,(%rax) e: 03 74 d8 01 add 0x1(%rax,%rbx,8),%esi 1e: 00 51 52 add %dl,0x52(%rcx) 21: 55 push %rbp 22: 89 e5 mov %esp,%ebp 24: 0f 34 sysenter 26: cd 80 int $0x80 * 28: 5d pop %rbp <-- trapping instruction 29: 5a pop %rdx 2a: 59 pop %rcx 2b: c3 ret 2c: 90 nop 2d: 90 nop 2e: 90 nop 2f: 90 nop 30: 8d b4 26 00 00 00 00 lea 0x0(%rsi,%riz,1),%esi 37: 8d b4 26 00 00 00 00 lea 0x0(%rsi,%riz,1),%esi