====================================================== WARNING: possible circular locking dependency detected 5.15.178-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor/4166 is trying to acquire lock: ffff88807656a138 ((wq_completion)ocfs2_wq){+.+.}-{0:0}, at: flush_workqueue+0x154/0x1610 kernel/workqueue.c:2830 but task is already holding lock: ffff88802a8f60e0 (&type->s_umount_key#83){++++}-{3:3}, at: deactivate_super+0xa9/0xe0 fs/super.c:365 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&type->s_umount_key#83){++++}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498 ocfs2_finish_quota_recovery+0x15a/0x2260 fs/ocfs2/quota_local.c:600 ocfs2_complete_recovery+0x173c/0x24a0 fs/ocfs2/journal.c:1295 process_one_work+0x8a1/0x10c0 kernel/workqueue.c:2310 worker_thread+0xaca/0x1280 kernel/workqueue.c:2457 kthread+0x3f6/0x4f0 kernel/kthread.c:334 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:287 -> #1 ((work_completion)(&journal->j_recovery_work)){+.+.}-{0:0}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 process_one_work+0x7f1/0x10c0 kernel/workqueue.c:2286 worker_thread+0xaca/0x1280 kernel/workqueue.c:2457 kthread+0x3f6/0x4f0 kernel/kthread.c:334 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:287 -> #0 ((wq_completion)ocfs2_wq){+.+.}-{0:0}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 flush_workqueue+0x170/0x1610 kernel/workqueue.c:2830 ocfs2_shutdown_local_alloc+0x105/0xa90 fs/ocfs2/localalloc.c:379 ocfs2_dismount_volume+0x1db/0x8b0 fs/ocfs2/super.c:1882 generic_shutdown_super+0x130/0x310 fs/super.c:475 kill_block_super+0x7a/0xe0 fs/super.c:1427 deactivate_locked_super+0xa0/0x110 fs/super.c:335 cleanup_mnt+0x44e/0x500 fs/namespace.c:1143 task_work_run+0x129/0x1a0 kernel/task_work.c:188 tracehook_notify_resume include/linux/tracehook.h:189 [inline] exit_to_user_mode_loop+0x106/0x130 kernel/entry/common.c:181 exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:214 __syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline] syscall_exit_to_user_mode+0x5d/0x240 kernel/entry/common.c:307 do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:86 entry_SYSCALL_64_after_hwframe+0x66/0xd0 other info that might help us debug this: Chain exists of: (wq_completion)ocfs2_wq --> (work_completion)(&journal->j_recovery_work) --> &type->s_umount_key#83 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&type->s_umount_key#83); lock((work_completion)(&journal->j_recovery_work)); lock(&type->s_umount_key#83); lock( (wq_completion)ocfs2_wq); *** DEADLOCK *** 1 lock held by syz-executor/4166: #0: ffff88802a8f60e0 (&type->s_umount_key#83){++++}-{3:3}, at: deactivate_super+0xa9/0xe0 fs/super.c:365 stack backtrace: CPU: 1 PID: 4166 Comm: syz-executor Not tainted 5.15.178-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 flush_workqueue+0x170/0x1610 kernel/workqueue.c:2830 ocfs2_shutdown_local_alloc+0x105/0xa90 fs/ocfs2/localalloc.c:379 ocfs2_dismount_volume+0x1db/0x8b0 fs/ocfs2/super.c:1882 generic_shutdown_super+0x130/0x310 fs/super.c:475 kill_block_super+0x7a/0xe0 fs/super.c:1427 deactivate_locked_super+0xa0/0x110 fs/super.c:335 cleanup_mnt+0x44e/0x500 fs/namespace.c:1143 task_work_run+0x129/0x1a0 kernel/task_work.c:188 tracehook_notify_resume include/linux/tracehook.h:189 [inline] exit_to_user_mode_loop+0x106/0x130 kernel/entry/common.c:181 exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:214 __syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline] syscall_exit_to_user_mode+0x5d/0x240 kernel/entry/common.c:307 do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:86 entry_SYSCALL_64_after_hwframe+0x66/0xd0 RIP: 0033:0x7f69b9f3b0d7 Code: a8 ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 0f 1f 44 00 00 31 f6 e9 09 00 00 00 66 0f 1f 84 00 00 00 00 00 b8 a6 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 01 c3 48 c7 c2 a8 ff ff ff f7 d8 64 89 02 b8 RSP: 002b:00007fff2f78f058 EFLAGS: 00000246 ORIG_RAX: 00000000000000a6 RAX: 0000000000000000 RBX: 00007f69b9fbb08c RCX: 00007f69b9f3b0d7 RDX: 0000000000000000 RSI: 0000000000000009 RDI: 00007fff2f78f110 RBP: 00007fff2f78f110 R08: 0000000000000000 R09: 0000000000000000 R10: 00000000ffffffff R11: 0000000000000246 R12: 00007fff2f7901a0 R13: 00007f69b9fbb08c R14: 0000000000015a85 R15: 00007fff2f7901e0 ocfs2: Unmounting device (7,0) on (node local)