====================================================== WARNING: possible circular locking dependency detected 5.15.113-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.1/7029 is trying to acquire lock: ffff0001232920b0 (&tree->tree_lock#2/1){+.+.}-{3:3}, at: hfsplus_find_init+0x144/0x1bc but task is already holding lock: ffff00011d661548 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x198/0x14e0 fs/hfsplus/extents.c:457 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 hfsplus_file_extend+0x198/0x14e0 fs/hfsplus/extents.c:457 hfsplus_bmap_reserve+0xec/0x474 fs/hfsplus/btree.c:357 __hfsplus_ext_write_extent+0x1e8/0x4bc fs/hfsplus/extents.c:104 __hfsplus_ext_cache_extent+0x84/0xa84 fs/hfsplus/extents.c:186 hfsplus_ext_read_extent fs/hfsplus/extents.c:218 [inline] hfsplus_file_extend+0x390/0x14e0 fs/hfsplus/extents.c:461 hfsplus_get_block+0x398/0x1194 fs/hfsplus/extents.c:245 __block_write_begin_int+0x3ec/0x1608 fs/buffer.c:2012 __block_write_begin fs/buffer.c:2062 [inline] block_write_begin fs/buffer.c:2122 [inline] cont_write_begin+0x538/0x710 fs/buffer.c:2471 hfsplus_write_begin+0xa8/0xf8 fs/hfsplus/inode.c:53 generic_perform_write+0x24c/0x520 mm/filemap.c:3776 __generic_file_write_iter+0x230/0x454 mm/filemap.c:3903 generic_file_write_iter+0xb4/0x1b8 mm/filemap.c:3935 call_write_iter include/linux/fs.h:2103 [inline] new_sync_write fs/read_write.c:507 [inline] vfs_write+0x87c/0xb3c fs/read_write.c:594 ksys_write+0x15c/0x26c fs/read_write.c:647 __do_sys_write fs/read_write.c:659 [inline] __se_sys_write fs/read_write.c:656 [inline] __arm64_sys_write+0x7c/0x90 fs/read_write.c:656 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:596 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:614 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #0 (&tree->tree_lock#2/1){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3787 [inline] __lock_acquire+0x32cc/0x7620 kernel/locking/lockdep.c:5011 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5622 __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 hfsplus_find_init+0x144/0x1bc hfsplus_ext_read_extent fs/hfsplus/extents.c:216 [inline] hfsplus_file_extend+0x364/0x14e0 fs/hfsplus/extents.c:461 hfsplus_get_block+0x398/0x1194 fs/hfsplus/extents.c:245 __block_write_full_page+0x2f4/0x1084 fs/buffer.c:1764 block_write_full_page+0x124/0x154 hfsplus_writepage+0x30/0x40 fs/hfsplus/inode.c:33 __mpage_writepage+0x13f8/0x1738 fs/mpage.c:660 write_cache_pages+0x878/0xf58 mm/page-writeback.c:2255 mpage_writepages+0x11c/0x280 fs/mpage.c:712 hfsplus_writepages+0x30/0x40 fs/hfsplus/inode.c:155 do_writepages+0x39c/0x5ec mm/page-writeback.c:2364 filemap_fdatawrite_wbc+0x1c8/0x228 mm/filemap.c:400 __filemap_fdatawrite_range mm/filemap.c:433 [inline] filemap_write_and_wait_range+0x16c/0x244 mm/filemap.c:704 filemap_write_and_wait include/linux/fs.h:2823 [inline] hfsplus_file_fsync+0x378/0x508 fs/hfsplus/inode.c:347 vfs_fsync_range+0x168/0x188 fs/sync.c:188 generic_write_sync include/linux/fs.h:2913 [inline] generic_file_write_iter+0x15c/0x1b8 mm/filemap.c:3939 call_write_iter include/linux/fs.h:2103 [inline] new_sync_write fs/read_write.c:507 [inline] vfs_write+0x87c/0xb3c fs/read_write.c:594 ksys_write+0x15c/0x26c fs/read_write.c:647 __do_sys_write fs/read_write.c:659 [inline] __se_sys_write fs/read_write.c:656 [inline] __arm64_sys_write+0x7c/0x90 fs/read_write.c:656 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:596 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:614 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock#2/1); lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock#2/1); *** DEADLOCK *** 4 locks held by syz-executor.1/7029: #0: ffff0000cc4b9770 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0xdc/0x108 fs/file.c:1073 #1: ffff0000c9c62460 (sb_writers#15){.+.+}-{0:0}, at: vfs_write+0x228/0xb3c fs/read_write.c:590 #2: ffff00011d665ac0 (&sb->s_type->i_mutex_key#22){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline] #2: ffff00011d665ac0 (&sb->s_type->i_mutex_key#22){+.+.}-{3:3}, at: hfsplus_file_fsync+0xd8/0x508 fs/hfsplus/inode.c:314 #3: ffff00011d661548 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x198/0x14e0 fs/hfsplus/extents.c:457 stack backtrace: CPU: 1 PID: 7029 Comm: syz-executor.1 Not tainted 5.15.113-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/28/2023 Call trace: dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3787 [inline] __lock_acquire+0x32cc/0x7620 kernel/locking/lockdep.c:5011 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5622 __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 hfsplus_find_init+0x144/0x1bc hfsplus_ext_read_extent fs/hfsplus/extents.c:216 [inline] hfsplus_file_extend+0x364/0x14e0 fs/hfsplus/extents.c:461 hfsplus_get_block+0x398/0x1194 fs/hfsplus/extents.c:245 __block_write_full_page+0x2f4/0x1084 fs/buffer.c:1764 block_write_full_page+0x124/0x154 hfsplus_writepage+0x30/0x40 fs/hfsplus/inode.c:33 __mpage_writepage+0x13f8/0x1738 fs/mpage.c:660 write_cache_pages+0x878/0xf58 mm/page-writeback.c:2255 mpage_writepages+0x11c/0x280 fs/mpage.c:712 hfsplus_writepages+0x30/0x40 fs/hfsplus/inode.c:155 do_writepages+0x39c/0x5ec mm/page-writeback.c:2364 filemap_fdatawrite_wbc+0x1c8/0x228 mm/filemap.c:400 __filemap_fdatawrite_range mm/filemap.c:433 [inline] filemap_write_and_wait_range+0x16c/0x244 mm/filemap.c:704 filemap_write_and_wait include/linux/fs.h:2823 [inline] hfsplus_file_fsync+0x378/0x508 fs/hfsplus/inode.c:347 vfs_fsync_range+0x168/0x188 fs/sync.c:188 generic_write_sync include/linux/fs.h:2913 [inline] generic_file_write_iter+0x15c/0x1b8 mm/filemap.c:3939 call_write_iter include/linux/fs.h:2103 [inline] new_sync_write fs/read_write.c:507 [inline] vfs_write+0x87c/0xb3c fs/read_write.c:594 ksys_write+0x15c/0x26c fs/read_write.c:647 __do_sys_write fs/read_write.c:659 [inline] __se_sys_write fs/read_write.c:656 [inline] __arm64_sys_write+0x7c/0x90 fs/read_write.c:656 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:596 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:614 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 hfsplus: inconsistency in B*Tree (2,0,1,0,1)