====================================================== WARNING: possible circular locking dependency detected 6.2.0-rc2-next-20230105-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor130/5088 is trying to acquire lock: ffff88807a7907c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1bf/0xf60 fs/hfsplus/extents.c:457 but task is already holding lock: ffff88807a7ca0b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x1bb/0x230 fs/hfsplus/bfind.c:30 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&tree->tree_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x12f/0x1360 kernel/locking/mutex.c:747 hfsplus_file_truncate+0xe87/0x10d0 fs/hfsplus/extents.c:595 hfsplus_delete_inode+0x191/0x220 fs/hfsplus/inode.c:454 hfsplus_unlink+0x5a6/0x830 fs/hfsplus/dir.c:405 vfs_unlink+0x355/0x930 fs/namei.c:4252 do_unlinkat+0x3b7/0x640 fs/namei.c:4320 __do_sys_unlinkat fs/namei.c:4363 [inline] __se_sys_unlinkat fs/namei.c:4356 [inline] __x64_sys_unlinkat+0xc1/0x130 fs/namei.c:4356 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain kernel/locking/lockdep.c:3831 [inline] __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5055 lock_acquire.part.0+0x11a/0x350 kernel/locking/lockdep.c:5668 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x12f/0x1360 kernel/locking/mutex.c:747 hfsplus_file_extend+0x1bf/0xf60 fs/hfsplus/extents.c:457 hfsplus_bmap_reserve+0x31c/0x410 fs/hfsplus/btree.c:358 hfsplus_rename_cat+0x271/0x1270 fs/hfsplus/catalog.c:456 hfsplus_unlink+0x4ad/0x830 fs/hfsplus/dir.c:376 vfs_unlink+0x355/0x930 fs/namei.c:4252 do_unlinkat+0x3b7/0x640 fs/namei.c:4320 do_coredump+0x10b9/0x3ca0 fs/coredump.c:673 get_signal+0x1c08/0x24f0 kernel/signal.c:2845 arch_do_signal_or_restart+0x79/0x5c0 arch/x86/kernel/signal.c:306 exit_to_user_mode_loop kernel/entry/common.c:168 [inline] exit_to_user_mode_prepare+0x15f/0x250 kernel/entry/common.c:203 irqentry_exit_to_user_mode+0x9/0x40 kernel/entry/common.c:309 exc_page_fault+0xc0/0x170 arch/x86/mm/fault.c:1578 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:570 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&tree->tree_lock); lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock); lock(&HFSPLUS_I(inode)->extents_lock); *** DEADLOCK *** 5 locks held by syz-executor130/5088: #0: ffff888028f4e460 (sb_writers#9){.+.+}-{0:0}, at: do_unlinkat+0x183/0x640 fs/namei.c:4299 #1: ffff88807a791e00 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:791 [inline] #1: ffff88807a791e00 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: do_unlinkat+0x270/0x640 fs/namei.c:4303 #2: ffff8880793a9080 (&sb->s_type->i_mutex_key#17){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:756 [inline] #2: ffff8880793a9080 (&sb->s_type->i_mutex_key#17){+.+.}-{3:3}, at: vfs_unlink+0xd9/0x930 fs/namei.c:4241 #3: ffff88807a74e198 (&sbi->vh_mutex){+.+.}-{3:3}, at: hfsplus_unlink+0x151/0x830 fs/hfsplus/dir.c:370 #4: ffff88807a7ca0b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x1bb/0x230 fs/hfsplus/bfind.c:30 stack backtrace: CPU: 1 PID: 5088 Comm: syz-executor130 Not tainted 6.2.0-rc2-next-20230105-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd1/0x138 lib/dump_stack.c:106 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2177 check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain kernel/locking/lockdep.c:3831 [inline] __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5055 lock_acquire.part.0+0x11a/0x350 kernel/locking/lockdep.c:5668 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x12f/0x1360 kernel/locking/mutex.c:747 hfsplus_file_extend+0x1bf/0xf60 fs/hfsplus/extents.c:457 hfsplus_bmap_reserve+0x31c/0x410 fs/hfsplus/btree.c:358 hfsplus_rename_cat+0x271/0x1270 fs/hfsplus/catalog.c:456 hfsplus_unlink+0x4ad/0x830 fs/hfsplus/dir.c:376 vfs_unlink+0x355/0x930 fs/namei.c:4252 do_unlinkat+0x3b7/0x640 fs/namei.c:4320 do_coredump+0x10b9/0x3ca0 fs/coredump.c:673 get_signal+0x1c08/0x24f0 kernel/signal.c:2845 arch_do_signal_or_restart+0x79/0x5c0 arch/x86/kernel/signal.c:306 exit_to_user_mode_loop kernel/entry/common.c:168 [inline] exit_to_user_mode_prepare+0x15f/0x250 kernel/entry/common.c:203 irqentry_exit_to_user_mode+0x9/0x40 kernel/entry/common.c:309 exc_page_fault+0xc0/0x170 arch/x86/mm/fault.c:1578 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:570 RIP: 0033:0x0 Code: Unable to access opcode bytes at 0xffffffffffffffd6. RSP: 002b:0000000020000048 EFLAGS: 00010217 RAX: 0000000000000000 RBX: 0000000000000018 RCX: 00007f780fb5ff49 RDX: 0000000000000000 RSI: 0000000020000040 RDI: 0000000000000080 RBP: 00007fffca872358 R08: 0000000000000000 R09: 00007f780fbcee40 R10: 0000000000000000 R11: 0000000000000246 R12: 00007fffca872360 R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000