====================================================== WARNING: possible circular locking dependency detected 6.1.106-syzkaller #0 Not tainted ------------------------------------------------------ syz.1.508/5606 is trying to acquire lock: ffff8880588625e0 (&ni->ni_lock){+.+.}-{3:3}, at: ntfs_set_state+0x1fa/0x660 fs/ntfs3/fsntfs.c:920 but task is already holding lock: ffff888058860860 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1101 [inline] ffff888058860860 (&ni->ni_lock/4){+.+.}-{3:3}, at: ntfs_lookup+0xf5/0x1f0 fs/ntfs3/namei.c:82 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ni->ni_lock/4){+.+.}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 ni_lock fs/ntfs3/ntfs_fs.h:1101 [inline] mi_read+0x2dd/0x5a0 fs/ntfs3/record.c:148 ntfs_read_mft fs/ntfs3/inode.c:69 [inline] ntfs_iget5+0x479/0x38e0 fs/ntfs3/inode.c:525 ni_update_parent+0x93f/0xdc0 fs/ntfs3/frecord.c:3208 ni_write_inode+0xe34/0x1070 fs/ntfs3/frecord.c:3306 write_inode fs/fs-writeback.c:1460 [inline] __writeback_single_inode+0x67d/0x11e0 fs/fs-writeback.c:1677 writeback_single_inode+0x22c/0x960 fs/fs-writeback.c:1733 sync_inode_metadata+0xc8/0x130 fs/fs-writeback.c:2789 __generic_file_fsync+0x13b/0x190 fs/libfs.c:1143 generic_file_fsync+0x6f/0xe0 fs/libfs.c:1173 generic_write_sync include/linux/fs.h:2957 [inline] ntfs_file_write_iter+0x5c2/0x6d0 fs/ntfs3/file.c:1169 do_iter_write+0x6e6/0xc40 fs/read_write.c:861 iter_file_splice_write+0x830/0xfc0 fs/splice.c:685 do_splice_from fs/splice.c:763 [inline] direct_splice_actor+0xe3/0x1c0 fs/splice.c:950 splice_direct_to_actor+0x4c7/0xc30 fs/splice.c:896 do_splice_direct+0x2a5/0x3e0 fs/splice.c:1002 do_sendfile+0x619/0xff0 fs/read_write.c:1255 __do_sys_sendfile64 fs/read_write.c:1323 [inline] __se_sys_sendfile64+0x178/0x1e0 fs/read_write.c:1309 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #0 (&ni->ni_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 ntfs_set_state+0x1fa/0x660 fs/ntfs3/fsntfs.c:920 ntfs_read_ea+0x2a3/0xa00 fs/ntfs3/xattr.c:177 ntfs_get_ea+0x1c2/0x680 fs/ntfs3/xattr.c:271 ntfs_get_wsl_perm+0xd5/0x4c0 fs/ntfs3/xattr.c:1018 ntfs_read_mft fs/ntfs3/inode.c:374 [inline] ntfs_iget5+0x1b07/0x38e0 fs/ntfs3/inode.c:525 dir_search_u+0x2f6/0x390 fs/ntfs3/dir.c:264 ntfs_lookup+0x102/0x1f0 fs/ntfs3/namei.c:83 lookup_one_qstr_excl+0x117/0x240 fs/namei.c:1605 do_unlinkat+0x293/0x820 fs/namei.c:4376 __do_sys_unlinkat fs/namei.c:4435 [inline] __se_sys_unlinkat fs/namei.c:4428 [inline] __x64_sys_unlinkat+0xca/0xf0 fs/namei.c:4428 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ni->ni_lock/4); lock(&ni->ni_lock); lock(&ni->ni_lock/4); lock(&ni->ni_lock); *** DEADLOCK *** 3 locks held by syz.1.508/5606: #0: ffff88807cc62460 (sb_writers#19){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:393 #1: ffff888058860b00 (&type->i_mutex_dir_key#13/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline] #1: ffff888058860b00 (&type->i_mutex_dir_key#13/1){+.+.}-{3:3}, at: do_unlinkat+0x266/0x820 fs/namei.c:4375 #2: ffff888058860860 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1101 [inline] #2: ffff888058860860 (&ni->ni_lock/4){+.+.}-{3:3}, at: ntfs_lookup+0xf5/0x1f0 fs/ntfs3/namei.c:82 stack backtrace: CPU: 0 PID: 5606 Comm: syz.1.508 Not tainted 6.1.106-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 ntfs_set_state+0x1fa/0x660 fs/ntfs3/fsntfs.c:920 ntfs_read_ea+0x2a3/0xa00 fs/ntfs3/xattr.c:177 ntfs_get_ea+0x1c2/0x680 fs/ntfs3/xattr.c:271 ntfs_get_wsl_perm+0xd5/0x4c0 fs/ntfs3/xattr.c:1018 ntfs_read_mft fs/ntfs3/inode.c:374 [inline] ntfs_iget5+0x1b07/0x38e0 fs/ntfs3/inode.c:525 dir_search_u+0x2f6/0x390 fs/ntfs3/dir.c:264 ntfs_lookup+0x102/0x1f0 fs/ntfs3/namei.c:83 lookup_one_qstr_excl+0x117/0x240 fs/namei.c:1605 do_unlinkat+0x293/0x820 fs/namei.c:4376 __do_sys_unlinkat fs/namei.c:4435 [inline] __se_sys_unlinkat fs/namei.c:4428 [inline] __x64_sys_unlinkat+0xca/0xf0 fs/namei.c:4428 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 RIP: 0033:0x7f12ff179e79 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f12fff25038 EFLAGS: 00000246 ORIG_RAX: 0000000000000107 RAX: ffffffffffffffda RBX: 00007f12ff315f80 RCX: 00007f12ff179e79 RDX: 0000000000000000 RSI: 00000000200001c0 RDI: ffffffffffffff9c RBP: 00007f12ff1e793e R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f12ff315f80 R15: 00007ffd65318128