====================================================== WARNING: possible circular locking dependency detected 5.15.0-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.3/18929 is trying to acquire lock: ffff88804f025088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:355 [inline] ffff88804f025088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_list_lock net/can/j1939/transport.c:238 [inline] ffff88804f025088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_activate+0x43/0x4b0 net/can/j1939/transport.c:1553 but task is already holding lock: ffff888083c1b5c0 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:355 [inline] ffff888083c1b5c0 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: j1939_sk_queue_activate_next+0x56/0x460 net/can/j1939/socket.c:204 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&jsk->sk_session_queue_lock){+.-.}-{2:2}: __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:355 [inline] j1939_sk_queue_drop_all+0x40/0x2f0 net/can/j1939/socket.c:139 j1939_sk_netdev_event_netdown+0x7b/0x160 net/can/j1939/socket.c:1272 j1939_netdev_notify+0x199/0x1d0 net/can/j1939/main.c:365 notifier_call_chain+0xb5/0x200 kernel/notifier.c:83 call_netdevice_notifiers_info+0xb5/0x130 net/core/dev.c:2002 call_netdevice_notifiers_extack net/core/dev.c:2014 [inline] call_netdevice_notifiers net/core/dev.c:2028 [inline] dev_close_many+0x2ff/0x620 net/core/dev.c:1603 dev_close net/core/dev.c:1625 [inline] dev_close net/core/dev.c:1619 [inline] __dev_change_net_namespace+0xd18/0x1330 net/core/dev.c:11199 do_setlink+0x275/0x3970 net/core/rtnetlink.c:2624 __rtnl_newlink+0xde6/0x1750 net/core/rtnetlink.c:3391 rtnl_newlink+0x64/0xa0 net/core/rtnetlink.c:3506 rtnetlink_rcv_msg+0x413/0xb80 net/core/rtnetlink.c:5571 netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2491 netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline] netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1345 netlink_sendmsg+0x86d/0xda0 net/netlink/af_netlink.c:1916 sock_sendmsg_nosec net/socket.c:704 [inline] sock_sendmsg+0xcf/0x120 net/socket.c:724 ____sys_sendmsg+0x6e8/0x810 net/socket.c:2409 ___sys_sendmsg+0xf3/0x170 net/socket.c:2463 __sys_sendmsg+0xe5/0x1b0 net/socket.c:2492 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae -> #1 (&priv->j1939_socks_lock){+.-.}-{2:2}: __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:355 [inline] j1939_sk_errqueue+0x9f/0x1a0 net/can/j1939/socket.c:1078 __j1939_session_cancel+0x3b9/0x460 net/can/j1939/transport.c:1124 j1939_tp_rxtimer.cold+0x15e/0x1aa net/can/j1939/transport.c:1249 __run_hrtimer kernel/time/hrtimer.c:1685 [inline] __hrtimer_run_queues+0x609/0xe50 kernel/time/hrtimer.c:1749 hrtimer_run_softirq+0x17b/0x360 kernel/time/hrtimer.c:1766 __do_softirq+0x29b/0x9c2 kernel/softirq.c:558 invoke_softirq kernel/softirq.c:432 [inline] __irq_exit_rcu+0x123/0x180 kernel/softirq.c:636 irq_exit_rcu+0x5/0x20 kernel/softirq.c:648 sysvec_apic_timer_interrupt+0x93/0xc0 arch/x86/kernel/apic/apic.c:1097 asm_sysvec_apic_timer_interrupt+0x12/0x20 arch/x86/include/asm/idtentry.h:638 memory_is_nonzero mm/kasan/generic.c:114 [inline] memory_is_poisoned_n mm/kasan/generic.c:128 [inline] memory_is_poisoned mm/kasan/generic.c:159 [inline] check_region_inline mm/kasan/generic.c:180 [inline] kasan_check_range+0xa0/0x180 mm/kasan/generic.c:189 strncpy_from_user+0x9d/0x3e0 lib/strncpy_from_user.c:136 getname_flags.part.0+0x95/0x4f0 fs/namei.c:149 getname_flags include/linux/audit.h:323 [inline] getname fs/namei.c:217 [inline] __do_sys_unlink fs/namei.c:4215 [inline] __se_sys_unlink fs/namei.c:4213 [inline] __x64_sys_unlink+0xb1/0x110 fs/namei.c:4213 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae -> #0 (&priv->active_session_list_lock){+.-.}-{2:2}: check_prev_add kernel/locking/lockdep.c:3051 [inline] check_prevs_add kernel/locking/lockdep.c:3174 [inline] validate_chain kernel/locking/lockdep.c:3789 [inline] __lock_acquire+0x2a07/0x54a0 kernel/locking/lockdep.c:5015 lock_acquire kernel/locking/lockdep.c:5625 [inline] lock_acquire+0x1ab/0x510 kernel/locking/lockdep.c:5590 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:355 [inline] j1939_session_list_lock net/can/j1939/transport.c:238 [inline] j1939_session_activate+0x43/0x4b0 net/can/j1939/transport.c:1553 j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:181 [inline] j1939_sk_queue_activate_next+0x29b/0x460 net/can/j1939/socket.c:205 j1939_session_deactivate_activate_next net/can/j1939/transport.c:1101 [inline] j1939_session_completed+0x80/0x120 net/can/j1939/transport.c:1214 j1939_xtp_rx_eoma_one net/can/j1939/transport.c:1384 [inline] j1939_xtp_rx_eoma+0x2a6/0x5f0 net/can/j1939/transport.c:1399 j1939_tp_cmd_recv net/can/j1939/transport.c:2083 [inline] j1939_tp_recv+0x430/0xb40 net/can/j1939/transport.c:2122 j1939_can_recv+0x6d7/0x930 net/can/j1939/main.c:101 deliver net/can/af_can.c:574 [inline] can_rcv_filter+0x5d4/0x8d0 net/can/af_can.c:608 can_receive+0x31d/0x580 net/can/af_can.c:665 can_rcv+0x120/0x1c0 net/can/af_can.c:696 __netif_receive_skb_one_core+0x114/0x180 net/core/dev.c:5462 __netif_receive_skb+0x24/0x1b0 net/core/dev.c:5576 process_backlog+0x2a5/0x6c0 net/core/dev.c:6452 __napi_poll+0xaf/0x440 net/core/dev.c:7017 napi_poll net/core/dev.c:7084 [inline] net_rx_action+0x801/0xb40 net/core/dev.c:7171 __do_softirq+0x29b/0x9c2 kernel/softirq.c:558 invoke_softirq kernel/softirq.c:432 [inline] __irq_exit_rcu+0x123/0x180 kernel/softirq.c:636 irq_exit_rcu+0x5/0x20 kernel/softirq.c:648 sysvec_apic_timer_interrupt+0x93/0xc0 arch/x86/kernel/apic/apic.c:1097 asm_sysvec_apic_timer_interrupt+0x12/0x20 arch/x86/include/asm/idtentry.h:638 __raw_spin_unlock_irqrestore include/linux/spinlock_api_smp.h:152 [inline] _raw_spin_unlock_irqrestore+0x38/0x70 kernel/locking/spinlock.c:194 spin_unlock_irqrestore include/linux/spinlock.h:405 [inline] __unfreeze_partials+0x31c/0x360 mm/slub.c:2495 qlink_free mm/kasan/quarantine.c:146 [inline] qlist_free_all+0x5a/0xc0 mm/kasan/quarantine.c:165 kasan_quarantine_reduce+0x180/0x200 mm/kasan/quarantine.c:272 ____kasan_kmalloc mm/kasan/common.c:479 [inline] __kasan_kmalloc+0xb8/0xd0 mm/kasan/common.c:522 kmalloc_node include/linux/slab.h:609 [inline] kzalloc_node include/linux/slab.h:732 [inline] __get_vm_area_node.constprop.0+0xd3/0x380 mm/vmalloc.c:2416 __vmalloc_node_range+0x12c/0x9d0 mm/vmalloc.c:3013 __vmalloc_node mm/vmalloc.c:3072 [inline] vmalloc+0x67/0x80 mm/vmalloc.c:3105 netlink_alloc_large_skb net/netlink/af_netlink.c:1196 [inline] netlink_sendmsg+0x5f0/0xda0 net/netlink/af_netlink.c:1891 sock_sendmsg_nosec net/socket.c:704 [inline] sock_sendmsg+0xcf/0x120 net/socket.c:724 sock_no_sendpage+0xf6/0x140 net/core/sock.c:3080 kernel_sendpage.part.0+0x1a0/0x340 net/socket.c:3504 kernel_sendpage net/socket.c:3501 [inline] sock_sendpage+0xe5/0x140 net/socket.c:1003 pipe_to_sendpage+0x2ad/0x380 fs/splice.c:364 splice_from_pipe_feed fs/splice.c:418 [inline] __splice_from_pipe+0x43e/0x8a0 fs/splice.c:562 splice_from_pipe fs/splice.c:597 [inline] generic_splice_sendpage+0xd4/0x140 fs/splice.c:746 do_splice_from fs/splice.c:767 [inline] direct_splice_actor+0x110/0x180 fs/splice.c:936 splice_direct_to_actor+0x34b/0x8c0 fs/splice.c:891 do_splice_direct+0x1b3/0x280 fs/splice.c:979 do_sendfile+0xaf2/0x1250 fs/read_write.c:1245 __do_sys_sendfile64 fs/read_write.c:1310 [inline] __se_sys_sendfile64 fs/read_write.c:1296 [inline] __x64_sys_sendfile64+0x1cc/0x210 fs/read_write.c:1296 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae other info that might help us debug this: Chain exists of: &priv->active_session_list_lock --> &priv->j1939_socks_lock --> &jsk->sk_session_queue_lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&jsk->sk_session_queue_lock); lock(&priv->j1939_socks_lock); lock(&jsk->sk_session_queue_lock); lock(&priv->active_session_list_lock); *** DEADLOCK *** 4 locks held by syz-executor.3/18929: #0: ffffffff8bac99f8 (remove_cache_srcu){....}-{0:0}, at: kasan_quarantine_reduce+0x41/0x200 mm/kasan/quarantine.c:274 #1: ffffffff8b982da0 (rcu_read_lock){....}-{1:2}, at: __skb_unlink include/linux/skbuff.h:2103 [inline] #1: ffffffff8b982da0 (rcu_read_lock){....}-{1:2}, at: __skb_dequeue include/linux/skbuff.h:2118 [inline] #1: ffffffff8b982da0 (rcu_read_lock){....}-{1:2}, at: process_backlog+0x250/0x6c0 net/core/dev.c:6450 #2: ffffffff8b982da0 (rcu_read_lock){....}-{1:2}, at: can_receive+0x1ef/0x580 net/can/af_can.c:655 #3: ffff888083c1b5c0 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:355 [inline] #3: ffff888083c1b5c0 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: j1939_sk_queue_activate_next+0x56/0x460 net/can/j1939/socket.c:204 stack backtrace: CPU: 1 PID: 18929 Comm: syz-executor.3 Not tainted 5.15.0-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2131 check_prev_add kernel/locking/lockdep.c:3051 [inline] check_prevs_add kernel/locking/lockdep.c:3174 [inline] validate_chain kernel/locking/lockdep.c:3789 [inline] __lock_acquire+0x2a07/0x54a0 kernel/locking/lockdep.c:5015 lock_acquire kernel/locking/lockdep.c:5625 [inline] lock_acquire+0x1ab/0x510 kernel/locking/lockdep.c:5590 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:355 [inline] j1939_session_list_lock net/can/j1939/transport.c:238 [inline] j1939_session_activate+0x43/0x4b0 net/can/j1939/transport.c:1553 j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:181 [inline] j1939_sk_queue_activate_next+0x29b/0x460 net/can/j1939/socket.c:205 j1939_session_deactivate_activate_next net/can/j1939/transport.c:1101 [inline] j1939_session_completed+0x80/0x120 net/can/j1939/transport.c:1214 j1939_xtp_rx_eoma_one net/can/j1939/transport.c:1384 [inline] j1939_xtp_rx_eoma+0x2a6/0x5f0 net/can/j1939/transport.c:1399 j1939_tp_cmd_recv net/can/j1939/transport.c:2083 [inline] j1939_tp_recv+0x430/0xb40 net/can/j1939/transport.c:2122 j1939_can_recv+0x6d7/0x930 net/can/j1939/main.c:101 deliver net/can/af_can.c:574 [inline] can_rcv_filter+0x5d4/0x8d0 net/can/af_can.c:608 can_receive+0x31d/0x580 net/can/af_can.c:665 can_rcv+0x120/0x1c0 net/can/af_can.c:696 __netif_receive_skb_one_core+0x114/0x180 net/core/dev.c:5462 __netif_receive_skb+0x24/0x1b0 net/core/dev.c:5576 process_backlog+0x2a5/0x6c0 net/core/dev.c:6452 __napi_poll+0xaf/0x440 net/core/dev.c:7017 napi_poll net/core/dev.c:7084 [inline] net_rx_action+0x801/0xb40 net/core/dev.c:7171 __do_softirq+0x29b/0x9c2 kernel/softirq.c:558 invoke_softirq kernel/softirq.c:432 [inline] __irq_exit_rcu+0x123/0x180 kernel/softirq.c:636 irq_exit_rcu+0x5/0x20 kernel/softirq.c:648 sysvec_apic_timer_interrupt+0x93/0xc0 arch/x86/kernel/apic/apic.c:1097 asm_sysvec_apic_timer_interrupt+0x12/0x20 arch/x86/include/asm/idtentry.h:638 RIP: 0010:__raw_spin_unlock_irqrestore include/linux/spinlock_api_smp.h:152 [inline] RIP: 0010:_raw_spin_unlock_irqrestore+0x38/0x70 kernel/locking/spinlock.c:194 Code: 74 24 10 e8 5a 6d 22 f8 48 89 ef e8 a2 e3 22 f8 81 e3 00 02 00 00 75 25 9c 58 f6 c4 02 75 2d 48 85 db 74 01 fb bf 01 00 00 00 43 ab 15 f8 65 8b 05 1c 42 c8 76 85 c0 74 0a 5b 5d c3 e8 40 7f RSP: 0018:ffffc9000308f398 EFLAGS: 00000206 RAX: 0000000000000002 RBX: 0000000000000200 RCX: 1ffffffff1ade509 RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000001 RBP: ffff888010c40840 R08: 0000000000000001 R09: 0000000000000001 R10: ffffffff817dad68 R11: 0000000000000001 R12: ffffea0002004e08 R13: ffff888010c41dc0 R14: ffff888010c40840 R15: ffffea0002004e00 spin_unlock_irqrestore include/linux/spinlock.h:405 [inline] __unfreeze_partials+0x31c/0x360 mm/slub.c:2495 qlink_free mm/kasan/quarantine.c:146 [inline] qlist_free_all+0x5a/0xc0 mm/kasan/quarantine.c:165 kasan_quarantine_reduce+0x180/0x200 mm/kasan/quarantine.c:272 ____kasan_kmalloc mm/kasan/common.c:479 [inline] __kasan_kmalloc+0xb8/0xd0 mm/kasan/common.c:522 kmalloc_node include/linux/slab.h:609 [inline] kzalloc_node include/linux/slab.h:732 [inline] __get_vm_area_node.constprop.0+0xd3/0x380 mm/vmalloc.c:2416 __vmalloc_node_range+0x12c/0x9d0 mm/vmalloc.c:3013 __vmalloc_node mm/vmalloc.c:3072 [inline] vmalloc+0x67/0x80 mm/vmalloc.c:3105 netlink_alloc_large_skb net/netlink/af_netlink.c:1196 [inline] netlink_sendmsg+0x5f0/0xda0 net/netlink/af_netlink.c:1891 sock_sendmsg_nosec net/socket.c:704 [inline] sock_sendmsg+0xcf/0x120 net/socket.c:724 sock_no_sendpage+0xf6/0x140 net/core/sock.c:3080 kernel_sendpage.part.0+0x1a0/0x340 net/socket.c:3504 kernel_sendpage net/socket.c:3501 [inline] sock_sendpage+0xe5/0x140 net/socket.c:1003 pipe_to_sendpage+0x2ad/0x380 fs/splice.c:364 splice_from_pipe_feed fs/splice.c:418 [inline] __splice_from_pipe+0x43e/0x8a0 fs/splice.c:562 splice_from_pipe fs/splice.c:597 [inline] generic_splice_sendpage+0xd4/0x140 fs/splice.c:746 do_splice_from fs/splice.c:767 [inline] direct_splice_actor+0x110/0x180 fs/splice.c:936 splice_direct_to_actor+0x34b/0x8c0 fs/splice.c:891 do_splice_direct+0x1b3/0x280 fs/splice.c:979 do_sendfile+0xaf2/0x1250 fs/read_write.c:1245 __do_sys_sendfile64 fs/read_write.c:1310 [inline] __se_sys_sendfile64 fs/read_write.c:1296 [inline] __x64_sys_sendfile64+0x1cc/0x210 fs/read_write.c:1296 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae RIP: 0033:0x7fdc1be1dae9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fdc19393188 EFLAGS: 00000246 ORIG_RAX: 0000000000000028 RAX: ffffffffffffffda RBX: 00007fdc1bf30f60 RCX: 00007fdc1be1dae9 RDX: 0000000000000000 RSI: 0000000000000008 RDI: 000000000000000b RBP: 00007fdc1be77f25 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000100000002 R11: 0000000000000246 R12: 0000000000000000 R13: 00007fff38c91c5f R14: 00007fdc19393300 R15: 0000000000022000 ---------------- Code disassembly (best guess): 0: 74 24 je 0x26 2: 10 e8 adc %ch,%al 4: 5a pop %rdx 5: 6d insl (%dx),%es:(%rdi) 6: 22 f8 and %al,%bh 8: 48 89 ef mov %rbp,%rdi b: e8 a2 e3 22 f8 callq 0xf822e3b2 10: 81 e3 00 02 00 00 and $0x200,%ebx 16: 75 25 jne 0x3d 18: 9c pushfq 19: 58 pop %rax 1a: f6 c4 02 test $0x2,%ah 1d: 75 2d jne 0x4c 1f: 48 85 db test %rbx,%rbx 22: 74 01 je 0x25 24: fb sti 25: bf 01 00 00 00 mov $0x1,%edi * 2a: e8 43 ab 15 f8 callq 0xf815ab72 <-- trapping instruction 2f: 65 8b 05 1c 42 c8 76 mov %gs:0x76c8421c(%rip),%eax # 0x76c84252 36: 85 c0 test %eax,%eax 38: 74 0a je 0x44 3a: 5b pop %rbx 3b: 5d pop %rbp 3c: c3 retq 3d: e8 .byte 0xe8 3e: 40 rex 3f: 7f .byte 0x7f